Subject: bug#13886: closed (Re: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 25 Nov 2013 02:31:03 +0000

Your bug report

#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
13886: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13886
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation
From: Dmitry Gutov <[email-masked]>
To: E Sabof <[email-masked]>
Cc: [email-masked]
Date: Mon, 25 Nov 2013 04:30:25 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.4

Thanks for the report, fixed in 115219.

Though I've changed it to use `beginning-of-line' for better
consistency, because implementations of this command in other backends
do that.

Subject: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation
From: E Sabof <[email-masked]>
To: [email-masked]
Date: Wed, 6 Mar 2013 02:37:51 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

While in vc-annotate mode, with a git backend, if one hides the
annotations with vc-annotate-toggle-annotation-visiblity, and
tries to run vc-annotate-show-log-revision-at-line, it will display the
message "Cannot extract revision number from the current line".
Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()
  (save-excursion
    (forward-line 0)
    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")
      (let ((revision (match-string-no-properties 1)))
(if (match-beginning 2)
    (let ((fname (match-string-no-properties 3)))
      ;; Remove trailing whitespace from the file name.
      (when (string-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))))
      (cons revision
    (expand-file-name fname (vc-git-root default-directory))))
  revision)))))

Evgeni