From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 21:38:32 2013 Received: (at submit) by debbugs.gnu.org; 6 Mar 2013 02:38:32 +0000 Received: from localhost ([127.0.0.1]:33413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UD4FT-00064z-LT for submit@debbugs.gnu.org; Tue, 05 Mar 2013 21:38:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59313) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UD4FS-00064o-BK for submit@debbugs.gnu.org; Tue, 05 Mar 2013 21:38:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UD4Ex-0007gK-4O for submit@debbugs.gnu.org; Tue, 05 Mar 2013 21:38:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:49222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD4Ex-0007gG-11 for submit@debbugs.gnu.org; Tue, 05 Mar 2013 21:37:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD4Eu-0000m4-Gy for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 21:37:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UD4Es-0007fq-1V for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 21:37:56 -0500 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:33649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD4Er-0007fj-PK for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 21:37:53 -0500 Received: by mail-la0-f41.google.com with SMTP id fo12so6909025lab.14 for ; Tue, 05 Mar 2013 18:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=ZrqHrjSnMXzIIglu9X87uyaLEUEs0Zk1xEnWuyfmnyM=; b=GRyAeovzZDexEhO3H10tjMOOuH8qQeFNq97xRFA+1em9GcLW5zZAjC+2KB+ONvowNP OUCbX2ZrTbMctXzCs3s6xgg5jD+gvy2Z29hMaG29Ie6Ao/CE0MGArG1d5tL+TfXRMcdO oFU3VoIr6NmRvOzzf9EAfDYaPrnj1ayyg/zmwx6xhXqpwXl7F9DcqSNbmlMe3+sDc5Zk W8V0MLFimDLDyjR01Ua5fkN3kGwHpxUfrUx1PcmEU19hpijLmjhIg74JSnAwyAe0I9vA kt304K8I393AbymUW++Yg6WR0bcyyRV6SZb7ZewYrqrfQyJfQqXSWvnWqZ/PlBRH/1jJ GQhQ== MIME-Version: 1.0 X-Received: by 10.152.147.36 with SMTP id th4mr23612119lab.19.1362537472058; Tue, 05 Mar 2013 18:37:52 -0800 (PST) Received: by 10.112.48.106 with HTTP; Tue, 5 Mar 2013 18:37:51 -0800 (PST) Date: Wed, 6 Mar 2013 02:37:51 +0000 Message-ID: Subject: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation From: E Sabof To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=e89a8f22c38103e8f504d7387aec X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --e89a8f22c38103e8f504d7387aec Content-Type: text/plain; charset=ISO-8859-1 While in vc-annotate mode, with a git backend, if one hides the annotations with vc-annotate-toggle-annotation-visiblity, and tries to run vc-annotate-show-log-revision-at-line, it will display the message "Cannot extract revision number from the current line". Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here: (defun vc-git-annotate-extract-revision-at-line () (save-excursion (forward-line 0) (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?") (let ((revision (match-string-no-properties 1))) (if (match-beginning 2) (let ((fname (match-string-no-properties 3))) ;; Remove trailing whitespace from the file name. (when (string-match " +\\'" fname) (setq fname (substring fname 0 (match-beginning 0)))) (cons revision (expand-file-name fname (vc-git-root default-directory)))) revision))))) Evgeni --e89a8f22c38103e8f504d7387aec Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
While in vc-annotate mode, with a git backend, if one= hides the
annotations with vc-annotate-toggle-annotation-visibli= ty, and
tries to run vc-annotate-show-log-revision-at-line, it wi= ll display the
message "Cannot extract revision number from the current line&quo= t;.
Fixable by changing (move-beginning-of-line 1) to (forward-li= ne 0) here:

(defun vc-git-annotate-extract-revisio= n-at-line ()
=A0 (save-excursion
=A0 =A0 (forward-line 0)
=A0 = =A0 (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?&qu= ot;)
=A0 =A0 =A0 (let ((revision (match-string-no-properties 1)))=
(if (match-be= ginning 2)
=A0 =A0(let ((fnam= e (match-string-no-properties 3)))
=A0 =A0 =A0;; Remove trailing whitespace from the fil= e name.
=A0 =A0 =A0(when (strin= g-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))= ))
=A0 =A0 =A0(cons revisi= on
=A0 =A0(e= xpand-file-name fname (vc-git-root default-directory))))
=A0revision)))))

Evgeni

--e89a8f22c38103e8f504d7387aec-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 21:30:43 2013 Received: (at 13886-done) by debbugs.gnu.org; 25 Nov 2013 02:30:44 +0000 Received: from localhost ([127.0.0.1]:43142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vklwg-0003zD-Pl for submit@debbugs.gnu.org; Sun, 24 Nov 2013 21:30:43 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:37842) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vklwc-0003yu-Il for 13886-done@debbugs.gnu.org; Sun, 24 Nov 2013 21:30:39 -0500 Received: by mail-we0-f170.google.com with SMTP id w61so3279143wes.15 for <13886-done@debbugs.gnu.org>; Sun, 24 Nov 2013 18:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=+ROsWouStHRDYRcO2KcTztrzwPuKw8/19pxb61/8pRU=; b=euYUe8FpIijFlMi/8FNX6SfGaU5TF9W2mpsaK8oybnkpq/NodYU6mdOvLjZZGE20Dy USuJUm1SKKtUekE/WXhEJNvgoqfJg+wxF/na2zXsh5ugnuSVCFmiNZjQCeCD0D0WdiSc I0hT3UdZBoK2Cpr0C8BBdKH4aC98TDGS7bh4b5IBGzKrH0vXf2Zmz79aMmnSG5OqtMS6 mmXq7mLIoIW8pvAVhtJOI9gHTG9RGFoBYgNR7rKsJbEtmFwAiTk+iI+nwltYS9COvhbB p1pw8btsCEXaEKsBYOY0VOd7pyC4G0TZxNX+Q619X6VyDV5NDTyAqF2FS2b3O7CvOIP/ tKhQ== X-Received: by 10.180.10.74 with SMTP id g10mr11625586wib.11.1385346632520; Sun, 24 Nov 2013 18:30:32 -0800 (PST) Received: from axl ([93.109.200.157]) by mx.google.com with ESMTPSA id nb16sm43368209wic.0.2013.11.24.18.30.30 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 24 Nov 2013 18:30:31 -0800 (PST) From: Dmitry Gutov To: E Sabof Subject: Re: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation References: Date: Mon, 25 Nov 2013 04:30:25 +0200 In-Reply-To: (E. Sabof's message of "Wed, 6 Mar 2013 02:37:51 +0000") Message-ID: <87bo19nrge.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13886-done Cc: 13886-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 24.4 Thanks for the report, fixed in 115219. Though I've changed it to use `beginning-of-line' for better consistency, because implementations of this command in other backends do that. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:15:00 2013 Received: (at 13886-done) by debbugs.gnu.org; 26 Nov 2013 17:15:00 +0000 Received: from localhost ([127.0.0.1]:46209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlMDz-00034M-PN for submit@debbugs.gnu.org; Tue, 26 Nov 2013 12:14:59 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:45469) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlMDx-000348-Sf for 13886-done@debbugs.gnu.org; Tue, 26 Nov 2013 12:14:58 -0500 Received: by mail-we0-f180.google.com with SMTP id u56so5529929wes.25 for <13886-done@debbugs.gnu.org>; Tue, 26 Nov 2013 09:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Pbhk20M+XAcnlUtOZcYgmk+zBWuXQUMtVcgQhipGr+s=; b=HRNW5iNlS1pz9E8b1j//qIlDpobDr3XBiHX1nPfbo8K+A/mcR/H3NruNrFIFNc/83h u9UuDEsVLm58xyZOY+BH6vPeUKcYrwYRFU3J0R4/nSgQVnRd+UWjD8mwRQap5+AJI/FF wCZIPqb5amZOk6dHbaAwz5yCrIkanlSaKrrC+3cEHmyox3lVUyLg3lA/P8E+MEkE38Zh P7AwwaEe2vLWDWLYXwnnpIZAXe9gsI+ydswCe4m3y7C2ASqAKQ6dMnU9obpAEv1TmUo2 pXZNKXZbeE27IU4Tl0ZIJKv6+HHgkp9oOFXf0gvjl3eWibgxY7TwVs5vpLnkzoSxwEwO BLpw== MIME-Version: 1.0 X-Received: by 10.180.10.74 with SMTP id g10mr19073358wib.11.1385486091888; Tue, 26 Nov 2013 09:14:51 -0800 (PST) Received: by 10.216.195.195 with HTTP; Tue, 26 Nov 2013 09:14:51 -0800 (PST) In-Reply-To: <87bo19nrge.fsf@yandex.ru> References: <87bo19nrge.fsf@yandex.ru> Date: Tue, 26 Nov 2013 17:14:51 +0000 Message-ID: Subject: Re: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation From: E Sabof To: Dmitry Gutov Content-Type: multipart/alternative; boundary=001a11c25a925933f704ec179e5e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13886-done Cc: 13886-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c25a925933f704ec179e5e Content-Type: text/plain; charset=ISO-8859-1 Sounds good, if it still fixes the problem. Thanks! Evgeni On Mon, Nov 25, 2013 at 2:30 AM, Dmitry Gutov wrote: > Version: 24.4 > > Thanks for the report, fixed in 115219. > > Though I've changed it to use `beginning-of-line' for better > consistency, because implementations of this command in other backends > do that. > --001a11c25a925933f704ec179e5e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Sounds good, if it still fixes the problem. Thanks!
Evgeni


On Mon, Nov 25, 2013 at 2:30 AM, Dmitry Gutov <dgutov@y= andex.ru> wrote:
Version: 24.4

Thanks for the report, fixed in 115219.

Though I've changed it to use `beginning-of-line' for better
consistency, because implementations of this command in other backends
do that.

--001a11c25a925933f704ec179e5e-- From unknown Sun Jun 22 00:10:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Dec 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator