From rgm@gnu.org Thu Nov 20 00:03:10 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,BAYES_00,NUMONLY, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at quiet) by emacsbugs.donarmstrong.com; 20 Nov 2008 08:03:10 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAK836Vm032650 for ; Thu, 20 Nov 2008 00:03:08 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L34V6-00049r-3A for quiet@emacsbugs.donarmstrong.com; Thu, 20 Nov 2008 03:02:56 -0500 From: "Jhair Tocancipa Triana" To: quiet@debbugs.gnu.org Subject: 23.0.60; Emacs shell problem with echo "1+1" | bc Date: Tue, 6 May 2008 16:35:15 +0200 Lines: 168 X-From-Line: emacs-devel-bounces+rgm=gnu.org@gnu.org Tue May 6 14:03:43 2008 Received: from mx10.gnu.org ([199.232.76.166]:49029) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JtRVv-0001Ne-7S for rgm@gnu.org; Tue, 06 May 2008 14:03:43 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JtRWQ-0004bO-6J for rgm@gnu.org; Tue, 06 May 2008 14:04:19 -0400 Received: from lists.gnu.org ([199.232.76.165]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtRWP-0004bD-T5 for rgm@gnu.org; Tue, 06 May 2008 14:04:13 -0400 Received: from localhost ([127.0.0.1]:41046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtRWP-0004Lm-OQ for rgm@gnu.org; Tue, 06 May 2008 14:04:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtOGM-0001to-5j for emacs-devel@gnu.org; Tue, 06 May 2008 10:35:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtOGL-0001sE-58 for emacs-devel@gnu.org; Tue, 06 May 2008 10:35:25 -0400 Received: from [199.232.76.173] (port=40554 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtOGK-0001rv-Ug for emacs-devel@gnu.org; Tue, 06 May 2008 10:35:24 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtOGK-0005KW-Ht for emacs-devel@gnu.org; Tue, 06 May 2008 10:35:24 -0400 Received: from mx10.gnu.org ([199.232.76.166]:60886) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JtOFj-0006HD-Pd for emacs-pretest-bug@gnu.org; Tue, 06 May 2008 10:34:47 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JtOGD-0005ID-St for emacs-pretest-bug@gnu.org; Tue, 06 May 2008 10:35:23 -0400 Received: from rv-out-0708.google.com ([209.85.198.244]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtOGD-0005HN-3u for emacs-pretest-bug@gnu.org; Tue, 06 May 2008 10:35:17 -0400 Received: by rv-out-0708.google.com with SMTP id k29so2153159rvb.6 for ; Tue, 06 May 2008 07:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; bh=FGekL1INscYwfjr9LBm0536U7fZSnXTCh/ReXY4dmg4=; b=ezzT6Ip45+RKiL8YPT0x9j3lYesBPZqBN56iBbM+ciasJAGRhROWgkuClIi8uRegHM6TEiuo6DYkiyVV3JCDSBXY07e01OP6gy0yKV4A+pwSVke2o0LBamKPO7xkBQT6NRm0+3ooiIsW035hg6XUHERRN8hwlCdC3+NxQUUrfA4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=Iun9KeRqV35NMJxh0levZJUvw8BFATzGOqzcgEr7+S3oon9lAPkrsU6o4wrTbPDcj1TpUI3HcC9EisYUfpn/IIejMNchNsfM4g7ILytTx7sQWsgEGPWSTnWdLlst1tD5FK2qxkyTst8vMG9hUfbJ7hPB2K4VNonfqgtflC0Kq9g= Received: by 10.141.23.7 with SMTP id a7mr389261rvj.5.1210084515296; Tue, 06 May 2008 07:35:15 -0700 (PDT) Received: by 10.140.126.14 with HTTP; Tue, 6 May 2008 07:35:15 -0700 (PDT) X-Debbugs-No-Ack: yes X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Tue, 06 May 2008 14:02:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+rgm=gnu.org@gnu.org X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-=-=" Sender: Glenn Morris --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline [ Edited resend from http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg00349.html ] Type the following after M-x eshell RET: echo "1+1" | bc and then the return key. Instead of the expected answer 2, eshell displays: bc 1.06 Copyright 1991-1994, 1997, 1998, 2000 Free Software Foundation, Inc. This is free software with ABSOLUTELY NO WARRANTY. For details type `warranty'. now type the return key again. Here the answer is shown: 2 type the return key again. Nothing happens. Eshell blocks. Control-C shows: (interrupt) use quit to exit. In GNU Emacs 23.0.60.3 (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2008-05-06 on golem Windowing system distributor `The X.Org Foundation', version 11.0.70000000 configured using `configure '--enable-font-backend--with-gtk' '--with-gif=no'' --=-=-=-- From rgm@gnu.org Fri Nov 21 17:47:08 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 22 Nov 2008 01:47:08 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAM1l5Lo017574 for <1388@emacsbugs.donarmstrong.com>; Fri, 21 Nov 2008 17:47:06 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L3haH-0002Gd-7L; Fri, 21 Nov 2008 20:46:53 -0500 From: Glenn Morris To: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: X-Spook: chameleon man Lon Horiuchi Belknap beanpole Compsec X-Ran: *\ZdpoDhezTm,]\X9WhN$z}I (Jhair Tocancipa Triana's message of "Tue, 6 May 2008 16:35:15 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Jhair Tocancipa Triana" wrote: > Type the following after M-x eshell RET: > > echo "1+1" | bc > > and then the return key. Instead of the expected answer 2, eshell > displays: > > bc 1.06 > Copyright 1991-1994, 1997, 1998, 2000 Free Software Foundation, Inc. [...] I think this is because isatty(0) returns 1 on the right-hand side of an eshell pipe, so bc thinks it is running interactively. Does anyone know if that is fixable? From monnier@iro.umontreal.ca Fri Nov 21 20:02:52 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 22 Nov 2008 04:02:52 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAM42m7v020879 for <1388@emacsbugs.donarmstrong.com>; Fri, 21 Nov 2008 20:02:50 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqEEAMsSJ0nO+KUv/2dsb2JhbACBbdJIgnyBGw X-IronPort-AV: E=Sophos;i="4.33,648,1220241600"; d="scan'208";a="30172082" Received: from 206-248-165-47.dsl.teksavvy.com (HELO pastel.home) ([206.248.165.47]) by ironport2-out.teksavvy.com with ESMTP; 21 Nov 2008 23:02:43 -0500 Received: by pastel.home (Postfix, from userid 20848) id E7A0A80FF; Fri, 21 Nov 2008 23:03:45 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc Message-ID: References: Date: Fri, 21 Nov 2008 23:03:45 -0500 In-Reply-To: (Glenn Morris's message of "Fri, 21 Nov 2008 20:46:53 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> echo "1+1" | bc >> and then the return key. Instead of the expected answer 2, eshell >> displays: >> bc 1.06 >> Copyright 1991-1994, 1997, 1998, 2000 Free Software Foundation, Inc. > I think this is because isatty(0) returns 1 on the right-hand side of > an eshell pipe, so bc thinks it is running interactively. Does anyone > know if that is fixable? Yes, an appropriate binding of process-connection-type at the right place and the right time should do the trick. Stefan From rgm@gnu.org Sat Nov 22 13:02:41 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 22 Nov 2008 21:02:41 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAML2cpL030065 for <1388@emacsbugs.donarmstrong.com>; Sat, 22 Nov 2008 13:02:39 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L3zcV-00024v-Kl; Sat, 22 Nov 2008 16:02:23 -0500 From: Glenn Morris To: Stefan Monnier Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: X-Spook: Iran doctrine AGT. AMME asset strategic DES bank Semtex X-Ran: /q^+s{\J""/68_yz}M4IFl (Stefan Monnier's message of "Fri, 21 Nov 2008 23:03:45 -0500") Message-ID: <7p1vx3jwyo.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: > Yes, an appropriate binding of process-connection-type at the right > place and the right time should do the trick. Awesome, thanks. The following seems to work, though: i) One needs to use either /bin/echo or set eshell-plain-echo-behavior non-nil if `echo 1+1 | bc' is to work. ii) I'm not sure whether the following is mistakenly changing the behaviour of the first command in a pipeline. Can't think of a good test for that... *** esh-proc.el.~1.21.~ 2008-05-20 16:28:53.000000000 -0700 --- esh-proc.el 2008-11-22 12:55:59.000000000 -0800 *************** *** 250,260 **** (cond ((fboundp 'start-process) (setq proc (apply 'start-process (file-name-nondirectory command) nil ! ;; `start-process' can't deal with relative ! ;; filenames ! (append (list (expand-file-name command)) args))) (eshell-record-process-object proc) (set-process-buffer proc (current-buffer)) (if (eshell-interactive-output-p) --- 250,263 ---- (cond ((fboundp 'start-process) (setq proc + ;; Bug#1388. Some commands (eg bc) check isatty to decide + ;; whether they are being called interactively. + (let ((process-connection-type (unless eshell-in-pipeline-p + process-connection-type))) (apply 'start-process (file-name-nondirectory command) nil ! ;; `start-process' can't deal with relative filenames ! (append (list (expand-file-name command)) args)))) (eshell-record-process-object proc) (set-process-buffer proc (current-buffer)) (if (eshell-interactive-output-p) From rgm@gnu.org Sat Nov 22 19:12:47 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.9 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 23 Nov 2008 03:12:47 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAN3Ci89031937 for <1388@emacsbugs.donarmstrong.com>; Sat, 22 Nov 2008 19:12:45 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L45Og-0006f9-9a; Sat, 22 Nov 2008 22:12:30 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18728.51742.251222.477040@fencepost.gnu.org> Date: Sat, 22 Nov 2008 22:12:30 -0500 From: Glenn Morris To: Stefan Monnier , 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc In-Reply-To: <7p1vx3jwyo.fsf@fencepost.gnu.org> References: <7p1vx3jwyo.fsf@fencepost.gnu.org> X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: hN?s)$m=dUCfNS@PJHGP4|k]}8RZ'?{Nn04g4J!Q=@io*6~M\'=9TRlSlxnFw}Af)m\wje I've installed a fix that sets process-connection-type to nil for every element of a pipeline but the first. Or do you think the first element should have p-c-t nil as well? Currently, the first/last elements in an eshell pipeline have: stdin = tty/non-tty, stdout = tty/non-tty; whereas in a "real" shell pipeline they have: stdin = tty/non-tty, stdout = non-tty/tty; ie I chose to get the input right over the output. From rgm@gnu.org Sat Nov 22 19:16:44 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388-done) by emacsbugs.donarmstrong.com; 23 Nov 2008 03:16:44 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAN3Gf9r000724 for <1388-done@emacsbugs.donarmstrong.com>; Sat, 22 Nov 2008 19:16:43 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L45SW-0006iG-3b; Sat, 22 Nov 2008 22:16:28 -0500 From: Glenn Morris To: 1388-done@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: X-Spook: domestic disruption Perl-RSA afsatcom FTS2000 Pine Gap X-Ran: Rk|8S|8\}d& (Stefan Monnier's message of "Fri, 21 Nov 2008 23:03:45 -0500") Message-ID: <9askpji12r.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks for the report; sorry for the long delay in responding. This should be fixed in the current CVS. You still need to use /bin/echo, or set eshell-plain-echo-behavior non-nil, for it to work right. From monnier@iro.umontreal.ca Sat Nov 22 20:28:43 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 23 Nov 2008 04:28:43 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAN4SdXH019242 for <1388@emacsbugs.donarmstrong.com>; Sat, 22 Nov 2008 20:28:41 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuoEAFJrKEnO+J+z/2dsb2JhbACBbc4UgnyBHA X-IronPort-AV: E=Sophos;i="4.33,653,1220241600"; d="scan'208";a="30190517" Received: from 206-248-159-179.dsl.teksavvy.com (HELO pastel.home) ([206.248.159.179]) by ironport2-out.teksavvy.com with ESMTP; 22 Nov 2008 23:28:27 -0500 Received: by pastel.home (Postfix, from userid 20848) id 71CDC8101; Sat, 22 Nov 2008 23:28:27 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc Message-ID: References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> Date: Sat, 22 Nov 2008 23:28:27 -0500 In-Reply-To: <18728.51742.251222.477040@fencepost.gnu.org> (Glenn Morris's message of "Sat, 22 Nov 2008 22:12:30 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I've installed a fix that sets process-connection-type to nil for > every element of a pipeline but the first. Or do you think the first > element should have p-c-t nil as well? > Currently, the first/last elements in an eshell pipeline have: > stdin = tty/non-tty, stdout = tty/non-tty; > whereas in a "real" shell pipeline they have: > stdin = tty/non-tty, stdout = non-tty/tty; > ie I chose to get the input right over the output. Not sure if it's better in general. Maybe we should just leave the code as is for now, but add a comment explaining the problem. For the longer term we can either try your approach, or better try and come up with a way to make it work right (i.e. extending start-process). Stefan From rgm@gnu.org Sun Nov 23 23:48:06 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 24 Nov 2008 07:48:06 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAO7m3pF031963 for <1388@emacsbugs.donarmstrong.com>; Sun, 23 Nov 2008 23:48:04 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L4WAe-0002kP-0k; Mon, 24 Nov 2008 02:47:48 -0500 From: Glenn Morris To: Stefan Monnier Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> X-Spook: TELINT Mossad M-14 Legion of Doom e-bomb KGB X-Ran: #)gja81Uu<22QVG;cbU$E|IQJT(\WO[I.kYz,ULssR/UCfo> (Stefan Monnier's message of "Sat, 22 Nov 2008 23:28:27 -0500") Message-ID: <921vx1efa4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: > Not sure if it's better in general. > Maybe we should just leave the code as is for now, but add a comment > explaining the problem. For the longer term we can either try your > approach, I'm happy to make changes, but I'm not sure what you are saying here. Do you want me to just set process-connection-type nil for every element of an eshell pipe, including the first? What I installed was the version where the first command gets p-c-t non-nil (actually, whatever the default is). From monnier@iro.umontreal.ca Mon Nov 24 08:15:25 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 24 Nov 2008 16:15:26 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAOGFNkx005014 for <1388@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 08:15:24 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAA9iKknO+J+z/2dsb2JhbACBbc8bgnyBHQ X-IronPort-AV: E=Sophos;i="4.33,660,1220241600"; d="scan'208";a="30228455" Received: from 206-248-159-179.dsl.teksavvy.com (HELO pastel.home) ([206.248.159.179]) by ironport2-out.teksavvy.com with ESMTP; 24 Nov 2008 11:15:17 -0500 Received: by pastel.home (Postfix, from userid 20848) id 49FB08107; Mon, 24 Nov 2008 11:15:17 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc Message-ID: References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> Date: Mon, 24 Nov 2008 11:15:17 -0500 In-Reply-To: <921vx1efa4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 24 Nov 2008 02:47:47 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Not sure if it's better in general. >> Maybe we should just leave the code as is for now, but add a comment >> explaining the problem. For the longer term we can either try your >> approach, > I'm happy to make changes, but I'm not sure what you are saying here. > Do you want me to just set process-connection-type nil for every > element of an eshell pipe, including the first? What I installed was > the version where the first command gets p-c-t non-nil (actually, > whatever the default is). "as is" means, as it was when the OP bumped into the problem. I see you've already made a change to eshell, but I was not referring to that. Stefan From rgm@gnu.org Mon Nov 24 09:26:25 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 24 Nov 2008 17:26:25 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAOHQMUE023644 for <1388@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 09:26:23 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L4fCI-0003Tg-9o; Mon, 24 Nov 2008 12:26:06 -0500 From: Glenn Morris To: Stefan Monnier Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> X-Spook: Bellcore Peking AMEMB ASPIC gamma UFO terrorist world X-Ran: _h,PNwL0_D,N+2;)X$+J~Km^1Q,oC!mYy,2^w\d6?4f`&hiVt!h&r.k X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 24 Nov 2008 12:26:06 -0500 In-Reply-To: (Stefan Monnier's message of "Mon, 24 Nov 2008 11:15:17 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: > "as is" means, as it was when the OP bumped into the problem. Oh, OK, so you want me to take out my changes... > I see you've already made a change to eshell, but I was not referring > to that. ...now you've gone and confused me again! :) Maybe you mean, eshell changes ok, but leave start-process as is, which I would certainly agree with? Sorry for being obtuse... From monnier@iro.umontreal.ca Mon Nov 24 19:21:25 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 25 Nov 2008 03:21:25 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP3LLGS017353 for <1388@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 19:21:23 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtEEAO/9KknO+J+z/2dsb2JhbACBbdAygnyBHQ X-IronPort-AV: E=Sophos;i="4.33,661,1220241600"; d="scan'208";a="30257509" Received: from 206-248-159-179.dsl.teksavvy.com (HELO pastel.home) ([206.248.159.179]) by ironport2-out.teksavvy.com with ESMTP; 24 Nov 2008 22:21:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id DE02D8107; Mon, 24 Nov 2008 22:21:11 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc Message-ID: References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> Date: Mon, 24 Nov 2008 22:21:11 -0500 In-Reply-To: (Glenn Morris's message of "Mon, 24 Nov 2008 12:26:06 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> "as is" means, as it was when the OP bumped into the problem. > Oh, OK, so you want me to take out my changes... Yes, I think they're not "obviously better" enough. Maybe they are, but I'd need some convincing. Stefan From rgm@gnu.org Mon Nov 24 20:31:27 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-13.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 25 Nov 2008 04:31:27 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4VJqt003402; Mon, 24 Nov 2008 20:31:20 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L4pZl-0004UC-EL; Mon, 24 Nov 2008 23:31:01 -0500 From: Glenn Morris To: Stefan Monnier Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> X-Spook: Cocaine cryptographic fissionable broadside Watergate AMW X-Ran: p3x"kU`fTW8s=m&_}5/3ky*mPN8;4|;1P2[Z.r5s(Nesr4NIi]~klDAgZh!;N#q{&"r2Ma X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 24 Nov 2008 23:31:01 -0500 Message-ID: <5uskpgfmuy.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii reopen 1388 stop Stefan Monnier wrote: >>> "as is" means, as it was when the OP bumped into the problem. >> Oh, OK, so you want me to take out my changes... > > Yes, I think they're not "obviously better" enough. Maybe they are, but > I'd need some convincing. OK, change reverted, bug re-opened. Given that said change solves the reported bug, and I was just following your own suggestion on what to do, I'm thoroughly confused. (But this is not atypical.) From monnier@iro.umontreal.ca Thu Nov 27 10:21:22 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 27 Nov 2008 18:21:22 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mARILJG1025737 for <1388@emacsbugs.donarmstrong.com>; Thu, 27 Nov 2008 10:21:20 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtsEANxzLknO+Jkl/2dsb2JhbACBbdA3gn2BJA X-IronPort-AV: E=Sophos;i="4.33,676,1220241600"; d="scan'208";a="30370611" Received: from 206-248-153-37.dsl.teksavvy.com (HELO ceviche.home) ([206.248.153.37]) by ironport2-out.teksavvy.com with ESMTP; 27 Nov 2008 13:21:13 -0500 Received: by ceviche.home (Postfix, from userid 20848) id DE594700CF; Thu, 27 Nov 2008 13:21:11 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc Message-ID: References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> <5uskpgfmuy.fsf@fencepost.gnu.org> Date: Thu, 27 Nov 2008 13:21:11 -0500 In-Reply-To: <5uskpgfmuy.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 24 Nov 2008 23:31:01 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > OK, change reverted, bug re-opened. Thank you. > Given that said change solves the reported bug, and I was just > following your own suggestion on what to do, I'm thoroughly confused. > (But this is not atypical.) My suggestion was for how to fix the particular circumstance. I didn't imply that it would fix the problem in general. And indeed, you've found that there's a fundamental problem in how we handle processes that seems to make it impossible right now to reproduce what a normal shell would do. This said, I haven't looked closely enough to know that your change might make things worse in some cases. But it doesn't seem obviously safe. So maybe you can convince me that it's not making things worse in other circumstances, or that those circumstances are much less likely (or didn't work well anyway in the past for other reasons). Stefan From rgm@gnu.org Fri Nov 28 18:35:09 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388) by emacsbugs.donarmstrong.com; 29 Nov 2008 02:35:09 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAT2Z6fw003715 for <1388@emacsbugs.donarmstrong.com>; Fri, 28 Nov 2008 18:35:07 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L6FfQ-0006YG-Jz; Fri, 28 Nov 2008 21:34:44 -0500 From: Glenn Morris To: Stefan Monnier Cc: 1388@debbugs.gnu.org Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> <5uskpgfmuy.fsf@fencepost.gnu.org> X-Spook: Waco, Texas Defcon Al-Qaeda cracking UMTS MP5K-SD PGP X-Ran: }vu0ZC?g^`3Q-h$F'|JP{_W9|F;,Gp9MT=W#ao*O"8lc9_kqW?|b%w[6=yq@4^-A_r"<*5 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 28 Nov 2008 21:34:44 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 27 Nov 2008 13:21:11 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: > So maybe you can convince me that it's not making things worse in > other circumstances, or that those circumstances are much less > likely (or didn't work well anyway in the past for other reasons). Let's see: i) I didn't change the behaviour for the first element in a pipeline. ii) For the "middle" elements, it must be more correct to uses pipes, must it not? iii) For the last element, I dunno. One has to use pipes for the bc case to get the right result. Checking if the final command in a pipeline looks like "bc" and if so doing something special seems like an ugly hack. That's about all I can say. From rgm@gnu.org Sat Nov 29 17:30:14 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.8 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,UNRESOLVED_TEMPLATE,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1388-done) by emacsbugs.donarmstrong.com; 30 Nov 2008 01:30:15 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAU1UBSi000347 for <1388-done@emacsbugs.donarmstrong.com>; Sat, 29 Nov 2008 17:30:13 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L6b88-0000ck-Mk; Sat, 29 Nov 2008 20:29:48 -0500 From: Glenn Morris To: 1388-done@debbugs.gnu.org Cc: Stefan Monnier Subject: Re: bug#1388: 23.0.60; Emacs shell problem with echo "1+1" | bc References: <7p1vx3jwyo.fsf@fencepost.gnu.org> <18728.51742.251222.477040@fencepost.gnu.org> <921vx1efa4.fsf@fencepost.gnu.org> <5uskpgfmuy.fsf@fencepost.gnu.org> X-Spook: AFSPC Roswell ANDVT CIA Guantanamo S Key embassy Mena X-Ran: AZ1Qhw3{,#0jol*v2_TZ[m%DGxOqJp<};on.|:f2%dnr8lN"IY=bc (Glenn Morris's message of "Fri, 28 Nov 2008 21:34:44 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Glenn Morris wrote: > Checking if the final command in a pipeline looks like "bc" and if > so doing something special seems like an ugly hack. On second thoughts, no it doesn't, and I installed something along those lines. From unknown Sun Jun 15 08:47:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Jan 2009 15:24:05 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator