GNU bug report logs - #13875
24.3.50; whitespace-mode should use 'prepend for whitespace-line face

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#13875: closed (Re: bug#13875: 24.3.50; whitespace-mode should
 use 'prepend for whitespace-line face)
Date: Tue, 19 Mar 2013 04:26:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#13875: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 13875 <at> debbugs.gnu.org.

-- 
13875: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13875
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13875-done <at> debbugs.gnu.org
Subject: Re: bug#13875: 24.3.50;
	whitespace-mode should use 'prepend for whitespace-line face
Date: Tue, 19 Mar 2013 08:24:05 +0400

Version: 24.4

On 18.03.2013 2:27, Stefan Monnier wrote:
>> -	 whitespace-line t))
>> +	 whitespace-line 'prepend))
>
> No objection on my part,

Thanks, installed.

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face
Date: Tue, 05 Mar 2013 20:36:21 +0400

Tags: patch

Right now, there's no way to tell whitespace-mode to keep the foreground
color of the underlying text when highlighting lines that are too long.

Related SO question:
http://stackoverflow.com/questions/14636786/how-to-unset-the-foreground-color-of-whitespace-mode-for-emacs

With the patch at the bottom applied, the following code will make it
keep the text's foreground and just change background:

  (set-face-attribute 'whitespace-line nil :foreground nil
                                           :background "gainsboro")

(Changing :backround is not necessary, but gray20 looks bad with the
default foreground color.)

=== modified file 'lisp/whitespace.el'
--- lisp/whitespace.el	2013-01-11 23:08:55 +0000
+++ lisp/whitespace.el	2013-03-05 16:25:51 +0000
@@ -2291,7 +2291,7 @@
 	 (if (memq 'lines whitespace-active-style)
 	     0				; whole line
 	   2)				; line tail
-	 whitespace-line t))
+	 whitespace-line 'prepend))
        t))
     (cond
      ((memq 'space-before-tab whitespace-active-style)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.