GNU bug report logs - #13866
[VC] ‘vc-git-root’ is too lax

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13866 in the body.
You can then email your comments to 13866 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-emacs <at> gnu.org
Subject: [VC] ‘vc-git-root’ is too lax
Date: Mon, 04 Mar 2013 10:50:50 +0100

[Message part 1 (text/plain, inline)]

Hello,

‘vc-git-root’ as found in Emacs 24.2.1 is too lax: when called from a
non-Git directory under $HOME, it ends up returning ~/ because users
normally have a ~/.git directory holding a config file.

A better definition would be something like this:

[Message part 2 (application/emacs-lisp, inline)]

[Message part 3 (text/plain, inline)]

Thanks,
Ludo’.

Message #8 received at 13866 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 13866 <at> debbugs.gnu.org
Subject: Re: bug#13866: [VC] ‘vc-git-root’ is
	too lax
Date: Mon, 04 Mar 2013 11:56:51 +0100

ludo <at> gnu.org (Ludovic Courtès) writes:

> ‘vc-git-root’ as found in Emacs 24.2.1 is too lax: when called from a
> non-Git directory under $HOME, it ends up returning ~/ because users
> normally have a ~/.git directory holding a config file.

Do they?  Who created it?

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #13 received at 13866-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 13866-done <at> debbugs.gnu.org
Subject: Re: bug#13866: [VC] ‘vc-git-root’ is
	too lax
Date: Mon, 04 Mar 2013 14:16:55 +0100

Andreas Schwab <schwab <at> linux-m68k.org> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> ‘vc-git-root’ as found in Emacs 24.2.1 is too lax: when called from a
>> non-Git directory under $HOME, it ends up returning ~/ because users
>> normally have a ~/.git directory holding a config file.
>
> Do they?  Who created it?

I did, but now I realize that ~/.gitconfig is what matters nowadays (or
maybe ~/.git/config never mattered, even.)

Sorry for the noise.

Ludo’.

Message #16 received at 13866 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 13866 <at> debbugs.gnu.org
Subject: Re: bug#13866: [VC] ‘vc-git-root’ is
	too lax
Date: Mon, 04 Mar 2013 09:58:33 -0500

> A better definition would be something like this:
> (defun vc-git-root (file)
>   (lexical-let ((root (vc-find-root file ".git")))
>     (and (file-in-directory-p root "objects")
>          root)))

Beside the fact that ~/.git is not the config directory, the above code
has some problems:

vc-git.el uses lexical-binding, so using lexical-let in it is a bad idea.
file-in-directory-p sounds completely wrong here.  You want to use
(file-directory-p (expand-file-name "objects" root)) instead.

And of course you could have used simply (vc-find-root file ".git/objects").


        Stefan

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#13866: [VC] ‘vc-git-root’ is
	too lax
Date: Mon,  4 Mar 2013 15:11:00 +0000 (GMT)

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> And of course you could have used simply (vc-find-root file
> ".git/objects").

That is not right.  .git in a git root directory might be a regular
file.

        Christopher

Message #22 received at 13866 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13866 <at> debbugs.gnu.org
Subject: Re: bug#13866: [VC] ‘vc-git-root’ is
	too lax
Date: Mon, 04 Mar 2013 17:00:14 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> skribis:

>> A better definition would be something like this:
>> (defun vc-git-root (file)
>>   (lexical-let ((root (vc-find-root file ".git")))
>>     (and (file-in-directory-p root "objects")
>>          root)))
>
> Beside the fact that ~/.git is not the config directory, the above code
> has some problems:
>
> vc-git.el uses lexical-binding, so using lexical-let in it is a bad idea.
> file-in-directory-p sounds completely wrong here.  You want to use
> (file-directory-p (expand-file-name "objects" root)) instead.
>
> And of course you could have used simply (vc-find-root file ".git/objects").

Indeed, point taken!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.