GNU bug report logs - #13843
[PATCH] Fix "later bindings win" stipulation for with-fluids

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mark H Weaver <mhw <at> netris.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13843: closed ([PATCH] Fix "later bindings win" stipulation
 for with-fluids)
Date: Thu, 28 Feb 2013 23:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 28 Feb 2013 18:48:15 -0500
with message-id <877glsvw3k.fsf <at> tines.lan>
and subject line Re: bug#13843: [PATCH] Fix "later bindings win" stipulation for with-fluids
has caused the debbugs.gnu.org bug report #13843,
regarding [PATCH] Fix "later bindings win" stipulation for with-fluids
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13843: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13843
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Kastrup <dak <at> gnu.org>
To: bug-guile <at> gnu.org
Cc: David Kastrup <dak <at> gnu.org>
Subject: [PATCH] Fix "later bindings win" stipulation for with-fluids
Date: Thu, 28 Feb 2013 11:04:06 +0100

The following code displayed 2:

(define a (make-fluid))
(with-fluids ((a 1) (a 2) (a 3))
	     (display (fluid-ref a)))
---
 libguile/fluids.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/fluids.c b/libguile/fluids.c
index bd59e26..11309c9 100644
--- a/libguile/fluids.c
+++ b/libguile/fluids.c
@@ -321,7 +321,7 @@ scm_i_make_with_fluids (size_t n, SCM *fluids, SCM *vals)
     size_t i, j = n;
 
     while (j--)
-      for (i = 0; i < j; i++)
+      for (i = j; i--;)
         if (scm_is_eq (fluids[i], fluids[j]))
           {
             vals[i] = vals[j]; /* later bindings win */
-- 
1.7.10.4

[Message part 3 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: David Kastrup <dak <at> gnu.org>
Cc: 13843-done <at> debbugs.gnu.org
Subject: Re: bug#13843: [PATCH] Fix "later bindings win" stipulation for
	with-fluids
Date: Thu, 28 Feb 2013 18:48:15 -0500

Fixed in 8dd01861a9a0331b912a1ae6310e64eb6b47c29c.

   Thanks!
     Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.