From unknown Sun Jun 22 17:13:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13838 <13838@debbugs.gnu.org> To: bug#13838 <13838@debbugs.gnu.org> Subject: Status: [PATCH] Fix duplicate removal of with-fluids Reply-To: bug#13838 <13838@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:13:22 +0000 retitle 13838 [PATCH] Fix duplicate removal of with-fluids reassign 13838 guile submitter 13838 David Kastrup severity 13838 normal tag 13838 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 28 04:43:01 2013 Received: (at submit) by debbugs.gnu.org; 28 Feb 2013 09:43:01 +0000 Received: from localhost ([127.0.0.1]:55151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UB00y-0008SF-M8 for submit@debbugs.gnu.org; Thu, 28 Feb 2013 04:43:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36482) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UB00v-0008S5-02 for submit@debbugs.gnu.org; Thu, 28 Feb 2013 04:42:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UAzz2-0006UA-H4 for submit@debbugs.gnu.org; Thu, 28 Feb 2013 04:41:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzz2-0006Tq-ER for submit@debbugs.gnu.org; Thu, 28 Feb 2013 04:41:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzz1-0002cq-9E for bug-guile@gnu.org; Thu, 28 Feb 2013 04:41:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UAzz0-0006SH-1L for bug-guile@gnu.org; Thu, 28 Feb 2013 04:40:59 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzyz-0006S9-Jy for bug-guile@gnu.org; Thu, 28 Feb 2013 04:40:57 -0500 Received: from localhost ([127.0.0.1]:58186 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzyy-0001oZ-2C; Thu, 28 Feb 2013 04:40:56 -0500 Received: by lola (Postfix, from userid 1000) id E0CAA201C09; Thu, 28 Feb 2013 10:40:28 +0100 (CET) From: David Kastrup To: bug-guile@gnu.org Subject: [PATCH] Fix duplicate removal of with-fluids Date: Thu, 28 Feb 2013 10:40:16 +0100 Message-Id: <1362044416-8464-1-git-send-email-dak@gnu.org> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit Cc: David Kastrup X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.6 (-------) The following code displayed #f: (define a (make-fluid)) (define b (make-fluid)) (with-fluids ((a 3) (a 1) (b 2)) (display (fluid-ref b))) In general, removing any duplicate that is not right at the end of the (remaining) list will exhibit this problem. The fluids and vals arguments are modified in situ; the previous code only modified vals. --- libguile/fluids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libguile/fluids.c b/libguile/fluids.c index f1c09cb..bd59e26 100644 --- a/libguile/fluids.c +++ b/libguile/fluids.c @@ -326,6 +326,8 @@ scm_i_make_with_fluids (size_t n, SCM *fluids, SCM *vals) { vals[i] = vals[j]; /* later bindings win */ n--; + fluids[j] = fluids[n]; + vals[j] = vals[n]; break; } } -- 1.7.10.4 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 28 06:34:00 2013 Received: (at 13838-done) by debbugs.gnu.org; 28 Feb 2013 11:34:00 +0000 Received: from localhost ([127.0.0.1]:55225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UB1kO-0002gN-CX for submit@debbugs.gnu.org; Thu, 28 Feb 2013 06:34:00 -0500 Received: from world.peace.net ([96.39.62.75]:36740) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UB1kM-0002gG-Iw for 13838-done@debbugs.gnu.org; Thu, 28 Feb 2013 06:33:59 -0500 Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UB1iO-0000v1-V5; Thu, 28 Feb 2013 06:31:57 -0500 From: Mark H Weaver To: David Kastrup Subject: Re: bug#13838: [PATCH] Fix duplicate removal of with-fluids References: <1362044416-8464-1-git-send-email-dak@gnu.org> Date: Thu, 28 Feb 2013 06:31:49 -0500 In-Reply-To: <1362044416-8464-1-git-send-email-dak@gnu.org> (David Kastrup's message of "Thu, 28 Feb 2013 10:40:16 +0100") Message-ID: <87y5e8wu6y.fsf@tines.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13838-done Cc: 13838-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Applied, thanks. Mark From unknown Sun Jun 22 17:13:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 29 Mar 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator