GNU bug report logs - #13837
24.2; Make it possible to turn whitespace-mode only when there are no existing problems

Previous Next

Full log

Message #74 received at 13837 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13837 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#13837: 24.2; Make it possible to turn whitespace-mode only
 when there are no existing problems
Date: Tue, 28 Jan 2014 00:48:21 +0000

[Message part 1 (text/plain, inline)]

On 28 January 2014 00:32, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> > -(defun whitespace-report (&optional force report-if-bogus)
> > +(defun whitespace-report (&optional force report)
>
> I'd leave the name unchanged.  Will make for a cleaner diff and the
> name "report" is not convincingly better.
>

Sure, OK.


>  > +If REPORT is t, it reports only when there are any whitespace
> > +problems in buffer; if it is 'never, it does not report problems.
>                                 ^^^^^^
> should be                       `never'
>
> > +problems in buffer; if it is 'never, it does not report problems.
>                                 ^^^^^^
> should be                       `never'
>
> >  * If `indent-tabs-mode' is non-nil:
> > +   indentation               6. 8 or more SPACEs at beginning of line.
> >  * If `indent-tabs-mode' is nil:
> > +   indentation               6. TABS at beginning of line.
>
> Why not
>
>       indentation               6. if `indent-tabs-mode':
>                                    8 or more SPACEs at beginning of line
>                                    else: TABS at beginning of line.
>

OK.


> > -     (when (if report-if-bogus has-bogus t)
> > +     (when (if (equal report t) has-bogus (null report))
>
> For better backward compatibility, this should check for `never' and
> treat any other non-nil value as t.   IOW
>
>         (when (pcase report-if-bogus (`nil t) (`never nil) (_ has-bogus))
>

Fine, revised patch to follow.

-- 
http://rrt.sc3d.org

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.