GNU bug report logs - #13835
[PATCH] Let reverse! accept arbitrary types as second argument (new_tail)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mark H Weaver <mhw <at> netris.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13835: closed ([PATCH] Let reverse! accept arbitrary types as
 second argument (new_tail))
Date: Thu, 28 Feb 2013 01:53:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 27 Feb 2013 20:50:24 -0500
with message-id <87fw0hxl3z.fsf <at> tines.lan>
and subject line Re: bug#13835: [PATCH] Let reverse! accept arbitrary types as second argument (new_tail)
has caused the debbugs.gnu.org bug report #13835,
regarding [PATCH] Let reverse! accept arbitrary types as second argument (new_tail)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13835: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13835
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Kastrup <dak <at> gnu.org>
To: bug-guile <at> gnu.org
Cc: David Kastrup <dak <at> gnu.org>
Subject: [PATCH] Let reverse! accept arbitrary types as second argument
	(new_tail)
Date: Wed, 27 Feb 2013 16:37:21 +0100

There is no reason to restrict the type of the second argument to proper
lists as it is added as last CDR to the list without interpretation.

This allows for stack-depth friendly usage (simplified from an actual
use case that blew up around my ears) like

SCM
my_tree_copy (SCM src)
{
  if (scm_is_pair (src))
    {
      SCM res = SCM_EOL;
      do
        {
          res = scm_cons (my_tree_copy (scm_car (src)), res);
          src = scm_cdr (src);
        }
      while (scm_is_pair (src));
      return scm_reverse_x (res, my_tree_copy (src));
    }
  return src;
}

* libguile/list.c (scm_reverse_x): remove typecheck for 2nd arg
---
 libguile/list.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/libguile/list.c b/libguile/list.c
index 6c8f8be..d30f9e8 100644
--- a/libguile/list.c
+++ b/libguile/list.c
@@ -377,8 +377,6 @@ SCM_DEFINE (scm_reverse_x, "reverse!", 1, 1, 0,
   SCM_VALIDATE_LIST (1, lst);
   if (SCM_UNBNDP (new_tail))
     new_tail = SCM_EOL;
-  else
-    SCM_VALIDATE_LIST (2, new_tail);
 
   while (!SCM_NULL_OR_NIL_P (lst))
     {
-- 
1.7.10.4

[Message part 3 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: David Kastrup <dak <at> gnu.org>
Cc: 13835-done <at> debbugs.gnu.org
Subject: Re: bug#13835: [PATCH] Let reverse! accept arbitrary types as second
	argument (new_tail)
Date: Wed, 27 Feb 2013 20:50:24 -0500

David Kastrup <dak <at> gnu.org> writes:
> There is no reason to restrict the type of the second argument to proper
> lists as it is added as last CDR to the list without interpretation.
>
> This allows for stack-depth friendly usage [...]

Looks good to me.  Applied, thanks!

    Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.