GNU bug report logs - #13831
24.3.50; [PATCH] net-utils-mode have no revert-buffer function

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13831 <at> debbugs.gnu.org
Subject: bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function
Date: Wed, 13 Mar 2013 15:43:48 +0100

Hi Stefan,

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> Installed, thank you,

Ok thanks.

Also here something wrong also:

--8<---------------cut here---------------start------------->8---
;; Simplified versions of some at-point functions from ffap.el.
;; It's not worth loading all of ffap just for these.
(defun net-utils-machine-at-point ()
--8<---------------cut here---------------end--------------->8---

This function return not only machine but anything at point, which is
annoying.

Thus we find some lines later:

--8<---------------cut here---------------start------------->8---
    (read-from-minibuffer "Lookup host: "
                          (or (ffap-string-at-point 'machine) ""))))
--8<---------------cut here---------------end--------------->8---

And ffap is not required.

I think actually it is not a problem loading ffap when needed:

--8<---------------cut here---------------start------------->8---
  (defun net-utils-machine-at-point ()
    (require 'ffap)
    (ffap-machine-at-point))

  (defun net-utils-url-at-point ()
    (require 'ffap)
    (ffap-url-at-point))
--8<---------------cut here---------------end--------------->8---

This reduce code and do the right thing.

I can send a patch if ok.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.