GNU bug report logs - #13780
24.2; Making find-file-hook customizable seems to cause troublle

Previous Next

Package: emacs;

Reported by: Reuben Thomas <rrt <at> sc3d.org>

Date: Fri, 22 Feb 2013 00:36:01 UTC

Severity: minor

Tags: patch, wontfix

Found in version 24.2

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 13780 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13780 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, rrt <at> sc3d.org
Subject: Re: bug#13780: 24.2; Making find-file-hook customizable seems to
 cause troublle
Date: Wed, 25 Nov 2020 16:07:00 -0500
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>>
>> >>> So until Custom is fixed to actually properly handle customisation of
>> >>> hooks (e.g. by storing "add functions foo, bar, and baz" rather than
>> >>> "ignore current value and just set it to (foo bar baz)").
>> >> This sentence seems to be missing its main clause…
>> >
>> > That's not just an appearance.  Its main clause is:
>> >
>> >    So until Custom ...blabla... I think it's better to use defcustom for
>> >    hooks very sparingly, i.e. only for those hook we can reasonably
>> >    expect will only be modified by the user's customization.
>
> IMO, this rationale is good for future additions, not for
> already-existing user options.  We cannot un-defcustom a user option
> just because someone became confused by some subtle use case.  This is
> the price we pay for the flexibility and power we have in Emacs.

Fine by me.




This bug report was last modified 4 years and 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.