Subject: bug#13780: 24.2; Making find-file-hook customizable seems to cause troublle

From: Stefan Kangas <[email-masked]>
Date: Fri, 4 Dec 2020 06:05:47 -0500

tags 13780 + wontfix
close 13780
thanks

Stefan Kangas <[email-masked]> writes:

> Eli Zaretskii <[email-masked]> writes:
>
>>> Stefan Monnier <[email-masked]> writes:
>>>
>>> >>> So until Custom is fixed to actually properly handle customisation of
>>> >>> hooks (e.g. by storing "add functions foo, bar, and baz" rather than
>>> >>> "ignore current value and just set it to (foo bar baz)").
>>> >> This sentence seems to be missing its main clause…
>>> >
>>> > That's not just an appearance.  Its main clause is:
>>> >
>>> >    So until Custom ...blabla... I think it's better to use defcustom for
>>> >    hooks very sparingly, i.e. only for those hook we can reasonably
>>> >    expect will only be modified by the user's customization.
>>
>> IMO, this rationale is good for future additions, not for
>> already-existing user options.  We cannot un-defcustom a user option
>> just because someone became confused by some subtle use case.  This is
>> the price we pay for the flexibility and power we have in Emacs.
>
> Fine by me.

No further comments within 7 days, closing as wontfix.