GNU bug report logs - #13777
[patch] Add toolbars for Edebug and debugger-mode

Previous Next

Full log

Message #8 received at 13777 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 13777 <at> debbugs.gnu.org
Subject: Re: bug#13777: [patch] Add toolbars for Edebug and debugger-mode
Date: Wed, 08 May 2013 03:50:35 -0400

Thanks for the patches.

Xue Fuqiao wrote:

> *** trunk/lisp/emacs-lisp/edebug.el.orig 2013-02-03
> 09:46:50.383143000 +0800
> --- trunk/lisp/emacs-lisp/edebug.el 2013-02-21
> 18:10:30.220096536 +0800 *************** be installed in
> `emacs-lisp-mode-map'.") *** 3727,3732 ****
> --- 3727,3745 ----

(These patches seem mangled somehow?)

> + (defvar edebug-tool-bar-map
> +   (let ((map (make-sparse-keymap)))
> +     (dolist (x '((edebug-set-breakpoint . "gud/break")
> + 		 (edebug-unset-breakpoint . "gud/remove")
> + 		 (edebug-go-mode . "gud/go")
> + 		 (edebug-stop . "gud/stop")
> + 		 (edebug-continue-mode . "gud/cont")
> + 		 (edebug-next-mode . "gud/next")
> + 		 (edebug-step-mode . "gud/step"))
> + 	       map)
> +       (tool-bar-local-item-from-menu
> +        (car x) (cdr x) map edebug-mode-map))))

Looks alright but:

i) I think this needs to be moved after the easy-menu-define call.

ii) You need to find a way to restore the normal tool-bar after edebug
exits (for whatever reason).

> + (defvar debugger-tool-bar-map
> +   (let ((map (make-sparse-keymap)))
> +     (dolist (x '((debugger-continue . "gud/cont")
> + 		 (debugger-step-through . "gud/step"))
> + 	       map)
> +       (tool-bar-local-item-from-menu
> +        (car x) (cdr x) map debugger-mode-map))))

Looks ok, but it's a very sparse tool-bar. Is there nothing more that
can go in it? It looks a bit silly with just 2 items...
Maybe keep some of the standard ones?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.