From unknown Tue Aug 19 23:13:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 13777@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136144385717102 (code B ref -1); Thu, 21 Feb 2013 10:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2013 10:50:57 +0000 Received: from localhost ([127.0.0.1]:41475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Tjs-0004Rm-Dp for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:50:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40602) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Tjp-0004Rd-Fy for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:50:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8TiW-0004EA-UK for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:49:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiW-0004Dq-R5 for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:49:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiR-0003rh-0N for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8TiK-00044w-Dm for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:26 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiK-00044n-4U for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:20 -0500 Received: by mail-pa0-f53.google.com with SMTP id bg4so4627499pad.40 for ; Thu, 21 Feb 2013 02:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:organization:x-mailer :mime-version:content-type:content-transfer-encoding; bh=GHI71aTd676OQaY0Kqihz/iW0me09thHRx87VINqsME=; b=VAx3/ng3UUic+jDglfLQceeXOdnyV/1WV39wIwJl55bxBpyKKh/jhh602OZHA0p0Lb kuT2D16JwB4aYLkI8hoKF17yGvJtkDl0J4uKoy+O5YpH1kZi0KbFaGet9EBbDtwmb4kc KDiDFa0PI8IaK6tvMxr/5qaFiFpnJbSL46WP1n7dBqCHY1jsVfuQgaw6xfVg18ojf34y zYkJe4P2fDhgITI5Bvp1+nlWy6dZXX1XwksyBHvdHA77bjmYBGS/Ll0iutaOAA6gcgOd 3R4n/9Oh3YUfPirKm1czm0fR0jt7rbPh+yH8bx79TkH2VTzTIB5E6HMjmOqo0EQ+vv66 45tA== X-Received: by 10.68.191.9 with SMTP id gu9mr54313878pbc.23.1361443759130; Thu, 21 Feb 2013 02:49:19 -0800 (PST) Received: from Emacs ([123.114.124.215]) by mx.google.com with ESMTPS id x2sm114628969paw.8.2013.02.21.02.49.16 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Feb 2013 02:49:18 -0800 (PST) Date: Thu, 21 Feb 2013 18:49:13 +0800 From: Xue Fuqiao Message-Id: <20130221184913.101bd49379994f15f3156829@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) The following patch adds toolbars for Edebug and debugger-mode: *** trunk/etc/TODO.orig 2013-02-10 19:50:32.740492000 +0800 --- trunk/etc/TODO 2013-02-21 18:37:30.696132043 +0800 *************** not have one at the moment and probably *** 52,60 **** ** Check if all items on the mode-line have a suitable tooltip for all modes. - ** edebug and debugger-mode should have a toolbar. - It can use the same icons as gud. - ** Check what minor modes don't use define-minor-mode and convert them to use it. --- 52,57 ---- *** trunk/lisp/emacs-lisp/edebug.el.orig 2013-02-03 09:46:50.383143000 +0800 --- trunk/lisp/emacs-lisp/edebug.el 2013-02-21 18:10:30.220096536 +0800 *************** be installed in `emacs-lisp-mode-map'.") *** 3727,3732 **** --- 3727,3745 ---- (define-key map "\C-c\C-l" 'edebug-where) map)) + (defvar edebug-tool-bar-map + (let ((map (make-sparse-keymap))) + (dolist (x '((edebug-set-breakpoint . "gud/break") + (edebug-unset-breakpoint . "gud/remove") + (edebug-go-mode . "gud/go") + (edebug-stop . "gud/stop") + (edebug-continue-mode . "gud/cont") + (edebug-next-mode . "gud/next") + (edebug-step-mode . "gud/step")) + map) + (tool-bar-local-item-from-menu + (car x) (cdr x) map edebug-mode-map)))) + ;; Autoloading these global bindings doesn't make sense because ;; they cannot be used anyway unless Edebug is already loaded and active. *************** Options: *** 3811,3817 **** ;; exit to top level, because the edebug command loop can't usefully ;; continue running in such a case. (add-hook 'kill-buffer-hook 'edebug-kill-buffer nil t) ! (use-local-map edebug-mode-map)) (defun edebug-kill-buffer () "Used on `kill-buffer-hook' when Edebug is operating in a buffer of Lisp code." --- 3824,3831 ---- ;; exit to top level, because the edebug command loop can't usefully ;; continue running in such a case. (add-hook 'kill-buffer-hook 'edebug-kill-buffer nil t) ! (use-local-map edebug-mode-map) ! (set (make-local-variable 'tool-bar-map) edebug-tool-bar-map)) (defun edebug-kill-buffer () "Used on `kill-buffer-hook' when Edebug is operating in a buffer of Lisp code." *** trunk/lisp/emacs-lisp/debug.el.orig 2013-02-21 18:46:46.462887964 +0800 --- trunk/lisp/emacs-lisp/debug.el 2013-02-21 18:32:39.786689513 +0800 *************** Applies to the frame whose line point is *** 702,707 **** --- 702,715 ---- :help "Proceed, stepping through subexpressions of this expression")) map)) + (defvar debugger-tool-bar-map + (let ((map (make-sparse-keymap))) + (dolist (x '((debugger-continue . "gud/cont") + (debugger-step-through . "gud/step")) + map) + (tool-bar-local-item-from-menu + (car x) (cdr x) map debugger-mode-map)))) + (put 'debugger-mode 'mode-class 'special) (defun debugger-mode () *************** Complete list of commands: *** 725,730 **** --- 733,739 ---- (setq truncate-lines t) (set-syntax-table emacs-lisp-mode-syntax-table) (use-local-map debugger-mode-map) + (set (make-local-variable 'tool-bar-map) debugger-tool-bar-map) (run-mode-hooks 'debugger-mode-hook)) (defcustom debugger-record-buffer "*Debugger-record*" *** trunk/lisp/ChangeLog.orig 2013-02-17 22:42:17.309803000 +0800 --- trunk/lisp/ChangeLog 2013-02-21 18:36:47.851919598 +0800 *************** *** 1,3 **** --- 1,9 ---- + 2013-02-21 Xue Fuqiao + + * emacs-lisp/debug.el: Add a toolbar for debugger-mode. + + * emacs-lisp/edebug.el (edebug-mode): Add a toolbar. + 2013-02-17 Glenn Morris * menu-bar.el (menu-bar-tools-menu): Fix case of EDE entry. -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao From unknown Tue Aug 19 23:13:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2013 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Xue Fuqiao Cc: 13777@debbugs.gnu.org Received: via spool by 13777-submit@debbugs.gnu.org id=B13777.136799950910139 (code B ref 13777); Wed, 08 May 2013 07:52:02 +0000 Received: (at 13777) by debbugs.gnu.org; 8 May 2013 07:51:49 +0000 Received: from localhost ([127.0.0.1]:33543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZzAA-0002dP-Gd for submit@debbugs.gnu.org; Wed, 08 May 2013 03:51:48 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:46793) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZzA7-0002dB-BW for 13777@debbugs.gnu.org; Wed, 08 May 2013 03:51:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UZz91-0003b0-4d; Wed, 08 May 2013 03:50:35 -0400 From: Glenn Morris References: <20130221184913.101bd49379994f15f3156829@gmail.com> X-Spook: president MD2 ASIO Merlin Leuken-Baden jihad Al-Qaeda X-Ran: ?f!{[v*l8iViFSNO2@\:;\,* X-Hue: blue X-Attribution: GM Date: Wed, 08 May 2013 03:50:35 -0400 In-Reply-To: <20130221184913.101bd49379994f15f3156829@gmail.com> (Xue Fuqiao's message of "Thu, 21 Feb 2013 18:49:13 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -8.2 (--------) Thanks for the patches. Xue Fuqiao wrote: > *** trunk/lisp/emacs-lisp/edebug.el.orig 2013-02-03 > 09:46:50.383143000 +0800 > --- trunk/lisp/emacs-lisp/edebug.el 2013-02-21 > 18:10:30.220096536 +0800 *************** be installed in > `emacs-lisp-mode-map'.") *** 3727,3732 **** > --- 3727,3745 ---- (These patches seem mangled somehow?) > + (defvar edebug-tool-bar-map > + (let ((map (make-sparse-keymap))) > + (dolist (x '((edebug-set-breakpoint . "gud/break") > + (edebug-unset-breakpoint . "gud/remove") > + (edebug-go-mode . "gud/go") > + (edebug-stop . "gud/stop") > + (edebug-continue-mode . "gud/cont") > + (edebug-next-mode . "gud/next") > + (edebug-step-mode . "gud/step")) > + map) > + (tool-bar-local-item-from-menu > + (car x) (cdr x) map edebug-mode-map)))) Looks alright but: i) I think this needs to be moved after the easy-menu-define call. ii) You need to find a way to restore the normal tool-bar after edebug exits (for whatever reason). > + (defvar debugger-tool-bar-map > + (let ((map (make-sparse-keymap))) > + (dolist (x '((debugger-continue . "gud/cont") > + (debugger-step-through . "gud/step")) > + map) > + (tool-bar-local-item-from-menu > + (car x) (cdr x) map debugger-mode-map)))) Looks ok, but it's a very sparse tool-bar. Is there nothing more that can go in it? It looks a bit silly with just 2 items... Maybe keep some of the standard ones? From unknown Tue Aug 19 23:13:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2013 09:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Glenn Morris Cc: 13777@debbugs.gnu.org Received: via spool by 13777-submit@debbugs.gnu.org id=B13777.13680060733671 (code B ref 13777); Wed, 08 May 2013 09:42:02 +0000 Received: (at 13777) by debbugs.gnu.org; 8 May 2013 09:41:13 +0000 Received: from localhost ([127.0.0.1]:33608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua0s0-0000wq-OT for submit@debbugs.gnu.org; Wed, 08 May 2013 05:41:12 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:45892) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua0rv-0000wM-AA for 13777@debbugs.gnu.org; Wed, 08 May 2013 05:41:07 -0400 Received: by mail-ie0-f180.google.com with SMTP id ar20so2734710iec.39 for <13777@debbugs.gnu.org>; Wed, 08 May 2013 02:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=msSP5LTGt4YC4j3GCYvPRfnDYXnmv02E+NTlw/A1Utk=; b=DKWyoVVr1uftTqcinPOQEpC3+eTUjgBwn2tyccri2/itwgvitsfTFwhmZIuBMDmg0g tPyEfgCM1jAyYu88abHB5XAQ0k6+8BM1OtKlreReJSHJ6bw0KayU4wzo0VlPfj3NL/Al DK1G9E7vfufD2UMR8DWywW1LCLYfHO7VAkw2YmP5fYU8EWBp4nokt4OXF2p+l/RWOYmh 4KqT050OQeCxPbZ4i0c69p0BsS35Vfx4GXOMlgToze64IpswkkQ4wJkNY5QXsNkkphmI cXM7QLTCVXBdAz9yK27iPlPerE1xj+/SV4mpwWuBCImL/QvWLiWwtaPz8vX/KgNBSGLu 4WAg== MIME-Version: 1.0 X-Received: by 10.50.114.166 with SMTP id jh6mr5157184igb.78.1368005995283; Wed, 08 May 2013 02:39:55 -0700 (PDT) Received: by 10.43.18.10 with HTTP; Wed, 8 May 2013 02:39:55 -0700 (PDT) In-Reply-To: References: <20130221184913.101bd49379994f15f3156829@gmail.com> Date: Wed, 8 May 2013 17:39:55 +0800 Message-ID: From: Xue Fuqiao Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Wed, May 8, 2013 at 3:50 PM, Glenn Morris wrote: >> + (defvar edebug-tool-bar-map >> + (let ((map (make-sparse-keymap))) >> + (dolist (x '((edebug-set-breakpoint . "gud/break") >> + (edebug-unset-breakpoint . "gud/remove") >> + (edebug-go-mode . "gud/go") >> + (edebug-stop . "gud/stop") >> + (edebug-continue-mode . "gud/cont") >> + (edebug-next-mode . "gud/next") >> + (edebug-step-mode . "gud/step")) >> + map) >> + (tool-bar-local-item-from-menu >> + (car x) (cdr x) map edebug-mode-map)))) > > Looks alright but: > > i) I think this needs to be moved after the easy-menu-define call. > > ii) You need to find a way to restore the normal tool-bar after edebug > exits (for whatever reason). Agreed. >> + (defvar debugger-tool-bar-map >> + (let ((map (make-sparse-keymap))) >> + (dolist (x '((debugger-continue . "gud/cont") >> + (debugger-step-through . "gud/step")) >> + map) >> + (tool-bar-local-item-from-menu >> + (car x) (cdr x) map debugger-mode-map)))) > > Looks ok, but it's a very sparse tool-bar. Is there nothing more that > can go in it? There are some candidates, such as `backtrace', `cancel-debug-on-entry'. But I haven't found suitable icons for them yet. > It looks a bit silly with just 2 items... Maybe keep some of the > standard ones? Sounds like a good compromise. -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ From unknown Tue Aug 19 23:13:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2013 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Xue Fuqiao Cc: Glenn Morris , 13777@debbugs.gnu.org Received: via spool by 13777-submit@debbugs.gnu.org id=B13777.136802573117665 (code B ref 13777); Wed, 08 May 2013 15:09:01 +0000 Received: (at 13777) by debbugs.gnu.org; 8 May 2013 15:08:51 +0000 Received: from localhost ([127.0.0.1]:33982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua5z8-0004aq-SY for submit@debbugs.gnu.org; Wed, 08 May 2013 11:08:51 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:54553) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ua5z6-0004ae-PL for 13777@debbugs.gnu.org; Wed, 08 May 2013 11:08:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="11557439" Received: from 184-175-6-252.dsl.teksavvy.com (HELO pastel.home) ([184.175.6.252]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 May 2013 11:07:35 -0400 Received: by pastel.home (Postfix, from userid 20848) id F31AD67A20; Wed, 8 May 2013 11:07:38 -0400 (EDT) From: Stefan Monnier Message-ID: References: <20130221184913.101bd49379994f15f3156829@gmail.com> Date: Wed, 08 May 2013 11:07:38 -0400 In-Reply-To: (Xue Fuqiao's message of "Wed, 8 May 2013 17:39:55 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> ii) You need to find a way to restore the normal tool-bar after edebug >> exits (for whatever reason). > Agreed. The code on trunk has changed, made edebug-mode into a "proper" minor mode, and includes the necessary infrastructure to restore the old value (it uses it for buffer-read-only). Stefan From unknown Tue Aug 19 23:13:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 05:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Xue Fuqiao , Glenn Morris , 13777@debbugs.gnu.org Received: via spool by 13777-submit@debbugs.gnu.org id=B13777.145629274819035 (code B ref 13777); Wed, 24 Feb 2016 05:46:02 +0000 Received: (at 13777) by debbugs.gnu.org; 24 Feb 2016 05:45:48 +0000 Received: from localhost ([127.0.0.1]:42244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYSGh-0004wn-Q8 for submit@debbugs.gnu.org; Wed, 24 Feb 2016 00:45:48 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36538) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYSGf-0004u1-EU for 13777@debbugs.gnu.org; Wed, 24 Feb 2016 00:45:45 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYSGH-0002Au-9C; Wed, 24 Feb 2016 06:45:22 +0100 From: Lars Ingebrigtsen References: <20130221184913.101bd49379994f15f3156829@gmail.com> Date: Wed, 24 Feb 2016 16:45:15 +1100 In-Reply-To: (Stefan Monnier's message of "Wed, 08 May 2013 11:07:38 -0400") Message-ID: <87bn76fyqc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYSGH-0002Au-9C X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456897522.62482@ad1vViQ/WfyT8qZop2zRGA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >>> ii) You need to find a way to restore the normal tool-bar after edebug >>> exits (for whatever reason). >> Agreed. > > The code on trunk has changed, made edebug-mode into a "proper" minor > mode, and includes the necessary infrastructure to restore the old value > (it uses it for buffer-read-only). Xue, could you respin the toolbar patches for the Emacs trunk? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 23:13:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xue Fuqiao Subject: bug#13777: closed (Re: bug#13777: [patch] Add toolbars for Edebug and debugger-mode) Message-ID: References: <20130221184913.101bd49379994f15f3156829@gmail.com> X-Gnu-PR-Message: they-closed 13777 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 13777@debbugs.gnu.org Date: Thu, 25 Feb 2016 00:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1456360082-7419-1" This is a multi-part message in MIME format... ------------=_1456360082-7419-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13777: [patch] Add toolbars for Edebug and debugger-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13777@debbugs.gnu.org. --=20 13777: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13777 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1456360082-7419-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13777-done) by debbugs.gnu.org; 25 Feb 2016 00:27:08 +0000 Received: from localhost ([127.0.0.1]:44418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYjlo-0001uN-Nc for submit@debbugs.gnu.org; Wed, 24 Feb 2016 19:27:08 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:34368) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYjlj-0001tq-GE for 13777-done@debbugs.gnu.org; Wed, 24 Feb 2016 19:27:03 -0500 Received: by mail-ig0-f178.google.com with SMTP id g6so3095561igt.1 for <13777-done@debbugs.gnu.org>; Wed, 24 Feb 2016 16:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=0ZT0giBVVBC8mo9hvPrf/7SlxgKBJLkoMsFFe6N+WrE=; b=HFcLpqrLn7lAfRM9kAyEATzoo1RCG5KcXh7GSuDJ6YNQ90zeppVQ5PJb0SIXY+MZrF iGjuo72NXjcl7AlXmGhs+KtFgcWJiQC4k0A9t6TfCXZY64WRY1OH5yOCve6QKhLSQOp/ DCvQ++mVnSeaVanVfR261tM54YdqqqEdal7OR0miMLkK56in0aBVjC76W6vv5IgdZmwh luuxoZKL1ABYaz8dz3CPUwPzYTjMkEehwbkRl0OHS/xWkMJOKDtWxX5+hSl6D9RBFxk2 L99Qe+qu7lKUMtEmqt+zmB6vlsAYHMutMhRy5uF65z5BSLIOse/H54MwtvM7PeD42iid 0a3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=0ZT0giBVVBC8mo9hvPrf/7SlxgKBJLkoMsFFe6N+WrE=; b=RmNvL6d7eRZBWy8TVkyxuTR8gn6IeUlzmY3IO8MWjah1OwonBV8MaRPS9VDYbRMs9M R8KXeyIRewtHTFxuwH8G4MoLVa3XvxhyIoCQuJMR/MnNZ+lMe5EJicjREkvJ/17v1dZi 3lW72MRPcedXnhMKO2DOeOmEW0Trv87+oM3YKIwgOV9V9smTGzAfP+0Ufqg7rsfuYMjy NTYrzJZbbdJfpAATKiP9C5/7Tm8Cz42ItwpWyXY1GGApzTSI0lCjvMslOTEl47uu4d7m UWYENBMPdW8qglwPgJ+Jjn1Q+vYKoNasZV98FZhLJDK+1Vw/GuYfI3ZzZkEGuAkATdWn sFGA== X-Gm-Message-State: AG10YOSv3NmgbGRr30nXlaHRZPfUNNRZ886IIKMoUSM29vMQKIGb9Vf+HYku1wOW61eh9+W5o9fO/S9uN3JA+Q== MIME-Version: 1.0 X-Received: by 10.50.110.99 with SMTP id hz3mr517948igb.16.1456360013906; Wed, 24 Feb 2016 16:26:53 -0800 (PST) Received: by 10.79.127.68 with HTTP; Wed, 24 Feb 2016 16:26:53 -0800 (PST) Date: Thu, 25 Feb 2016 08:26:53 +0800 Message-ID: Subject: Re: bug#13777: [patch] Add toolbars for Edebug and debugger-mode From: Xue Fuqiao To: 13777-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13777-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Feb 24, 2016 at 1:45 PM, Lars Ingebrigtsen wrote: > Xue, could you respin the toolbar patches for the Emacs trunk? Sorry, I've been too busy these days. I'll close this bug for now. I will submit a new bug report or reopen this bug when I have time. Thanks for working on these old bugs, Lars! ------------=_1456360082-7419-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Feb 2013 10:50:57 +0000 Received: from localhost ([127.0.0.1]:41475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Tjs-0004Rm-Dp for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:50:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40602) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Tjp-0004Rd-Fy for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:50:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8TiW-0004EA-UK for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:49:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiW-0004Dq-R5 for submit@debbugs.gnu.org; Thu, 21 Feb 2013 05:49:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiR-0003rh-0N for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8TiK-00044w-Dm for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:26 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8TiK-00044n-4U for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 05:49:20 -0500 Received: by mail-pa0-f53.google.com with SMTP id bg4so4627499pad.40 for ; Thu, 21 Feb 2013 02:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:organization:x-mailer :mime-version:content-type:content-transfer-encoding; bh=GHI71aTd676OQaY0Kqihz/iW0me09thHRx87VINqsME=; b=VAx3/ng3UUic+jDglfLQceeXOdnyV/1WV39wIwJl55bxBpyKKh/jhh602OZHA0p0Lb kuT2D16JwB4aYLkI8hoKF17yGvJtkDl0J4uKoy+O5YpH1kZi0KbFaGet9EBbDtwmb4kc KDiDFa0PI8IaK6tvMxr/5qaFiFpnJbSL46WP1n7dBqCHY1jsVfuQgaw6xfVg18ojf34y zYkJe4P2fDhgITI5Bvp1+nlWy6dZXX1XwksyBHvdHA77bjmYBGS/Ll0iutaOAA6gcgOd 3R4n/9Oh3YUfPirKm1czm0fR0jt7rbPh+yH8bx79TkH2VTzTIB5E6HMjmOqo0EQ+vv66 45tA== X-Received: by 10.68.191.9 with SMTP id gu9mr54313878pbc.23.1361443759130; Thu, 21 Feb 2013 02:49:19 -0800 (PST) Received: from Emacs ([123.114.124.215]) by mx.google.com with ESMTPS id x2sm114628969paw.8.2013.02.21.02.49.16 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Feb 2013 02:49:18 -0800 (PST) Date: Thu, 21 Feb 2013 18:49:13 +0800 From: Xue Fuqiao To: bug-gnu-emacs@gnu.org Subject: [patch] Add toolbars for Edebug and debugger-mode Message-Id: <20130221184913.101bd49379994f15f3156829@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) The following patch adds toolbars for Edebug and debugger-mode: *** trunk/etc/TODO.orig 2013-02-10 19:50:32.740492000 +0800 --- trunk/etc/TODO 2013-02-21 18:37:30.696132043 +0800 *************** not have one at the moment and probably *** 52,60 **** ** Check if all items on the mode-line have a suitable tooltip for all modes. - ** edebug and debugger-mode should have a toolbar. - It can use the same icons as gud. - ** Check what minor modes don't use define-minor-mode and convert them to use it. --- 52,57 ---- *** trunk/lisp/emacs-lisp/edebug.el.orig 2013-02-03 09:46:50.383143000 +0800 --- trunk/lisp/emacs-lisp/edebug.el 2013-02-21 18:10:30.220096536 +0800 *************** be installed in `emacs-lisp-mode-map'.") *** 3727,3732 **** --- 3727,3745 ---- (define-key map "\C-c\C-l" 'edebug-where) map)) + (defvar edebug-tool-bar-map + (let ((map (make-sparse-keymap))) + (dolist (x '((edebug-set-breakpoint . "gud/break") + (edebug-unset-breakpoint . "gud/remove") + (edebug-go-mode . "gud/go") + (edebug-stop . "gud/stop") + (edebug-continue-mode . "gud/cont") + (edebug-next-mode . "gud/next") + (edebug-step-mode . "gud/step")) + map) + (tool-bar-local-item-from-menu + (car x) (cdr x) map edebug-mode-map)))) + ;; Autoloading these global bindings doesn't make sense because ;; they cannot be used anyway unless Edebug is already loaded and active. *************** Options: *** 3811,3817 **** ;; exit to top level, because the edebug command loop can't usefully ;; continue running in such a case. (add-hook 'kill-buffer-hook 'edebug-kill-buffer nil t) ! (use-local-map edebug-mode-map)) (defun edebug-kill-buffer () "Used on `kill-buffer-hook' when Edebug is operating in a buffer of Lisp code." --- 3824,3831 ---- ;; exit to top level, because the edebug command loop can't usefully ;; continue running in such a case. (add-hook 'kill-buffer-hook 'edebug-kill-buffer nil t) ! (use-local-map edebug-mode-map) ! (set (make-local-variable 'tool-bar-map) edebug-tool-bar-map)) (defun edebug-kill-buffer () "Used on `kill-buffer-hook' when Edebug is operating in a buffer of Lisp code." *** trunk/lisp/emacs-lisp/debug.el.orig 2013-02-21 18:46:46.462887964 +0800 --- trunk/lisp/emacs-lisp/debug.el 2013-02-21 18:32:39.786689513 +0800 *************** Applies to the frame whose line point is *** 702,707 **** --- 702,715 ---- :help "Proceed, stepping through subexpressions of this expression")) map)) + (defvar debugger-tool-bar-map + (let ((map (make-sparse-keymap))) + (dolist (x '((debugger-continue . "gud/cont") + (debugger-step-through . "gud/step")) + map) + (tool-bar-local-item-from-menu + (car x) (cdr x) map debugger-mode-map)))) + (put 'debugger-mode 'mode-class 'special) (defun debugger-mode () *************** Complete list of commands: *** 725,730 **** --- 733,739 ---- (setq truncate-lines t) (set-syntax-table emacs-lisp-mode-syntax-table) (use-local-map debugger-mode-map) + (set (make-local-variable 'tool-bar-map) debugger-tool-bar-map) (run-mode-hooks 'debugger-mode-hook)) (defcustom debugger-record-buffer "*Debugger-record*" *** trunk/lisp/ChangeLog.orig 2013-02-17 22:42:17.309803000 +0800 --- trunk/lisp/ChangeLog 2013-02-21 18:36:47.851919598 +0800 *************** *** 1,3 **** --- 1,9 ---- + 2013-02-21 Xue Fuqiao + + * emacs-lisp/debug.el: Add a toolbar for debugger-mode. + + * emacs-lisp/edebug.el (edebug-mode): Add a toolbar. + 2013-02-17 Glenn Morris * menu-bar.el (menu-bar-tools-menu): Fix case of EDE entry. -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao ------------=_1456360082-7419-1--