From unknown Fri Sep 05 20:55:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13774 <13774@debbugs.gnu.org> To: bug#13774 <13774@debbugs.gnu.org> Subject: Status: [patch] Use `completion-at-point' instead of `comint-dynamic-complete' Reply-To: bug#13774 <13774@debbugs.gnu.org> Date: Sat, 06 Sep 2025 03:55:59 +0000 retitle 13774 [patch] Use `completion-at-point' instead of `comint-dynamic-= complete' reassign 13774 emacs submitter 13774 Xue Fuqiao severity 13774 minor tag 13774 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 21 01:48:18 2013 Received: (at submit) by debbugs.gnu.org; 21 Feb 2013 06:48:18 +0000 Received: from localhost ([127.0.0.1]:41172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Px3-0007Om-PL for submit@debbugs.gnu.org; Thu, 21 Feb 2013 01:48:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52044) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Px1-0007Of-0r for submit@debbugs.gnu.org; Thu, 21 Feb 2013 01:48:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8Pvm-0007Qb-GA for submit@debbugs.gnu.org; Thu, 21 Feb 2013 01:47:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8Pvm-0007QV-DA for submit@debbugs.gnu.org; Thu, 21 Feb 2013 01:46:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8Pvl-0001k8-0f for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 01:46:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8Pvj-0007Pg-1S for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 01:46:56 -0500 Received: from mail-pb0-f51.google.com ([209.85.160.51]:49624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8Pvi-0007PO-Nu for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2013 01:46:54 -0500 Received: by mail-pb0-f51.google.com with SMTP id un15so3328948pbc.38 for ; Wed, 20 Feb 2013 22:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:organization:x-mailer :mime-version:content-type:content-transfer-encoding; bh=f337dIH2K6Xo64iz3O1PrPVj0Z8EggN8WyTMZ0d5T4A=; b=PPKZgYCSKH8oPHPZm6Zt069CwFxDlbmkdR38xWMIrBrGKtxLWZ3SkHUx70HQspCsB+ c6jTHJnV75pLY53B0jMe3F6kx+GfkGCcfoVxA3k9gs/5Lv8yWpuFdkkL0iObiB/axCZt MiqeCk8JWppOWM4fk8eutBqM+k0vEoZqSZ9ghuKEIK+7f9JM4hDiq0xGEXEV63FG/rQy nJZLCotUDeLirCqMOMZ1vHetB3vJCH2Ks5C6sNTv7B0QQ6c5B0W1wGvW3S4I219n9vDV XmVFbGl5E5tJLaGatmPfWC0/lLnGULq/jTY9ZvvwvB6DsdRO3robITgB5e7yWe0ay2JX nS4A== X-Received: by 10.66.160.9 with SMTP id xg9mr6760659pab.135.1361429213949; Wed, 20 Feb 2013 22:46:53 -0800 (PST) Received: from Emacs ([219.224.52.162]) by mx.google.com with ESMTPS id ww9sm24311773pbc.41.2013.02.20.22.46.52 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Feb 2013 22:46:53 -0800 (PST) Date: Thu, 21 Feb 2013 14:46:50 +0800 From: Xue Fuqiao To: bug-gnu-emacs@gnu.org Subject: [patch] Use `completion-at-point' instead of `comint-dynamic-complete' Message-Id: <20130221144650.9aa0061ff0da86ac890bd565@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Since `comint-dynamic-complete' is obsolete since 24.1, I made the following patch: *** trunk/lisp/ChangeLog.orig 2013-02-17 22:42:17.309803000 +0800 --- trunk/lisp/ChangeLog 2013-02-21 14:42:36.373241996 +0800 *************** *** 1,3 **** --- 1,9 ---- + 2013-02-21 Xue Fuqiao + + * comint.el: Remove `comint-dynamic-complete'. + + * ielm.el: Remove `comint-dynamic-complete'. + 2013-02-17 Glenn Morris * menu-bar.el (menu-bar-tools-menu): Fix case of EDE entry. *** trunk/lisp/comint.el.orig 2013-02-03 09:46:50.383143000 +0800 --- trunk/lisp/comint.el 2013-02-21 14:34:18.066771022 +0800 *************** This mirrors the optional behavior of tc *** 213,219 **** If the value is `input', then the expansion is seen on input. If the value is `history', then the expansion is only when inserting into the buffer's input ring. See also `comint-magic-space' and ! `comint-dynamic-complete'. This variable is buffer-local." :type '(choice (const :tag "off" nil) --- 213,219 ---- If the value is `input', then the expansion is seen on input. If the value is `history', then the expansion is only when inserting into the buffer's input ring. See also `comint-magic-space' and ! `completion-at-point'. This variable is buffer-local." :type '(choice (const :tag "off" nil) *************** text matching `comint-prompt-regexp', de *** 371,377 **** '(comint-c-a-p-replace-by-expanded-history comint-filename-completion) "List of functions called to perform completion. Works like `completion-at-point-functions'. ! See also `comint-dynamic-complete'. This is a good thing to set in mode hooks.") --- 371,377 ---- '(comint-c-a-p-replace-by-expanded-history comint-filename-completion) "List of functions called to perform completion. Works like `completion-at-point-functions'. ! See also `completion-at-point'. This is a good thing to set in mode hooks.") *************** Input ring expansion is controlled by th *** 616,622 **** and addition is controlled by the variable `comint-input-ignoredups'. Commands with no default key bindings include `send-invisible', ! `comint-dynamic-complete', `comint-dynamic-list-filename-completions', and `comint-magic-space'. Input to, and output from, the subprocess can cause the window to scroll to --- 616,622 ---- and addition is controlled by the variable `comint-input-ignoredups'. Commands with no default key bindings include `send-invisible', ! `completion-at-point', `comint-dynamic-list-filename-completions', and `comint-magic-space'. Input to, and output from, the subprocess can cause the window to scroll to *************** its response can be seen." *** 2892,2898 **** ;; Useful completion functions, courtesy of the Ergo group. ;; Six commands: ! ;; comint-dynamic-complete Complete or expand command, filename, ;; history at point. ;; comint-dynamic-complete-filename Complete filename at point. ;; comint-dynamic-list-filename-completions List completions in help buffer. --- 2892,2898 ---- ;; Useful completion functions, courtesy of the Ergo group. ;; Six commands: ! ;; completion-at-point Complete or expand command, filename, ;; history at point. ;; comint-dynamic-complete-filename Complete filename at point. ;; comint-dynamic-list-filename-completions List completions in help buffer. *************** its response can be seen." *** 2901,2907 **** ;; These are not installed in the comint-mode keymap. But they are ;; available for people who want them. Shell-mode installs them: ! ;; (define-key shell-mode-map "\t" 'comint-dynamic-complete) ;; (define-key shell-mode-map "\M-?" ;; 'comint-dynamic-list-filename-completions))) ;; --- 2901,2907 ---- ;; These are not installed in the comint-mode keymap. But they are ;; available for people who want them. Shell-mode installs them: ! ;; (define-key shell-mode-map "\t" 'completion-at-point) ;; (define-key shell-mode-map "\M-?" ;; 'comint-dynamic-list-filename-completions))) ;; *************** REGEXP-GROUP is the regular expression g *** 3812,3818 **** ;; (setq shell-mode-map (copy-keymap comint-mode-map)) ;; (define-key shell-mode-map "\C-c\C-f" 'shell-forward-command) ;; (define-key shell-mode-map "\C-c\C-b" 'shell-backward-command) ! ;; (define-key shell-mode-map "\t" 'comint-dynamic-complete) ;; (define-key shell-mode-map "\M-?" ;; 'comint-dynamic-list-filename-completions))) ;; --- 3812,3818 ---- ;; (setq shell-mode-map (copy-keymap comint-mode-map)) ;; (define-key shell-mode-map "\C-c\C-f" 'shell-forward-command) ;; (define-key shell-mode-map "\C-c\C-b" 'shell-backward-command) ! ;; (define-key shell-mode-map "\t" 'completion-at-point) ;; (define-key shell-mode-map "\M-?" ;; 'comint-dynamic-list-filename-completions))) ;; *** trunk/lisp/ielm.el.orig 2013-02-21 14:45:23.078068628 +0800 --- trunk/lisp/ielm.el 2013-02-21 14:39:44.452389458 +0800 *************** This variable is buffer-local.") *** 167,177 **** (defvar ielm-map (let ((map (make-sparse-keymap))) ! (define-key map "\t" 'comint-dynamic-complete) (define-key map "\C-m" 'ielm-return) (define-key map "\C-j" 'ielm-send-input) (define-key map "\e\C-x" 'eval-defun) ; for consistency with - (define-key map "\e\t" 'completion-at-point) ; lisp-interaction-mode ;; These bindings are from `lisp-mode-shared-map' -- can you inherit ;; from more than one keymap?? (define-key map "\e\C-q" 'indent-sexp) --- 167,176 ---- (defvar ielm-map (let ((map (make-sparse-keymap))) ! (define-key map "\t" 'completion-at-point) (define-key map "\C-m" 'ielm-return) (define-key map "\C-j" 'ielm-send-input) (define-key map "\e\C-x" 'eval-defun) ; for consistency with ;; These bindings are from `lisp-mode-shared-map' -- can you inherit ;; from more than one keymap?? (define-key map "\e\C-q" 'indent-sexp) -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 23:21:03 2013 Received: (at 13774-done) by debbugs.gnu.org; 21 Apr 2013 03:21:03 +0000 Received: from localhost ([127.0.0.1]:34332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTkpp-0006Zy-Ss for submit@debbugs.gnu.org; Sat, 20 Apr 2013 23:21:03 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:46457) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UTkpm-0006Zc-DR for 13774-done@debbugs.gnu.org; Sat, 20 Apr 2013 23:20:59 -0400 Received: by mail-ia0-f174.google.com with SMTP id m10so2469717iam.5 for <13774-done@debbugs.gnu.org>; Sat, 20 Apr 2013 20:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=YLLcGoz9xmPYu1pWcAy4LKcRJH712ZA+hmAHr7Ppt7U=; b=fBK8h2RjuhijC5vMV3Qn62MNrvzmr4lYrbWbQ4xY/lqcW6k39kJuEpO90FB0d1x3U7 GkaC8pYdMyLHaGOjbSDsLRE+Hoto3ZPyNnU18YoUzPzDYr3pIYdoFm3PhyAtPA5DNltC J2iz1DE/AHlUpIEEnEO/Dg5kR9cIW0Oco4rXwUanP4GTKdfAEmvmhw54/g+myN3Av6jz +dfIa4n6kvIFqRl68kS1mNCTRxxZ8MSM1iLuZSS7nweEMMSS5ATDw955V1INr+x3JJeV mHQtMtz7+rpf6v7ppT3sh5lq4sm/YbEfk7dQCGPq22Lc3FXK3jsUUIeEhjkzZjZ5YHhw u6KA== MIME-Version: 1.0 X-Received: by 10.50.2.40 with SMTP id 8mr5359042igr.78.1366514174777; Sat, 20 Apr 2013 20:16:14 -0700 (PDT) Received: by 10.43.18.10 with HTTP; Sat, 20 Apr 2013 20:16:14 -0700 (PDT) Date: Sun, 21 Apr 2013 11:16:14 +0800 Message-ID: Subject: Re: [patch] Use `completion-at-point' instead of `comint-dynamic-complete' From: xfq To: 13774-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13774-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Fixed. -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ From unknown Fri Sep 05 20:55:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 May 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator