From unknown Mon Jun 23 06:03:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13769: gnus-tree-hightlight-article moves point in summary buffer Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bugs@gnus.org Resent-Date: Wed, 20 Feb 2013 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13769 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: 13769@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Received: via spool by submit@debbugs.gnu.org id=B.136132670223093 (code B ref -1); Wed, 20 Feb 2013 02:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Feb 2013 02:18:22 +0000 Received: from localhost ([127.0.0.1]:37626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7zGF-00060M-Fb for submit@debbugs.gnu.org; Tue, 19 Feb 2013 21:18:21 -0500 Received: from mail-ye0-f177.google.com ([209.85.213.177]:55965) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7zGB-00060C-Uk for submit@debbugs.gnu.org; Tue, 19 Feb 2013 21:18:17 -0500 Received: by mail-ye0-f177.google.com with SMTP id m14so1358459yen.8 for ; Tue, 19 Feb 2013 18:17:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:subject:x-debbugs-version:x-debbugs-package:date :message-id:user-agent:mime-version:content-type:x-gm-message-state; bh=nUBx7pGTz8nc5zCkEWa/e/Ki3hr2y+9q8jeURDggbHM=; b=OVtCMGTSzUM6AprTddn4bTcPfV8sD1GvWDCaERLTmV1T1HotUOj4IQ/2oa+OtDRsGs 2UPYxSy45hOWfIp5E6vStTRDuPtbl+NJoovqAXhUf1eTeXFg6eYCtDqMzaHpq/1wooSp ifYstbRKo6JLccWS/mGcFZu8Jy+PknBmJ2OyzzkkdBANG0N1eAjnbT6M4hkbA5DKOGD1 jDcX1Yo3dW6nCAbCgLYn2i+cMUcasO+m4ZC0S2aZU0aFJpAqlxlw9E3xnv6fbEf/IWwV pp3RbSEXa0pht1KptXJwSsiVfs2ercJOIRg9BVF69oxiU2DixjYlfEz0k4LqXtnBmJUg QDEw== X-Received: by 10.236.119.9 with SMTP id m9mr32737199yhh.106.1361326626832; Tue, 19 Feb 2013 18:17:06 -0800 (PST) Received: from pluto.boostpro.com (c-50-143-153-218.hsd1.ca.comcast.net. [50.143.153.218]) by mx.google.com with ESMTPS id w7sm102509063yhj.0.2013.02.19.18.17.05 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 19 Feb 2013 18:17:06 -0800 (PST) Received: by pluto.boostpro.com (Postfix, from userid 501) id AF701138DEFD; Tue, 19 Feb 2013 18:17:03 -0800 (PST) From: Dave Abrahams Date: Tue, 19 Feb 2013 18:17:03 -0800 Message-ID: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.93 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Gm-Message-State: ALoCoQkfvdyEsGpxg0MsZlV71dIVn2lDWj2J0JcQZqms+FnEMHk21FGuYiQ91YdLyG3fmSM0ek/t X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This bug affects gnus-summary-mark-forward; the point moves backward in the summary buffer quite perplexingly. The following patch seems to suppress the symptoms of the bug: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/gnus-salt.el b/lisp/gnus-salt.el index 48b51d2..4b37980 100644 --- a/lisp/gnus-salt.el +++ b/lisp/gnus-salt.el @@ -857,12 +857,14 @@ Two predefined functions are available: (set-buffer buf)))) (defun gnus-tree-highlight-article (article face) + (save-excursion (with-current-buffer (gnus-get-tree-buffer) (let (region) (when (setq region (gnus-tree-article-region article)) (gnus-put-text-property (car region) (cdr region) 'face face) (set-window-point (gnus-get-buffer-window (current-buffer) t) (cdr region)))))) + ) ;;; Allow redefinition of functions. (gnus-ems-redefine) --8<---------------cut here---------------end--------------->8--- Ma Gnus v0.6 GNU Emacs 24.2.93.1 (x86_64-apple-darwin11.4.2, Carbon Version 1.6.0 AppKit 1138.51) of 2013-02-09 on Takanami.local 200 Leafnode NNTP Daemon, version 1.11.8 running at localhost (my fqdn: cube.boostpro.com) 100 Legal commands on THIS server: ARTICLE [|] BODY [|] DATE GROUP HDR
| HEAD [|] HELP LAST LIST [ACTIVE|NEWSGROUPS] []] LIST [ACTIVE.TIMES|EXTENSIONS|OVERVIEW.FMT] LISTGROUP MODE READER NEWGROUPS [GMT] NEXT POST OVER SLAVE STAT [|] XHDR
| XOVER . -- Dave Abrahams From unknown Mon Jun 23 06:03:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13769: gnus-tree-hightlight-article moves point in summary buffer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bugs@gnus.org Resent-Date: Sat, 06 Jul 2013 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13769 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Dave Abrahams Cc: 13769@debbugs.gnu.org Received: via spool by 13769-submit@debbugs.gnu.org id=B13769.137312745026973 (code B ref 13769); Sat, 06 Jul 2013 16:18:01 +0000 Received: (at 13769) by debbugs.gnu.org; 6 Jul 2013 16:17:30 +0000 Received: from localhost ([127.0.0.1]:34893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UvVAu-00070y-TZ for submit@debbugs.gnu.org; Sat, 06 Jul 2013 12:17:29 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:46085) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UvVAr-00070p-J3 for 13769@debbugs.gnu.org; Sat, 06 Jul 2013 12:17:26 -0400 Received: from 46.157.223.218.tmi.telenormobil.no ([46.157.223.218] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UvVAf-0002UK-6f; Sat, 06 Jul 2013 18:17:13 +0200 From: Lars Ingebrigtsen References: Date: Sat, 06 Jul 2013 18:17:01 +0200 In-Reply-To: (Dave Abrahams's message of "Tue, 19 Feb 2013 18:17:03 -0800") Message-ID: <87bo6fwtmq.fsf@building.gnus.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1UvVAf-0002UK-6f X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1373732234.38931@7Hd9efDY0+B79zgvGDaGTw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dave Abrahams writes: > This bug affects gnus-summary-mark-forward; the point moves backward in > the summary buffer quite perplexingly. The following patch seems to > suppress the symptoms of the bug: [...] > (defun gnus-tree-highlight-article (article face) > + (save-excursion > (with-current-buffer (gnus-get-tree-buffer) > (let (region) > (when (setq region (gnus-tree-article-region article)) > (gnus-put-text-property (car region) (cdr region) 'face face) > (set-window-point > (gnus-get-buffer-window (current-buffer) t) (cdr region)))))) > + ) Hm. I don't quite understand this patch. `save-excursion' saves the point in the current buffer, and what the current buffer is. The bit inside the save-excursion all happens in a different buffer, so point in the current buffer shouldn't change at all. Does anybody have any ideas why this patch would help? It could be some magic connected to `set-window-point', I guess... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Mon Jun 23 06:03:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13769: gnus-tree-hightlight-article moves point in summary buffer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bugs@gnus.org Resent-Date: Fri, 31 Jan 2014 00:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13769 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: To: Dave Abrahams Cc: 13769@debbugs.gnu.org Received: via spool by 13769-submit@debbugs.gnu.org id=B13769.139112798031655 (code B ref 13769); Fri, 31 Jan 2014 00:27:02 +0000 Received: (at 13769) by debbugs.gnu.org; 31 Jan 2014 00:26:20 +0000 Received: from localhost ([127.0.0.1]:41989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W91w0-0008EI-Gy for submit@debbugs.gnu.org; Thu, 30 Jan 2014 19:26:20 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W91vu-0008Dj-PX for 13769@debbugs.gnu.org; Thu, 30 Jan 2014 19:26:14 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W91ve-0002sj-K8; Fri, 31 Jan 2014 01:25:55 +0100 From: Lars Ingebrigtsen References: <87bo6fwtmq.fsf@building.gnus.org> Date: Thu, 30 Jan 2014 16:25:06 -0800 In-Reply-To: <87bo6fwtmq.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Sat, 06 Jul 2013 18:17:01 +0200") Message-ID: <87k3dh80bh.fsf@building.gnus.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1W91ve-0002sj-K8 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1391732755.26674@C87ekIYmLA8cDgpdvlziYA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Dave Abrahams writes: > >> This bug affects gnus-summary-mark-forward; the point moves backward in >> the summary buffer quite perplexingly. The following patch seems to >> suppress the symptoms of the bug: > > [...] > >> (defun gnus-tree-highlight-article (article face) >> + (save-excursion >> (with-current-buffer (gnus-get-tree-buffer) >> (let (region) >> (when (setq region (gnus-tree-article-region article)) >> (gnus-put-text-property (car region) (cdr region) 'face face) >> (set-window-point >> (gnus-get-buffer-window (current-buffer) t) (cdr region)))))) >> + ) > > Hm. I don't quite understand this patch. `save-excursion' saves the > point in the current buffer, and what the current buffer is. The bit > inside the save-excursion all happens in a different buffer, so point in > the current buffer shouldn't change at all. > > Does anybody have any ideas why this patch would help? It could be some > magic connected to `set-window-point', I guess... Even though I don't understand why it helps, I've applied your patch (but changed it slightly, so that it doesn't do both a save-excursion and a with-current-buffer). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 19:26:16 2014 Received: (at control) by debbugs.gnu.org; 31 Jan 2014 00:26:16 +0000 Received: from localhost ([127.0.0.1]:41985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W91vz-0008E8-QU for submit@debbugs.gnu.org; Thu, 30 Jan 2014 19:26:16 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37445) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W91vx-0008Dp-Lp for control@debbugs.gnu.org; Thu, 30 Jan 2014 19:26:14 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W91vj-0002sv-MH for control@debbugs.gnu.org; Fri, 31 Jan 2014 01:26:00 +0100 Date: Thu, 30 Jan 2014 16:25:11 -0800 Message-Id: <87iot180bc.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13769 X-MailScanner-ID: 1W91vj-0002sv-MH X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1391732760.20306@mHfhrRWa+l1u7X9jeYAxSw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 13769 fixed close 13769 24.4