From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 19 12:47:18 2013 Received: (at submit) by debbugs.gnu.org; 19 Feb 2013 17:47:18 +0000 Received: from localhost ([127.0.0.1]:37261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7rHi-0000e3-04 for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:47:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34721) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7rHf-0000dw-LS for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7rG2-00014p-1d for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:46:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rG1-0000od-Q0 for submit@debbugs.gnu.org; Tue, 19 Feb 2013 12:45:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7r8B-0003sx-W2 for bug-coreutils@gnu.org; Tue, 19 Feb 2013 12:37:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7r83-0006dV-Ko for bug-coreutils@gnu.org; Tue, 19 Feb 2013 12:37:27 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:50279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7jC7-0001Qj-Fv; Tue, 19 Feb 2013 04:08:59 -0500 Received: from DualCore (dsdf-4db50f91.pool.mediaWays.net [77.181.15.145]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MWfQV-1UMIKY0whf-00Xeu0; Tue, 19 Feb 2013 10:08:57 +0100 From: "Joachim Schmitz" To: <10305@debbugs.gnu.org>, , References: In-Reply-To: Subject: RE: coreutils-8.21, some changes needed Date: Tue, 19 Feb 2013 10:08:53 +0100 Message-ID: <007d01ce0e80$be6ab4f0$3b401ed0$@schmitz-digital.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: Ac4Od35oCaxTIUelRSOz/vyNGR4pCwACJKgw Content-Language: de X-Provags-ID: V02:K0:aFRvnm53j3JbLhKKNtmi278vbxxRglMQ9KjliXsb9wZ EN12J4ZKk4tSFJeKb8sZdDjXkqj3ihvl3ENDy2y1+U07pGUBIn esR5RloSUazoPirD6AwgxR4tsgVr83Lfggpi7jwDevU+ygVzdk c5vSC4VJ4FsHzIv+7P0HOkIKgCc+xKvNKHjFyqzbfBKm64addT WIkJ3ruz4SK1tftf5dZ3KDf5vjbx9cfxJqaAw++u078mxJqj2K /7cA3+BBcEL0aMIgtDDJdlR4oh9OxN8NocE0z3QlxlbQoc3Dpt JPnp0s1bYup2Jn8Qd33ZhYCv8CHqMvpVPVJtkKD9tep3BNh2MB 08KO53IimaV18BRY+HYP2JZNgLK7OmpSllgUCnDaZxRppEXKYI dnKGLo/7wPjJA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > -----Original Message----- > From: Joachim Schmitz [mailto:jojo@schmitz-digital.de] > Sent: Tuesday, February 19, 2013 9:18 AM > To: '10305@debbugs.gnu.org'; 'bug-gnulib@gnu.org' > Subject: coreutils-8.21, some changes needed > > Hi folks > > In an attempt to port coreutils 8.21 to HP-NonStop I stumbled accross a couple problems, here are my fixes to them: > > Here another file needs to get adjusted to using the new root-uid.h > > diff -EBbu ./src/copy.c.orig ./src/copy.c > --- ./src/copy.c.orig 2013-02-07 03:37:05 -0600 > +++ ./src/copy.c 2013-02-18 09:29:22 -0600 > @@ -51,6 +51,7 @@ > #include "ignore-value.h" > #include "ioblksize.h" > #include "quote.h" > +#include "root-uid.h" > #include "same.h" > #include "savedir.h" > #include "stat-size.h" > @@ -1127,7 +1128,7 @@ > { > bool access_changed = false; > > - if (!(sb.st_mode & S_IWUSR) && geteuid () != 0) > + if (!(sb.st_mode & S_IWUSR) && geteuid () != ROOT_UID) > access_changed = fchmod_or_lchmod (dest_desc, dst_name, 0600) == 0; > > if (!copy_attr (src_name, source_desc, dst_name, dest_desc, x) > @@ -2718,7 +2719,7 @@ > priv_freeset (pset); > } > #else > - x->chown_privileges = x->owner_privileges = (geteuid () == 0); > + x->chown_privileges = x->owner_privileges = (geteuid () == ROOT_UID); > #endif > } > > > > On HP-NonStop we use 0x80000000 instead of -1 for getuid(), getgid() and friends to indicate NO_UID rsp. NO_GID > Guess that difference could go into gnulibs root-uid.h? > Such a change would affect coreutils in ...src/{groups,id,install,test,whoami}.c (in addition to root-uid.h of course) > > > Here two trailing _ seem missing? > > diff -EBbu ./src/numfmt.c.orig ./src/numfmt.c > --- ./src/numfmt.c.orig 2013-02-14 08:49:30 -0600 > +++ ./src/numfmt.c 2013-02-18 10:58:27 -0600 > @@ -1195,7 +1195,7 @@ > Returns a pointer to the *delimiter* of the requested field, > or a pointer to NUL (if reached the end of the string). */ > static inline char * > -__attribute ((pure)) > +__attribute__ ((pure)) > skip_fields (char *buf, int fields) > { > char *ptr = buf; > And here as a git diff: diff --git a/src/copy.c b/src/copy.c index 3f2cc2b..affdda1 100644 --- a/src/copy.c +++ b/src/copy.c @@ -51,6 +51,7 @@ #include "ignore-value.h" #include "ioblksize.h" #include "quote.h" +#include "root-uid.h" #include "same.h" #include "savedir.h" #include "stat-size.h" @@ -1127,7 +1128,7 @@ preserve_metadata: { bool access_changed = false; - if (!(sb.st_mode & S_IWUSR) && geteuid () != 0) + if (!(sb.st_mode & S_IWUSR) && geteuid () != ROOT_UID) access_changed = fchmod_or_lchmod (dest_desc, dst_name, 0600) == 0; if (!copy_attr (src_name, source_desc, dst_name, dest_desc, x) @@ -2718,7 +2719,7 @@ cp_options_default (struct cp_options *x) priv_freeset (pset); } #else - x->chown_privileges = x->owner_privileges = (geteuid () == 0); + x->chown_privileges = x->owner_privileges = (geteuid () == ROOT_UID); #endif } diff --git a/src/numfmt.c b/src/numfmt.c index 8c21c2b..50f295d 100644 --- a/src/numfmt.c +++ b/src/numfmt.c @@ -1195,7 +1195,7 @@ process_suffixed_number (char *text, long double *result, Returns a pointer to the *delimiter* of the requested field, or a pointer to NUL (if reached the end of the string). */ static inline char * -__attribute ((pure)) +__attribute__ ((pure)) skip_fields (char *buf, int fields) { char *ptr = buf; From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 18 19:47:14 2018 Received: (at 13765) by debbugs.gnu.org; 18 Oct 2018 23:47:15 +0000 Received: from localhost ([127.0.0.1]:57601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDI0W-00028b-Pn for submit@debbugs.gnu.org; Thu, 18 Oct 2018 19:47:13 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:35105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDI0V-00023b-6h; Thu, 18 Oct 2018 19:47:11 -0400 Received: by mail-pl1-f174.google.com with SMTP id f8-v6so15037583plb.2; Thu, 18 Oct 2018 16:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=PDgWzvkaTMZZPgPw+Q05RJytTdT+U7CEu2Ya0oJglzE=; b=U1UN5IO92MmuA48hMRbDO43wXWiEwoTLqIhwFnIL2zwcciYoXyvqynsX/2/gypDrES tdagcCaLLBY/BGoWIO6Y1YIkQlINjU9MV83elJFzgCqOnTTuciA8Yh80jCe0Jlx3eb0m 9gNdXGiyaJo/5/0VTx30sp/67aiZ3E/BAZ0/MDVQ8ffYmRXitZb/4ENGxeD2mlTF1G88 dRD1ZigFHZhfnLr67/s3GJuoG3Vc4LYcKjphvSAHhHh+zkMYnX3Km+MePNzcpCjDgjdC W+TVqPJxjoDTuAs8TkZF7cKXIxrfzZ6us1a/z5sajeUI3Av+RQR46B34R5RBnvoMBYrV wkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PDgWzvkaTMZZPgPw+Q05RJytTdT+U7CEu2Ya0oJglzE=; b=DxZt+q5NVTC+knwq8gLy1YSAPClrYfjupiMVQV9oYx3nImuRqA9CZGaynosaOTya5h HuA0n0z5DgV1+uOVuEU9setFZVpION14TFdVhnJwP7m8DYjLlL4EL72UbytHk3FjKBtU qsVQ0Gz0AN9zyn6I1RcVW/3/dFpmXGCDpxYmpKNzBh0oTnRuh4wwOIgM1UqC7ICIqB6f 6Qa2PQoJeje3I/m7pPSJV6WQDvaT1QQ2uG8JyVdgzdK8yJqd//54zgshNArZYEUKKjz+ m8yqRoSUlPHZEGo5wfN5/+/v60BmpEgg3eRCvYXlC5ku8e4jBhVQqfyyFufdKdIpJuo/ z9yQ== X-Gm-Message-State: ABuFfohjkiRN4Sfmez3PesagY/CajZM5S5yI+2oW3ZwfiMFiFNeSrSVE laBus3nZ9CrPJOqxMDchiVEtQNw4 X-Google-Smtp-Source: ACcGV60jfu4lAWQleB1dGQymjYPeGgtZnSfYPtd8r6AJeAUnwUKagB2YOItanGyQS4lwznx3u2cnoA== X-Received: by 2002:a17:902:9696:: with SMTP id n22-v6mr23273987plp.282.1539906424697; Thu, 18 Oct 2018 16:47:04 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id h5-v6sm25301194pfo.135.2018.10.18.16.47.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 16:47:03 -0700 (PDT) Subject: Re: bug#13765: coreutils-8.21, some changes needed To: 13765@debbugs.gnu.org, 13765@debbugs.gnu.org References: <007d01ce0e80$be6ab4f0$3b401ed0$@schmitz-digital.de> From: Assaf Gordon Message-ID: Date: Thu, 18 Oct 2018 17:47:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <007d01ce0e80$be6ab4f0$3b401ed0$@schmitz-digital.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13765 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 13765 fixed retitle 13765 build: HP-NonStop fix close 13765 stop (triaging old bugs) On 19/02/13 02:08 AM, Joachim Schmitz wrote: >> In an attempt to port coreutils 8.21 to HP-NonStop I stumbled accross a couple problems, here are my fixes to them: >> >> Here another file needs to get adjusted to using the new root-uid.h Pushed here in 2013: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=6229654741554561952c6106f75681e4382cc890 Closing. -assaf From unknown Mon Jun 23 06:02:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 16 Nov 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator