Subject: Re: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)'

From: Lars Ingebrigtsen <[email-masked]>
Date: Fri, 29 Apr 2016 00:31:08 +0200

"Drew Adams" <[email-masked]> writes:

> These are not tiny, trivial functions.
>
> They do not fit the criteria for `defsubst' outlined in (elisp)
> `Inline Functions'.  And they introduce all of the disadvantages
> listed there, especially this one, listed first:

[...]

> I see no reason why these function should not be defuns.

Presumably they are that way because of efficiency concerns.  Have you
done benchmarking to compare the impact of these defsubsts turning into
defuns?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no