GNU bug report logs - #13745
c1-acronyms

Previous Next

Package: emacs;

Reported by: starback <at> stp.lingfil.uu.se (Per Starbäck)

Date: Mon, 18 Feb 2013 17:03:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 26.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13745 in the body.
You can then email your comments to 13745 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#13745; Package emacs. (Mon, 18 Feb 2013 17:03:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to starback <at> stp.lingfil.uu.se (Per Starbäck):
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 18 Feb 2013 17:03:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: starback <at> stp.lingfil.uu.se (Per Starbäck)
To: bug-gnu-emacs <at> gnu.org
Subject: c1-acronyms
Date: Mon, 18 Feb 2013 18:00:45 +0100

In GNU Emacs 24.2.93.1.

char-acronym-table has three entries with "XXX". They are from
lisp/international/characters.el :

> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))

These are the three C1 control characters that are listed with no name
in Unicode and that aren't part of ISO/IEC 6429.

These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
standardized (not accepted to ISO 10646).

  http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
  http://www.aivosto.com/vbtips/control-characters.html

I don't like the acronym feature showing different characters the same,
so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
here.

Alternatively, if that is not OK, that the target c1-control for
glyphless-char-display skips these three characters.

======================================================================
$  diff -cp lisp/international/characters.el lisp/international/characters-fixc1.el
*** lisp/international/characters.el	2013-01-01 21:37:17.000000000 +0100
--- lisp/international/characters-fixc1.el	2013-02-18 17:58:29.103018508 +0100
*************** Setup char-width-table appropriate for n
*** 1354,1363 ****
      (aset char-acronym-table i (car c0-acronyms))
      (setq c0-acronyms (cdr c0-acronyms))))
  
! (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
  		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
  		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
! 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
    (dotimes (i 32)
      (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
      (setq c1-acronyms (cdr c1-acronyms))))
--- 1354,1363 ----
      (aset char-acronym-table i (car c0-acronyms))
      (setq c0-acronyms (cdr c0-acronyms))))
  
! (let ((c1-acronyms '("PAD" "HOP" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
  		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
  		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
! 		     "SOS" "SGCI" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
    (dotimes (i 32)
      (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
      (setq c1-acronyms (cdr c1-acronyms))))

======================================================================

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13745; Package emacs. (Wed, 24 Feb 2016 05:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 13745 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: starback <at> stp.lingfil.uu.se (Per Starbäck)
Cc: 13745 <at> debbugs.gnu.org
Subject: Re: bug#13745: c1-acronyms
Date: Wed, 24 Feb 2016 16:48:39 +1100

starback <at> stp.lingfil.uu.se (Per Starbäck) writes:

> In GNU Emacs 24.2.93.1.
>
> char-acronym-table has three entries with "XXX". They are from
> lisp/international/characters.el :
>
>> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
>> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>
> These are the three C1 control characters that are listed with no name
> in Unicode and that aren't part of ISO/IEC 6429.
>
> These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
> standardized (not accepted to ISO 10646).
>
>   http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
>   http://www.aivosto.com/vbtips/control-characters.html
>
> I don't like the acronym feature showing different characters the same,
> so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
> here.

If this list is automatically generated from the C1 control code list,
then perhaps that generating function should be removed?

If not, I think your patch is OK, if I understand what it's doing here.
(I may very well be not.)

> ! (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>   		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>   		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> ! 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>     (dotimes (i 32)
>       (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
>       (setq c1-acronyms (cdr c1-acronyms))))
> --- 1354,1363 ----
>       (aset char-acronym-table i (car c0-acronyms))
>       (setq c0-acronyms (cdr c0-acronyms))))
>
> ! (let ((c1-acronyms '("PAD" "HOP" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>   		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>   		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> ! 		     "SOS" "SGCI" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>     (dotimes (i 32)
>       (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
>       (setq c1-acronyms (cdr c1-acronyms))))
>
> ======================================================================

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13745; Package emacs. (Wed, 24 Feb 2016 17:22:01 GMT) Full text and rfc822 format available.

Message #11 received at 13745 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: starback <at> stp.lingfil.uu.se, 13745 <at> debbugs.gnu.org
Subject: Re: bug#13745: c1-acronyms
Date: Wed, 24 Feb 2016 19:21:24 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 24 Feb 2016 16:48:39 +1100
> Cc: 13745 <at> debbugs.gnu.org
> 
> starback <at> stp.lingfil.uu.se (Per Starbäck) writes:
> 
> > In GNU Emacs 24.2.93.1.
> >
> > char-acronym-table has three entries with "XXX". They are from
> > lisp/international/characters.el :
> >
> >> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
> >> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
> >> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> >> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
> >
> > These are the three C1 control characters that are listed with no name
> > in Unicode and that aren't part of ISO/IEC 6429.
> >
> > These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
> > standardized (not accepted to ISO 10646).
> >
> >   http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
> >   http://www.aivosto.com/vbtips/control-characters.html
> >
> > I don't like the acronym feature showing different characters the same,
> > so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
> > here.
> 
> If this list is automatically generated from the C1 control code list,
> then perhaps that generating function should be removed?
> 
> If not, I think your patch is OK, if I understand what it's doing here.
> (I may very well be not.)

I'm okay with applying this, thanks.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#13745; Package emacs. (Thu, 25 Feb 2016 05:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 13745 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13745 <at> debbugs.gnu.org, starback <at> stp.lingfil.uu.se
Subject: Re: bug#13745: c1-acronyms
Date: Thu, 25 Feb 2016 16:22:57 +1030

Eli Zaretskii <eliz <at> gnu.org> writes:

>> then perhaps that generating function should be removed?
>> 
>> If not, I think your patch is OK, if I understand what it's doing here.
>> (I may very well be not.)
>
> I'm okay with applying this, thanks.

Ok; applied to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 25 Feb 2016 05:54:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 25.2, send any further explanations to 13745 <at> debbugs.gnu.org and starback <at> stp.lingfil.uu.se (Per Starbäck) Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 25 Feb 2016 05:54:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Mar 2016 11:24:04 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug Marked as fixed in versions 26.1. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug No longer marked as fixed in versions 25.2. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Jan 2017 12:24:15 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 174 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.

GNU bug report logs - #13745 c1-acronyms

GNU bug report logs - #13745
c1-acronyms