From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Feb 2013 00:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13740@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136114718521429 (code B ref -1); Mon, 18 Feb 2013 00:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Feb 2013 00:26:25 +0000 Received: from localhost ([127.0.0.1]:33465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7EYq-0005ZZ-W2 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:26:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58074) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7EYo-0005ZS-89 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:26:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7EXs-0000Fo-ND for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:25:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXs-0000Fk-KR for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:25:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXr-0003tN-I7 for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7EXq-0000FG-KR for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:23 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:56679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXq-0000FA-Cm for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:22 -0500 Received: by mail-pb0-f42.google.com with SMTP id xb4so1371881pbc.1 for ; Sun, 17 Feb 2013 16:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:organization:x-mailer :mime-version:content-type:content-transfer-encoding; bh=QSk8b6rFBe8kYDQuiPLK9/cLP+aIse0GgKPuIx6Cq4U=; b=sjIPND4a2mf7tL1ILs2VeRu3aTR+1+Um2L0kkkfLRKsainBRsiTcbTyOhahGpjiBOz 3K2BzBXN6uEFH/FHyLrek9UWa8Rd01iWoAcMB+NG1WeO1fZH3d6/u5HnelRod1r9yGMC iBBXqf8ivSHabFa3q6MJR7xEg0nSZ9z4/jDqDMItNcAHyHgk4lBOnNprVM4wDVporvOQ R6y0IaUPdxn1Kp+LK007nhWk6pp8j3pkJcuWrtjSxmWl8p0f9Xq+Uk4ZUvq2Ystd1JS9 79Z8+lpEZnio84APwj98wPNkpAMAo/oqzjaiVIUbVlPvzRkMUUt1xjoxFomNhVLaTAL7 CNJw== X-Received: by 10.66.76.41 with SMTP id h9mr31515895paw.1.1361147121411; Sun, 17 Feb 2013 16:25:21 -0800 (PST) Received: from Emacs ([124.117.94.252]) by mx.google.com with ESMTPS id iu10sm12450977pbc.13.2013.02.17.16.25.18 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Feb 2013 16:25:20 -0800 (PST) Date: Mon, 18 Feb 2013 08:25:15 +0800 From: Xue Fuqiao Message-Id: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) In (info "(elisp) Coding Conventions"): * Constructs that define a function or variable should be macros, not functions, and their names should start with `define-'. The macro should receive the name to be defined as the first argument. That will help various tools find the definition automatically. Avoid constructing the names in the macro itself, since that would confuse these tools. I think macros like `cl-defsubst', `cl-defun' should be mentioned here. -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Feb 2013 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Xue Fuqiao Cc: 13740@debbugs.gnu.org Received: via spool by 13740-submit@debbugs.gnu.org id=B13740.136130380818167 (code B ref 13740); Tue, 19 Feb 2013 19:57:02 +0000 Received: (at 13740) by debbugs.gnu.org; 19 Feb 2013 19:56:48 +0000 Received: from localhost ([127.0.0.1]:37393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7tJ1-0004ix-OI for submit@debbugs.gnu.org; Tue, 19 Feb 2013 14:56:48 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:60397) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7tIx-0004in-FO for 13740@debbugs.gnu.org; Tue, 19 Feb 2013 14:56:46 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U7tHr-0004IK-Pv; Tue, 19 Feb 2013 14:55:35 -0500 From: Glenn Morris References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> X-Spook: EuroFed mailbomb Croatian threat counter terrorism X-Ran: ?;Pc'aCXpMS>29/;t&13*h>P6Kz>Awd{h}j2(A (Xue Fuqiao's message of "Mon, 18 Feb 2013 08:25:15 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Xue Fuqiao wrote: > In (info "(elisp) Coding Conventions"): > > * Constructs that define a function or variable should be macros, > not functions, and their names should start with `define-'. The > macro should receive the name to be defined as the first argument. > That will help various tools find the definition automatically. > Avoid constructing the names in the macro itself, since that would > confuse these tools. > > I think macros like `cl-defsubst', `cl-defun' should be mentioned here. Why? What would you say about them? From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13740@debbugs.gnu.org Received: via spool by 13740-submit@debbugs.gnu.org id=B13740.136140661924024 (code B ref 13740); Thu, 21 Feb 2013 00:31:02 +0000 Received: (at 13740) by debbugs.gnu.org; 21 Feb 2013 00:30:19 +0000 Received: from localhost ([127.0.0.1]:40810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8K3H-0006FR-1X for submit@debbugs.gnu.org; Wed, 20 Feb 2013 19:30:19 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:64832) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8K3E-0006FJ-DV for 13740@debbugs.gnu.org; Wed, 20 Feb 2013 19:30:17 -0500 Received: by mail-pa0-f41.google.com with SMTP id fb11so4345335pad.14 for <13740@debbugs.gnu.org>; Wed, 20 Feb 2013 16:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:in-reply-to :references:organization:x-mailer:mime-version:content-type :content-transfer-encoding; bh=T5L1vjMOGWR8zSaZ+nj2oUa/AmFWN4+xw3gu/7hC01E=; b=hu0Ze26mQSr5FG7fJDHt6bR+/os7FwEPBupoONl+cEdgrhYjmFqJegJ0rB1Wr6dYoE hXGQ+82MoihTjVi2/l2kHR6qF+TjbJRWe5UJyiLad9tgD8pCoAuTRSpQG8zkBDKDC0aK seDTLKwg5qK6dOoYru6w8DZYAO3J3+2rXFKPtJkpbOy1fEdXJZlGa2ixAS+S2mSD5rs4 bAu26g9RnQSgUHAttZr+QstB6zs3BlMkjHxtWjO7KriDx/633xr4edcxZiOi/A7CNYrb DUiDgMHLsWfv4x9VGxKEyWsCAJR1Qv7A+vCjGwtwg3kPyEFOy1e8/Ib54WFFWI0Ha/ip Slyg== X-Received: by 10.66.25.105 with SMTP id b9mr51367568pag.45.1361406541900; Wed, 20 Feb 2013 16:29:01 -0800 (PST) Received: from Emacs ([219.224.52.162]) by mx.google.com with ESMTPS id y9sm112803293paw.1.2013.02.20.16.28.59 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Feb 2013 16:29:00 -0800 (PST) Date: Thu, 21 Feb 2013 08:28:57 +0800 From: Xue Fuqiao Message-Id: <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> In-Reply-To: References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On Tue, 19 Feb 2013 14:55:35 -0500 Glenn Morris wrote: > Xue Fuqiao wrote: > > In (info "(elisp) Coding Conventions"): > > > > * Constructs that define a function or variable should be macros, > > not functions, and their names should start with `define-'. The > > macro should receive the name to be defined as the first argument. > > That will help various tools find the definition automatically. > > Avoid constructing the names in the macro itself, since that would > > confuse these tools. > > > > I think macros like `cl-defsubst', `cl-defun' should be mentioned here. > Why? They are macros that define functions, but they don't start with `define-'. > What would you say about them? Maybe something like this: Constructs that define a function or variable should be macros, not functions, and their names should start with `define-', except for some macros in `cl-lib', like `cl-defsubst' and `cl-defun'. -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention Resent-From: Xue Fuqiao Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 02:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christopher Schmidt Cc: 13740@debbugs.gnu.org Received: via spool by 13740-submit@debbugs.gnu.org id=B13740.1361412733382 (code B ref 13740); Thu, 21 Feb 2013 02:13:01 +0000 Received: (at 13740) by debbugs.gnu.org; 21 Feb 2013 02:12:13 +0000 Received: from localhost ([127.0.0.1]:40927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Ldt-000066-8C for submit@debbugs.gnu.org; Wed, 20 Feb 2013 21:12:13 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:55844) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Ldr-00005z-7H for 13740@debbugs.gnu.org; Wed, 20 Feb 2013 21:12:11 -0500 Received: by mail-pa0-f46.google.com with SMTP id kp14so4353154pab.19 for <13740@debbugs.gnu.org>; Wed, 20 Feb 2013 18:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:in-reply-to :references:organization:x-mailer:mime-version:content-type :content-transfer-encoding; bh=z6ok2pU8EgQWSctiKd5xZmNT1RFeOlwwI4Isw8CuiZk=; b=BtvLr8TNPENFwbdaJRmQDGVjqWLyaF/hMV7m3mG4LI74bwYyQ5B0CaX6AD7ZOhh1F/ wEJTwxh7RDejZqnFyr8tbFMDjtzunZ2FY5St4vs0sww50XzINiNsP8h+uHzZ7sagocxX PrVC/uXvmKRtK84fe+JAiS3uXdXWTjNJxZxbUSi650uAMVgBZsCqWDEVIVEQFxjn7Obf WpuIL7JuR6d7O5ukIqZaGW5SLhYedv5bdWjWbjPOHYOTg5wNX8ODroppWnfjjgZJWv/d C3cVb+g0nPxInkuxdrYEtAU3W3NyYg1qGovMTgCF0ckCb7JKKN14N01tZuyeUU6XmLMS k0ag== X-Received: by 10.68.196.193 with SMTP id io1mr5768256pbc.196.1361412656364; Wed, 20 Feb 2013 18:10:56 -0800 (PST) Received: from Emacs ([219.224.52.162]) by mx.google.com with ESMTPS id bi2sm113090515pab.18.2013.02.20.18.10.54 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Feb 2013 18:10:55 -0800 (PST) Date: Thu, 21 Feb 2013 10:10:52 +0800 From: Xue Fuqiao Message-Id: <20130221101052.7351d1083319dfe7a7bdd581@gmail.com> In-Reply-To: <8738wqa0sp@ch.ristopher.com> References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> <8738wqa0sp@ch.ristopher.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Thu, 21 Feb 2013 01:54:56 +0000 (GMT) Christopher Schmidt wrote: > Xue Fuqiao writes: > > They are macros that define functions, but they don't start with > > `define-'. > Anything about cl-lib does not belong into the Elisp node. IMO cl-lib > breaking conventions is not worth a note, either. But cl-lib is a part of Emacs. We make aliases like this: define-inline-function-cl --> cl-defsubst defune-function-cl --> cl-defun Or we can mention the convention breakage in the CL manual. > Christopher -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Xue Fuqiao Cc: Glenn Morris , 13740@debbugs.gnu.org Received: via spool by 13740-submit@debbugs.gnu.org id=B13740.136146017916249 (code B ref 13740); Thu, 21 Feb 2013 15:23:01 +0000 Received: (at 13740) by debbugs.gnu.org; 21 Feb 2013 15:22:59 +0000 Received: from localhost ([127.0.0.1]:42596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Xz9-0004E1-HT for submit@debbugs.gnu.org; Thu, 21 Feb 2013 10:22:59 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:51225) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8Xz8-0004Du-0Y for 13740@debbugs.gnu.org; Thu, 21 Feb 2013 10:22:58 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r1LFLdWf006859; Thu, 21 Feb 2013 10:21:39 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id DBF00B43AD; Thu, 21 Feb 2013 10:21:38 -0500 (EST) From: Stefan Monnier Message-ID: References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> Date: Thu, 21 Feb 2013 10:21:38 -0500 In-Reply-To: <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> (Xue Fuqiao's message of "Thu, 21 Feb 2013 08:28:57 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4499=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4499> : streams <910864> : uri <1351704> X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > Constructs that define a function or variable should be macros, not > functions, and their names should start with `define-', except for some > macros in `cl-lib', like `cl-defsubst' and `cl-defun'. Actually, I think they can also start with "-define-". Stefan From unknown Sun Jun 22 00:56:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13740: About a coding convention In-Reply-To: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2013 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Xue Fuqiao Cc: 13740@debbugs.gnu.org Received: via spool by 13740-submit@debbugs.gnu.org id=B13740.136146619625219 (code B ref 13740); Thu, 21 Feb 2013 17:04:02 +0000 Received: (at 13740) by debbugs.gnu.org; 21 Feb 2013 17:03:16 +0000 Received: from localhost ([127.0.0.1]:42688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8ZYB-0006Yh-UI for submit@debbugs.gnu.org; Thu, 21 Feb 2013 12:03:16 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:36703) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U8ZY9-0006Ya-3Z for 13740@debbugs.gnu.org; Thu, 21 Feb 2013 12:03:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U8ZWs-000284-T1; Thu, 21 Feb 2013 12:01:54 -0500 From: Glenn Morris References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> X-Spook: genetic clandestine MP5K-SD Bletchley Park MD5 asset X-Ran: aocPDB6XF;,{F,sgxj?B3.`+i&0q`=;*]p1`vlT_=4f$%{FR{#VQQ(5CL~][D"_nwhT|X, X-Hue: red X-Attribution: GM Date: Thu, 21 Feb 2013 12:01:54 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.9 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Xue Fuqiao wrote: > Constructs that define a function or variable should be macros, not > functions, and their names should start with `define-', except for > some macros in `cl-lib', like `cl-defsubst' and `cl-defun'. I don't think it is useful to list pre-existing exceptions to a general guideline. The whole thing is mutually inconsistent anyway: constructs that define functions, variables, etc., work better if they start with @samp{defun} or @samp{defvar}, [...] [...] Constructs that define a function or variable should be macros, not functions, and their names should start with @samp{define-}. From unknown Sun Jun 22 00:56:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xue Fuqiao Subject: bug#13740: closed (Re: bug#13740: About a coding convention) Message-ID: References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> X-Gnu-PR-Message: they-closed 13740 X-Gnu-PR-Package: emacs Reply-To: 13740@debbugs.gnu.org Date: Fri, 07 Aug 2020 11:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1596799442-11377-1" This is a multi-part message in MIME format... ------------=_1596799442-11377-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13740: About a coding convention which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13740@debbugs.gnu.org. --=20 13740: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13740 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1596799442-11377-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13740-done) by debbugs.gnu.org; 7 Aug 2020 11:23:45 +0000 Received: from localhost ([127.0.0.1]:55943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40TC-0002wm-8A for submit@debbugs.gnu.org; Fri, 07 Aug 2020 07:23:45 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:33271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40TA-0002wX-9H for 13740-done@debbugs.gnu.org; Fri, 07 Aug 2020 07:23:28 -0400 Received: by mail-yb1-f195.google.com with SMTP id p191so841836ybg.0 for <13740-done@debbugs.gnu.org>; Fri, 07 Aug 2020 04:23:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=hRGg4MDc0YcrFYiKyWt8VdmYNNRJSCNKzxERVax0rdY=; b=f2usaew5k6WAKMGP48tnkjV3kURLd9IYCipCnbE3qCJTmoq934xjT6TO2WeW+3amVT m0J4qJ1wQUZWhyRA9598AtNjX2fiUEh+3HQfv3uyBrF8OzArr0s76uTrwavwY/UpWyeR rvmTMt2VGOatdK5sLDnJqamUHBJSsROQ0UjycbLBL79FN8yDT4/G8TD0MbnZBmiGLFqR iyVKzHxwDjEBjiyxzYcaRqFzO08ZwHARQkMAk7NdjgtN84E9mkyDhZYapbXyawdsry/G OPYz1WYYTiB6QOFS2NZAPCduL2qVax8vYeDdsdhpwpOOfPJ3zg+nePG6AJCJaxvwvmE1 bm+A== X-Gm-Message-State: AOAM5330GqAgsaRJCI9FLxWWJ3u4bj4D8mlAKmUl1yaxzABFBPu4HjYt 7w/ult2z7MbASQKbig1NURx3CsOhbOT7i8p+fJg= X-Google-Smtp-Source: ABdhPJwXaBMam6G3qqKSJzls8bJlf3cQqVabXaJtClU9v2dex2tf71w12nKeDihy5iYgRfXyDiTkJmrq4ucb5UAMDRM= X-Received: by 2002:a25:b88b:: with SMTP id w11mr20709671ybj.129.1596799403011; Fri, 07 Aug 2020 04:23:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Aug 2020 04:23:22 -0700 From: Stefan Kangas In-Reply-To: (Glenn Morris's message of "Thu, 21 Feb 2013 12:01:54 -0500") References: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 7 Aug 2020 04:23:22 -0700 Message-ID: Subject: Re: bug#13740: About a coding convention To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13740-done Cc: Xue Fuqiao , 13740-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Xue Fuqiao wrote: > >> Constructs that define a function or variable should be macros, not >> functions, and their names should start with `define-', except for >> some macros in `cl-lib', like `cl-defsubst' and `cl-defun'. > > I don't think it is useful to list pre-existing exceptions to a general > guideline. Agreed. Since no one else has voiced an opinion, I'm therefore closing this bug report. Best regards, Stefan Kangas ------------=_1596799442-11377-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Feb 2013 00:26:25 +0000 Received: from localhost ([127.0.0.1]:33465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7EYq-0005ZZ-W2 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:26:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58074) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7EYo-0005ZS-89 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:26:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7EXs-0000Fo-ND for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:25:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXs-0000Fk-KR for submit@debbugs.gnu.org; Sun, 17 Feb 2013 19:25:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXr-0003tN-I7 for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7EXq-0000FG-KR for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:23 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:56679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7EXq-0000FA-Cm for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 19:25:22 -0500 Received: by mail-pb0-f42.google.com with SMTP id xb4so1371881pbc.1 for ; Sun, 17 Feb 2013 16:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:organization:x-mailer :mime-version:content-type:content-transfer-encoding; bh=QSk8b6rFBe8kYDQuiPLK9/cLP+aIse0GgKPuIx6Cq4U=; b=sjIPND4a2mf7tL1ILs2VeRu3aTR+1+Um2L0kkkfLRKsainBRsiTcbTyOhahGpjiBOz 3K2BzBXN6uEFH/FHyLrek9UWa8Rd01iWoAcMB+NG1WeO1fZH3d6/u5HnelRod1r9yGMC iBBXqf8ivSHabFa3q6MJR7xEg0nSZ9z4/jDqDMItNcAHyHgk4lBOnNprVM4wDVporvOQ R6y0IaUPdxn1Kp+LK007nhWk6pp8j3pkJcuWrtjSxmWl8p0f9Xq+Uk4ZUvq2Ystd1JS9 79Z8+lpEZnio84APwj98wPNkpAMAo/oqzjaiVIUbVlPvzRkMUUt1xjoxFomNhVLaTAL7 CNJw== X-Received: by 10.66.76.41 with SMTP id h9mr31515895paw.1.1361147121411; Sun, 17 Feb 2013 16:25:21 -0800 (PST) Received: from Emacs ([124.117.94.252]) by mx.google.com with ESMTPS id iu10sm12450977pbc.13.2013.02.17.16.25.18 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Feb 2013 16:25:20 -0800 (PST) Date: Mon, 18 Feb 2013 08:25:15 +0800 From: Xue Fuqiao To: bug-gnu-emacs@gnu.org Subject: About a coding convention Message-Id: <20130218082515.6ed5dfd2988fa1090af99a10@gmail.com> Organization: The Church of Emacs X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) In (info "(elisp) Coding Conventions"): * Constructs that define a function or variable should be macros, not functions, and their names should start with `define-'. The macro should receive the name to be defined as the first argument. That will help various tools find the definition automatically. Avoid constructing the names in the macro itself, since that would confuse these tools. I think macros like `cl-defsubst', `cl-defun' should be mentioned here. -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao ------------=_1596799442-11377-1--