Subject: bug#13715: 24.2; Invalid function when calling sql-connect

From: Michael Mauger <[email-masked]>
Date: Sun, 10 Mar 2013 18:54:42 -0700 (PDT)

This was a documentation error, version 3.2 corrects this, and the "Wrong number of arguments" error.

Replaced "symbol" with "case-insensitive string"

Thanks for the report.

--Michael

----- Original Message -----
> From: Glenn Morris <[email-masked]>
> To: [email-masked]
> Cc: [email-masked]; [email-masked]
> Sent: Thursday, February 14, 2013 8:50 PM
> Subject: Re: bug#13715: 24.2; Invalid function when calling sql-connect
> 
> Re: http://debbugs.gnu.org/13715
> 
> Glenn Morris wrote:
> 
>>  [email-masked] wrote:
>> 
>>>  When calling sql-connect Emacs errors with the message "Invalid
>>>  function: (db1 db2)" when hitting tab or when typing the 
> connection name
>>>  and pressing enter.
>> 
>>  Thanks for the report. This should fix it:
>> 
>>  *** lisp/progmodes/sql.el    2013-01-01 09:11:05 +0000
>>  --- lisp/progmodes/sql.el    2013-02-14 23:46:50 +0000
>>  ***************
>>  *** 3919,3925 ****
>>      "Read a connection name."
>>      (let ((completion-ignore-case t))
>>        (completing-read prompt
>>  !                      (mapcar (lambda (c) (car c))
>>                                 sql-connection-alist)
>>                         nil t initial 'sql-connection-history default)))
>>   
>>  --- 3919,3925 ----
>>      "Read a connection name."
>>      (let ((completion-ignore-case t))
>>        (completing-read prompt
>>  !                      (mapcar (lambda (c) (symbol-name (car c)))
>>                                 sql-connection-alist)
>>                         nil t initial 'sql-connection-history default)))
> 
> 
> However, there seems to be an inconsistency, in that:
> 
> sql-connection-alist says "CONNECTION is a symbol identifying the 
> connection"
> 
> whereas sql-connect (above) assumes it to be a string.
> AFAICS, sql-save-connection also saves strings rather than symbols for NAME.
> 
> So maybe it is a doc bug?
> 
> 
> On a semi-related note:
> 
> emacs -Q -l sql
> M-x sql-connect
>   -> "Wrong number of arguments" error
>