From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 11 23:56:47 2013 Received: (at submit) by debbugs.gnu.org; 12 Feb 2013 04:56:47 +0000 Received: from localhost ([127.0.0.1]:51320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U57vB-0007Ia-Kk for submit@debbugs.gnu.org; Mon, 11 Feb 2013 23:56:46 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54821) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U57v8-0007IS-L0 for submit@debbugs.gnu.org; Mon, 11 Feb 2013 23:56:43 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U57uk-0002yG-7n; Mon, 11 Feb 2013 23:56:18 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: mouse clicks in vc-dir buffers accidentally changing marks X-Spook: Attorney General analyzer defense information warfare Uzi X-Ran: :T&%_\12IOyOUGuN^,?Fv-Fx=s}sFN~M!Ci>kjj#-@;^Q|*0$I=P3;~'57[1#]Y6@KGe8X X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 11 Feb 2013 23:56:18 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Package: emacs Version: 24.3 Severity: minor Maybe it's just me, but I find it too easy to accidentally change the marked files in a vc-dir buffer with careless mouse clicks. In a directory under version control with modified files: emacs -Q -f vc-dir The text that says "edited" (and the space following it all the way up to the filename) runs vc-dir-toggle-mark on mouse clicks. I find this makes it too easy to accidentally change the marked state when using the mouse to select a different window or frame. In a dired buffer, there is no way to mark files with mouse clicks AFAICS. I don't see why vc-dir needs one. (Confusingly, clicking on the actual mark character itself at the start of the line in a vc-dir buffer does nothing.) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 22:58:41 2021 Received: (at 13692) by debbugs.gnu.org; 20 Jan 2021 03:58:41 +0000 Received: from localhost ([127.0.0.1]:52418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24dl-0006vQ-6k for submit@debbugs.gnu.org; Tue, 19 Jan 2021 22:58:41 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24dj-0006vB-10 for 13692@debbugs.gnu.org; Tue, 19 Jan 2021 22:58:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VTL3rzIZhSHJdr7n85C9RPcLw7gNCbAQnBFquDlzoqc=; b=vKj3MdzE6LU1IysPNRvL4HVD6h 0q01JR3ehr/UGDeCmaMoQo9q7m1wbNjyjyQ8HCaavzCZLTyQwq6ucZqmnAO92ruucK3zlfEVmLHZt D9kFBkchqYroM5XOn2m7886Tx1aA5HvMVeyb1gzlqagHvezvaXNYg37kAIrEKcGBaDlY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l24dY-0000Vr-Ix; Wed, 20 Jan 2021 04:58:32 +0100 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: X-Now-Playing: M.A. Jaiyesimi & His Crescent Bros. Band's _Nigeria 70 (No Wahala: Highlife, Afro-Funk & Juju 1973-1987)_: "Mundiya Loju" Date: Wed, 20 Jan 2021 04:58:27 +0100 In-Reply-To: (Glenn Morris's message of "Mon, 11 Feb 2013 23:56:18 -0500") Message-ID: <875z3suun0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > Maybe it's just me, but I find it too easy to accidentally change the > marked files in a vc-dir buffer with careless mouse clicks. > > In a directory under version control with modified files: > > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Maybe it's just me, but I find it too easy to accidentally change the > marked files in a vc-dir buffer with careless mouse clicks. > > In a directory under version control with modified files: > > emacs -Q -f vc-dir > > The text that says "edited" (and the space following it all the way up > to the filename) runs vc-dir-toggle-mark on mouse clicks. I find this > makes it too easy to accidentally change the marked state when using the > mouse to select a different window or frame. > > In a dired buffer, there is no way to mark files with mouse clicks > AFAICS. I don't see why vc-dir needs one. (Confusingly, clicking on the > actual mark character itself at the start of the line in a vc-dir buffer > does nothing.) So the suggestion is to remove the `[mouse-2]' binding in `vc-dir-mode'. I've never used the functionality myself, but I can see that somebody might find this useful, but if we're going to have it, perhaps the clickable area should be extended to the mark character, too? (I think removing the binding after more than a decade in existence would be confusing.) Anybody got any opinions here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 22:08:16 2021 Received: (at 13692) by debbugs.gnu.org; 21 Jan 2021 03:08:16 +0000 Received: from localhost ([127.0.0.1]:56532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2QKV-0002CN-Sm for submit@debbugs.gnu.org; Wed, 20 Jan 2021 22:08:16 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:34808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2QKU-0002C3-1F for 13692@debbugs.gnu.org; Wed, 20 Jan 2021 22:08:14 -0500 Received: by mail-wr1-f41.google.com with SMTP id g10so335682wrx.1 for <13692@debbugs.gnu.org>; Wed, 20 Jan 2021 19:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y4N1eK5MuDaRNqxcVs9X0YzVKE/eo3F0+5T9GmR8G3Y=; b=PRfc1eK46y9063834JEprTbsh0wMQthZLe/TW4Ga+DU2LaVIaf+tO0V+/1Gcy99U+G 2449NqncsPEr7+pHB7zHJXtuZxFB9oNrjnAcK86s778+44TObEg2wTUG7kAXiwGg9rgP I+zx0bSH3cDnNR99zAnkbxiV4AEpyonOyWBl3bsce5sfoMbyg6HDvDNL9U7uf43e/JIY 7sFNfs4uv3bHq5Jb64DHXzAUhK77j62D+hHHT6AqgogJ0Gk4ZjermtkXhx7DumSbyLWH jyjQFJlI3vNkJXJ8/l+v1LCJptudpKmfBtPtqDR048V2SjnOxPyj6EVIZQk/3Six/uu2 lUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y4N1eK5MuDaRNqxcVs9X0YzVKE/eo3F0+5T9GmR8G3Y=; b=fb5XBnCJor+2DiDLnrhcyLjbVu6nM5T2bMXHlk9yevcT3dQThR+k+Cp8aUr/mLxdzT lFDLRh8EyWI7R1zVoUie8XQaWwJsiC1XyhSGl4ND1yMlL149PCN3EnZ4EFAMg/JzhVPT AkblBF86FIihQRQH98LJYJ0yURfveVCk/WAzaSxoG6hHV+YgDBMxZf2Wim4RuiuyqIR2 W8NsH3M9S34O8eUBb7+HAZmoxU6QB7C3XVtN8IgSLJr/Foi14ftFCEw4IGayeqjxsWMp x+Hdpw/fxqTaEWzNnJjykB0N1L7K0fDaTdKFe64mZ432hsqyQbfmn/gRGBgUPZ9JJYhK YMXg== X-Gm-Message-State: AOAM530prvqrmTLUidjZfknOMk8/C7S6m1FW43y1QgZxxmmDV2O3Od/y wElvlA7jIxshC6kL2HZyaQHtknJ2L2k= X-Google-Smtp-Source: ABdhPJxkJ49UP0uWeWOwH2+AQu3uz0jQul4kb2l5aLFB2Wp6AC6Mhwe+xtxkarcuCY7+MJnxz9BqWQ== X-Received: by 2002:adf:eb4e:: with SMTP id u14mr12080200wrn.99.1611198488037; Wed, 20 Jan 2021 19:08:08 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j2sm6463799wrh.78.2021.01.20.19.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 19:08:07 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen , Glenn Morris References: <875z3suun0.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Thu, 21 Jan 2021 05:08:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z3suun0.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 13692 Cc: 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 20.01.2021 05:58, Lars Ingebrigtsen wrote: > So the suggestion is to remove the `[mouse-2]' binding in > `vc-dir-mode'. I'm not sure, actually. Perhaps the complaint is about the mouse-1 effect on status buttons. But the rest of my email is on the assumption that we're talking about the mouse-2 binding. > I've never used the functionality myself, but I can see > that somebody might find this useful, but if we're going to have it, > perhaps the clickable area should be extended to the mark character, > too? I've never noticed this functionality in almost a decade of using Emacs. And working on VC for a number of years. > (I think removing the binding after more than a decade in existence > would be confusing.) I don't have a strong opinion about this feature, but it seems like it was designed almost with the main goal of being non-discoverable. As such, I don't think it has many users. It only works when you click on an empty space; if you click on a file or directory name (which are highlighted as buttons and thus invite you to click on them), using mouse-1 or mouse-2, you get to visit the file instead. Only the "status" buttons work for that. If the binding still causes problems (Glenn can tell us), perhaps we'd better remove it. We can still keep the toggle effect on the status buttons, so not much in the way of functionality would be missed. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 21 09:46:19 2021 Received: (at 13692) by debbugs.gnu.org; 21 Jan 2021 14:46:19 +0000 Received: from localhost ([127.0.0.1]:57230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2bE3-0007VP-Er for submit@debbugs.gnu.org; Thu, 21 Jan 2021 09:46:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2bE0-0007VB-Sf for 13692@debbugs.gnu.org; Thu, 21 Jan 2021 09:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B6RcAc3tZckM2h+tV4P1xqTvY3YGgqTA01o1jX1MfnY=; b=kzFmsNkQCdpFzBKkaHZYAxXVkZ beEsFqHw+hC9metiiDwiCsHiAUjGmIdCrFIH1C/tPwmLn50Um68gD5rrCHDhWtfNbkAr6P9B53ki1 4kzb7CqOFndb0DPfduW1hDU8N39Z9uQ8yX5SkBczQkjXWkLtikhzJj54jmRZd/EKrHIs=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2bDs-000641-4f; Thu, 21 Jan 2021 15:46:10 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEWXlpP+/v7o6+xN p/eZyfKCgX3T1teAfnp9e3d0b24eFhZUT1JGNjeiWyX///8QTMQsAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UBFQ4lJA6Ut7AAAAGiSURBVDjLxdK9TuNAEAfwNVIQQRQZFxYl68INZXgEHiAg+UIZu3BB hZCs3XQ00a6oUqEIUaArBzc0FCHNdSdneYFIvAuzgL8Sp6Bi5Gp+nv3PWmaMMQfWy+cu9dnOWrvf 758AGzD2ZxP6YCcGrUATjDfhlIqgwzoRbBa76rC9Vki3wSQM20Gl22HI20Cn4aAdRHgDP4M0vCrC 4wao8OLmW0a1MKZ0KApxE14HoYX8Et9PouooqbTWchrZvg+JX4KWBMqKa+UoKsGWFPLsE2I+ioqt Ugt6HAXgBnESxHExMRFDOmvC7+9IkqCcsFspraYeIkk8Cgqw7xNeHyLiC9D/VNxDyIlU4di5xIWh mWC32moo1VDx+8yYV3NXXnCmlaCHIkxDWHcm7LrXPcxySsGsAK9rP8nYOZ7TSIb4WAB43RltxW8X +JS/rfC5BCti6qLJs8X7KncqAG9vdt7DpzkuzSqDGtBMdIz/DaIpI74APL6PFEwp/5oA0PvcFdFZ h2/J+AaQLB+qiBqA9/Ca/20D8A6qiAaAN+ftAC5sAfhNqG31ARSB4felKw/AAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIxLTAxLTIxVDE0OjM3OjM2KzAwOjAwfdVHfQAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMS0wMS0yMVQxNDozNzozNiswMDowMAyI/8EAAAAASUVORK5CYII= X-Now-Playing: repository's _Depeche Mode_: "Black Celebration: The 12" Singles (5): A Question of Time (Limited Edition)/03-Black Celebration (Black Tulip Mix).mp3" Date: Thu, 21 Jan 2021 15:46:03 +0100 In-Reply-To: (Dmitry Gutov's message of "Thu, 21 Jan 2021 05:08:05 +0200") Message-ID: <87o8hijql0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 20.01.2021 05:58, Lars Ingebrigtsen wrote: >> So the suggestion is to remove the `[mouse-2]' binding in >> `vc-dir-mode'. > > I'm not sure, actually. Perhaps the complaint is about the mouse-1 > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 20.01.2021 05:58, Lars Ingebrigtsen wrote: >> So the suggestion is to remove the `[mouse-2]' binding in >> `vc-dir-mode'. > > I'm not sure, actually. Perhaps the complaint is about the mouse-1 > effect on status buttons. > > But the rest of my email is on the assumption that we're talking about > the mouse-2 binding. Depending on your settings, it's the same binding. I think the default is that mouse-1 and mouse-2 will work the same here (because of the (define-key map [follow-link] 'mouse-face) thing)? > I don't have a strong opinion about this feature, but it seems like it > was designed almost with the main goal of being non-discoverable. As > such, I don't think it has many users. > > It only works when you click on an empty space; if you click on a file > or directory name (which are highlighted as buttons and thus invite > you to click on them), using mouse-1 or mouse-2, you get to visit the > file instead. Only the "status" buttons work for that. It works on the status column, which normally has text like "edited " in it (if you've edited something) -- the button extends to the end of the column... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 20:43:32 2021 Received: (at 13692) by debbugs.gnu.org; 23 Jan 2021 01:43:32 +0000 Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l37xb-000857-Nz for submit@debbugs.gnu.org; Fri, 22 Jan 2021 20:43:31 -0500 Received: from mail-ed1-f43.google.com ([209.85.208.43]:33679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l37xY-00084p-Kt for 13692@debbugs.gnu.org; Fri, 22 Jan 2021 20:43:30 -0500 Received: by mail-ed1-f43.google.com with SMTP id c6so8698114ede.0 for <13692@debbugs.gnu.org>; Fri, 22 Jan 2021 17:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R4yX46LJ9dEp2PlKYog5B/rWm1PT/fIhDP3Dgx/B0Xc=; b=lmOP2RGUYn//AH8nuOSh/m+L9d0q72cuysjjGvnf+cflprxr8CbOHAZT7GvfNV4dCD aHjYWMbCECTY5yDEMqWZ8DjYyzCWW0H/pj4+AwdToWo9SDPgut4CeKlcSHp09TUG9qsw DO2JaC1AsKyK6sflvbeK4xOO7uOMQ7Zl8YrLLiOT/plQ8kRItETk/b5Q5m126nBPvORw Fe52zNEJp/ZOzMjjqtjtNjO5Er4e8o1mnbobhnGnOsxP0ecWQ9LW573WVwpsNx2GJyoI 3cZkO34I5ynGfbEyJFQeVPuCgMYxhqWHWvrl14i+H8ui4f8q9G1A2wod/zEnepjZKlpV Torg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R4yX46LJ9dEp2PlKYog5B/rWm1PT/fIhDP3Dgx/B0Xc=; b=U6YbI3icQIsyXXs8gIrMD9VwLNWsG9FpOBGLA5K9FMkG9HBdt1MPXV1hDExMpQPBK7 4A9PiSI3EGTwSobXS3R/LxmD1vrz/sMZE2Qqj3HR2ZxNLKRWNujEmSgS3P49G31qVLvM D+1+OFQID3NKUbHZC5aDXyM6gOHkg0xqZv+uy3nJaNtIvvOjTFp6goMdnFISx7ODYmWY BZd1REZ7rClFOEd1iX1CJiv4OSBCr8vZB/TXTcVqescv0W3Vek/ACtfJ7OdxJ7PN5dhT bi2/iVQvUU/ZTeVqquSxAyUh27BBIXl1U+AktNAWs7CRJCtVGUs9d0C+PiZzy3l06rpp JNdQ== X-Gm-Message-State: AOAM532qkJpTJQ/mtQ0rFlcafO1ys8xEezf1Jo/+rad1SpelEkx27Tad gsd+hePUdOO2tqdEvggb6aOAVyLmQ5c= X-Google-Smtp-Source: ABdhPJwVPjUsi+RmzfwnpTMdQAuaSKMRFLDKImaOSo9Gj8oDmLGPO9A/4YjJYIzl6jbUT0s0O5PNlQ== X-Received: by 2002:aa7:cfc3:: with SMTP id r3mr1826896edy.125.1611366202236; Fri, 22 Jan 2021 17:43:22 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id gt12sm5377878ejb.38.2021.01.22.17.43.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 17:43:21 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> From: Dmitry Gutov Message-ID: <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> Date: Sat, 23 Jan 2021 03:43:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87o8hijql0.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 21.01.2021 16:46, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 20.01.2021 05:58, Lars Ingebrigtsen wrote: >>> So the suggestion is to remove the `[mouse-2]' binding in >>> `vc-dir-mode'. >> >> I'm not sure, actually. Perhaps the complaint is about the mouse-1 >> effect on status buttons. >> >> But the rest of my email is on the assumption that we're talking about >> the mouse-2 binding. > > Depending on your settings, it's the same binding. I think the default > is that mouse-1 and mouse-2 will work the same here (because of the > > (define-key map [follow-link] 'mouse-face) > > thing)? We're talking about slightly different things. When I hear "mouse-2 binding", I think the global bidning in vc-dir-mode-map, which affects how mouse-2 works also when clicking outside of any buttons (on whitespace beside the buttons). And I think that behavior is relatively weird and could be removed. But we also have the behavior of mouse-1 and mouse-2 clicks on the "status" button. Which seem fairly sensible to me, but might be the cause of Glenn's annoyance in this report because it's relatively easy to click mouse-1 anywhere in the buffer by mistake. >> I don't have a strong opinion about this feature, but it seems like it >> was designed almost with the main goal of being non-discoverable. As >> such, I don't think it has many users. >> >> It only works when you click on an empty space; if you click on a file >> or directory name (which are highlighted as buttons and thus invite >> you to click on them), using mouse-1 or mouse-2, you get to visit the >> file instead. Only the "status" buttons work for that. > > It works on the status column, which normally has text like "edited " > in it (if you've edited something) -- the button extends to the end of > the column... Right. But if that is what is at issue here, I think the question becomes whether to remove the "buttons" from that column (and keep the mouse-2 binding globally) or whether to remove the mouse-2 binding, but set up the buttons to continue working. Or make mouse-1 stop working on the buttons but keep mouse-2 working everywhere (except the file names, I guess?). From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 14:03:12 2021 Received: (at 13692) by debbugs.gnu.org; 23 Jan 2021 19:03:12 +0000 Received: from localhost ([127.0.0.1]:35297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OBk-0004bz-Gp for submit@debbugs.gnu.org; Sat, 23 Jan 2021 14:03:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OBj-0004bl-Dt for 13692@debbugs.gnu.org; Sat, 23 Jan 2021 14:03:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jETYSMjSHKg+U+m5/uj72yPdKDvkiKbuBE8HXg2rU4I=; b=diclVoRFYK8gCTL/F6yp7nGqI7 lf2nzgEFmfItOlZFOPD20FA5YHk3y4s8yMJcicc2vcyk7Docc0vEXgzxEmgleg3YYxzj1dQwCWyUQ sKDLKw+d7i7+hPRmmtbSUIDlS4wSQC4HeACm1tE8MH0I7iyQ8T/GEZlX6MR9OifsED6k=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3OBX-00048a-Ct; Sat, 23 Jan 2021 20:03:05 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX8/PylqahUT0Yx OjccNTmzXi3///+ih99BAAAAAWJLR0QGYWa4fQAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1F B+UBFxIlOdKnSfYAAAF4SURBVDjLfZRtcgIhDIZXewEdPYANy//KxwFcxguAuf9VGiCBhZ02f9zJ 45uEkLAsYlcguy6zncBZsgCXyb8GW8xtl9Fvmw1k5yfS/bewB+67BbKTSbDbDJ5/CETydQSPY0m7 wk7hCNylRwrKqDHWvXwZTO9kGngRqP9DjO/km8ZIijdmhf9AT3LOwOmqWH1i8ODcSMAn89HYspd+ bFhMk5DS5PKeFXhsxuBVi9IdUBLIsIMIBUQB5FYqe2hGdAXKVQBQQMygZCdHBVVBjsi/DGqoCNZQ caAVh8rJFUXQmBSl19SvoSqKorNCowA+YG5WIhpRDthbon05p7SkN7EWhdLEs+Wjx035tXaxtL1e lC8XldvOgKbBytVudIM+olxtG4YCNKY2DDw+PoMVILTx4YFzQEAZ1wdukZmh8uVz60NtgK2wn/0a 5DEUBW/OnZOQDYsjEgoDg2DeNSeCf9Z5ObnuD+PT4HivpieDCFdqJn95lqiw/iz9AsXRwxoTRAM0 AAAAGXRFWHRjb21tZW50AENyZWF0ZWQgd2l0aCBHSU1Q569AywAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0wMS0yM1QxODozNzo1NyswMDowMADX2dYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDEt MjNUMTg6Mzc6NTcrMDA6MDBximFqAAAAAElFTkSuQmCC X-Now-Playing: Herbert's _Part Four_: "Resident" Date: Sat, 23 Jan 2021 20:02:57 +0100 In-Reply-To: <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> (Dmitry Gutov's message of "Sat, 23 Jan 2021 03:43:19 +0200") Message-ID: <875z3nv5lq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > We're talking about slightly different things. > > When I hear "mouse-2 binding", I think the global bidning in > vc-dir-mode-map, which affects how mouse-2 works also when clicking > outside of any [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > We're talking about slightly different things. > > When I hear "mouse-2 binding", I think the global bidning in > vc-dir-mode-map, which affects how mouse-2 works also when clicking > outside of any buttons (on whitespace beside the buttons). And I think > that behavior is relatively weird and could be removed. I didn't even notice that `mouse-2' did stuff when outside the "buttons". And what it does is quite odd... hm, no, if you click after the final line, it'll mark the last line, and before the first, it'll mark the first, so perhaps that's logical? > But we also have the behavior of mouse-1 and mouse-2 clicks on the > "status" button. Which seem fairly sensible to me, but might be the > cause of Glenn's annoyance in this report because it's relatively easy > to click mouse-1 anywhere in the buffer by mistake. Yes, I think he was complaining about the "status" button. > Right. But if that is what is at issue here, I think the question > becomes whether to remove the "buttons" from that column (and keep the > mouse-2 binding globally) or whether to remove the mouse-2 binding, > but set up the buttons to continue working. Or make mouse-1 stop > working on the buttons but keep mouse-2 working everywhere (except the > file names, I guess?). I think removing the global mouse bindings and only having them on the "buttons" would be least surprising -- that's how most modes work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 21:23:54 2021 Received: (at 13692) by debbugs.gnu.org; 24 Jan 2021 02:23:54 +0000 Received: from localhost ([127.0.0.1]:35695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3V4E-0004c7-0N for submit@debbugs.gnu.org; Sat, 23 Jan 2021 21:23:54 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:39165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3V4C-0004bv-Pq for 13692@debbugs.gnu.org; Sat, 23 Jan 2021 21:23:53 -0500 Received: by mail-wr1-f45.google.com with SMTP id a1so8801330wrq.6 for <13692@debbugs.gnu.org>; Sat, 23 Jan 2021 18:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=uvPbY/bwpcbhFPpnh637AqSKqtv53G0ctVzjIMNlMHw=; b=iZzg69rPJPeK3tFu0lnPNmT39XcYfTXqg5vedRfVijwJSl2GOWuvSKjaADVCU74UJW tGX7a+FeZSzE4Q2q9WBqpzNdQwijfXqylp1dL5yMLKAH3xksUaCvhoaPDncOM1x6S7o6 tQbATN9VCqiHwJERNsQ6eibZce0k7dpYgEl55CQO70c+Cx6RpogKB1a0CHYMMxoy0RhE DM/CKP4Iwhlk1/ZLywhX/rpk5EYcrVMUHLyCEuG1N3K8wEHF4RoNDUTi9aV5Tb+9iK/5 WZQfaFIKCTTt4itp6NfsrhKoaFxGuSsMCEgwJsSj/MNfk8RBdPRTQqe/fbBy8hhJIIIa uilQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=uvPbY/bwpcbhFPpnh637AqSKqtv53G0ctVzjIMNlMHw=; b=qYDmPZRzAPSUyg40l8bgdDkSP1SVDz8XwIRvUkzXq1IBcEb0Yqmg3PY8SrMzi8TXV4 ztURACbKo81JN5D+d56Q2q58RUW25BpzQqbkzWMGiiq15v6zBtpMOXhMesUZ92kd+vrf P4n7fRdb4ShGn2LV1qjexJpuVuewWYMsJi7FKu1kz3kEpjt8keUUr26OfrJtIJuuN2vu ndGFtKrsUL/hdD/aT9QpgpXjV4z0+cqquKVxbP1u5DSq3AYHaydqxA9tC5VU623W/xWv aHNv0K5pIrN5eBwo5aN5UlmvEMtjK2oGKimcITpmZq2ZvWYRE4F+J3cHuC3JUAytKN7A ndPg== X-Gm-Message-State: AOAM53335EyJQadZ+RvgcDBitS2+5lzB9pa4CsZrCXd+QfsH62qZrGaS Sg8/2oQxb7DWRzzeMtkP/50Rd2gmmWI= X-Google-Smtp-Source: ABdhPJy4GFk6AKbnSdY8JwJ5ECyUaUe2h8C1FCrjkliryJJAMdRwayhiDJP+kcZSJuTxRFyjj1oJvw== X-Received: by 2002:a5d:5049:: with SMTP id h9mr1064721wrt.404.1611455026764; Sat, 23 Jan 2021 18:23:46 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k6sm6608462wro.27.2021.01.23.18.23.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 18:23:45 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> From: Dmitry Gutov Message-ID: <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> Date: Sun, 24 Jan 2021 04:23:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z3nv5lq.fsf@gnus.org> Content-Type: multipart/mixed; boundary="------------CBE7F39E17A289E3ECE1CADA" Content-Language: en-US X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------CBE7F39E17A289E3ECE1CADA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 23.01.2021 21:02, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> We're talking about slightly different things. >> >> When I hear "mouse-2 binding", I think the global bidning in >> vc-dir-mode-map, which affects how mouse-2 works also when clicking >> outside of any buttons (on whitespace beside the buttons). And I think >> that behavior is relatively weird and could be removed. > > I didn't even notice that `mouse-2' did stuff when outside the > "buttons". And what it does is quite odd... hm, no, if you click after > the final line, it'll mark the last line, and before the first, it'll > mark the first, so perhaps that's logical? I meant more like between the buttons, but on the same line as them. The "before" and "after" behaviors are logical, but the whole binding is very non-discoverable. Nor does it work on file names. >> But we also have the behavior of mouse-1 and mouse-2 clicks on the >> "status" button. Which seem fairly sensible to me, but might be the >> cause of Glenn's annoyance in this report because it's relatively easy >> to click mouse-1 anywhere in the buffer by mistake. > > Yes, I think he was complaining about the "status" button. > >> Right. But if that is what is at issue here, I think the question >> becomes whether to remove the "buttons" from that column (and keep the >> mouse-2 binding globally) or whether to remove the mouse-2 binding, >> but set up the buttons to continue working. Or make mouse-1 stop >> working on the buttons but keep mouse-2 working everywhere (except the >> file names, I guess?). > > I think removing the global mouse bindings and only having them on the > "buttons" would be least surprising -- that's how most modes work. The attached patch seems to do that, except for the "status" buttons beside directory names, which seem to be printed by ewoc in some other way, and thus don't go through vc-dir-printer. Which is a new different kind of awkward. We're also solving a different problem than the one which was reported. So I'm not sure about the change, TBH. --------------CBE7F39E17A289E3ECE1CADA Content-Type: text/x-patch; charset=UTF-8; name="vc-dir-no-mouse-2.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-dir-no-mouse-2.diff" diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index bbb73240be..9d0808c043 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -300,7 +300,6 @@ vc-dir-mode-map (define-key map "\C-o" 'vc-dir-display-file) (define-key map "\C-c\C-c" 'vc-dir-kill-dir-status-process) (define-key map [down-mouse-3] 'vc-dir-menu) - (define-key map [mouse-2] 'vc-dir-toggle-mark) (define-key map [follow-link] 'mouse-face) (define-key map "x" 'vc-dir-hide-up-to-date) (define-key map [?\C-k] 'vc-dir-kill-line) @@ -1085,7 +1084,6 @@ vc-dir-mode as the current file - if the cursor is on a directory: unmark all child files - with a prefix argument: unmark all files -mouse-2 - toggles the mark state VC commands VC commands in the `C-x v' prefix can be used. @@ -1392,6 +1390,12 @@ vc-default-dir-extra-headers (propertize "Please add backend specific headers here. It's easy!" 'face 'font-lock-warning-face))) +(defvar vc-dir-status-mouse-map + (let ((map (make-sparse-keymap))) + (define-key map [mouse-2] 'vc-dir-toggle-mark) + map) + "Local keymap for toggling mark.") + (defvar vc-dir-filename-mouse-map (let ((map (make-sparse-keymap))) (define-key map [mouse-2] 'vc-dir-find-file-other-window) @@ -1418,7 +1422,8 @@ vc-default-dir-printer ((memq state '(missing conflict)) 'font-lock-warning-face) ((eq state 'edited) 'font-lock-constant-face) (t 'font-lock-variable-name-face)) - 'mouse-face 'highlight) + 'mouse-face 'highlight + 'keymap vc-dir-status-mouse-map) " " (propertize (format "%s" filename) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index a9ee28e3aa..94fac3a83b 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -481,7 +481,8 @@ vc-git-dir-printer 'face (cond ((eq state 'up-to-date) 'font-lock-builtin-face) ((eq state 'missing) 'font-lock-warning-face) (t 'font-lock-variable-name-face)) - 'mouse-face 'highlight) + 'mouse-face 'highlight + 'keymap vc-dir-status-mouse-map) " " (vc-git-permissions-as-string old-perm new-perm) " " (propertize (vc-git-escape-file-name (vc-dir-fileinfo->name info)) --------------CBE7F39E17A289E3ECE1CADA-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 18:59:54 2021 Received: (at 13692) by debbugs.gnu.org; 25 Jan 2021 23:59:54 +0000 Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Bly-0005JZ-3b for submit@debbugs.gnu.org; Mon, 25 Jan 2021 18:59:54 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Blx-0005JN-B3 for 13692@debbugs.gnu.org; Mon, 25 Jan 2021 18:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JHkxOMxE32pmQOEcAovP/J8UdxvdkWmQ7nUgt4WRT18=; b=iUuLyz7duviWOerdVQQNOTdXUa A+swPnJB1+boLjED7aVQjCnhGoHuyNIYQYwb1fbFbw6cIrKxUOmzfgnh8pmcslVSNXxqEEccKtm6y H4F0QWKsXQaOHFPkcyAVGvNIMlKZ7OOk0EyOgCH9fnjfgOHxYzgtA3vLX+EkQMoGw6Bc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4Blp-0002qE-3K; Tue, 26 Jan 2021 00:59:47 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX3+fPa2dbEvr57 a3ehoqpGPEkTDBH///+rYgGBAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UBGRceG91hUvIAAAGiSURB VDjLjdLBmoIgEABgMPcOVnclumfqnsvo3mbjfb9V3v8RdgYMafOwHIrmbwYYYOx9SCkztRBnHGUR SLJFYP8Bnr9DQtPVMRbuYMNSxtK6fAPOtOBF80j/lkqZyjfn7bARRrCz+2e8eDroQuciE0Wa+HNM ltzdl2LnrPXAuXAZX2EFIT0kgrMiWd1YlmAIV5haInEiBFsdMMpzBPzIou6uD74MZog8bvu+bP8e 0I8r2NMiNNYOi9BbOy7eh0UQ8w2GxRMEm883G2BFIOJXMv34IDjNj+QV8jkhAJX6iRICpAjfATKl Qwae4xZByNjjyQ9hU1Gpa9OPMYRSVQPd6Rl/gQq6clpC10qZUKoCqKd2VHWFIGeozm5La4DOGFcS 4dIAwIPisrHjUXuQUlwwDh1Ns75uFWYUXq4EcMDZbsBNvYKFO1Uq1RuMXYFLFxRHQFcFAXYLjrLp sIMEysO+H+k5dDu4u4QZ6KLsCE1/dAmGGUMit3Yao08gcLJ2UbD27hMckGgH5dW2xsxgTKt7gocy +hWM8fAMm4pdptknwTDDL00Yf353BdPtAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTI1VDIz OjMwOjI3KzAwOjAwIPc4KgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0yNVQyMzozMDoyNysw MDowMFGqgJYAAAAASUVORK5CYII= X-Now-Playing: Sam Amidon's _Bright Sunny South_: "Weeping Mary" Date: Tue, 26 Jan 2021 00:59:43 +0100 In-Reply-To: <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> (Dmitry Gutov's message of "Sun, 24 Jan 2021 04:23:43 +0200") Message-ID: <875z3ko9e8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: >> I think removing the global mouse bindings and only having them on >> the >> "buttons" would be least surprising -- that's how most modes work. > > The attached patch seems to do that, except for t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >> I think removing the global mouse bindings and only having them on >> the >> "buttons" would be least surprising -- that's how most modes work. > > The attached patch seems to do that, except for the "status" buttons > beside directory names, which seem to be printed by ewoc in some other > way, and thus don't go through vc-dir-printer. Which is a new > different kind of awkward. > > We're also solving a different problem than the one which was reported. It's a different problem, but I think this change makes sense. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 19:36:36 2021 Received: (at 13692) by debbugs.gnu.org; 26 Jan 2021 00:36:36 +0000 Received: from localhost ([127.0.0.1]:40461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4CLT-000208-Va for submit@debbugs.gnu.org; Mon, 25 Jan 2021 19:36:36 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:39018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4CLS-0001zs-P2 for 13692@debbugs.gnu.org; Mon, 25 Jan 2021 19:36:35 -0500 Received: by mail-ed1-f46.google.com with SMTP id b21so17737817edy.6 for <13692@debbugs.gnu.org>; Mon, 25 Jan 2021 16:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1ZCIGBBTnaPgc1/Ub4Hi1ntZ5GfpaQY3t8p+7cmO8VI=; b=dCq9f5A/ONDZC6QHdk50U5PsnCipiR4xkx9LfhEBVV5yM/o9H4F20pGirt+0FAWr6S UXHf7QmUp6jKSe345ytCdDch3LOzxkJ9z0qOqQ2b7iGhKnafiCiyIMlPlMwjPKOryvio on/VpnBOEq0uf1vynkVpbhM6wSHbTP9pEE2Qr7dQH4UUojX9ZRKCl7wUeRxV3lbDunBU pD+xbgPUGVMnuxD0jBeLrSRkt7kXIg3ZJUPtDy/G98eewXIyHwy5cBg3/0AkJF4XeZ1m MbWiJpwuvZuYBlG/dvrQGJVFr8VDkexBHI2nWKxxGNri6zOz2reNZpboEOAZaGsRJTtM jBuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1ZCIGBBTnaPgc1/Ub4Hi1ntZ5GfpaQY3t8p+7cmO8VI=; b=jqOsHSsowO3PzDxcfV/yhjaJffKjnpT9xTfHTkO/oGpPGbJju8nc3Sn+YyE2svq/r3 R0XVTEA3RtWxUmZCqrgEEZSDu00vDV6ojWjNZispZv5ZSqU8N3vcymTVXdfX+bjjw9CQ tUGNDw5s8MBaU/X1Y2wdJo5JwyHEyKgLPivIWpy8rsV/jlMY4EefISFQGwmD+/Tyssz5 EtsV4PO0Lg6jHV3+nOx8tJU/VnSJwvxQ/mMGKv2fGeRKB3lbW5MRc4OBwXNzZ7cW5vgP EsVnIZncVpYSOJIODpOuFj5bDOMazGdNeIDZN+L3m0NtUNWrGrrX/Z34tO9UDMFlCpDe NtuQ== X-Gm-Message-State: AOAM532MHC8fRgYPPLb3YKOM0mRR+EqqL4cudkYfTeGdzB9b7OtZ3Yul 1Y6J/dbeniB1mY+QmIwuof0dvO7dCro= X-Google-Smtp-Source: ABdhPJzcbC5Bdl5N2CDdGfrlpo1u2ev/NCuJSEgEpyaqYB3DYXiZM9HIgLg0UaFN0ZgzQTwOG1m9uA== X-Received: by 2002:aa7:d919:: with SMTP id a25mr2592777edr.243.1611621388776; Mon, 25 Jan 2021 16:36:28 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r10sm11578867edw.24.2021.01.25.16.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 16:36:27 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> From: Dmitry Gutov Message-ID: <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> Date: Tue, 26 Jan 2021 02:36:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <875z3ko9e8.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 26.01.2021 01:59, Lars Ingebrigtsen wrote: > It's a different problem, but I think this change makes sense. I'm fine with doing it, but someone should look into the buttons beside directory names first (clicking on them stops working if that patch is applied). From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 20:39:30 2021 Received: (at 13692) by debbugs.gnu.org; 27 Jan 2021 01:39:30 +0000 Received: from localhost ([127.0.0.1]:43090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Znt-0005M3-Sy for submit@debbugs.gnu.org; Tue, 26 Jan 2021 20:39:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Znr-0005Lr-Us for 13692@debbugs.gnu.org; Tue, 26 Jan 2021 20:39:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=f8LcEBTPFhTBHdnywdapJKr7tbFui6LfhKRTbAWkZgc=; b=pFiB1nFRKgiVbBnOaWkpv4Wu8z bWis8+KYO9YMTs7Z/XYnwMm56OFk1AIXHGD5C9d+kzPFiK7MA6kSc3GegUt2kD5x4Q05XOFXqdtRa /REzdq4ZOXKPvpYM91N4zv8gBpvh/oZjBf2AzD4mBj6hGiD4vN98DapCpGRklOxPj3VA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4Znj-0007da-PY; Wed, 27 Jan 2021 02:39:22 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> X-Now-Playing: repository's _Depeche Mode_: "Black Celebration: The 12" Singles (4): A Question of Time/02-Black Celebration (Live).mp3" Date: Wed, 27 Jan 2021 02:39:18 +0100 In-Reply-To: <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> (Dmitry Gutov's message of "Tue, 26 Jan 2021 02:36:25 +0200") Message-ID: <87wnvzf9a1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 26.01.2021 01:59, Lars Ingebrigtsen wrote: >> It's a different problem, but I think this change makes sense. > > I'm fine with doing it, but someone should look into the buttons > beside director [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 26.01.2021 01:59, Lars Ingebrigtsen wrote: >> It's a different problem, but I think this change makes sense. > > I'm fine with doing it, but someone should look into the buttons > beside directory names first (clicking on them stops working if that > patch is applied). Do you mean the `vc-default-dir-printer' thing? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 29 21:01:46 2021 Received: (at 13692) by debbugs.gnu.org; 30 Jan 2021 02:01:46 +0000 Received: from localhost ([127.0.0.1]:53255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5fa5-0001NR-Oz for submit@debbugs.gnu.org; Fri, 29 Jan 2021 21:01:46 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5fa1-0001Mv-Pk for 13692@debbugs.gnu.org; Fri, 29 Jan 2021 21:01:44 -0500 Received: by mail-ej1-f43.google.com with SMTP id bl23so15649409ejb.5 for <13692@debbugs.gnu.org>; Fri, 29 Jan 2021 18:01:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bh9rv9Dn9+PyF/LAd2VT15yxaUP+N9UsnZmjVP9doWo=; b=P2kQstsEa5AHdG73JiYWGm5w2qJf0YmAbz8v3Su47jyObXvxHHPkmQdssRxmCDzXaK wMMmsLcBKh/v0DBV/fSWHD3vlgzhPJCZdWEia8dh8hU5KjiastVFW0+2FmoDNidNTHSv z6gJlLaqwgZNCoxZFMAhXDjW+DgSWvu5+djYtA/Ls9/qwVhKUTjfqJYqJhLiO0r85fbu CoML5X93R8lfQ+tXqL4T/0hWyBJRxqasCNPbAvCh4cu7HbRzG449fJzCW44FkZ/LqwQj Rz9HtxpM1ZTWIWIcPremuHNmaJl4n16Nvnk2vG8bXplj9uGlTq2teyDqnGxG0zmsenPx gI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bh9rv9Dn9+PyF/LAd2VT15yxaUP+N9UsnZmjVP9doWo=; b=k2crP5MjFPtHjsowEEys/pz6Vvzi+yVWal7ajMiemQjUrI7Vv0CLMftgEXZm+anx7z qjsAKwVMavt4xUOsdBTIYMWof97Y7Y73xxf8xjNPHTUUL4GbA0luAOOELHuH+4MLgBSH 7V9GbzQXM0QbmQcX5X5E6WTWVGkN2UqTJtdsoJPHpuBWIdE6TkquJtQqQU/Oi7CVZYeY 2fOl/yawYlEASmq1fcqNtKhvk/3PWeFPR777MH6kZKFk+Mddt8w1Xeh2Sz95Hp5U088W BocdgF1Yh6mEVZtpoPJ3hvWnWy2LT4Vy4tChtnoS/z4Y4bzfTqIfraOzWI3dvvCdhpPF CaOQ== X-Gm-Message-State: AOAM531f3A2w5KXlUt5J2fRH1IgI/qtlAamNkDu5181RI6Jyh7xQgUCx 9tgSkUaGf81pFvL9+LG07VCwI98vrlg= X-Google-Smtp-Source: ABdhPJyZSwKAY7VeUz/xlt+sJPD9vHdnfghrMybA+nvkfK1z/cNMxidXjwjI7Y3HKX1aU3txNYNkRw== X-Received: by 2002:a17:906:eb1b:: with SMTP id mb27mr7463667ejb.332.1611972095440; Fri, 29 Jan 2021 18:01:35 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l1sm4490423eje.12.2021.01.29.18.01.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jan 2021 18:01:34 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> From: Dmitry Gutov Message-ID: <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> Date: Sat, 30 Jan 2021 04:01:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87wnvzf9a1.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.01.2021 03:39, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 26.01.2021 01:59, Lars Ingebrigtsen wrote: >>> It's a different problem, but I think this change makes sense. >> I'm fine with doing it, but someone should look into the buttons >> beside directory names first (clicking on them stops working if that >> patch is applied). > Do you mean the `vc-default-dir-printer' thing? Huh, never mind. After applying the patch re-compiling both files and restarting Emacs, the behavior now is as expected. So I pushed the patch, thank you. Not sure if we should close this now. The thing that tripped me up last time was that when vc-dir-revert-buffer-function is invoked, neither vc-default-dir-printer nor vc-git-dir-printer are called to re-print the directory entries. They remain as they were when the VC-Dir buffer was created (unless the refresh ends up adding some some files in other directories, I suppose). While we're on the subject of buttons, I think it's odd that mouse-1 and mouse-2 routinely do the same thing, here and in other cases (e.g. links in Compilation buffers). But I suppose this is outside of scope for this discussion. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 30 01:21:49 2021 Received: (at 13692) by debbugs.gnu.org; 30 Jan 2021 06:21:49 +0000 Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5jdl-0003GJ-C5 for submit@debbugs.gnu.org; Sat, 30 Jan 2021 01:21:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5jdj-0003G4-91 for 13692@debbugs.gnu.org; Sat, 30 Jan 2021 01:21:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PWjmgnNoGllYmksgfWcg90jVjk9IcEPHJyriTPXLWuk=; b=gWikzWeFtfb6Zf+uMrAmWrVgt1 qG5b68UwsnvXOS7b/QpiHZyz7EcMFSAZJEgRH3yqpHbxfR4CADl+43YfE1o82c5tzkZZ4Mpnvj6lh S06NERJ7N/nBcjN8UlGpT3TvK7QZgs24ehuMqGTmy1xlOBzXhiBxJpIIAxj2XqUK9L4s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5jdX-0004gt-Na; Sat, 30 Jan 2021 07:21:41 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXcu6+qbl9eLioN BAb///8QCg2MAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UBHgYFForVFCsAAAGZSURBVDjLhZKLkcMg DESDrwEkGohEA0Hqv7fbBX+Sm3hOmUmIHystax6P/6rM7zqX4o6FoIrIJkc9NDJf56ZNauHjio9o PnfwwNM6iSpg0UMBTeUCoBvJqVi/VYr3cAzln0WKTSOemSRUz5kTlFKSFUK7HAtQjYLSJ3Gt1wwp kGguScdwqTxGvUD0dAKeCCONTqomnnp3f16NjRapcBwyZ6u2+tZakUW4H5Esi5BUKgAMgK62HQyk 0rqpuy9F20Ggq6ZBINKpWGeKlginuM5EgvksTwKAcIx/wxk7ZnMewLMMLDwgagAbAcLacmzhpmYa wleLM3nCi+T4ycDCxJSgrdQycjS2h9z7rqAndp6Je46lKNw1ih0BzJHHDHdkuT+GXfM8XHk5QUQf EyAS95ADwEU06y++A1yYHLISSIV5nUCRUk8c61A4bglBD+bOIM4KQyRwaWziPU9bwVbYPjf7myLp in1Gn4d6rwVgJd9nXMBZ3wAM6neAIM878RecB/wEN8PnPbkD0W9Atjvgn6Dk18Klvlr3T3BTvw+Q kZeiVD5bAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTMwVDA2OjA1OjIyKzAwOjAwDLrbIwAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0zMFQwNjowNToyMiswMDowMH3nY58AAAAASUVORK5C YII= X-Now-Playing: Simon & Garfunkel's _Live 1969_: "Bridge Over Troubled Water" Date: Sat, 30 Jan 2021 07:21:34 +0100 In-Reply-To: <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> (Dmitry Gutov's message of "Sat, 30 Jan 2021 04:01:32 +0200") Message-ID: <87o8h70wsx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Not sure if we should close this now. I think we should make the "*" area also clickable -- I think that's the most confusing part here now (that only clicking the status area toggles the "*", and clicking the "*" itself doesn't do anythi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Not sure if we should close this now. I think we should make the "*" area also clickable -- I think that's the most confusing part here now (that only clicking the status area toggles the "*", and clicking the "*" itself doesn't do anything). > While we're on the subject of buttons, I think it's odd that mouse-1 > and mouse-2 routinely do the same thing, here and in other cases > (e.g. links in Compilation buffers). But I suppose this is outside of > scope for this discussion. Yeah, the mouse thing is pretty confusing, but the `mouse-1-click-follows-link' variable can be set to change the behaviour. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 30 09:05:17 2021 Received: (at 13692) by debbugs.gnu.org; 30 Jan 2021 14:05:17 +0000 Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5qsH-0006i0-CR for submit@debbugs.gnu.org; Sat, 30 Jan 2021 09:05:17 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:38457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5qsF-0006hl-PC for 13692@debbugs.gnu.org; Sat, 30 Jan 2021 09:05:16 -0500 Received: by mail-wm1-f54.google.com with SMTP id y187so9365097wmd.3 for <13692@debbugs.gnu.org>; Sat, 30 Jan 2021 06:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZI64sRvYc9W7xCpmdc3uKNOEr6J3WDocze9wc0h2ZmM=; b=APJ94x6PmLOZVfl9WcvjP9bLkITCp5sHOV0Ot1lr6wE/ILzXP3VB3aWuQCqC6Kb/1e WDd7Vwp1s6/Mai4AcWNOmKadHaVRem/pmPlB0HceTEpHG5UED54Fe4RLVQ1vvg1BW/pN hbntTipmPfJDrw3r4dm/lOz0uxXeFnvEPDlExUZHoyVojWTS67uncRkKlxcjABXa4er6 6RLqO72n979Noxk73oGhlPn14ShhGPmAP633PMdtH9bladbrxRGkQpKK2kGqhhNWesDI 7/rdyOFAFPWH5iqwNv7hcnXT8F/rwA0Qxa0SYTNeNOWyTGglhoUBUsD9tuEZJ3pUWvcG lUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZI64sRvYc9W7xCpmdc3uKNOEr6J3WDocze9wc0h2ZmM=; b=YgxLgC0qFsP6qBeDzePUHdhKfaSnyCriDXQduA4vNZ2gfH+dGFCs7L34sq/MLrrHEr E/BVJeVxczqEMn0TcvAf0YuxDaMEZ+lcZXkNVQmISHoklQMN0QQYvyYlJcAW91c6GjBz 5L6TWK4yDZQhR1RAohbdaaf45amxc2luDHilkPwOXo2FfUe6KW+rsPfD4QboCwqnV8yM +FT2FPVlk1X6JSk8twXfcar0Yi+d286H18cTDd84+LsQ9ceiGOhlj2DZOmP9hjGy+1mJ kv9czJuWMQG/5uAekIQLb0gF2zLskf9I3CKckzsZTnTrd3IxQ9r84zFcf1i8INn/wDOC 0hWQ== X-Gm-Message-State: AOAM530+qRMy+o661K/4u9RvowMJYrGNlNFLqvY2d9myhf66G72/qVFE e2CE6ovzWaWU4fHvliyIXnQtwsgvbD4= X-Google-Smtp-Source: ABdhPJw2aTd7yAr4SUbGmPMJWsIKEBFDkCBMZa3fEXe3PwFZatbHnmq3iuEWr++ThFEMIu3idugT0g== X-Received: by 2002:a7b:c24c:: with SMTP id b12mr7873743wmj.167.1612015508595; Sat, 30 Jan 2021 06:05:08 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z130sm14048273wmb.33.2021.01.30.06.05.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Jan 2021 06:05:07 -0800 (PST) Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks To: Lars Ingebrigtsen References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> <87o8h70wsx.fsf@gnus.org> From: Dmitry Gutov Message-ID: <86a50315-e3c4-1a6f-a92e-abcca84b81b3@yandex.ru> Date: Sat, 30 Jan 2021 16:05:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87o8h70wsx.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 30.01.2021 08:21, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> Not sure if we should close this now. > > I think we should make the "*" area also clickable -- I think that's the > most confusing part here now (that only clicking the status area toggles > the "*", and clicking the "*" itself doesn't do anything). I don't know if it's so confusing: after all, we have mouse-face to let the user know which area can be interacted with mouse clicks. The asterisk is not highlighted, so it's not clickable. We can change that, but how? Extend highlighting to the asterisk column? On all lines, whether the asterisk is there or not? The way that the button currently starts where the text starts looks tidy and nice, IMHO. >> While we're on the subject of buttons, I think it's odd that mouse-1 >> and mouse-2 routinely do the same thing, here and in other cases >> (e.g. links in Compilation buffers). But I suppose this is outside of >> scope for this discussion. > > Yeah, the mouse thing is pretty confusing, but the > `mouse-1-click-follows-link' variable can be set to change the > behaviour. All right. And I guess (setq mouse-1-click-follows-link nil) can be a solution for the original complaint here. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 02:27:49 2021 Received: (at 13692) by debbugs.gnu.org; 31 Jan 2021 07:27:49 +0000 Received: from localhost ([127.0.0.1]:56296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l679B-00070j-2I for submit@debbugs.gnu.org; Sun, 31 Jan 2021 02:27:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6798-00070W-B8 for 13692@debbugs.gnu.org; Sun, 31 Jan 2021 02:27:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v9h8+ZBAET0JWL4modYRT0+91Qy5X3lRQ1IubD63ffU=; b=rW7Bd+3vlvzZj7SSQ+jQ1EoEeG +ZxZGDUGL5FRBYdl/Vcjy5K0gAKvsh3QaE1DscALlRnT+TIv8q/oMrOAPWJsPzN6UXLAdzTuQVxpD +Ca9QDahtj+lr++wLbTfJx7Zxd1qmK3FfGpz0YLa8OnvGM7ATIVXqd/DH7HiVVEwDylE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6790-0002ib-Bp; Sun, 31 Jan 2021 08:27:40 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> <87o8h70wsx.fsf@gnus.org> <86a50315-e3c4-1a6f-a92e-abcca84b81b3@yandex.ru> X-Now-Playing: Tuxedomoon's _Live in Eindhoven (1980)_: "East" Date: Sun, 31 Jan 2021 08:27:37 +0100 In-Reply-To: <86a50315-e3c4-1a6f-a92e-abcca84b81b3@yandex.ru> (Dmitry Gutov's message of "Sat, 30 Jan 2021 16:05:05 +0200") Message-ID: <87eei1va52.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > We can change that, but how? Extend highlighting to the asterisk > column? On all lines, whether the asterisk is there or not? Yes, I think that would be a pretty consistent interface, so that you can click the "*" off and on as you wish. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > We can change that, but how? Extend highlighting to the asterisk > column? On all lines, whether the asterisk is there or not? Yes, I think that would be a pretty consistent interface, so that you can click the "*" off and on as you wish. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 23 10:12:24 2021 Received: (at 13692) by debbugs.gnu.org; 23 Aug 2021 14:12:24 +0000 Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIAga-0000tU-6K for submit@debbugs.gnu.org; Mon, 23 Aug 2021 10:12:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIAgX-0000tF-WC for 13692@debbugs.gnu.org; Mon, 23 Aug 2021 10:12:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+UwxtTSJx5+OK3Ng8Td7PyvjKUYWq2tfmztHncrZC+I=; b=ubv12kvMkrjleGMsljPT6YrDeL AMyad506NhuDuYybBwct2w5rgFqc8GUWe3p/dsEfADE+0WFuwGNxA6eKxNu/vKeYXecp72ZIEOHn1 zIS1m8WDRYhVNsKtwNeIPowStX378jQOnAN5GPNAYJeQ8QXNxChIyOn/v2FmYCIM3Xo0=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIAgM-00040B-UF; Mon, 23 Aug 2021 16:12:15 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> <87o8h70wsx.fsf@gnus.org> <86a50315-e3c4-1a6f-a92e-abcca84b81b3@yandex.ru> <87eei1va52.fsf@gnus.org> Date: Mon, 23 Aug 2021 16:12:10 +0200 In-Reply-To: <87eei1va52.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 31 Jan 2021 08:27:37 +0100") Message-ID: <87r1eks11h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Dmitry Gutov writes: > >> We can change that, but how? Extend highlighting to the asterisk >> column? On all lines, whether the asterisk is there or not? > > Yes, I think that wou [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 13692 Cc: Glenn Morris , 13692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Dmitry Gutov writes: > >> We can change that, but how? Extend highlighting to the asterisk >> column? On all lines, whether the asterisk is there or not? > > Yes, I think that would be a pretty consistent interface, so that you > can click the "*" off and on as you wish. Actually, playing with this a bit more, I think the way it works now makes sense. Having the leading space be a button is confusing -- you don't expect that clicking on space should do anything. So just having the status column clickable is best. So I think your changes here were sufficient, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 23 10:12:27 2021 Received: (at control) by debbugs.gnu.org; 23 Aug 2021 14:12:27 +0000 Received: from localhost ([127.0.0.1]:42242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIAgd-0000tj-D7 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 10:12:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIAgc-0000tM-D5 for control@debbugs.gnu.org; Mon, 23 Aug 2021 10:12:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LVMgK8nCZ3bayRXTLNSgQ/VtWaKQEVPH+nnXroPQW4s=; b=lKOQcXgIeZ8JfA3Hw4JNhrWrJS cRvwFAq3dSDsAapL5D3K9ufLGiWDSEFLjRX6vp7HeTHtSfElr1tgqqOmVlTQa/j2iwr/8guTJdeBT mE9hVjEIKJrl1RfyWx2eh5GNKQJFWOD2VO4KgA5SsDiY0eMirdDrSBFKQUu2rUnANMhA=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIAgU-00040Q-L9 for control@debbugs.gnu.org; Mon, 23 Aug 2021 16:12:20 +0200 Date: Mon, 23 Aug 2021 16:12:18 +0200 Message-Id: <87pmu4s119.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13692 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 13692 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 13692 28.1 quit From unknown Sat Aug 16 13:48:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Sep 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator