GNU bug report logs - #13625
24.1; Enable 'package-menu-execute being non-interactive

Previous Next

Package: emacs;

Reported by: Yves Baumes <ybaumes <at> gmail.com>

Date: Mon, 4 Feb 2013 00:20:02 UTC

Severity: normal

Found in version 24.1

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Yves Baumes <ybaumes <at> gmail.com>
Cc: 13625 <at> debbugs.gnu.org
Subject: bug#13625: 24.1; Enable 'package-menu-execute being non-interactive
Date: Sun, 03 Feb 2013 22:39:43 -0500

> Well, from my point of view the implementation must be silent when
> called non interactively.

As a general rule, I tend to agree.

> Here is a modification that I made that suit my needs:

> (defun package-menu-execute ()
> ...
>     (when install-list
>       (if (or
>            (not (called-interactively-p 'any))
>            (yes-or-no-p
> ...
>     ;; Delete packages, prompting if necessary.
>     (when delete-list
>       (if (or
>            (not (called-interactively-p 'any))
>            (yes-or-no-p
> ...

Better would be to move those questions to the `interactive' spec, so
you don't even need called-interactively-p.

But you'd also want to check if there are callers of this function that
would need to be adjusted.


        Stefan
This bug report was last modified 12 years and 187 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.