GNU bug report logs - #13625
24.1; Enable 'package-menu-execute being non-interactive

Previous Next

Package: emacs;

Reported by: Yves Baumes <ybaumes <at> gmail.com>

Date: Mon, 4 Feb 2013 00:20:02 UTC

Severity: normal

Found in version 24.1

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #26 received at 13625 <at> debbugs.gnu.org (full text, mbox):

From: Yves Baumes <ybaumes <at> gmail.com>
To: 13625 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Rép : bug#13625: 24.1; Enable
	'package-menu-execute being non-interactive
Date: Tue, 05 Feb 2013 17:38:34 +0100
[bug_16325.txt (text/plain, inline)]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: ybaumes <at> gmail.com-20130205153237-82xdt2b5f4i85bv2
# target_branch: bzr://bzr.savannah.gnu.org/emacs/trunk/
# testament_sha1: 509b0f8920808cc725a441fb32877e16e6ec513f
# timestamp: 2013-02-05 16:34:09 +0100
# source_branch: bzr://bzr.savannah.gnu.org/emacs/trunk
# base_revision_id: jan.h.d <at> swipnet.se-20130205122155-exqwhauamc0k0y1a
# 
# Begin patch
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2013-02-05 12:16:35 +0000
+++ lisp/ChangeLog	2013-02-05 15:32:37 +0000
@@ -1,3 +1,8 @@
+2013-02-05  Yves Baumes  <ybaumes <at> gmail.com>
+
+	* lisp/emacs-lisp/package.el (package-menu-execute): Don't query
+	for the user input when called non-interactively (bug#13625).
+
 2013-02-05  Jan Djärv  <jan.h.d <at> swipnet.se>
 
 	* cus-start.el (all): Add ns-use-native-fullscreen.

=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el	2013-01-01 09:11:05 +0000
+++ lisp/emacs-lisp/package.el	2013-02-05 15:32:37 +0000
@@ -1588,7 +1588,7 @@
 	       (length upgrades)
 	       (if (= (length upgrades) 1) "" "s")))))
 
-(defun package-menu-execute ()
+(defun package-menu-execute (&optional dont-query)
   "Perform marked Package Menu actions.
 Packages marked for installation are downloaded and installed;
 packages marked for deletion are removed."
@@ -1611,26 +1611,30 @@
 		 (push (car id) install-list))))
 	(forward-line)))
     (when install-list
-      (if (yes-or-no-p
-	   (if (= (length install-list) 1)
-	       (format "Install package `%s'? " (car install-list))
-	     (format "Install these %d packages (%s)? "
-		     (length install-list)
-		     (mapconcat 'symbol-name install-list ", "))))
+      (if (or
+           dont-query
+           (yes-or-no-p
+            (if (= (length install-list) 1)
+                (format "Install package `%s'? " (car install-list))
+              (format "Install these %d packages (%s)? "
+                      (length install-list)
+                      (mapconcat 'symbol-name install-list ", ")))))
 	  (mapc 'package-install install-list)))
     ;; Delete packages, prompting if necessary.
     (when delete-list
-      (if (yes-or-no-p
-	   (if (= (length delete-list) 1)
-	       (format "Delete package `%s-%s'? "
-		       (caar delete-list)
-		       (cdr (car delete-list)))
-	     (format "Delete these %d packages (%s)? "
-		     (length delete-list)
-		     (mapconcat (lambda (elt)
-				  (concat (car elt) "-" (cdr elt)))
-				delete-list
-				", "))))
+      (if (or
+           dont-query
+           (yes-or-no-p
+            (if (= (length delete-list) 1)
+                (format "Delete package `%s-%s'? "
+                        (caar delete-list)
+                        (cdr (car delete-list)))
+              (format "Delete these %d packages (%s)? "
+                      (length delete-list)
+                      (mapconcat (lambda (elt)
+                                   (concat (car elt) "-" (cdr elt)))
+                                 delete-list
+                                 ", ")))))
 	  (dolist (elt delete-list)
 	    (condition-case-unless-debug err
 		(package-delete (car elt) (cdr elt))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWVO9iMYAAuR/gDD0FALb9//3
3iQAIP////BQBd5ytjWgaU0UAAQklNFMZR5TI2jTRPTKekxHqNAAABoBzAEYJiAYBME0ZDQwCYIx
MJTUaUYU2oPQhkAA0GCAGg0ABzAEYJiAYBME0ZDQwCYIxMJJATQIZMiaZMg01MmintU/SmATBPUb
KYFoE19fHbwg8lMd+/YHZy5U77T+j+S0OoYZvoxXqLHKhDnqQnnO4ezaIxfOghA5CPpX6BzLrmD8
xrBDMVlctQ76o4iyexYM11MkC+M4TRn0THKL1ogsivQIRdKUVq22ykLhaM9xLUQ5d91ncewQ6S6S
IzWKQImQyUiMmIFgfPSciX89uyMSmVF/huCIs4GAnIFOfsEtYesTNkTJZeGGSCWMxDmVJIQZDhKG
N8nTzcTJ5MyY3jCTF4564E7JPrKDGchSPxB9AOPMC9yZcNLFxOoZMNFk7pzPMJHqUW20z6OrEVh8
Y2ovCgWbzLEGjdM0SSL/Xe/HaPNtgMw94OEqiod0iC1kpRCL3Aq5kh47gTJPCQUMRbEw8LOJsLTV
AkyHgbVlpjbzUPfMOOliQSKJSjeGWibn4OqgJUC37i5cAiZG695aBWsUyP6ZzYBrsxIuyqF/EFo2
57ZdMalJsRHft/Zeec5SMPCsZC3RCIldqqTtLKwjIDXGEyEpjPM564I0naBE4GnM4ddYFtcbdF+E
dIyFpmOC8CpVvyYyLI2gQWOgxJxIhYDFjEwg8jrobddRBcNSRZVfa9zTtIWrGO9EAkwG7EeJS+kc
CC46JgV6bsSsD/weIPXeXl5cOQwsiOe6H2O2+RrqHYtqH1xkasohZUQHtcgvM5DiUSQ4gP3RdVIJ
7Km3Bu3WStTnFJMWwJ9cvgOUW76qp0ZoXoF9pPaEFTlMRXXJIffombK6eWvnoJVnQbY+5UZtY6Nj
ReF705wNJoKaJTZu9bT2PCm9mM0zchser9h2B+xTzETClzMwyVo+KWgPAUNrDGcVSYo6HCyU67jT
6z7/FgYatsBs37FxN5xEYTQ4qEY89YrzH4qKh/YUyVDyomwSeD0yguhzBax2GADzyie4+ALYSK9T
dfgNMD4BUBAonzTot0jKFOkcTZYMeevE5gWxYIvTwtAfDKUX8GXf4FvWSOOoPTsKA900aQqfbVo/
TaENS+Y+RX9gNH+etwYnT0PI7nnQk4kDIkBIaGjj6c84c5MehcbYNazrLRkX8zBa4nQ66gkNxfWi
Ghumvv4zRXXm1Ps8ay4jcKqCc0GjCShYoEwTqgiyZE7ar0otOGuHvHCOdw46gvSvR7CuRGYbeRyO
R7G8+fafH3DgU3HPuPVoK0PG0nevofE7jZ+DvAGPI6X/DtGGuSKMhjtcS9REA3hl7wbmL/rj7KJe
4cYJMV8AO4s7vxQ0sg81qEcBQNlx2IveKhTdpjiilA9yPFJeMCI+YZckyFrxRmYzHJg38RDwrRBw
VaoigOCCXvlrNaRWlix2TRRi0CTDl2CLDQlV5MKaoCw0GuyUFCwlFEQaAwTvN71GKHeYOeqgmpkD
aHv/seEqJhwyZkmXDiUDV9cj23JHyKVDIeru5UPr1FxcckOSyctUDgLdDMKj1OLM83sMG4mq8At3
/L0qlmKXo6zUM3spGd6bgOHg5DI63pWd9FLwuqSze+B8ouBmYYX3o7BwzCJ7nL0DMuwZWmxDFQYV
wFRkGsTpi+Acz87zIBxePXgMDUCgWgT7oHUE0qpjDIfoibAr8gcFedmk24l6K1FmYMcDUw9Vp+e1
G5d0QTV6C4uVJgeoTuLV9jNFpcrTMvCwIloeoFSREwWYyONZjMmMGoymcuaiO+qI/8XckU4UJBTv
YjGA
[Message part 2 (text/plain, inline)]
Attached is a bzr bundle for the modifications.

Regards
Yves 

This bug report was last modified 12 years and 187 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.