GNU bug report logs - #13625
24.1; Enable 'package-menu-execute being non-interactive

Previous Next

Package: emacs;

Reported by: Yves Baumes <ybaumes <at> gmail.com>

Date: Mon, 4 Feb 2013 00:20:02 UTC

Severity: normal

Found in version 24.1

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Yves Baumes <ybaumes <at> gmail.com>
Cc: 13625 <at> debbugs.gnu.org
Subject: bug#13625: 24.1; Enable 'package-menu-execute being non-interactive
Date: Mon, 04 Feb 2013 10:13:48 -0500
>> Better would be to move those questions to the `interactive' spec, so
>> you don't even need called-interactively-p.

> Ok. I've read the Emacs Lisp Reference manual. As you told, they say
> an alternative to `called-interactively-p' is possible with
> `interactive'. Note sure if I understand it all with this example:

> (defun test (&optional print-msg)
>   (interactive "p")
>   (if print-msg
>       (message "IS INTERACTIVE")
>     (message "IS *NOT* INTERACTIVE")))

That's one option: it doesn't move the questions to the interactive
spec, but it removes the use of called-interactively-p.

What I was suggesting was more like:

  (defun test ()
    (interactive
     (if (yes-or-no-p ...) ... ...)))

but I see that it's probably not applicable to package-menu-execute.
Maybe the best option here is to add an optional `dont-query' argument.


        Stefan




This bug report was last modified 12 years and 187 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.