From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Lawrence Mitchell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Feb 2013 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13623@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135992924120151 (code B ref -1); Sun, 03 Feb 2013 22:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Feb 2013 22:07:21 +0000 Received: from localhost ([127.0.0.1]:34637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U27ia-0005Ex-FA for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:07:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37189) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U27iX-0005Eq-JN for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:07:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U27hT-0005W2-5e for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:06:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:51554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hT-0005Vw-2D for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:06:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hR-0007Hi-TB for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U27hQ-0005VR-MI for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:09 -0500 Received: from nougat.ucs.ed.ac.uk ([129.215.13.205]:37510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hQ-0005Ux-Ds for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:08 -0500 Received: from lmtp1.ucs.ed.ac.uk (lmtp1.ucs.ed.ac.uk [129.215.149.64]) by nougat.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id r13M5ow3002141 for ; Sun, 3 Feb 2013 22:05:55 GMT Received: from e4300lm (cpc12-sgyl27-2-0-cust472.sgyl.cable.virginmedia.com [94.173.21.217]) (authenticated user=lmitche4 mech=PLAIN bits=0) by lmtp1.ucs.ed.ac.uk (8.13.8/8.13.7) with ESMTP id r13M5GCX011993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sun, 3 Feb 2013 22:05:40 GMT From: Lawrence Mitchell Date: Sun, 03 Feb 2013 22:05:15 +0000 Message-ID: <877gmp5a04.fsf@ed.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-Edinburgh-Scanned: at nougat.ucs.ed.ac.uk with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus X-Scanned-By: MIMEDefang 2.60 on 129.215.13.205 X-Scanned-By: MIMEDefang 2.52 on 129.215.149.64 X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) When using word or sexp marking commands, the active region does not always get highlighted. emacs -Q M-< M-@ # note how ";; This" is selected, and highlighted in region-face M-@ # ";; This buffer" is selected, however, " buffer" is not highlighted Pressing C-l at this point, correctly shows the highlighted region. This is with: commit e6762a6d2dc65d3201c03d5995686112483dc4ff Merge: 4ba48d0 6840160 Author: dancol@dancol.org <> Date: Sun Feb 3 09:02:56 2013 -0800 Daniel Colascione 2013-02-03 * emacs.c: Use execvp, not execv, when DAEMON_MUST_EXEC I'd previously updated and built on the 19th of January: commit c5a8149837c5ed53655d4383dea3b8f29374b266 Author: Glenn Morris Date: Sat Jan 19 18:40:49 2013 -0800 * lisp-mode.el (emacs-lisp-mode-map): Add native profiler menu entries. Which didn't demonstrate this behaviour, if that happens to help with tracking the issue down. Cheers, Lawrence In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2013-02-01 on e4300lm Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Ubuntu 12.04.1 LTS Configured using: `configure --prefix=/home/lmitche4/Apps/emacs -C CFLAGS=-O0 -ggdb --no-create --no-recursion' Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2013 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lawrence Mitchell , Dmitry Antipov Cc: 13623@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.13599930782470 (code B ref 13623); Mon, 04 Feb 2013 15:52:02 +0000 Received: (at 13623) by debbugs.gnu.org; 4 Feb 2013 15:51:18 +0000 Received: from localhost ([127.0.0.1]:36163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2OKE-0000dm-6j for submit@debbugs.gnu.org; Mon, 04 Feb 2013 10:51:18 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:62581) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2OKA-0000da-UW for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 10:51:16 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MHP00600DAG6Y00@a-mtaout22.012.net.il> for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 17:49:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHP0063DDAY5Y20@a-mtaout22.012.net.il>; Mon, 04 Feb 2013 17:49:46 +0200 (IST) Date: Mon, 04 Feb 2013 17:49:54 +0200 From: Eli Zaretskii In-reply-to: <877gmp5a04.fsf@ed.ac.uk> X-012-Sender: halo1@inter.net.il Message-id: <83vca89izh.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Lawrence Mitchell > Date: Sun, 03 Feb 2013 22:05:15 +0000 > > > When using word or sexp marking commands, the active region does not > always get highlighted. > > emacs -Q > M-< > M-@ # note how "; ; This" is selected, and highlighted in region-face > M-@ # "; ; This buffer" is selected, however, " buffer" is not highlighted > > Pressing C-l at this point, correctly shows the highlighted region. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4968] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > From: Lawrence Mitchell > Date: Sun, 03 Feb 2013 22:05:15 +0000 > > > When using word or sexp marking commands, the active region does not > always get highlighted. > > emacs -Q > M-< > M-@ # note how ";; This" is selected, and highlighted in region-face > M-@ # ";; This buffer" is selected, however, " buffer" is not highlighted > > Pressing C-l at this point, correctly shows the highlighted region. Thanks, should be fixed now (revision 111673 on the trunk). Dmitry, this bug and also 13626 were both caused by your changes in revision 111647. While the reason for the changes was to use non-Lisp objects for some fields, several hunks in the changeset had no relation whatsoever to that, and were highly questionable. Example: - /* If showing the region, and mark has changed, we must redisplay - the whole window. The assignment to this_line_start_pos prevents - the optimization directly below this if-statement. */ - if (((!NILP (Vtransient_mark_mode) - && !NILP (BVAR (XBUFFER (w->buffer), mark_active))) - != !NILP (w->region_showing)) - || (!NILP (w->region_showing) - && !EQ (w->region_showing, - Fmarker_position (BVAR (XBUFFER (w->buffer), mark))))) - CHARPOS (this_line_start_pos) = 0; I don't understand why such non-trivial code is being dropped on the floor without discussion. And there were others like this in this revision. Please don't assume that any dropped code that is really needed will cause bugs that will be immediately reported. I've seen display bugs that went unnoticed for months and even years. In this case, we were just lucky. From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode In-Reply-To: <877gmp5a04.fsf@ed.ac.uk> Resent-From: Lawrence Mitchell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2013 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13623@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135999850810559 (code B ref -1); Mon, 04 Feb 2013 17:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Feb 2013 17:21:48 +0000 Received: from localhost ([127.0.0.1]:36247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2Pjm-0002kE-G4 for submit@debbugs.gnu.org; Mon, 04 Feb 2013 12:21:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51555) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2Pjj-0002k5-KY for submit@debbugs.gnu.org; Mon, 04 Feb 2013 12:21:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2Pie-0007nf-Ns for submit@debbugs.gnu.org; Mon, 04 Feb 2013 12:20:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2Pie-0007nb-Kj for submit@debbugs.gnu.org; Mon, 04 Feb 2013 12:20:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2Pid-000368-Pu for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 12:20:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2Pic-0007mn-Hz for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 12:20:35 -0500 Received: from plane.gmane.org ([80.91.229.3]:49756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2Pic-0007mF-C9 for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 12:20:34 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1U2Pit-0006qW-8E for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 18:20:51 +0100 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Feb 2013 18:20:51 +0100 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Feb 2013 18:20:51 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: Lawrence Mitchell Date: Mon, 04 Feb 2013 17:20:21 +0000 Lines: 15 Message-ID: <87obg0xaga.fsf@gmx.li> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:A9ZXAEu/Tk5bhAY6yRrpRjmxUWQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Eli Zaretskii wrote: >> From: Lawrence Mitchell >> Date: Sun, 03 Feb 2013 22:05:15 +0000 >> Pressing C-l at this point, correctly shows the highlighted region. > Thanks, should be fixed now (revision 111673 on the trunk). [...] Yes, works for me. Cheers, Lawrence -- Lawrence Mitchell From unknown Sat Sep 13 11:13:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Lawrence Mitchell Subject: bug#13623: closed (Re: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode) Message-ID: References: <83lib49cgg.fsf@gnu.org> <877gmp5a04.fsf@ed.ac.uk> X-Gnu-PR-Message: they-closed 13623 X-Gnu-PR-Package: emacs Reply-To: 13623@debbugs.gnu.org Date: Mon, 04 Feb 2013 18:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1360001582-15165-1" This is a multi-part message in MIME format... ------------=_1360001582-15165-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13623: 24.3.50; Redisplay issue with transient-mark-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13623@debbugs.gnu.org. --=20 13623: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13623 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1360001582-15165-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13623-done) by debbugs.gnu.org; 4 Feb 2013 18:12:48 +0000 Received: from localhost ([127.0.0.1]:36304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2QXA-0003wC-I9 for submit@debbugs.gnu.org; Mon, 04 Feb 2013 13:12:48 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:44936) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2QX8-0003w5-NG for 13623-done@debbugs.gnu.org; Mon, 04 Feb 2013 13:12:47 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MHP00500JQSLA00@a-mtaout23.012.net.il> for 13623-done@debbugs.gnu.org; Mon, 04 Feb 2013 20:10:47 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHP00589JTYENA0@a-mtaout23.012.net.il>; Mon, 04 Feb 2013 20:10:47 +0200 (IST) Date: Mon, 04 Feb 2013 20:10:55 +0200 From: Eli Zaretskii Subject: Re: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode In-reply-to: <87obg0xaga.fsf@gmx.li> X-012-Sender: halo1@inter.net.il To: Lawrence Mitchell Message-id: <83lib49cgg.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <87obg0xaga.fsf@gmx.li> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 13623-done Cc: 13623-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Lawrence Mitchell > Date: Mon, 04 Feb 2013 17:20:21 +0000 > > Eli Zaretskii wrote: > >> From: Lawrence Mitchell > >> Date: Sun, 03 Feb 2013 22:05:15 +0000 > >> Pressing C-l at this point, correctly shows the highlighted region. > > > Thanks, should be fixed now (revision 111673 on the trunk). > > [...] > > Yes, works for me. Thanks, closing. ------------=_1360001582-15165-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Feb 2013 22:07:21 +0000 Received: from localhost ([127.0.0.1]:34637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U27ia-0005Ex-FA for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:07:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37189) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U27iX-0005Eq-JN for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:07:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U27hT-0005W2-5e for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:06:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:51554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hT-0005Vw-2D for submit@debbugs.gnu.org; Sun, 03 Feb 2013 17:06:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hR-0007Hi-TB for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U27hQ-0005VR-MI for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:09 -0500 Received: from nougat.ucs.ed.ac.uk ([129.215.13.205]:37510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U27hQ-0005Ux-Ds for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 17:06:08 -0500 Received: from lmtp1.ucs.ed.ac.uk (lmtp1.ucs.ed.ac.uk [129.215.149.64]) by nougat.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id r13M5ow3002141 for ; Sun, 3 Feb 2013 22:05:55 GMT Received: from e4300lm (cpc12-sgyl27-2-0-cust472.sgyl.cable.virginmedia.com [94.173.21.217]) (authenticated user=lmitche4 mech=PLAIN bits=0) by lmtp1.ucs.ed.ac.uk (8.13.8/8.13.7) with ESMTP id r13M5GCX011993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sun, 3 Feb 2013 22:05:40 GMT From: Lawrence Mitchell To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Redisplay issue with transient-mark-mode Date: Sun, 03 Feb 2013 22:05:15 +0000 Message-ID: <877gmp5a04.fsf@ed.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-Edinburgh-Scanned: at nougat.ucs.ed.ac.uk with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus X-Scanned-By: MIMEDefang 2.60 on 129.215.13.205 X-Scanned-By: MIMEDefang 2.52 on 129.215.149.64 X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) When using word or sexp marking commands, the active region does not always get highlighted. emacs -Q M-< M-@ # note how ";; This" is selected, and highlighted in region-face M-@ # ";; This buffer" is selected, however, " buffer" is not highlighted Pressing C-l at this point, correctly shows the highlighted region. This is with: commit e6762a6d2dc65d3201c03d5995686112483dc4ff Merge: 4ba48d0 6840160 Author: dancol@dancol.org <> Date: Sun Feb 3 09:02:56 2013 -0800 Daniel Colascione 2013-02-03 * emacs.c: Use execvp, not execv, when DAEMON_MUST_EXEC I'd previously updated and built on the 19th of January: commit c5a8149837c5ed53655d4383dea3b8f29374b266 Author: Glenn Morris Date: Sat Jan 19 18:40:49 2013 -0800 * lisp-mode.el (emacs-lisp-mode-map): Add native profiler menu entries. Which didn't demonstrate this behaviour, if that happens to help with tracking the issue down. Cheers, Lawrence In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2013-02-01 on e4300lm Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Ubuntu 12.04.1 LTS Configured using: `configure --prefix=/home/lmitche4/Apps/emacs -C CFLAGS=-O0 -ggdb --no-create --no-recursion' Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t ------------=_1360001582-15165-1-- From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Lawrence Mitchell , 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136004012214277 (code B ref 13623); Tue, 05 Feb 2013 04:56:01 +0000 Received: (at 13623) by debbugs.gnu.org; 5 Feb 2013 04:55:22 +0000 Received: from localhost ([127.0.0.1]:36686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2aYz-0003iE-I7 for submit@debbugs.gnu.org; Mon, 04 Feb 2013 23:55:22 -0500 Received: from forward19.mail.yandex.net ([95.108.253.144]:56946) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2aYu-0003i3-Th for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 23:55:19 -0500 Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [95.108.252.17]) by forward19.mail.yandex.net (Yandex) with ESMTP id BA9D41120A5D; Tue, 5 Feb 2013 08:54:06 +0400 (MSK) Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id 7A0CD1900214; Tue, 5 Feb 2013 08:54:06 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTP id s5f4UcLY-s6fStDjY; Tue, 5 Feb 2013 08:54:06 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1360040046; bh=jHb9Jzjf7Y2H/rjaHXJRFHLKx6GgTVimBoWL0tHdM44=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Dgg5W0TiiMHNsyNV5KUENtYok8RLT/uBUQVQ14GjFkWi25zBEgJdgvlCRj0aSuSqw s8XpwnhqY+1hsCyU7WjRp9u4FiALb1mGyGT9IQS16WneFJIhCCz3SjJuloEmpAFobz W+0LTfqoX9lZQuqGCZC8PlgJXi94NnWJauYQPu3o= Message-ID: <5110906D.7020406@yandex.ru> Date: Tue, 05 Feb 2013 08:54:05 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> In-Reply-To: <83vca89izh.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On 02/04/2013 07:49 PM, Eli Zaretskii wrote: > Dmitry, this bug and also 13626 were both caused by your changes in > revision 111647. While the reason for the changes was to use non-Lisp > objects for some fields, several hunks in the changeset had no > relation whatsoever to that, and were highly questionable. Example: > > - /* If showing the region, and mark has changed, we must redisplay > - the whole window. The assignment to this_line_start_pos prevents > - the optimization directly below this if-statement. */ > - if (((!NILP (Vtransient_mark_mode) > - && !NILP (BVAR (XBUFFER (w->buffer), mark_active))) > - != !NILP (w->region_showing)) > - || (!NILP (w->region_showing) > - && !EQ (w->region_showing, > - Fmarker_position (BVAR (XBUFFER (w->buffer), mark))))) > - CHARPOS (this_line_start_pos) = 0; Hm. Although this is an obvious bug, are you sure that we must redisplay the whole window even if the region doesn't span multiple lines? IIUC it should be enough to redisplay the current line only. Dmitry From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Lawrence Mitchell , 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136006614921620 (code B ref 13623); Tue, 05 Feb 2013 12:10:02 +0000 Received: (at 13623) by debbugs.gnu.org; 5 Feb 2013 12:09:09 +0000 Received: from localhost ([127.0.0.1]:37277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2hKm-0005ce-SX for submit@debbugs.gnu.org; Tue, 05 Feb 2013 07:09:09 -0500 Received: from forward10.mail.yandex.net ([77.88.61.49]:33828) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2hKg-0005cE-KQ for 13623@debbugs.gnu.org; Tue, 05 Feb 2013 07:09:06 -0500 Received: from smtp9.mail.yandex.net (smtp9.mail.yandex.net [77.88.61.35]) by forward10.mail.yandex.net (Yandex) with ESMTP id BC3781021FE5; Tue, 5 Feb 2013 16:07:48 +0400 (MSK) Received: from smtp9.mail.yandex.net (localhost [127.0.0.1]) by smtp9.mail.yandex.net (Yandex) with ESMTP id 6A3F41520782; Tue, 5 Feb 2013 16:07:48 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp9.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 7lUasVUN-7mU0mldR; Tue, 5 Feb 2013 16:07:48 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1360066068; bh=Zgd4Dq8MgBPq20t7uz/C0/yeyLVzkGtudtXGwmDSWbE=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=MCz5V8TCHOxfYCWYo34W5TCnND5NW9EK2QdAjz5qPhIazeCi4RGIbjQ6xCQldYfcE BPafypKBFSkkbOMdhpKc44ZfEIsWk0mr56I0bed9oVbnLNpi9T64VWceH6djRs0TyE dQE+IW7JgWnGxyEj4eYEzcVMJjr1udkUj/RKmM7E= Message-ID: <5110F613.5000206@yandex.ru> Date: Tue, 05 Feb 2013 16:07:47 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> In-Reply-To: <5110906D.7020406@yandex.ru> Content-Type: multipart/mixed; boundary="------------070007070103020808080900" X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------070007070103020808080900 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/05/2013 08:54 AM, Dmitry Antipov wrote: > Hm. Although this is an obvious bug, are you sure that we must redisplay > the whole window even if the region doesn't span multiple lines? IIUC > it should be enough to redisplay the current line only. E.g. something like attached. This is the revert of 111673 plus special treatment of single-line region. Dmitry --------------070007070103020808080900 Content-Type: text/plain; charset=UTF-8; name="single_line_region.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="single_line_region.patch" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy93aW5kb3cuaCcKLS0tIHNyYy93aW5kb3cuaAkyMDEz LTAyLTA0IDE1OjM5OjU1ICswMDAwCisrKyBzcmMvd2luZG93LmgJMjAxMy0wMi0wNSAwOTo1 ODozNiArMDAwMApAQCAtMzMzLDE1ICszMzMsMTMgQEAKICAgICAgICB0aGUgZnJhbWUgaW1h Z2UgdGhhdCB3aW5kb3dfZW5kX3BvcyBkaWQgbm90IGdldCBvbnRvIHRoZSBmcmFtZS4gICov CiAgICAgdW5zaWduZWQgd2luZG93X2VuZF92YWxpZCA6IDE7CiAKKyAgICAvKiBOb256ZXJv IGlmIHdlIGhhdmUgaGlnaGxpZ2h0ZWQgdGhlIHJlZ2lvbiAob3IgYW55IHBhcnQgb2YgaXQp LiAgKi8KKyAgICB1bnNpZ25lZCByZWdpb25fc2hvd2luZyA6IDE7CisKICAgICAvKiBBbW91 bnQgYnkgd2hpY2ggbGluZXMgb2YgdGhpcyB3aW5kb3cgYXJlIHNjcm9sbGVkIGluCiAgICAg ICAgeS1kaXJlY3Rpb24gKHNtb290aCBzY3JvbGxpbmcpLiAgKi8KICAgICBpbnQgdnNjcm9s bDsKIAotICAgIC8qIElmIHdlIGhhdmUgaGlnaGxpZ2h0ZWQgdGhlIHJlZ2lvbiAob3IgYW55 IHBhcnQgb2YgaXQpLCB0aGUgbWFyawotICAgICAgIHBvc2l0aW9uIG9yIC0xICh0aGUgbGF0 dGVyIGlzIHVzZWQgYnkgdGhlIGl0ZXJhdG9yIGZvciBpbnRlcm5hbAotICAgICAgIHB1cnBv c2VzKTsgb3RoZXJ3aXNlIHplcm8uICAqLwotICAgIHB0cmRpZmZfdCByZWdpb25fc2hvd2lu ZzsKLQogICAgIC8qIFpfQllURSAtIGJ1ZmZlciBwb3NpdGlvbiBvZiB0aGUgbGFzdCBnbHlw aCBpbiB0aGUgY3VycmVudCBtYXRyaXggb2YgVy4KICAgICAgICBTaG91bGQgYmUgbm9ubmVn YXRpdmUsIGFuZCBvbmx5IHZhbGlkIGlmIHdpbmRvd19lbmRfdmFsaWQgaXMgbm9uemVyby4g ICovCiAgICAgcHRyZGlmZl90IHdpbmRvd19lbmRfYnl0ZXBvczsKCj09PSBtb2RpZmllZCBm aWxlICdzcmMveGRpc3AuYycKLS0tIHNyYy94ZGlzcC5jCTIwMTMtMDItMDQgMTU6Mzk6NTUg KzAwMDAKKysrIHNyYy94ZGlzcC5jCTIwMTMtMDItMDUgMTE6NTk6MDEgKzAwMDAKQEAgLTI1 MzYsOCArMjUzNiw4IEBACiAKICNlbmRpZiAvKiBHTFlQSF9ERUJVRyBhbmQgRU5BQkxFX0NI RUNLSU5HICovCiAKLS8qIFJldHVybiBtYXJrIHBvc2l0aW9uIGlmIGN1cnJlbnQgYnVmZmVy IGhhcyB0aGUgcmVnaW9uIG9mIG5vbi16ZXJvIGxlbmd0aCwKLSAgIG9yIC0xIG90aGVyd2lz ZS4gICovCisvKiBSZXR1cm4gbWFyayBwb3NpdGlvbiBpZiBjdXJyZW50IGJ1ZmZlciBoYXMg dGhlIHJlZ2lvbiBvZiBub24temVybworICAgbGVuZ3RoLCB6ZXJvIGlmIG1hcmsgYW5kIHBv aW50IGFyZSB0aGUgc2FtZSwgb3IgLTEgb3RoZXJ3aXNlLiAgKi8KIAogc3RhdGljIHB0cmRp ZmZfdAogbWFya3Bvc19vZl9yZWdpb24gKHZvaWQpCkBAIC0yNTQ3LDkgKzI1NDcsNyBAQAog ICAgICAgJiYgWE1BUktFUiAoQlZBUiAoY3VycmVudF9idWZmZXIsIG1hcmspKS0+YnVmZmVy ICE9IE5VTEwpCiAgICAgewogICAgICAgcHRyZGlmZl90IG1hcmtwb3MgPSBYTUFSS0VSIChC VkFSIChjdXJyZW50X2J1ZmZlciwgbWFyaykpLT5jaGFycG9zOwotCi0gICAgICBpZiAobWFy a3BvcyAhPSBQVCkKLQlyZXR1cm4gbWFya3BvczsKKyAgICAgIHJldHVybiBtYXJrcG9zID09 IFBUID8gMCA6IG1hcmtwb3M7CiAgICAgfQogICByZXR1cm4gLTE7CiB9CkBAIC0yNjg5LDcg KzI2ODcsNyBAQAogICAgICBhbmQgSVQtPnJlZ2lvbl9lbmRfY2hhcnBvcyB0byB0aGUgc3Rh cnQgYW5kIGVuZCBvZiBhIHZpc2libGUgcmVnaW9uCiAgICAgIGluIHdpbmRvdyBJVC0+dy4g IFNldCBib3RoIHRvIC0xIHRvIGluZGljYXRlIG5vIHJlZ2lvbi4gICovCiAgIG1hcmtwb3Mg PSBtYXJrcG9zX29mX3JlZ2lvbiAoKTsKLSAgaWYgKDAgPD0gbWFya3BvcworICBpZiAoMCA8 IG1hcmtwb3MKICAgICAgIC8qIE1heWJlIGhpZ2hsaWdodCBvbmx5IGluIHNlbGVjdGVkIHdp bmRvdy4gICovCiAgICAgICAmJiAoLyogRWl0aGVyIHNob3cgcmVnaW9uIGV2ZXJ5d2hlcmUu ICAqLwogCSAgaGlnaGxpZ2h0X25vbnNlbGVjdGVkX3dpbmRvd3MKQEAgLTEwNzUzLDcgKzEw NzUxLDcgQEAKIAogICByZXR1cm4gKCgoQlVGX1NBVkVfTU9ESUZGIChiKSA8IEJVRl9NT0RJ RkYgKGIpKSAhPSB3LT5sYXN0X2hhZF9zdGFyKQogCSAgfHwgKCghTklMUCAoVnRyYW5zaWVu dF9tYXJrX21vZGUpICYmICFOSUxQIChCVkFSIChiLCBtYXJrX2FjdGl2ZSkpKQotCSAgICAg ICE9ICh3LT5yZWdpb25fc2hvd2luZyAhPSAwKSkpOworCSAgICAgICE9IHctPnJlZ2lvbl9z aG93aW5nKSk7CiB9CiAKIC8qIE5vbnplcm8gaWYgVyBoYXMgJWMgaW4gaXRzIG1vZGUgbGlu ZSBhbmQgbW9kZSBsaW5lIHNob3VsZCBiZSB1cGRhdGVkLiAgKi8KQEAgLTEyNzkzLDcgKzEy NzkxLDcgQEAKICAgaW50IG11c3RfZmluaXNoID0gMDsKICAgc3RydWN0IHRleHRfcG9zIHRs YnVmcG9zLCB0bGVuZHBvczsKICAgaW50IG51bWJlcl9vZl92aXNpYmxlX2ZyYW1lczsKLSAg cHRyZGlmZl90IGNvdW50LCBjb3VudDE7CisgIHB0cmRpZmZfdCBwb3MsIGNvdW50LCBjb3Vu dDE7CiAgIHN0cnVjdCBmcmFtZSAqc2Y7CiAgIGludCBwb2xsaW5nX3N0b3BwZWRfaGVyZSA9 IDA7CiAgIExpc3BfT2JqZWN0IHRhaWwsIGZyYW1lOwpAQCAtMTI4MDYsNiArMTI4MDQsOSBA QAogICAvKiBOb24temVybyBtZWFucyByZWRpc3BsYXkgaGFzIHRvIHJlZGlzcGxheSB0aGUg bWluaXdpbmRvdy4gICovCiAgIGludCB1cGRhdGVfbWluaXdpbmRvd19wID0gMDsKIAorICAv KiBOb24temVybyBtZWFucyB0aGUgbWFyayBpcyBvbiB0aGUgc2FtZSBsaW5lIGFzIHBvaW50 LiAgKi8KKyAgYm9vbCBtYXJrX2F0X3RoaXNfbGluZSA9IDA7CisKICAgVFJBQ0UgKChzdGRl cnIsICJyZWRpc3BsYXlfaW50ZXJuYWwgJWRcbiIsIHJlZGlzcGxheWluZ19wKSk7CiAKICAg LyogTm8gcmVkaXNwbGF5IGlmIHJ1bm5pbmcgaW4gYmF0Y2ggbW9kZSBvciBmcmFtZSBpcyBu b3QgeWV0IGZ1bGx5CkBAIC0xMzAxNiwyMyArMTMwMTcsMTcgQEAKICAgICAgIGNsZWFyX2dh cmJhZ2VkX2ZyYW1lcyAoKTsKICAgICB9CiAKLSAgLyogSWYgc2hvd2luZyB0aGUgcmVnaW9u LCBhbmQgbWFyayBoYXMgY2hhbmdlZCwgd2UgbXVzdCByZWRpc3BsYXkKLSAgICAgdGhlIHdo b2xlIHdpbmRvdy4gIFRoZSBhc3NpZ25tZW50IHRvIHRoaXNfbGluZV9zdGFydF9wb3MgcHJl dmVudHMKLSAgICAgdGhlIG9wdGltaXphdGlvbiBkaXJlY3RseSBiZWxvdyB0aGlzIGlmLXN0 YXRlbWVudC4gICovCi0gIGlmICgoKCFOSUxQIChWdHJhbnNpZW50X21hcmtfbW9kZSkKLQkm JiAhTklMUCAoQlZBUiAoWEJVRkZFUiAody0+YnVmZmVyKSwgbWFya19hY3RpdmUpKSkKLSAg ICAgICAhPSAody0+cmVnaW9uX3Nob3dpbmcgPiAwKSkKLSAgICAgIHx8ICh3LT5yZWdpb25f c2hvd2luZwotCSAgJiYgdy0+cmVnaW9uX3Nob3dpbmcKLQkgICE9IFhJTlQgKEZtYXJrZXJf cG9zaXRpb24gKEJWQVIgKFhCVUZGRVIgKHctPmJ1ZmZlciksIG1hcmspKSkpKQotICAgIENI QVJQT1MgKHRoaXNfbGluZV9zdGFydF9wb3MpID0gMDsKLQogICAvKiBPcHRpbWl6ZSB0aGUg Y2FzZSB0aGF0IG9ubHkgdGhlIGxpbmUgY29udGFpbmluZyB0aGUgY3Vyc29yIGluIHRoZQog ICAgICBzZWxlY3RlZCB3aW5kb3cgaGFzIGNoYW5nZWQuICBWYXJpYWJsZXMgc3RhcnRpbmcg d2l0aCB0aGlzXyBhcmUKICAgICAgc2V0IGluIGRpc3BsYXlfbGluZSBhbmQgcmVjb3JkIGlu Zm9ybWF0aW9uIGFib3V0IHRoZSBsaW5lCiAgICAgIGNvbnRhaW5pbmcgdGhlIGN1cnNvci4g ICovCiAgIHRsYnVmcG9zID0gdGhpc19saW5lX3N0YXJ0X3BvczsKICAgdGxlbmRwb3MgPSB0 aGlzX2xpbmVfZW5kX3BvczsKKyAgcG9zID0gbWFya3Bvc19vZl9yZWdpb24gKCk7CisgIGlm IChwb3MgIT0gLTEpCisgICAgbWFya19hdF90aGlzX2xpbmUgPSAoQ0hBUlBPUyAodGxidWZw b3MpIDw9IHBvcworCQkJICYmIHBvcyA8PSBaIC0gQ0hBUlBPUyAodGxlbmRwb3MpKTsKKwog ICBpZiAoIWNvbnNpZGVyX2FsbF93aW5kb3dzX3AKICAgICAgICYmIENIQVJQT1MgKHRsYnVm cG9zKSA+IDAKICAgICAgICYmICF3LT51cGRhdGVfbW9kZV9saW5lCkBAIC0xMzA0OCw2ICsx MzA0Myw4IEBACiAgICAgICAvKiBQb2ludCBtdXN0IGJlIG9uIHRoZSBsaW5lIHRoYXQgd2Ug aGF2ZSBpbmZvIHJlY29yZGVkIGFib3V0LiAgKi8KICAgICAgICYmIFBUID49IENIQVJQT1Mg KHRsYnVmcG9zKQogICAgICAgJiYgUFQgPD0gWiAtIENIQVJQT1MgKHRsZW5kcG9zKQorICAg ICAgLyogTm8gcmVnaW9uIG9yIHJlZ2lvbiB3aGljaCBkb2Vzbid0IHNwYW4gbXVsdGlwbGUg bGluZXMuICAqLworICAgICAgJiYgKHBvcyA9PSAtMSB8fCBtYXJrX2F0X3RoaXNfbGluZSkK ICAgICAgIC8qIEFsbCB0ZXh0IG91dHNpZGUgdGhhdCBsaW5lLCBpbmNsdWRpbmcgaXRzIGZp bmFsIG5ld2xpbmUsCiAJIG11c3QgYmUgdW5jaGFuZ2VkLiAgKi8KICAgICAgICYmIHRleHRf b3V0c2lkZV9saW5lX3VuY2hhbmdlZF9wICh3LCBDSEFSUE9TICh0bGJ1ZnBvcyksCkBAIC0x MzA1OSw3ICsxMzA1Niw3IEBACiAJICAgICAgfHwgRkVUQ0hfQllURSAoQllURVBPUyAodGxi dWZwb3MpKSA9PSAnXG4nKSkKIAkvKiBGb3JtZXIgY29udGludWF0aW9uIGxpbmUgaGFzIGRp c2FwcGVhcmVkIGJ5IGJlY29taW5nIGVtcHR5LiAgKi8KIAlnb3RvIGNhbmNlbDsKLSAgICAg IGVsc2UgaWYgKHdpbmRvd19vdXRkYXRlZCAodykgfHwgTUlOSV9XSU5ET1dfUCAodykpCisg ICAgICBlbHNlIGlmICh3aW5kb3dfb3V0ZGF0ZWQgKHcpIHx8IE1JTklfV0lORE9XX1AgKHcp IHx8IG1hcmtfYXRfdGhpc19saW5lKQogCXsKIAkgIC8qIFdlIGhhdmUgdG8gaGFuZGxlIHRo ZSBjYXNlIG9mIGNvbnRpbnVhdGlvbiBhcm91bmQgYQogCSAgICAgd2lkZS1jb2x1bW4gY2hh cmFjdGVyIChzZWUgdGhlIGNvbW1lbnQgaW4gaW5kZW50LmMgYXJvdW5kCkBAIC0xMzIzOSw4 ICsxMzIzNiw2IEBACiAgICsrY2xlYXJfaW1hZ2VfY2FjaGVfY291bnQ7CiAjZW5kaWYKIAot ICB3LT5yZWdpb25fc2hvd2luZyA9IFhJTlQgKEZtYXJrZXJfcG9zaXRpb24gKEJWQVIgKFhC VUZGRVIgKHctPmJ1ZmZlciksIG1hcmspKSk7Ci0KICAgLyogQnVpbGQgZGVzaXJlZCBtYXRy aWNlcywgYW5kIHVwZGF0ZSB0aGUgZGlzcGxheS4gIElmCiAgICAgIGNvbnNpZGVyX2FsbF93 aW5kb3dzX3AgaXMgbm9uLXplcm8sIGRvIGl0IGZvciBhbGwgd2luZG93cyBvbiBhbGwKICAg ICAgZnJhbWVzLiAgT3RoZXJ3aXNlIGRvIGl0IGZvciBzZWxlY3RlZF93aW5kb3csIG9ubHku ICAqLwpAQCAtMTQ4MzcsNyArMTQ4MzIsNyBAQAogICAgICAgLyogQ2FuJ3QgdXNlIHRoaXMg Y2FzZSBpZiBoaWdobGlnaHRpbmcgYSByZWdpb24uICBXaGVuIGEKICAgICAgICAgIHJlZ2lv biBleGlzdHMsIGN1cnNvciBtb3ZlbWVudCBoYXMgdG8gZG8gbW9yZSB0aGFuIGp1c3QKICAg ICAgICAgIHNldCB0aGUgY3Vyc29yLiAgKi8KLSAgICAgICYmIG1hcmtwb3Nfb2ZfcmVnaW9u ICgpIDwgMAorICAgICAgJiYgbWFya3Bvc19vZl9yZWdpb24gKCkgPD0gMAogICAgICAgJiYg IXctPnJlZ2lvbl9zaG93aW5nCiAgICAgICAmJiBOSUxQIChWc2hvd190cmFpbGluZ193aGl0 ZXNwYWNlKQogICAgICAgLyogVGhpcyBjb2RlIGlzIG5vdCB1c2VkIGZvciBtaW5pLWJ1ZmZl ciBmb3IgdGhlIHNha2Ugb2YgdGhlIGNhc2UKQEAgLTE1NTA1LDcgKzE1NTAwLDcgQEAKIAog CSAgLyogSWYgd2UgYXJlIGhpZ2hsaWdodGluZyB0aGUgcmVnaW9uLCB0aGVuIHdlIGp1c3Qg Y2hhbmdlZAogCSAgICAgdGhlIHJlZ2lvbiwgc28gcmVkaXNwbGF5IHRvIHNob3cgaXQuICAq LwotCSAgaWYgKDAgPD0gbWFya3Bvc19vZl9yZWdpb24gKCkpCisJICBpZiAoMCA8IG1hcmtw b3Nfb2ZfcmVnaW9uICgpKQogCSAgICB7CiAJICAgICAgY2xlYXJfZ2x5cGhfbWF0cml4ICh3 LT5kZXNpcmVkX21hdHJpeCk7CiAJICAgICAgaWYgKCF0cnlfd2luZG93ICh3aW5kb3csIHN0 YXJ0cCwgMCkpCkBAIC0xNjIwNiw3ICsxNjIwMSw3IEBACiAgICAgcmV0dXJuIDA7CiAKICAg LyogQ2FuJ3QgZG8gdGhpcyBpZiByZWdpb24gbWF5IGhhdmUgY2hhbmdlZC4gICovCi0gIGlm ICgwIDw9IG1hcmtwb3Nfb2ZfcmVnaW9uICgpCisgIGlmICgwIDwgbWFya3Bvc19vZl9yZWdp b24gKCkKICAgICAgIHx8IHctPnJlZ2lvbl9zaG93aW5nCiAgICAgICB8fCAhTklMUCAoVnNo b3dfdHJhaWxpbmdfd2hpdGVzcGFjZSkpCiAgICAgcmV0dXJuIDA7CkBAIC0xNzAzOCw3ICsx NzAzMyw3IEBACiAKICAgLyogQ2FuJ3QgdXNlIHRoaXMgaWYgaGlnaGxpZ2h0aW5nIGEgcmVn aW9uIGJlY2F1c2UgYSBjdXJzb3IgbW92ZW1lbnQKICAgICAgd2lsbCBkbyBtb3JlIHRoYW4g anVzdCBzZXQgdGhlIGN1cnNvci4gICovCi0gIGlmICgwIDw9IG1hcmtwb3Nfb2ZfcmVnaW9u ICgpKQorICBpZiAoMCA8IG1hcmtwb3Nfb2ZfcmVnaW9uICgpKQogICAgIEdJVkVfVVAgKDkp OwogCiAgIC8qIExpa2V3aXNlIGlmIGhpZ2hsaWdodGluZyB0cmFpbGluZyB3aGl0ZXNwYWNl LiAgKi8KQEAgLTE5MTMzLDcgKzE5MTI4LDcgQEAKICAgICB9CiAKICAgLyogSXMgSVQtPncg c2hvd2luZyB0aGUgcmVnaW9uPyAgKi8KLSAgaXQtPnctPnJlZ2lvbl9zaG93aW5nID0gaXQt PnJlZ2lvbl9iZWdfY2hhcnBvcyA+IDAgPyAtMSA6IDA7CisgIGl0LT53LT5yZWdpb25fc2hv d2luZyA9IGl0LT5yZWdpb25fYmVnX2NoYXJwb3MgPiAwOwogCiAgIC8qIENsZWFyIHRoZSBy ZXN1bHQgZ2x5cGggcm93IGFuZCBlbmFibGUgaXQuICAqLwogICBwcmVwYXJlX2Rlc2lyZWRf cm93IChyb3cpOwoK --------------070007070103020808080900-- From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: wence@gmx.li, 13623@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136008642727586 (code B ref 13623); Tue, 05 Feb 2013 17:48:01 +0000 Received: (at 13623) by debbugs.gnu.org; 5 Feb 2013 17:47:07 +0000 Received: from localhost ([127.0.0.1]:38192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2mbq-0007At-Ln for submit@debbugs.gnu.org; Tue, 05 Feb 2013 12:47:06 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:47496) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2mbn-0007Ai-Qw for 13623@debbugs.gnu.org; Tue, 05 Feb 2013 12:47:05 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MHR00000D7LE900@a-mtaout22.012.net.il> for 13623@debbugs.gnu.org; Tue, 05 Feb 2013 19:45:31 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHR00NI7DBU29C0@a-mtaout22.012.net.il>; Tue, 05 Feb 2013 19:45:31 +0200 (IST) Date: Tue, 05 Feb 2013 19:45:42 +0200 From: Eli Zaretskii In-reply-to: <5110906D.7020406@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83fw1aac3d.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Tue, 05 Feb 2013 08:54:05 +0400 > From: Dmitry Antipov > CC: Lawrence Mitchell , 13623@debbugs.gnu.org > > > - /* If showing the region, and mark has changed, we must redisplay > > - the whole window. The assignment to this_line_start_pos prevents > > - the optimization directly below this if-statement. */ > > - if (((!NILP (Vtransient_mark_mode) > > - && !NILP (BVAR (XBUFFER (w->buffer), mark_active))) > > - != !NILP (w->region_showing)) > > - || (!NILP (w->region_showing) > > - && !EQ (w->region_showing, > > - Fmarker_position (BVAR (XBUFFER (w->buffer), mark))))) > > - CHARPOS (this_line_start_pos) = 0; > > Hm. Although this is an obvious bug, are you sure that we must redisplay > the whole window even if the region doesn't span multiple lines? IIUC > it should be enough to redisplay the current line only. As long as we don't restrict the 'region' face to a very small subset of possible face customizations (e.g., just the background and the foreground colors), and ignore the other attributes, an arbitrary face change on one line might potentially affect many more lines in the window. E.g., try customizing the 'region' face to twice its normal height. And I'm not sure this is worth optimizing anyway: region changes are relatively rare and almost always driven by user input, so I don't think redisplay will become significantly faster as result of any optimizations in this area. From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: wence@gmx.li, 13623@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136008648227701 (code B ref 13623); Tue, 05 Feb 2013 17:49:01 +0000 Received: (at 13623) by debbugs.gnu.org; 5 Feb 2013 17:48:02 +0000 Received: from localhost ([127.0.0.1]:38196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2mck-0007CY-1t for submit@debbugs.gnu.org; Tue, 05 Feb 2013 12:48:02 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:52819) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2mch-0007CE-OW for 13623@debbugs.gnu.org; Tue, 05 Feb 2013 12:48:00 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MHR00D00CX67Q00@a-mtaout23.012.net.il> for 13623@debbugs.gnu.org; Tue, 05 Feb 2013 19:46:27 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHR00DOVDDE1BA0@a-mtaout23.012.net.il>; Tue, 05 Feb 2013 19:46:27 +0200 (IST) Date: Tue, 05 Feb 2013 19:46:38 +0200 From: Eli Zaretskii In-reply-to: <5110F613.5000206@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83ehguac1t.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <5110F613.5000206@yandex.ru> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Tue, 05 Feb 2013 16:07:47 +0400 > From: Dmitry Antipov > CC: Lawrence Mitchell , 13623@debbugs.gnu.org > > > Hm. Although this is an obvious bug, are you sure that we must redisplay > > the whole window even if the region doesn't span multiple lines? IIUC > > it should be enough to redisplay the current line only. > > E.g. something like attached. This is the revert of 111673 plus special > treatment of single-line region. If you customize the font of 'region' face, you will see that additional lines are affected anyway. From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: wence@gmx.li, 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136013509111540 (code B ref 13623); Wed, 06 Feb 2013 07:19:02 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 07:18:11 +0000 Received: from localhost ([127.0.0.1]:38623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2zGk-000305-SU for submit@debbugs.gnu.org; Wed, 06 Feb 2013 02:18:11 -0500 Received: from forward5h.mail.yandex.net ([84.201.186.23]:41833) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2zGg-0002zw-Vf for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 02:18:09 -0500 Received: from smtp3h.mail.yandex.net (smtp3h.mail.yandex.net [84.201.186.20]) by forward5h.mail.yandex.net (Yandex) with ESMTP id 35DADD01F6E; Wed, 6 Feb 2013 11:16:50 +0400 (MSK) Received: from smtp3h.mail.yandex.net (localhost [127.0.0.1]) by smtp3h.mail.yandex.net (Yandex) with ESMTP id BAEA51B404A2; Wed, 6 Feb 2013 11:16:49 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp3h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Gm5GHpSh-Gn5esNmd; Wed, 6 Feb 2013 11:16:49 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1360135009; bh=2WFhh9h3dfTH2ryt/H5+d+U8TjQ+y5Vdn5rcQcCEDII=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=qavoTGHgtpBa/+WzM0bjdbjFgNhxcOHL6NQhjJsSJcHFR/ge/BAvEkmhvtuJPeyMU wXmw5LxBGPMdvkiAMiQl+d41WWSBj6L6B96CXjBoUpJno2gEahmCMm9mA7MAFdZv4n QMZRwhckvb0vEoTGyQi5EPOpu7Ci+QJe1nWKt0K8= Message-ID: <51120360.4060104@yandex.ru> Date: Wed, 06 Feb 2013 11:16:48 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> In-Reply-To: <83fw1aac3d.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) On 02/05/2013 09:45 PM, Eli Zaretskii wrote: > As long as we don't restrict the 'region' face to a very small subset > of possible face customizations (e.g., just the background and the > foreground colors), and ignore the other attributes, an arbitrary face > change on one line might potentially affect many more lines in the > window. E.g., try customizing the 'region' face to twice its normal > height. This looks terribly ugly, but works (at least, I don't see any glitches while performing basic operations with the region). > And I'm not sure this is worth optimizing anyway: region changes are > relatively rare and almost always driven by user input, so I don't > think redisplay will become significantly faster as result of any > optimizations in this area. I have a strong suspicion that this also applies to ~50% of xdisp.c unless you're on 2400bps tty or remote X connection via 33600bps modem. Dmitry From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: wence@gmx.li, Eli Zaretskii , 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136016120022120 (code B ref 13623); Wed, 06 Feb 2013 14:34:02 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 14:33:20 +0000 Received: from localhost ([127.0.0.1]:38956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U363f-0005kV-FA for submit@debbugs.gnu.org; Wed, 06 Feb 2013 09:33:11 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:41417) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U363a-0005kJ-8f for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 09:33:04 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r16EVi8H008266; Wed, 6 Feb 2013 09:31:44 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id BE441B4182; Wed, 6 Feb 2013 09:31:44 -0500 (EST) From: Stefan Monnier Message-ID: References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> Date: Wed, 06 Feb 2013 09:31:44 -0500 In-Reply-To: <51120360.4060104@yandex.ru> (Dmitry Antipov's message of "Wed, 06 Feb 2013 11:16:48 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4483=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4483> : streams <901572> : uri <1338196> X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >> And I'm not sure this is worth optimizing anyway: region changes are >> relatively rare and almost always driven by user input, so I don't >> think redisplay will become significantly faster as result of any >> optimizations in this area. > I have a strong suspicion that this also applies to ~50% of xdisp.c > unless you're on 2400bps tty or remote X connection via 33600bps modem. For my use case, the optimisations that matter are the ones that avoid looking at the unmodified (and mostly all iconified) frames when I work within a frame or switch between two frames (or maybe 3 at most: the origin, the destination and the minibuffer-only frame). Stefan From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Dmitry Antipov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: wence@gmx.li, Eli Zaretskii , 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136016377026203 (code B ref 13623); Wed, 06 Feb 2013 15:17:01 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 15:16:10 +0000 Received: from localhost ([127.0.0.1]:39383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U36jI-0006oW-8E for submit@debbugs.gnu.org; Wed, 06 Feb 2013 10:16:10 -0500 Received: from forward4.mail.yandex.net ([77.88.46.9]:50722) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U36jE-0006oM-Fe for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 10:16:06 -0500 Received: from smtp2.mail.yandex.net (smtp2.mail.yandex.net [77.88.46.102]) by forward4.mail.yandex.net (Yandex) with ESMTP id 153E41BC257A; Wed, 6 Feb 2013 19:14:44 +0400 (MSK) Received: from smtp2.mail.yandex.net (localhost [127.0.0.1]) by smtp2.mail.yandex.net (Yandex) with ESMTP id B6D6DE20309; Wed, 6 Feb 2013 19:14:43 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp2.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Eh0OnWPg-Eh0uO8D2; Wed, 6 Feb 2013 19:14:43 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1360163683; bh=IJdACvKhX4h5vO//mAi9iTuI6/Rsk4kUuL7nSbCTPu8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=cTXZJXBtQ4nKXZeVSiqYn+QQrSvhLucaCeSD4gifCNkIJDrbCTzlOmf6jfpd7orPX 44YmdlKiXxUhw0jkR8RssLsuzXmjsj9FN+LwX/LtrI24j3J/DYkaVlZLvZiL1YHxrV wxXMKAMwo+qnTD4269MjMaI/M5qKSxI+Dlo45eEs= Message-ID: <51127363.5030203@yandex.ru> Date: Wed, 06 Feb 2013 19:14:43 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On 02/06/2013 06:31 PM, Stefan Monnier wrote: > For my use case, the optimisations that matter are the ones that avoid > looking at the unmodified (and mostly all iconified) frames when I work > within a frame or switch between two frames (or maybe 3 at most: the > origin, the destination and the minibuffer-only frame). This is a question of splitting global state between frames because current tricks like ++windows_or_buffers_changed effectively prevents single-frame redisplay optimizations. I have a few experimental patches with per-frame fonts_changed_p and cursor_type_changed flags. Since font/cursor changes are rare, the effect is negligible, but this opens the way towards more interesting things. On the other side, I suspect that the most of users are either 1) uses single-frame configuration or 2) uses reasonably modern hardware where the complete redisplay (all frames) is faster than the period between two keystrokes and so doesn't affect an editing experience. Dmitry From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: wence@gmx.li, 13623@debbugs.gnu.org, monnier@IRO.UMontreal.CA Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136017395213167 (code B ref 13623); Wed, 06 Feb 2013 18:06:01 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 18:05:52 +0000 Received: from localhost ([127.0.0.1]:39648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U39NY-0003QJ-IK for submit@debbugs.gnu.org; Wed, 06 Feb 2013 13:05:52 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:55689) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U39NV-0003QB-Lo for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 13:05:51 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MHT00G008SFQ800@a-mtaout22.012.net.il> for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 20:04:04 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHT00GND8UR9MA0@a-mtaout22.012.net.il>; Wed, 06 Feb 2013 20:04:04 +0200 (IST) Date: Wed, 06 Feb 2013 20:04:17 +0200 From: Eli Zaretskii In-reply-to: <51127363.5030203@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <837gml9v4u.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> <51127363.5030203@yandex.ru> X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Wed, 06 Feb 2013 19:14:43 +0400 > From: Dmitry Antipov > CC: Eli Zaretskii , wence@gmx.li, 13623@debbugs.gnu.org > > On the other side, I suspect that the most of users > are either 1) uses single-frame configuration or 2) uses reasonably modern > hardware where the complete redisplay (all frames) is faster than the period > between two keystrokes and so doesn't affect an editing experience. I doubt many users use only one frame. I certainly don't, although my usage patterns are pretty conservative, nowhere near Stefan's. As for full redisplay: please remember that there are 2 aspects to that: (1) on the xdisp.c level, which is device independent, and (2) on the device-dependent xterm.c/w32term.c/nsterm.m etc. level. Even if on the xdisp.c level we do a complete redisplay of a window, update_frame and its subroutines compare the desired and the current display and only redraw the lines that are different. Therefore, you could do a complete redisplay on xdisp.c level, and then redraw very little or even nothing at all, even if your video hardware is 10 years old. I'm saying that because due to this 2-level optimization, the hardware speed is rarely seen in Emacs. From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: wence@gmx.li, 13623@debbugs.gnu.org, monnier@IRO.UMontreal.CA Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136017506615002 (code B ref 13623); Wed, 06 Feb 2013 18:25:02 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 18:24:26 +0000 Received: from localhost ([127.0.0.1]:39682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U39fV-0003tv-Pb for submit@debbugs.gnu.org; Wed, 06 Feb 2013 13:24:26 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:51200) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U39fT-0003tj-7s for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 13:24:24 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MHT000009O04M00@a-mtaout21.012.net.il> for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 20:22:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHT00NY19Q22L70@a-mtaout21.012.net.il>; Wed, 06 Feb 2013 20:22:50 +0200 (IST) Date: Wed, 06 Feb 2013 20:23:04 +0200 From: Eli Zaretskii In-reply-to: <51127363.5030203@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <834nhp9u9j.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> <51127363.5030203@yandex.ru> X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Wed, 06 Feb 2013 19:14:43 +0400 > From: Dmitry Antipov > CC: Eli Zaretskii , wence@gmx.li, 13623@debbugs.gnu.org > > I have a few experimental patches with per-frame fonts_changed_p and > cursor_type_changed flags. Since font/cursor changes are rare, the > effect is negligible, but this opens the way towards more > interesting things. What exactly is the strategy of enabling per-frame redisplay optimizations? As you point out, font and cursor type changes are not the important cost drivers. The question is: what is? IOW, how do you know which changes affect what frames? The current display engine does not try to optimize per-frame redisplay (except on a TTY, but let's forget about that for a moment). It tries to optimize per-window redisplay. I don't see what's wrong with this approach; in fact, I think for GUI frames it's better than per-frame optimizations. Therefore, I think we should improve optimizations by more aggressively detecting windows that need not be updated, instead of turning our attention to frames. In any case, the first step towards any intelligent improvements in redisplay optimizations would be to compile a list of use cases where we currently give up and redisplay entire windows, and where this thorough redisplay really matters, i.e. we can actually see and measure the effect of this. Another area of redisplay optimizations would be the infamous very-long-lines use case. (Personally, I think this one is the single most important deficiency in the current display engine, by far more important than any other display problem.) From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: wence@gmx.li, Dmitry Antipov , 13623@debbugs.gnu.org Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136018270012045 (code B ref 13623); Wed, 06 Feb 2013 20:32:02 +0000 Received: (at 13623) by debbugs.gnu.org; 6 Feb 2013 20:31:40 +0000 Received: from localhost ([127.0.0.1]:39969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3Bee-00038E-6G for submit@debbugs.gnu.org; Wed, 06 Feb 2013 15:31:40 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:24555) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3Bea-000385-EA for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 15:31:39 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="620858" Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Feb 2013 15:30:17 -0500 Received: by pastel.home (Postfix, from userid 20848) id E7712592BB; Wed, 6 Feb 2013 15:30:12 -0500 (EST) From: Stefan Monnier Message-ID: References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> <51127363.5030203@yandex.ru> <834nhp9u9j.fsf@gnu.org> Date: Wed, 06 Feb 2013 15:30:12 -0500 In-Reply-To: <834nhp9u9j.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Feb 2013 20:23:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > per-frame optimizations. Therefore, I think we should improve > optimizations by more aggressively detecting windows that need not be > updated, instead of turning our attention to frames. Agreed. > In any case, the first step towards any intelligent improvements in > redisplay optimizations would be to compile a list of use cases where > we currently give up and redisplay entire windows, and where this One case where I notice performance sucks is when the minibuffer is in use (in my minibuffer-only frame), and I switch to another frame and try to work there. Stefan From unknown Sat Sep 13 11:13:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Feb 2013 03:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: wence@gmx.li, dmantipov@yandex.ru, 13623@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.136020855132376 (code B ref 13623); Thu, 07 Feb 2013 03:43:01 +0000 Received: (at 13623) by debbugs.gnu.org; 7 Feb 2013 03:42:31 +0000 Received: from localhost ([127.0.0.1]:40448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3INa-0008Q8-Nc for submit@debbugs.gnu.org; Wed, 06 Feb 2013 22:42:30 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:58970) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3INW-0008Px-BD for 13623@debbugs.gnu.org; Wed, 06 Feb 2013 22:42:27 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MHT00L00ZEAZC00@a-mtaout22.012.net.il> for 13623@debbugs.gnu.org; Thu, 07 Feb 2013 05:41:04 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHT00LN6ZKGPY70@a-mtaout22.012.net.il>; Thu, 07 Feb 2013 05:41:04 +0200 (IST) Date: Thu, 07 Feb 2013 05:41:19 +0200 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83wquk94f4.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> <51127363.5030203@yandex.ru> <834nhp9u9j.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stefan Monnier > Cc: Dmitry Antipov , wence@gmx.li, 13623@debbugs.gnu.org > One case where I notice performance sucks is when the minibuffer is in > use (in my minibuffer-only frame), and I switch to another frame and try > to work there. I suggest to create a new bug report with a recipe to reproduce this.