Subject: Re: bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->PDF converter

From: Glenn Morris <[email-masked]>
Date: Tue, 05 Feb 2013 03:04:13 -0500

Jambunathan K wrote:

> I am attaching a patch.  Please apply to trunk.

Some explanation as to why would be nice.

> +(defcustom doc-view-odf->pdf-converter-program
> +  (cond
> +   ((executable-find "soffice") "soffice")
> +   ((executable-find "unoconv") "unoconv"))

This could end up being nil, which would give a type mismatch with 'file.

>    :type 'file

>  
> +(defcustom doc-view-odf->pdf-converter-function
> +  (cond
> +   ((string-match "unoconv\\'" doc-view-odf->pdf-converter-program)
> +    #'doc-view-odf->pdf-converter-unoconv)
> +   ((string-match "soffice\\'" doc-view-odf->pdf-converter-program)
> +    #'doc-view-odf->pdf-converter-soffice))
> +  "Function to call to convert a ODF file into a PDF file."
> +  :type '(radio
> +          (function-item doc-view-odf->pdf-converter-unoconv
> +                         :doc "Use unoconv")
> +          (function-item doc-view-odf->pdf-converter-soffice
> +                         :doc "Use LibreOffice")
> +          function)
> +  :version "24.4")

Why do you need this, as opposed to a single function which calls
-program with a customizable -program-options argument?