GNU bug report logs - #13609
24.2.92; completion-list-insert-choice-function

Previous Next

Package: emacs;

Reported by: "Roland Winkler" <winkler <at> gnu.org>

Date: Sat, 2 Feb 2013 16:27:02 UTC

Severity: minor

Found in version 24.2.92

Done: "Roland Winkler" <winkler <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Roland Winkler" <winkler <at> gnu.org>
Cc: 13609 <at> debbugs.gnu.org
Subject: bug#13609: 24.2.92; completion-list-insert-choice-function
Date: Sun, 03 Feb 2013 08:51:39 -0500

> So I suggest to rename completion--replace to completion-replace
> to make it clear that other code may use this function.

No, because some other package may already have changed
completion-list-insert-choice-function, so you should really read the
current value of completion-list-insert-choice-function, and then call
that (via `funcall') rather than hard-coding completion--replace.

> (Or solve this problem in some other way that other code may rely upon.)

As a matter of fact there's a new feature in trunk that does just that:
`add-function'.


        Stefan
This bug report was last modified 12 years and 168 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.