GNU bug report logs - #13598
24.3.50; url-http.el doesn't correctly parse headers when they are sent line-by-line

Previous Next

Full log

Message #11 received at 13598 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: coroa <at> online.de (Jonas Hörsch)
Cc: 13598 <at> debbugs.gnu.org
Subject: Re: bug#13598: 24.3.50;
	url-http.el doesn't correctly parse headers when they are sent
	line-by-line
Date: Wed, 13 Feb 2013 18:19:15 +0100

Hi Jonas,

coroa <at> online.de (Jonas Hörsch) writes:

> On Thu, Jan 31 2013, Jonas Hoersch wrote:
>
>> changing the regex in (re-search-forward "^\r*$" nil t) to "^\r*\n"
>> solves the problem for me, but i'm unsure about what i might possibly be
>> breaking that way.
>
> i'm positive now, that changing the regex to "^\r+$" is the way to go.
>
> i would be happy to supply a patch, but i understand it is probably to
> trivial a matter to justify going through the legal requirements first.
>
> the following advice can serve as a hotfix:
>
> (defadvice url-http-wait-for-headers-change-function (around
>                                                       url-http-properly-wait-for-headers-advice
>                                                       activate)
>   (save-excursion
>     (goto-char (point-min))
>     (if (re-search-forward "^\r+$" nil t)
>         ad-do-it
>       (url-http-debug "Incomplete headers...: %d" (point-max)))))

I confirm both the problem and the fix.

It does not look critical though.  Stefan, Glenn, should I
commit the patch into trunk (or emacs-24)?

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.