GNU bug report logs - #13594
24.2.92; [PATCH] compilation-start doesn't consider nil OUTWIN

Previous Next

Full log

Message #83 received at 13594 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 13594 <at> debbugs.gnu.org
Subject: Re: bug#13594: 24.2.92;
	[PATCH] compilation-start doesn't consider nil OUTWIN
Date: Wed, 20 Mar 2013 08:51:52 -0400

>> It only does one half: change a few callers to handle a non-window
>> return value.  But the other half is important: the non-window return
>> value should only be possible if the caller announces that it's ready to
>> handle it.
> So add to display-buffer an optional arg like the following?
> (display-buffer BUFFER-OR-NAME &optional ACTION FRAME HANDLE-NONWINDOW)

That's one possibility, yes.  Tho adding an argument doesn't sound
much fun.  So I'd prefer if it could be passed via ACTION.

> display-buffer currently does not checking; it just passes back the
> non-nil value to the caller. WDYT?

That's OK.  The whole point is that the code (e.g. in
display-buffer-alist) that returns the non-window value needs to be able
to decide whether it's safe to do so.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.