GNU bug report logs - #13582
[PATCH] stat: add ext4 to the ext2/ext3 list

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13582: closed ([PATCH] stat: add ext4 to the ext2/ext3 list)
Date: Tue, 29 Jan 2013 06:59:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 29 Jan 2013 07:57:42 +0100
with message-id <510772E6.3050906 <at> bernhard-voelker.de>
and subject line Re: bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list
has caused the debbugs.gnu.org bug report #13582,
regarding [PATCH] stat: add ext4 to the ext2/ext3 list
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13582: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13582
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Frysinger <vapier <at> gentoo.org>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] stat: add ext4 to the ext2/ext3 list
Date: Tue, 29 Jan 2013 01:13:49 -0500

Since ext4 returns the same info as ext2/ext3, add it to the list.
This fixes the output of running `stat -f / -c %T` on my system that
has an ext4 rootfs.

* src/stat.c (human_fstype): Add "ext4" to the S_MAGIC_EXT2 and
FSTYPE_EXT2FS cases.
---
 src/stat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/stat.c b/src/stat.c
index dd210d1..d3d7190 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -293,7 +293,7 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
     case S_MAGIC_EXT: /* 0x137D local */
       return "ext";
     case S_MAGIC_EXT2: /* 0xEF53 local */
-      return "ext2/ext3";
+      return "ext2/ext3/ext4";
     case S_MAGIC_EXT2_OLD: /* 0xEF51 local */
       return "ext2";
     case S_MAGIC_FAT: /* 0x4006 local */
@@ -480,7 +480,7 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
     case FSTYPE_MISC:
       return "misc";
     case FSTYPE_EXT2FS:
-      return "ext2/ext3";
+      return "ext2/ext3/ext4";
     case FSTYPE_HTTP:
       return "http";
     case FSTYPE_MEMFS:
-- 
1.8.0.2

[Message part 3 (message/rfc822, inline)]

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Mike Frysinger <vapier <at> gentoo.org>
Cc: 13582-done <at> debbugs.gnu.org
Subject: Re: bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list
Date: Tue, 29 Jan 2013 07:57:42 +0100

tag 13582 + notabug
close 13582
stop

On 01/29/2013 07:13 AM, Mike Frysinger wrote:
> Since ext4 returns the same info as ext2/ext3, add it to the list.
> This fixes the output of running `stat -f / -c %T` on my system that
> has an ext4 rootfs.

Thanks for the patch, however, you submitted it to the bug-coreutils
mailing list which automatically opened a new ticket. Therefore, I'm
closing the bug (not intending to stop the discussion). Please use the
general discussion list coreutils <at> gnu.org next time.


Re. EXT4:
this has been discussed recently:
http://lists.gnu.org/archive/html/coreutils/2012-12/msg00068.html

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.