GNU bug report logs - #13563
tabulated-list-print-col nicer help-echo

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13563: closed (tabulated-list-print-col nicer help-echo)
Date: Sat, 16 Feb 2013 02:53:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 15 Feb 2013 21:52:01 -0500
with message-id <x9txpdkm26.fsf <at> fencepost.gnu.org>
and subject line Re: bug#13563: tabulated-list-print-col nicer help-echo
has caused the debbugs.gnu.org bug report #13563,
regarding tabulated-list-print-col nicer help-echo
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13563: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13563
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Subject: tabulated-list-print-col nicer help-echo
Date: Sat, 26 Jan 2013 22:14:37 +0100

[Message part 3 (text/plain, inline)]

`tabulated-list-set-col' adds a help-echo property to the "labels" that
it inserts.  With this patch this is done a bit differently:

* If the label already has a help-echo property then use that help-echo
  instead of overriding it with a generic one.  This allows displaying
  additional information when it makes sense.
* Otherwise propertize as before but don't prefix the help-echo with the
  column name.  That information is not really useful.

[tabulated-list-print-col.patch (text/x-diff, inline)]

From bbe78adda05897c892ea3c3687912a4c056d6fe1 Mon Sep 17 00:00:00 2001
From: Jonas Bernoulli <jonas <at> bernoul.li>
Date: Sat, 26 Jan 2013 22:03:09 +0100
Subject: [PATCH] lisp/emacs-lisp/tabulated-list.el (tabulated-list-print-col):
 don't prepend help-echo with column name, if help-echo is already predefined
 don't replace it

---
 lisp/emacs-lisp/tabulated-list.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 94b3c15..13fc730 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -363,7 +363,6 @@ Return the column number after insertion."
          (right-align (plist-get props :right-align))
 	 (label     (if (stringp col-desc) col-desc (car col-desc)))
          (label-width (string-width label))
-	 (help-echo (concat (car format) ": " label))
 	 (opoint (point))
 	 (not-last-col (< (1+ n) (length tabulated-list-format))))
     ;; Truncate labels if necessary (except last column).
@@ -379,7 +378,9 @@ Return the column number after insertion."
         (setq width (- width shift))
         (setq x (+ x shift))))
     (if (stringp col-desc)
-	(insert (propertize label 'help-echo help-echo))
+	(insert (if (get-text-property 0 'help-echo label)
+		    label
+		  (propertize label 'help-echo label)))
       (apply 'insert-text-button label (cdr col-desc)))
     (let ((next-x (+ x pad-right width)))
       ;; No need to append any spaces if this is the last column.
-- 
1.8.0.1

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 13563-done <at> debbugs.gnu.org
Subject: Re: bug#13563: tabulated-list-print-col nicer help-echo
Date: Fri, 15 Feb 2013 21:52:01 -0500

Version: 24.4

Jonas Bernoulli wrote:

>>> * If the label already has a help-echo property then use that help-echo
>>>   instead of overriding it with a generic one.  This allows displaying
>>>   additional information when it makes sense.

I applied this part, thanks.

> One other thing I forgot to include in this pull request: I think it
> would make sense to set `x-stretch-cursor' to nil in
> `tabulated-list-mode'. 

I don't see the point.

> One shouldn't set that to t globally (I did for a while, silly me) but
> it also does not hurt to actively override such a setting in cases
> where it is known not to make any sense.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.