From unknown Tue Sep 09 05:52:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13563 <13563@debbugs.gnu.org> To: bug#13563 <13563@debbugs.gnu.org> Subject: Status: tabulated-list-print-col nicer help-echo Reply-To: bug#13563 <13563@debbugs.gnu.org> Date: Tue, 09 Sep 2025 12:52:48 +0000 retitle 13563 tabulated-list-print-col nicer help-echo reassign 13563 emacs submitter 13563 Jonas Bernoulli severity 13563 minor tag 13563 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 16:15:11 2013 Received: (at submit) by debbugs.gnu.org; 26 Jan 2013 21:15:11 +0000 Received: from localhost ([127.0.0.1]:50771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzD5j-0003vK-Bk for submit@debbugs.gnu.org; Sat, 26 Jan 2013 16:15:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34878) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzD5h-0003vD-8g for submit@debbugs.gnu.org; Sat, 26 Jan 2013 16:15:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzD5M-0006lQ-Rf for submit@debbugs.gnu.org; Sat, 26 Jan 2013 16:14:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzD5M-0006lL-OO for submit@debbugs.gnu.org; Sat, 26 Jan 2013 16:14:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzD5J-00015N-Cc for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 16:14:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzD5E-0006iX-Ae for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 16:14:45 -0500 Received: from mail-ee0-f47.google.com ([74.125.83.47]:62552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzD5E-0006iL-4E for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 16:14:40 -0500 Received: by mail-ee0-f47.google.com with SMTP id e52so722137eek.20 for ; Sat, 26 Jan 2013 13:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:user-agent:date:message-id :mime-version:content-type; bh=C8oLzMulDicmqkx8wn11UY78JgEOn/cElD2zQw6STDs=; b=Bwv8SsRnRpfEJLdTUQx0OMhl51RmhdRLDss4i5i2z/qYOt9ylzW4kiHesLwszZcVpZ 6jGE+6LJ5IZQA3wfF9NZ+LisrNWEKamqfrrjCzZDTje23M/wXIUSH+pn7EA8mUoL2bMH SqRUX459qUrQBiWiKacL5oUNfZIMyT4DQRpLQJzayHj8Ecuu9AXavdyL5sXJGdEFI0KS 1eqWWGFbLGZ6yah8E6Wq6pQzwxtOVD4JxmLWDYUD08JC4+h5ChccW3Ty6mX9t0eS0r/R NteXKpAW5LhD0rQMmq/0XjivFsKkh07t8IHLbsiyKlLEtlDw5tKeJyRNLgm3gPOhdKdb ++8w== X-Received: by 10.14.175.70 with SMTP id y46mr33762619eel.6.1359234879396; Sat, 26 Jan 2013 13:14:39 -0800 (PST) Received: from lem (178-83-148-119.dynamic.hispeed.ch. [178.83.148.119]) by mx.google.com with ESMTPS id f49sm8242476eep.12.2013.01.26.13.14.38 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Jan 2013 13:14:38 -0800 (PST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: tabulated-list-print-col nicer help-echo User-agent: mu4e 0.9.9.5-dev6; emacs 24.3.50.1 Date: Sat, 26 Jan 2013 22:14:37 +0100 Message-ID: <877gmzve82.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --=-=-= Content-Type: text/plain `tabulated-list-set-col' adds a help-echo property to the "labels" that it inserts. With this patch this is done a bit differently: * If the label already has a help-echo property then use that help-echo instead of overriding it with a generic one. This allows displaying additional information when it makes sense. * Otherwise propertize as before but don't prefix the help-echo with the column name. That information is not really useful. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=tabulated-list-print-col.patch >From bbe78adda05897c892ea3c3687912a4c056d6fe1 Mon Sep 17 00:00:00 2001 From: Jonas Bernoulli Date: Sat, 26 Jan 2013 22:03:09 +0100 Subject: [PATCH] lisp/emacs-lisp/tabulated-list.el (tabulated-list-print-col): don't prepend help-echo with column name, if help-echo is already predefined don't replace it --- lisp/emacs-lisp/tabulated-list.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 94b3c15..13fc730 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -363,7 +363,6 @@ Return the column number after insertion." (right-align (plist-get props :right-align)) (label (if (stringp col-desc) col-desc (car col-desc))) (label-width (string-width label)) - (help-echo (concat (car format) ": " label)) (opoint (point)) (not-last-col (< (1+ n) (length tabulated-list-format)))) ;; Truncate labels if necessary (except last column). @@ -379,7 +378,9 @@ Return the column number after insertion." (setq width (- width shift)) (setq x (+ x shift)))) (if (stringp col-desc) - (insert (propertize label 'help-echo help-echo)) + (insert (if (get-text-property 0 'help-echo label) + label + (propertize label 'help-echo label))) (apply 'insert-text-button label (cdr col-desc))) (let ((next-x (+ x pad-right width))) ;; No need to append any spaces if this is the last column. -- 1.8.0.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 21:53:24 2013 Received: (at 13563) by debbugs.gnu.org; 27 Jan 2013 02:53:24 +0000 Received: from localhost ([127.0.0.1]:50919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzIN2-0003Oe-4Z for submit@debbugs.gnu.org; Sat, 26 Jan 2013 21:53:24 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54743) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzIN0-0003OY-Ud for 13563@debbugs.gnu.org; Sat, 26 Jan 2013 21:53:23 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzIMi-00071M-Uv; Sat, 26 Jan 2013 21:53:05 -0500 From: Glenn Morris To: Jonas Bernoulli Subject: Re: bug#13563: tabulated-list-print-col nicer help-echo References: <877gmzve82.fsf@bernoul.li> X-Spook: Peking MD4 S Box Mantis blackjack Al-Qaeda Defcon Firefly X-Ran: W;-Zz}U,X2gwy<:LfN (Jonas Bernoulli's message of "Sat, 26 Jan 2013 22:14:37 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13563 Cc: 13563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Jonas Bernoulli wrote: > `tabulated-list-set-col' adds a help-echo property to the "labels" that > it inserts. With this patch this is done a bit differently: > > * If the label already has a help-echo property then use that help-echo > instead of overriding it with a generic one. This allows displaying > additional information when it makes sense. Seems good. > * Otherwise propertize as before but don't prefix the help-echo with the > column name. That information is not really useful. Not sure I agree. Eg in Buffer-menu mode, the prefix is useful IMO. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 22:58:56 2013 Received: (at 13563) by debbugs.gnu.org; 27 Jan 2013 03:58:56 +0000 Received: from localhost ([127.0.0.1]:50931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzJOR-0005nn-G4 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 22:58:56 -0500 Received: from mail-ee0-f50.google.com ([74.125.83.50]:53075) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzJOM-0005nb-UH for 13563@debbugs.gnu.org; Sat, 26 Jan 2013 22:58:52 -0500 Received: by mail-ee0-f50.google.com with SMTP id e51so804852eek.37 for <13563@debbugs.gnu.org>; Sat, 26 Jan 2013 19:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:user-agent :in-reply-to:date:message-id:mime-version:content-type; bh=2NFzSixVjgxMyyK+qjGgtDvE2nA7v3kgfhC/oipqRPE=; b=URh2OjhbTlBv5JfXt9V8XEJrcwLjz4mBNSYFIx4dHyeNl0Z64v6DhqiSD+Duv+cxaC OTCVny/6fAsfjfmygHVO7UKsuumfTUkTebPIzWr6j6Xt+xT184EKytL1NBnF1NBoBUcT hfH65Mzhw/9M7TNqFy1zRsYaON1cLA6ovL2ypOWVQCJOBEDKg8xQ/iTEfUKdnmd9pJFf McxOMCGm0kXSspTkAO2lEGTN8s04WL7z+clDo1De/6fU9bo6ybn5bYOaPATs9IcRUa2J tLE0YfXwel3j294lbJhb2rsj/vhxs2mxb9RVbkAmUqEJ+6tYsKYINlprUVccOYnktHwD rjhw== X-Received: by 10.14.223.137 with SMTP id v9mr36847966eep.22.1359259112602; Sat, 26 Jan 2013 19:58:32 -0800 (PST) Received: from lem (178-83-148-119.dynamic.hispeed.ch. [178.83.148.119]) by mx.google.com with ESMTPS id q5sm9389340eeo.17.2013.01.26.19.58.31 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Jan 2013 19:58:31 -0800 (PST) From: Jonas Bernoulli To: "Glenn Morris" Subject: Re: bug#13563: tabulated-list-print-col nicer help-echo References: <877gmzve82.fsf@bernoul.li> User-agent: mu4e 0.9.9.5-dev6; emacs 24.3.50.1 In-reply-to: Date: Sun, 27 Jan 2013 04:58:30 +0100 Message-ID: <877gmzwa3d.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13563 Cc: 13563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Glenn Morris writes: > Jonas Bernoulli wrote: > >> `tabulated-list-set-col' adds a help-echo property to the "labels" that >> it inserts. With this patch this is done a bit differently: >> >> * If the label already has a help-echo property then use that help-echo >> instead of overriding it with a generic one. This allows displaying >> additional information when it makes sense. > > Seems good. > >> * Otherwise propertize as before but don't prefix the help-echo with the >> column name. That information is not really useful. > > Not sure I agree. Eg in Buffer-menu mode, the prefix is useful IMO. I don't find it very useful since the same information is also displayed in the header-line. But if the other change is merged then I can easily work around this by explicitly setting the help-echo in my Tabulated-List mode derived modes. One other thing I forgot to include in this pull request: I think it would make sense to set `x-stretch-cursor' to nil in `tabulated-list-mode'. One shouldn't set that to t globally (I did for a while, silly me) but it also does not hurt to actively override such a setting in cases where it is known not to make any sense. I don't care much about this (after all I have not enabled this globally anymore:). Let me know what you think and I will create a new patch with the second change above removed and this one included if desired. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 15 21:52:49 2013 Received: (at 13563-done) by debbugs.gnu.org; 16 Feb 2013 02:52:49 +0000 Received: from localhost ([127.0.0.1]:58397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6XtR-0007uo-29 for submit@debbugs.gnu.org; Fri, 15 Feb 2013 21:52:49 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:37864) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6XtP-0007uh-P7 for 13563-done@debbugs.gnu.org; Fri, 15 Feb 2013 21:52:48 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U6Xsf-0007CV-8r; Fri, 15 Feb 2013 21:52:01 -0500 From: Glenn Morris To: 13563-done@debbugs.gnu.org Subject: Re: bug#13563: tabulated-list-print-col nicer help-echo References: <877gmzve82.fsf@bernoul.li> <877gmzwa3d.fsf@bernoul.li> X-Spook: Axis of Evil undercover kilderkin Venezuela AVN Honduras X-Ran: ~N;Q}M<'{w{]M@AD8?@,97^RP2JV@Bj"YU18;}kT|gU@6WH%x{ (Jonas Bernoulli's message of "Sun, 27 Jan 2013 04:58:30 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13563-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Version: 24.4 Jonas Bernoulli wrote: >>> * If the label already has a help-echo property then use that help-echo >>> instead of overriding it with a generic one. This allows displaying >>> additional information when it makes sense. I applied this part, thanks. > One other thing I forgot to include in this pull request: I think it > would make sense to set `x-stretch-cursor' to nil in > `tabulated-list-mode'. I don't see the point. > One shouldn't set that to t globally (I did for a while, silly me) but > it also does not hurt to actively override such a setting in cases > where it is known not to make any sense. From unknown Tue Sep 09 05:52:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Mar 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator