From unknown Tue Sep 09 22:00:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13560 <13560@debbugs.gnu.org> To: bug#13560 <13560@debbugs.gnu.org> Subject: Status: 24.2.92; tabulated-list header buttons are broken Reply-To: bug#13560 <13560@debbugs.gnu.org> Date: Wed, 10 Sep 2025 05:00:13 +0000 retitle 13560 24.2.92; tabulated-list header buttons are broken reassign 13560 emacs submitter 13560 Jonas Bernoulli severity 13560 important tag 13560 confirmed help thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 13:32:00 2013 Received: (at submit) by debbugs.gnu.org; 26 Jan 2013 18:32:00 +0000 Received: from localhost ([127.0.0.1]:50643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzAXm-000068-Vv for submit@debbugs.gnu.org; Sat, 26 Jan 2013 13:31:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50647) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzAXk-00005z-GJ for submit@debbugs.gnu.org; Sat, 26 Jan 2013 13:31:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzAXS-00017o-G4 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 13:31:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzAXS-00017k-DN for submit@debbugs.gnu.org; Sat, 26 Jan 2013 13:31:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzAXP-0004vx-Kq for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 13:31:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzAXM-00016d-59 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 13:31:35 -0500 Received: from mail-ee0-f48.google.com ([74.125.83.48]:63994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzAXM-00016L-05 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 13:31:32 -0500 Received: by mail-ee0-f48.google.com with SMTP id t10so710817eei.35 for ; Sat, 26 Jan 2013 10:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:user-agent:date:message-id :mime-version:content-type; bh=SyHZu7J/NxUcvO69rom0MrBkcs4QkmL5vBvqU0DnJw0=; b=Sp8u9s6/Jukg5cbuJdUNKZoBoIKPvbcgEXEx1Bvn85DAKN7mC47gWTJ0F66d8pRF58 NbcFIrBtexQgzWVLxd2avXQVnrGbbybuHzZn4+GwV1z27hoLWaZANVP3cagmhCLsSv57 diz3D2Nmmq0Z9HmisJBGqFcd6ZqTRNmXBIoIv+mx7sHiiQ1JZE1uaUfZeIjWTYuuRfbM 3r586oB6GZ2NGZl/V9ULKcAOAVrJ/DDkTOYiJxcZ1JgDndPOqg5fhYqyUM7tTpATum2h g7PdZAlelt1K2E2kz0ZUn5wS75TEV/FCbHEkSbMWCVhq+lxVd1VF6EKzS3DRd8RSVEET L/FA== X-Received: by 10.14.223.135 with SMTP id v7mr32570591eep.41.1359225090649; Sat, 26 Jan 2013 10:31:30 -0800 (PST) Received: from lem (178-83-148-119.dynamic.hispeed.ch. [178.83.148.119]) by mx.google.com with ESMTPS id t4sm7644895eel.0.2013.01.26.10.31.28 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Jan 2013 10:31:29 -0800 (PST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: 24.2.92; tabulated-list header buttons are broken User-agent: mu4e 0.9.9.5-dev6; emacs 24.3.50.1 Date: Sat, 26 Jan 2013 19:31:27 +0100 Message-ID: <878v7fvls0.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Starting with 24.2.92 clicking on a column button created by a Tabulated-List mode derived mode does not sort correctly anymore. When clicking the first time the order should not be reversed, but it is. Clicking some more does not change the order, it stays reversed. I looked into why this is so and noticed that the command the mouse event is bound to is actually called twice. Thinking that for some reason clicking on the button on the header-line generates two events I modified tabulated-list-sort-button-map to only contain a binding for [header-line mouse-1]. Then I clicked again with the mouse button 1 and got the following warning in the echo area: ,---- | is undefined `---- It mentions mouse-2 even though I pressed mouse-1. Also the message did not appear in *Messages* and I could not get a backtrace after turning on debug-on-error. To check whether this is specific to Tabulated-List mode I tried the following: ,---- | (setq header-line-format | (propertize "button" | 'keymap (let ((map (make-sparse-keymap))) | (define-key map [header-line mouse-1] | (lambda (e) | (interactive "e") | (message "%s" e))) | map))) `---- Here everything works as expected: I don't get a warning about mouse-2 not being undefined, the command is only called once and it reports that mouse-1 was pressed. Jonas From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 21:52:43 2013 Received: (at 13560) by debbugs.gnu.org; 27 Jan 2013 02:52:43 +0000 Received: from localhost ([127.0.0.1]:50915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzIMM-0003NP-R5 for submit@debbugs.gnu.org; Sat, 26 Jan 2013 21:52:43 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54731) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzIMK-0003NI-NI for 13560@debbugs.gnu.org; Sat, 26 Jan 2013 21:52:41 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzIM2-0006zU-A6; Sat, 26 Jan 2013 21:52:22 -0500 From: Glenn Morris To: Jonas Bernoulli Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> X-Spook: Plame BRLO Panama USDOJ SAPO Ortega Ruby Ridge Kh-11 X-Ran: H3:1$9l6@vOVFFXHay[3m)\zX}#c[Fl5IJ9d)b,aPm5z\%1wH^~i0l+!/.@4JFQ4`[6hqa X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 26 Jan 2013 21:52:22 -0500 In-Reply-To: <878v7fvls0.fsf@bernoul.li> (Jonas Bernoulli's message of "Sat, 26 Jan 2013 19:31:27 +0100") Message-ID: <4vtxq35od5.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13560 Cc: 13560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Jonas Bernoulli wrote: > Starting with 24.2.92 clicking on a column button created by a > Tabulated-List mode derived mode does not sort correctly anymore. Thanks for the report. Eg visible in buffer-menu, where mouse-1 does not sort. I don't know what's going on here, but it seems to have some relation to mouse-1-click-follows-link. If you set it to nil, or leave it alone but make a long mouse-1 click, then it works. Otherwise it calls the sort function twice as you say. This seems like something that should be fixed for 24.3. > When clicking the first time the order should not be reversed, but it > is. Clicking some more does not change the order, it stays reversed. I > looked into why this is so and noticed that the command the mouse event > is bound to is actually called twice. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 27 20:37:11 2013 Received: (at 13560) by debbugs.gnu.org; 28 Jan 2013 01:37:11 +0000 Received: from localhost ([127.0.0.1]:51829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tzdeo-0006SZ-Pe for submit@debbugs.gnu.org; Sun, 27 Jan 2013 20:37:11 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:44392) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tzden-0006SS-E3 for 13560@debbugs.gnu.org; Sun, 27 Jan 2013 20:37:10 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzdeP-0007jo-Hv; Sun, 27 Jan 2013 20:36:45 -0500 From: Glenn Morris To: Jonas Bernoulli Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> X-Spook: gamma fraud defense information warfare airframe USCOI X-Ran: 8XQ$z^UR'LS+U1{WY{#N)_.TYC?DSR;b;}^=[F/|{so1mqm|4FJ[_n|U.6cA+Zh!Tp+$NW X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 27 Jan 2013 20:36:45 -0500 In-Reply-To: <4vtxq35od5.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 26 Jan 2013 21:52:22 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 13560 Cc: 13560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.3 (-------) Bisection suggests this stopped working with: On revision 110949 (cyd@gnu.org-20121124081500-x95lz4fz0j0t052c): Fix follow-mouse clicks on undraggable mode/header lines. * mouse.el (mouse-drag-line): Even if the line is not draggable, keep reading until we get the up-event anyway, in order to process the up-event for mouse-1-click-follows-link. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 28 12:11:34 2013 Received: (at 13560) by debbugs.gnu.org; 28 Jan 2013 17:11:34 +0000 Received: from localhost ([127.0.0.1]:52798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzsF3-0006ZD-1X for submit@debbugs.gnu.org; Mon, 28 Jan 2013 12:11:34 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:36488) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzsF1-0006Z6-0y for 13560@debbugs.gnu.org; Mon, 28 Jan 2013 12:11:31 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzsEa-0007jB-55; Mon, 28 Jan 2013 12:11:04 -0500 From: Glenn Morris To: Jonas Bernoulli Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> X-Spook: diwn BLU-114/B Leuken-Baden Vince Foster Fedayeen BATF X-Ran: %wY-+q]zB*~/]$h>xD4Ft}gavMkItrkLH8Ayujqh8_rMTGQ'cT{ (Jonas Bernoulli's message of "Sat, 26 Jan 2013 19:31:27 +0100") Message-ID: <81a9rtjkrb.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 13560 Cc: 13560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) Jonas Bernoulli wrote: > Thinking that for some reason clicking on the button on the header-line > generates two events I modified tabulated-list-sort-button-map to only > contain a binding for [header-line mouse-1]. Then I clicked again with > the mouse button 1 and got the following warning in the echo area: > > ,---- > | is undefined > `---- I guess this is due to the mouse-1-click-follows-link issue. Because the link you click has mouse-face, clicking mouse-1 tries to run the mouse-2 binding. I tried only binding mouse-2 in tabulated-list-sort-button-map, but that did not help. Not sure why it binds mouse-1 explicitly, yet uses follow-link as well. > To check whether this is specific to Tabulated-List mode I tried the > following: > > ,---- > | (setq header-line-format > | (propertize "button" > | 'keymap (let ((map (make-sparse-keymap))) > | (define-key map [header-line mouse-1] > | (lambda (e) > | (interactive "e") > | (message "%s" e))) > | map))) > `---- > > Here everything works as expected: I don't get a warning about mouse-2 > not being undefined, the command is only called once and it reports that > mouse-1 was pressed. A test that uses follow-link would be more informative, but at the moment this seems like a general mouse.el issue rather than anything specific to tabulated-list. Are there any other modes that use follow-link in the header line? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 28 22:12:25 2013 Received: (at 13560) by debbugs.gnu.org; 29 Jan 2013 03:12:25 +0000 Received: from localhost ([127.0.0.1]:53253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U01cW-0004ln-Pi for submit@debbugs.gnu.org; Mon, 28 Jan 2013 22:12:25 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:49369) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U01cU-0004lg-R9 for 13560@debbugs.gnu.org; Mon, 28 Jan 2013 22:12:23 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U01c0-0005AS-Hm; Mon, 28 Jan 2013 22:11:52 -0500 From: Glenn Morris To: Jonas Bernoulli Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <81a9rtjkrb.fsf@fencepost.gnu.org> X-Spook: AK-47 Centro industrial intelligence unclassified X-Ran: $F-S&Miz\8v[4Ee{E~/RN!4RW4fw[Ob+nZ\1.D-1a55CK3?8F,~/MNK?%Va*l (Glenn Morris's message of "Mon, 28 Jan 2013 12:11:04 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 13560 Cc: 13560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Glenn Morris wrote: > A test that uses follow-link would be more informative, but at the > moment this seems like a general mouse.el issue rather than anything > specific to tabulated-list. Are there any other modes that use > follow-link in the header line? Yes; info.el, and this is busted in the same way. Clicking mouse-1 in the Next/Prev breadcrumbs in the header-line of an Info page moves by two nodes rather than one. Clicking mouse-2 moves one. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 29 20:27:53 2013 Received: (at 13560) by debbugs.gnu.org; 30 Jan 2013 01:27:53 +0000 Received: from localhost ([127.0.0.1]:54915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0MSu-0003MM-Px for submit@debbugs.gnu.org; Tue, 29 Jan 2013 20:27:53 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:51220) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0MSs-0003ME-7u for 13560@debbugs.gnu.org; Tue, 29 Jan 2013 20:27:51 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0MSH-0005kk-Iz; Tue, 29 Jan 2013 20:27:13 -0500 From: Glenn Morris Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> to: 13560@debbugs.gnu.org X-Spook: UMTS UNSCOM advisors beanpole Bosnia David John Oates X-Ran: $m_lp|$%ZL(3S;(bopFhQR(&GE]t5^.GrOvP~|YiTPfEV8DcvPJ7%P7_J|V,Fp##fhT[38 X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 29 Jan 2013 20:27:13 -0500 In-Reply-To: (Glenn Morris's message of "Sun, 27 Jan 2013 20:36:45 -0500") Message-ID: <01sj5je9zi.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 13560 Cc: martin rudalics , Jonas Bernoulli , Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Ok, I think the issue here is mouse-drag-line pushing the same event onto unread-command-events twice in some cases. The recent history is a bit convoluted: 2012-07-08 changes to fix bug#374, and simplify mouse-drag-line loop. This caused bug#12006, fixed 2012-07-26. These changes reverted some of the loop simplifications, for reasons I don't understand. These changes in turn caused bug#12971 (no mouse-1 events in header), fixed 2012-11-24. It seems the fix actually gave us two sets of mouse-1 events in headers though (this bug). And then we have 2012-10-26 changes for bug#12731, introduced at some point along the way. What seems to work for me is going back to the 2012-07-26 changes, and reverting some of reversion. Basically, just check for switch-frame and select-window events and ignore them. Then I found I needed one more tweak to preserve the bug#12731 fix. The following change seems to not break any of bug 374, 12006, 12971, 12731, and to fix this bug; but I won't be surprised to hear that it breaks something else... *** lisp/mouse.el 2013-01-01 09:11:05 +0000 --- lisp/mouse.el 2013-01-29 22:22:44 +0000 *************** *** 425,431 **** (frame-parameters frame))) 'right))) (draggable t) ! finished event position growth dragged) (cond ((eq line 'header) ;; Check whether header-line can be dragged at all. --- 425,431 ---- (frame-parameters frame))) 'right))) (draggable t) ! event position growth dragged) (cond ((eq line 'header) ;; Check whether header-line can be dragged at all. *************** *** 456,494 **** ;; Start tracking. (track-mouse ! ;; Loop reading events and sampling the position of the mouse. ! (while (not finished) ! (setq event (read-event)) (setq position (mouse-position)) ;; Do nothing if ;; - there is a switch-frame event. ;; - the mouse isn't in the frame that we started in ;; - the mouse isn't in any Emacs frame - ;; Drag if - ;; - there is a mouse-movement event - ;; - there is a scroll-bar-movement event (Why? -- cyd) - ;; (same as mouse movement for our purposes) - ;; Quit if - ;; - there is a keyboard event or some other unknown event. (cond - ((not (consp event)) - (setq finished t)) ((memq (car event) '(switch-frame select-window)) nil) ! ((not (memq (car event) '(mouse-movement scroll-bar-movement))) ! (when (consp event) ! ;; Do not unread a drag-mouse-1 event to avoid selecting ! ;; some other window. For vertical line dragging do not ! ;; unread mouse-1 events either (but only if we dragged at ! ;; least once to allow mouse-1 clicks get through). ! (unless (and dragged ! (if (eq line 'vertical) ! (memq (car event) '(drag-mouse-1 mouse-1)) ! (eq (car event) 'drag-mouse-1))) ! (push event unread-command-events))) ! (setq finished t)) ! ((not (and (eq (car position) frame) ! (cadr position))) nil) ((eq line 'vertical) ;; Drag vertical divider. --- 456,480 ---- ;; Start tracking. (track-mouse ! ;; Loop reading events and sampling the position of the mouse, ! ;; until there is a non-mouse-movement event. Also, ! ;; scroll-bar-movement events are the same as mouse movement for ! ;; our purposes. (Why? -- cyd) ! (while (progn ! (setq event (read-event)) ! (memq (car-safe event) ! '(mouse-movement scroll-bar-movement ! switch-frame select-window))) (setq position (mouse-position)) ;; Do nothing if ;; - there is a switch-frame event. ;; - the mouse isn't in the frame that we started in ;; - the mouse isn't in any Emacs frame (cond ((memq (car event) '(switch-frame select-window)) nil) ! ((not (and (eq (car position) frame) ! (cadr position))) nil) ((eq line 'vertical) ;; Drag vertical divider. *************** *** 512,523 **** growth (- growth))))))) ;; Process the terminating event. ! (when (and (mouse-event-p event) on-link (not dragged) ! (mouse--remap-link-click-p start-event event)) ! ;; If mouse-2 has never been done by the user, it doesn't have ! ;; the necessary property to be interpreted correctly. ! (put 'mouse-2 'event-kind 'mouse-click) ! (setcar event 'mouse-2) (push event unread-command-events)))) (defun mouse-drag-mode-line (start-event) --- 498,510 ---- growth (- growth))))))) ;; Process the terminating event. ! (unless dragged ! (when (and (mouse-event-p event) on-link ! (mouse--remap-link-click-p start-event event)) ! ;; If mouse-2 has never been done by the user, it doesn't have ! ;; the necessary property to be interpreted correctly. ! (put 'mouse-2 'event-kind 'mouse-click) ! (setcar event 'mouse-2)) (push event unread-command-events)))) (defun mouse-drag-mode-line (start-event) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 30 11:06:15 2013 Received: (at 13560) by debbugs.gnu.org; 30 Jan 2013 16:06:15 +0000 Received: from localhost ([127.0.0.1]:55928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0aAv-0000GV-J0 for submit@debbugs.gnu.org; Wed, 30 Jan 2013 11:06:14 -0500 Received: from mout.gmx.net ([212.227.15.18]:54023) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0aAq-0000GF-10 for 13560@debbugs.gnu.org; Wed, 30 Jan 2013 11:06:09 -0500 Received: from mailout-de.gmx.net ([10.1.76.29]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Lobhc-1Uch8d3GtW-00gYkg for <13560@debbugs.gnu.org>; Wed, 30 Jan 2013 17:05:29 +0100 Received: (qmail invoked by alias); 30 Jan 2013 16:05:29 -0000 Received: from 62-47-60-173.adsl.highway.telekom.at (EHLO [62.47.60.173]) [62.47.60.173] by mail.gmx.net (mp029) with SMTP; 30 Jan 2013 17:05:29 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18689QF/GU61zZsYyRkDkxcCygCWg2v9d2Jcg9wOy ey5lYp+4pbcjTa Message-ID: <510944C7.2070603@gmx.at> Date: Wed, 30 Jan 2013 17:05:27 +0100 From: martin rudalics MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> <01sj5je9zi.fsf@fencepost.gnu.org> In-Reply-To: <01sj5je9zi.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13560 Cc: Jonas Bernoulli , 13560@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) > The following change seems to not break any of bug 374, 12006, 12971, > 12731, and to fix this bug; but I won't be surprised to hear that it > breaks something else... So far it works here. I'd suggest to install and port to the trunk immediately so it gets more coverage. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 30 12:18:54 2013 Received: (at 13560) by debbugs.gnu.org; 30 Jan 2013 17:18:54 +0000 Received: from localhost ([127.0.0.1]:56000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0bJF-0002tF-IU for submit@debbugs.gnu.org; Wed, 30 Jan 2013 12:18:54 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:50166) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0bJD-0002t9-Mi for 13560@debbugs.gnu.org; Wed, 30 Jan 2013 12:18:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0bIX-0002ZC-3q; Wed, 30 Jan 2013 12:18:09 -0500 From: Glenn Morris To: martin rudalics Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> <01sj5je9zi.fsf@fencepost.gnu.org> <510944C7.2070603@gmx.at> X-Spook: Project Monarch Ermes enemy of the state Noriega X-Ran: ,lM6 (martin rudalics's message of "Wed, 30 Jan 2013 17:05:27 +0100") Message-ID: <1ck3qutwrz.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 13560 Cc: Jonas Bernoulli , 13560@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) martin rudalics wrote: > So far it works here. I'd suggest to install and port to the trunk > immediately so it gets more coverage. Done. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 30 12:46:01 2013 Received: (at control) by debbugs.gnu.org; 30 Jan 2013 17:46:02 +0000 Received: from localhost ([127.0.0.1]:56022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0bjT-0004Vn-TB for submit@debbugs.gnu.org; Wed, 30 Jan 2013 12:46:01 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:50904) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0bjO-0004V8-AO for control@debbugs.gnu.org; Wed, 30 Jan 2013 12:45:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0bim-0008UM-AA for control@debbugs.gnu.org; Wed, 30 Jan 2013 12:45:16 -0500 Date: Wed, 30 Jan 2013 12:45:16 -0500 Message-Id: Subject: control message for bug 13560 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) close 13560 24.2.93 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 30 14:28:52 2013 Received: (at 13560) by debbugs.gnu.org; 30 Jan 2013 19:28:52 +0000 Received: from localhost ([127.0.0.1]:56180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0dL2-0000n3-0E for submit@debbugs.gnu.org; Wed, 30 Jan 2013 14:28:52 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:44000) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0dL0-0000mv-2Z for 13560@debbugs.gnu.org; Wed, 30 Jan 2013 14:28:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="47839" Received: from 184-175-13-222.dsl.teksavvy.com (HELO ceviche.home) ([184.175.13.222]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jan 2013 14:28:11 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 6046766130; Wed, 30 Jan 2013 14:28:11 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken Message-ID: References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> <01sj5je9zi.fsf@fencepost.gnu.org> Date: Wed, 30 Jan 2013 14:28:11 -0500 In-Reply-To: <01sj5je9zi.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 29 Jan 2013 20:27:13 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13560 Cc: Jonas Bernoulli , 13560@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > The following change seems to not break any of bug 374, 12006, 12971, > 12731, and to fix this bug; but I won't be surprised to hear that it > breaks something else... Sounds better than what we have now. Stefan "who hates unread-command-events" From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 31 11:05:01 2013 Received: (at 13560) by debbugs.gnu.org; 31 Jan 2013 16:05:01 +0000 Received: from localhost ([127.0.0.1]:57818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0wdI-00024g-GT for submit@debbugs.gnu.org; Thu, 31 Jan 2013 11:05:01 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:47262) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0wdF-00024Y-R1 for 13560@debbugs.gnu.org; Thu, 31 Jan 2013 11:04:58 -0500 Received: by mail-wi0-f172.google.com with SMTP id o1so4985178wic.17 for <13560@debbugs.gnu.org>; Thu, 31 Jan 2013 08:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:user-agent :in-reply-to:date:message-id:mime-version:content-type; bh=Zu0EyHUjkMRBtH9tTXfazyNuhuI9z9dkQ2Fy5wkFSHw=; b=YhC8v7Im9wc+4+gGQsp19AjEL/WJ+YkvnDbKtkR+NYCQBXe8KgJk5PqgVjZfFG3sTK KbVN79/xicwWjchmGOq1GK6ld9qCN/r2vn1JJIXuN/88aYDd8UFFycn8lqctVQOIU19n piLOmSMEBotsk9H37jibGOYkoJ2SukMnH4bl+bHCxc4hLgmpybegZQqL34ws7Ve1zZui eSon6lewjGZ8wpAq4k7UxsUZ7eCVpcpYyIssHcUPetjA4jgWhPsuxsELeHY9Sv04GInX 7xciJRPXhG/8bOqTSj8AWUsKfcxEyv1edz4eluMXj9Ra4cJphPTpagrtHxx2kjnItDCF Ifzg== X-Received: by 10.180.93.133 with SMTP id cu5mr16052270wib.32.1359648252934; Thu, 31 Jan 2013 08:04:12 -0800 (PST) Received: from lem (178-83-148-119.dynamic.hispeed.ch. [178.83.148.119]) by mx.google.com with ESMTPS id t17sm10185074wiv.6.2013.01.31.08.04.11 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 31 Jan 2013 08:04:12 -0800 (PST) From: Jonas Bernoulli To: "Glenn Morris" Subject: Re: bug#13560: 24.2.92; tabulated-list header buttons are broken References: <878v7fvls0.fsf@bernoul.li> <4vtxq35od5.fsf@fencepost.gnu.org> <01sj5je9zi.fsf@fencepost.gnu.org> <510944C7.2070603@gmx.at> <1ck3qutwrz.fsf@fencepost.gnu.org> User-agent: mu4e 0.9.9.5-dev6; emacs 24.3.50.1 In-reply-to: <1ck3qutwrz.fsf@fencepost.gnu.org> Date: Thu, 31 Jan 2013 17:04:10 +0100 Message-ID: <87sj5hl4p1.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 13560 Cc: 13560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Glenn Morris writes: > martin rudalics wrote: > >> So far it works here. I'd suggest to install and port to the trunk >> immediately so it gets more coverage. > > Done. Thanks a lot! From unknown Tue Sep 09 22:00:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Mar 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator