From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Lars Ljung Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jan 2013 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13547@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13591061905907 (code B ref -1); Fri, 25 Jan 2013 09:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2013 09:29:50 +0000 Received: from localhost ([127.0.0.1]:48642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tyfba-0001XD-6m for submit@debbugs.gnu.org; Fri, 25 Jan 2013 04:29:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47796) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyfbX-0001X6-8b for submit@debbugs.gnu.org; Fri, 25 Jan 2013 04:29:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyfbI-0002s5-JJ for submit@debbugs.gnu.org; Fri, 25 Jan 2013 04:29:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyfbI-0002s1-Gl for submit@debbugs.gnu.org; Fri, 25 Jan 2013 04:29:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyfbB-0000Zc-E9 for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2013 04:29:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tyfb5-0002pn-42 for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2013 04:29:25 -0500 Received: from mail2.surf-town.net ([212.97.132.42]:54595 helo=mailgw14.surf-town.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tyfb4-0002pW-Sj for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2013 04:29:19 -0500 Received: by mailgw14.surf-town.net (Postfix, from userid 65534) id CA7EE3E314; Fri, 25 Jan 2013 10:29:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailgw14.surf-town.net (Postfix) with ESMTP id B3EB33E0BA for ; Fri, 25 Jan 2013 10:29:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mailgw14.surf-town.net Received: from mailgw14.surf-town.net ([127.0.0.1]) by localhost (mailgw14.surf-town.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Jl6SwPZHHaQO for ; Fri, 25 Jan 2013 10:29:13 +0100 (CET) Received: from [192.168.0.101] (c80-216-222-115.bredband.comhem.se [80.216.222.115]) by mailgw14.surf-town.net (Postfix) with ESMTPSA id CE2033E324 for ; Fri, 25 Jan 2013 10:29:12 +0100 (CET) Message-ID: <51025067.7070204@matholka.se> Date: Fri, 25 Jan 2013 10:29:11 +0100 From: Lars Ljung User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) Hi, The functions vc-svn-previous-revision and vc-svn-next-revision just add or subtract 1 from the revision number. The is usually not correct. This patch uses "svn log" to get the correct previous/next revision of the file. Kind regards, Lars Ljung === modified file 'lisp/vc/vc-svn.el' *** lisp/vc/vc-svn.el 2013-01-02 16:13:04 +0000 --- lisp/vc/vc-svn.el 2013-01-25 08:26:53 +0000 *************** RESULT is a list of conses (FILE . STATE *** 259,279 **** ;; works just fine. (defun vc-svn-previous-revision (file rev) ! (let ((newrev (1- (string-to-number rev)))) ! (when (< 0 newrev) ! (number-to-string newrev)))) (defun vc-svn-next-revision (file rev) ! (let ((newrev (1+ (string-to-number rev)))) ! ;; The "working revision" is an uneasy conceptual fit under Subversion; ! ;; we use it as the upper bound until a better idea comes along. If the ! ;; workfile version W coincides with the tree's latest revision R, then ! ;; this check prevents a "no such revision: R+1" error. Otherwise, it ! ;; inhibits showing of W+1 through R, which could be considered anywhere ! ;; from gracious to impolite. ! (unless (< (string-to-number (vc-file-getprop file 'vc-working-revision)) ! newrev) ! (number-to-string newrev)))) ;;; --- 259,280 ---- ;; works just fine. (defun vc-svn-previous-revision (file rev) ! (with-temp-buffer ! (vc-svn-command t 0 file "log" "-q" "--limit" "2" ! (format "-r%s:1" rev)) ! (let ((revision-list '())) ! (while (re-search-backward "^r\\([0-9]+\\)" nil t) ! (setq revision-list (cons (match-string 1) revision-list))) ! (cadr revision-list)))) (defun vc-svn-next-revision (file rev) ! (with-temp-buffer ! (vc-svn-command t 0 file "log" "-q" "--limit" "2" ! (format "-r%s:HEAD" rev)) ! (let ((revision-list '())) ! (while (re-search-backward "^r\\([0-9]+\\)" nil t) ! (setq revision-list (cons (match-string 1) revision-list))) ! (cadr revision-list)))) ;;; From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 02:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ljung Cc: 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.135925346410557 (code B ref 13547); Sun, 27 Jan 2013 02:25:01 +0000 Received: (at 13547) by debbugs.gnu.org; 27 Jan 2013 02:24:24 +0000 Received: from localhost ([127.0.0.1]:50908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzHuy-0002kD-GH for submit@debbugs.gnu.org; Sat, 26 Jan 2013 21:24:24 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54460) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzHuw-0002k5-BW for 13547@debbugs.gnu.org; Sat, 26 Jan 2013 21:24:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzHue-0001N6-4h; Sat, 26 Jan 2013 21:24:04 -0500 From: Glenn Morris References: <51025067.7070204@matholka.se> X-Spook: anarchy John Kerry subversive CID Plame import Ron Brown X-Ran: jrH"QS_g)DK;Sf\H^/?i{a|f'x"5#y|(^cGnj!znrS{Jc_g=}DNid"RaY<|V,A|:_AqGt8 X-Hue: green X-Attribution: GM Date: Sat, 26 Jan 2013 21:24:03 -0500 In-Reply-To: <51025067.7070204@matholka.se> (Lars Ljung's message of "Fri, 25 Jan 2013 10:29:11 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Lars Ljung wrote: > The functions vc-svn-previous-revision and vc-svn-next-revision just add > or subtract 1 from the revision number. The is usually not correct. > > This patch uses "svn log" to get the correct previous/next revision of > the file. Thanks. I guess the drawback here is, that will contact the svn repository, which may be on a remote server, so could be slow. It seems this is used by vc-annotate, vc-rollback, and vc-diff. From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Lars Ljung Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.135928639432591 (code B ref 13547); Sun, 27 Jan 2013 11:34:01 +0000 Received: (at 13547) by debbugs.gnu.org; 27 Jan 2013 11:33:14 +0000 Received: from localhost ([127.0.0.1]:51122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzQU5-0008Tb-Jm for submit@debbugs.gnu.org; Sun, 27 Jan 2013 06:33:14 -0500 Received: from mail16.surf-town.net ([212.97.132.56]:53675 helo=mailgw21.surf-town.net) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzQU3-0008TT-AU for 13547@debbugs.gnu.org; Sun, 27 Jan 2013 06:33:12 -0500 Received: by mailgw21.surf-town.net (Postfix, from userid 65534) id 22D32403F; Sun, 27 Jan 2013 12:32:51 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailgw21.surf-town.net (Postfix) with ESMTP id 0CBE84068; Sun, 27 Jan 2013 12:32:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mailgw21.surf-town.net X-Spam-Flag: NO X-Spam-Score: -1.44 X-Spam-Level: X-Spam-Status: No, score=-1.44 tagged_above=-999 required=7 tests=[ALL_TRUSTED=-1.44] autolearn=disabled Received: from mailgw21.surf-town.net ([127.0.0.1]) by localhost (mailgw21.surf-town.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qDMp5D1l+qcw; Sun, 27 Jan 2013 12:32:48 +0100 (CET) Received: from [192.168.0.101] (c80-216-222-115.bredband.comhem.se [80.216.222.115]) by mailgw21.surf-town.net (Postfix) with ESMTPSA id 972E3403F; Sun, 27 Jan 2013 12:32:47 +0100 (CET) Message-ID: <5105105F.9040500@matholka.se> Date: Sun, 27 Jan 2013 12:32:47 +0100 From: Lars Ljung User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 References: <51025067.7070204@matholka.se> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) 2013-01-27 03:24, Glenn Morris skrev: > Thanks. I guess the drawback here is, that will contact the svn > repository, which may be on a remote server, so could be slow. > > It seems this is used by vc-annotate, vc-rollback, and vc-diff. Yes, it will be slower. But as far as I know there is no other way to get the previous/next revision of a file. I suppose the output from an unlimited "svn log" could be saved to speed up future operations. vc-annotate-warp-revision might actually call these functions multiple times. vc-rollback is not supported by the svn backend. I don'f fully understand how vc-diff works, but these functions are not called for "C-x v =". This is good since that operation should not require server access at all. vc-annotate-show-diff-revision-at-line calls vc-svn-previous-revision. In that case the server will be contacted twice for no good reason, a simple "svn diff -r rev" would suffice (isn't this true for all backends?). vc-annotate-show-changeset-diff-revision-at-line calls vc-svn-previous-revision with filename set to nil. It that case it makes sense to return rev-1. The modified patch below takes care of that. === modified file 'lisp/vc/vc-svn.el' *** lisp/vc/vc-svn.el 2013-01-02 16:13:04 +0000 --- lisp/vc/vc-svn.el 2013-01-27 11:04:07 +0000 *************** *** 259,279 **** ;; works just fine. (defun vc-svn-previous-revision (file rev) ! (let ((newrev (1- (string-to-number rev)))) ! (when (< 0 newrev) ! (number-to-string newrev)))) (defun vc-svn-next-revision (file rev) ! (let ((newrev (1+ (string-to-number rev)))) ! ;; The "working revision" is an uneasy conceptual fit under Subversion; ! ;; we use it as the upper bound until a better idea comes along. If the ! ;; workfile version W coincides with the tree's latest revision R, then ! ;; this check prevents a "no such revision: R+1" error. Otherwise, it ! ;; inhibits showing of W+1 through R, which could be considered anywhere ! ;; from gracious to impolite. ! (unless (< (string-to-number (vc-file-getprop file 'vc-working-revision)) ! newrev) ! (number-to-string newrev)))) ;;; --- 259,286 ---- ;; works just fine. (defun vc-svn-previous-revision (file rev) ! (if file ! (with-temp-buffer ! (let (process-file-side-effects) ! (vc-svn-command t 0 file "log" "-q" "--limit" "2" ! (format "-r%s:1" rev))) ! (let ((revision-list '())) ! (while (re-search-backward "^r\\([0-9]+\\)" nil t) ! (push (match-string 1) revision-list)) ! (cadr revision-list))) ! (let ((newrev (1- (string-to-number rev)))) ! (when (< 0 newrev) ! (number-to-string newrev))))) (defun vc-svn-next-revision (file rev) ! (with-temp-buffer ! (let (process-file-side-effects) ! (vc-svn-command t 0 file "log" "-q" "--limit" "2" ! (format "-r%s:HEAD" rev))) ! (let ((revision-list '())) ! (while (re-search-backward "^r\\([0-9]+\\)" nil t) ! (push (match-string 1) revision-list)) ! (cadr revision-list)))) ;;; From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 04:56:45 2021 Received: (at control) by debbugs.gnu.org; 15 Jul 2021 08:56:45 +0000 Received: from localhost ([127.0.0.1]:46796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xAj-0002oS-Lg for submit@debbugs.gnu.org; Thu, 15 Jul 2021 04:56:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xAi-0002oB-Ju for control@debbugs.gnu.org; Thu, 15 Jul 2021 04:56:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cycwf3gca1hQ6wXOXyt3gUQ30MPWp0F/B3mYpjDHrTw=; b=ORFsQ6LSXR2FF7XoUGZApXsy6d tlJtXERd7DNgF+X6EJ/a81v/zndkbBkNI64aSPNkIrW7MBn5yRDlwpgM3RTMKwearKefXbtAP7e9M RKBOiqF3o+C2bvGGdfK/g8xDBQZUD5SPLGp0hERoq7DQ086EQhSPVWqSJyWK2CsdqCQc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3xAa-0006PR-Vh for control@debbugs.gnu.org; Thu, 15 Jul 2021 10:56:39 +0200 Date: Thu, 15 Jul 2021 10:56:36 +0200 Message-Id: <87czrkkla3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13547 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 13547 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 13547 + patch quit From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jul 2021 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ljung Cc: Glenn Morris , Stefan Monnier , 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.162633968516238 (code B ref 13547); Thu, 15 Jul 2021 09:02:02 +0000 Received: (at 13547) by debbugs.gnu.org; 15 Jul 2021 09:01:25 +0000 Received: from localhost ([127.0.0.1]:46803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xFF-0004DX-5J for submit@debbugs.gnu.org; Thu, 15 Jul 2021 05:01:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xFD-00047k-1b for 13547@debbugs.gnu.org; Thu, 15 Jul 2021 05:01:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dOTjjqPeBhX72fkIo6Pl3WjAVhd3D+sOTaj7TJ/wy3k=; b=kLOqSxEyTVLYO2mj+aVR0LX8iX NrNve5Cl9Q8BOz1VY6mrYpR3nag27z8X18hdHJCfl//vNPtC84pz7ssWr4Z3zbb9Is2Nb+fLsZNhq sxgIWzDfXi1nNhEP+kroj7eCTUk06Vm4GPk2SX4HbbPIVrF/CH2D82Mbd4hepiI7SQVI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3xF3-0006Ts-Li; Thu, 15 Jul 2021 11:01:16 +0200 From: Lars Ingebrigtsen References: <51025067.7070204@matholka.se> <5105105F.9040500@matholka.se> X-Now-Playing: Bob Hund's _KlassiskBOBHUNkonsert_: "Hollywood =?UTF-8?Q?n=C3=A4sta?=" Date: Thu, 15 Jul 2021 11:01:13 +0200 In-Reply-To: <5105105F.9040500@matholka.se> (Lars Ljung's message of "Sun, 27 Jan 2013 12:32:47 +0100") Message-ID: <878s28kl2e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ljung writes: >> Thanks. I guess the drawback here is, that will contact the svn >> repository, which may be on a remote server, so could be slow. >> >> It seems this is used by vc-annotate, vc-rollback, and vc-dif [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ljung writes: >> Thanks. I guess the drawback here is, that will contact the svn >> repository, which may be on a remote server, so could be slow. >> >> It seems this is used by vc-annotate, vc-rollback, and vc-diff. > > Yes, it will be slower. But as far as I know there is no other way to > get the previous/next revision of a file. I haven't used svn in many years, so I don't have much of an opinion here. I've respun the patch for Emacs 28; included below. Anybody got an opinion here? diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el index c30920dd15..0cc7bda1ba 100644 --- a/lisp/vc/vc-svn.el +++ b/lisp/vc/vc-svn.el @@ -248,23 +248,29 @@ vc-svn-working-revision ;; vc-svn-mode-line-string doesn't exist because the default implementation ;; works just fine. -(defun vc-svn-previous-revision (_file rev) - (let ((newrev (1- (string-to-number rev)))) - (when (< 0 newrev) - (number-to-string newrev)))) +(defun vc-svn-previous-revision (file rev) + (if file + (with-temp-buffer + (let (process-file-side-effects) + (vc-svn-command t 0 file "log" "-q" "--limit" "2" + (format "-r%s:1" rev))) + (let ((revision-list '())) + (while (re-search-backward "^r\\([0-9]+\\)" nil t) + (push (match-string 1) revision-list)) + (cadr revision-list))) + (let ((newrev (1- (string-to-number rev)))) + (when (< 0 newrev) + (number-to-string newrev))))) (defun vc-svn-next-revision (file rev) - (let ((newrev (1+ (string-to-number rev)))) - ;; The "working revision" is an uneasy conceptual fit under Subversion; - ;; we use it as the upper bound until a better idea comes along. If the - ;; workfile version W coincides with the tree's latest revision R, then - ;; this check prevents a "no such revision: R+1" error. Otherwise, it - ;; inhibits showing of W+1 through R, which could be considered anywhere - ;; from gracious to impolite. - (unless (< (string-to-number (vc-file-getprop file 'vc-working-revision)) - newrev) - (number-to-string newrev)))) - + (with-temp-buffer + (let (process-file-side-effects) + (vc-svn-command t 0 file "log" "-q" "--limit" "2" + (format "-r%s:HEAD" rev))) + (let ((revision-list '())) + (while (re-search-backward "^r\\([0-9]+\\)" nil t) + (push (match-string 1) revision-list)) + (cadr revision-list)))) ;;; ;;; State-changing functions -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jul 2021 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ljung Cc: Glenn Morris , Dmitry Gutov , Stefan Monnier , 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.162764610629489 (code B ref 13547); Fri, 30 Jul 2021 11:56:02 +0000 Received: (at 13547) by debbugs.gnu.org; 30 Jul 2021 11:55:06 +0000 Received: from localhost ([127.0.0.1]:59188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9R6Y-0007fZ-H7 for submit@debbugs.gnu.org; Fri, 30 Jul 2021 07:55:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9R6W-0007ep-NY for 13547@debbugs.gnu.org; Fri, 30 Jul 2021 07:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FoOTqNEp+sW88SB8yN7cQfhw6BCnAh0voZlHtLBSaFY=; b=jElAQU/YDCoAh96GYp8vOGwYhP 2m9Q4q3gJU6qNSRTAsDhmVuRgz2VMoJ5gOmJWbL2eG4EAfoC2PLtE4YbUgygu2XljUF8Nr1y6DfQh aU6/Tz8vCX1CoxbCnjU7d02rvgrpcAEkwLOiWGn5QbYGuZ6JbC33SxHltkhTLSRAsJPo=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9R6M-00074l-N8; Fri, 30 Jul 2021 13:54:57 +0200 From: Lars Ingebrigtsen References: <51025067.7070204@matholka.se> <5105105F.9040500@matholka.se> <878s28kl2e.fsf@gnus.org> Date: Fri, 30 Jul 2021 13:54:52 +0200 In-Reply-To: <878s28kl2e.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 15 Jul 2021 11:01:13 +0200") Message-ID: <87v94snhir.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >>> Thanks. I guess the drawback here is, that will contact the svn >>> repository, which may be on a remote server, so could be slow. >>> >>> It seems this is used by vc-annotate, vc-rollback, and vc [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: >>> Thanks. I guess the drawback here is, that will contact the svn >>> repository, which may be on a remote server, so could be slow. >>> >>> It seems this is used by vc-annotate, vc-rollback, and vc-diff. >> >> Yes, it will be slower. But as far as I know there is no other way to >> get the previous/next revision of a file. > > I haven't used svn in many years, so I don't have much of an opinion > here. I've respun the patch for Emacs 28; included below. > > Anybody got an opinion here? I forgot to put Dmitry in the CCs; perhaps he'll have an opinion. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 02:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen , Lars Ljung Cc: Glenn Morris , Stefan Monnier , 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.162769924910604 (code B ref 13547); Sat, 31 Jul 2021 02:41:01 +0000 Received: (at 13547) by debbugs.gnu.org; 31 Jul 2021 02:40:49 +0000 Received: from localhost ([127.0.0.1]:33006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9evh-0002kx-2o for submit@debbugs.gnu.org; Fri, 30 Jul 2021 22:40:49 -0400 Received: from mail-ej1-f49.google.com ([209.85.218.49]:46980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9eve-0002kh-6F for 13547@debbugs.gnu.org; Fri, 30 Jul 2021 22:40:47 -0400 Received: by mail-ej1-f49.google.com with SMTP id gs8so20084933ejc.13 for <13547@debbugs.gnu.org>; Fri, 30 Jul 2021 19:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BIjBP7w9THC2AZ3jwB2Ps/YSRXkpK/s4VfUWR6x65G0=; b=JFsqoAFbRoIzcm79Uk8THzNd299EtoQnrEERT3f2jLVOq/FzvVea/S6lFqQe1HuQg/ PcBt5moihcYJQm9+713v0VdeufRK/Y9NFD0U5ScPPUPqWYxZkMLIzp4pgLZlYpEIN/s2 siQ117kB4Q8d9C7lFXpjsRAJwNtgAoYN5B5q+dbVC+oFmrk0z5RdDJYgpk1Gulz3rFUI DHb0B3kFPypm+eLFZ4ZWVHktvwHipkvZio9upbSIVT9vC3jLFWm0T5Hcs7LIntmEyAq4 dtPVf4tOERCmSatNaW3lJR+9SVt+JKaONvMn+91gjMiUtdiTu+Jk3J7/7VLDM8f8wix3 YJeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BIjBP7w9THC2AZ3jwB2Ps/YSRXkpK/s4VfUWR6x65G0=; b=WKLUupQAepTgReLsZJlHnZukSSH1PSgVh8ua7xpJ0BIwri4s5gVunIjUjHYHC6WRbT sNfCizfRqAzzvuw3twWkVAA3CEUk1MWzh6ErAjDSOpoSDEmlvy8JsTgDs+my+yP2v46+ ny/spwjB0A7ovYdMQ8111NZbdxzCyc/2LJi6xleQWRzAXEuoANFTcgRxn79nRSy2wwsg SIUKTgfFWgOwTF3sk23Io8dUs9fhIhEy4yITKdw5R6Z/tyCZy1QkCT491W9fb/nW2Vgq 18E6hNtXPc+ED/MijtfwIDltW3MnVNS68Ey9rszQ0wRo9FOVOeWMJ6ROWslP0Gnl7tX9 WPpw== X-Gm-Message-State: AOAM533Vrw4wtWOuRStlWuBpeHEo0wDELexSGur264kk7O0VzqMwQlch 9/Ak93Lg5QL7sD1j+cuZ3yg= X-Google-Smtp-Source: ABdhPJz/blWidOaaA0ykeJCZyajvfMjqIuRX9xvm+msw2rYi8RL5U9j4T59hfnXrbBE4+KT+TE9cBg== X-Received: by 2002:a17:906:405:: with SMTP id d5mr5486627eja.189.1627699240292; Fri, 30 Jul 2021 19:40:40 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id dg20sm1491713edb.13.2021.07.30.19.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 19:40:39 -0700 (PDT) References: <51025067.7070204@matholka.se> <5105105F.9040500@matholka.se> <878s28kl2e.fsf@gnus.org> <87v94snhir.fsf@gnus.org> From: Dmitry Gutov Message-ID: <265e7b3c-06c5-7fa4-81e4-0a75fea41765@yandex.ru> Date: Sat, 31 Jul 2021 05:40:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87v94snhir.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi! On 30.07.2021 14:54, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > >>>> Thanks. I guess the drawback here is, that will contact the svn >>>> repository, which may be on a remote server, so could be slow. >>>> >>>> It seems this is used by vc-annotate, vc-rollback, and vc-diff. >>> Yes, it will be slower. But as far as I know there is no other way to >>> get the previous/next revision of a file. >> I haven't used svn in many years, so I don't have much of an opinion >> here. I've respun the patch for Emacs 28; included below. >> >> Anybody got an opinion here? > I forgot to put Dmitry in the CCs; perhaps he'll have an opinion. Since this is about SVN, it's hard for me to have an opinion as well: all practical recollections are from ~10 years ago. How slow are SVN servers to respond to requests like this these days? Could someone also describe the effect that our current "not correct" revision numbers have? Do they trigger errors? Do them cause 'vc-annotate' to show wrong file contents? If it's either of these, then we probably should go ahead with the patch. From unknown Fri Sep 19 23:03:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13547: svn annotate - incorrect previous/next revision Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 19:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Glenn Morris , Lars Ljung , Stefan Monnier , 13547@debbugs.gnu.org Received: via spool by 13547-submit@debbugs.gnu.org id=B13547.164806544220343 (code B ref 13547); Wed, 23 Mar 2022 19:58:01 +0000 Received: (at 13547) by debbugs.gnu.org; 23 Mar 2022 19:57:22 +0000 Received: from localhost ([127.0.0.1]:46110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX76g-0005I3-4T for submit@debbugs.gnu.org; Wed, 23 Mar 2022 15:57:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX76e-0005Hm-AE for 13547@debbugs.gnu.org; Wed, 23 Mar 2022 15:57:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rUNIJLEaikfOgnQFEbCIHxQsRyNpVHUEG3IbScFkeik=; b=mORVQ2mKaN+vYGF9R+PRiaiomN UWnsyGsaD4qpiv4MJY2b7yb8ZvND4oeyTNkd8F9oL6sSrrufGMUPoVNfwoxSIHRQdmm21Os6a21VE eAyQfkvwLIt/SAaPHSn8meq6lbfitgMLdjuh1jCfXaR0FTyXWYkh/MFN/tKBs7uaYGo0=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX76U-0007fB-JO; Wed, 23 Mar 2022 20:57:12 +0100 From: Lars Ingebrigtsen References: <51025067.7070204@matholka.se> <5105105F.9040500@matholka.se> <878s28kl2e.fsf@gnus.org> <87v94snhir.fsf@gnus.org> <265e7b3c-06c5-7fa4-81e4-0a75fea41765@yandex.ru> Date: Wed, 23 Mar 2022 20:57:09 +0100 In-Reply-To: <265e7b3c-06c5-7fa4-81e4-0a75fea41765@yandex.ru> (Dmitry Gutov's message of "Sat, 31 Jul 2021 05:40:37 +0300") Message-ID: <874k3o788a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Since this is about SVN, it's hard for me to have an opinion as well: > all practical recollections are from ~10 years ago. How slow are SVN > servers to respond to requests like this these days? > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > Since this is about SVN, it's hard for me to have an opinion as well: > all practical recollections are from ~10 years ago. How slow are SVN > servers to respond to requests like this these days? > > Could someone also describe the effect that our current "not correct" > revision numbers have? Do they trigger errors? Do them cause > 'vc-annotate' to show wrong file contents? > > If it's either of these, then we probably should go ahead with the patch. This was half a year ago, and nobody's piped up, so I'm closing this bug report. (If somebody that uses svn wants this feature, they can resurrect the patch, probably.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 15:57:25 2022 Received: (at control) by debbugs.gnu.org; 23 Mar 2022 19:57:25 +0000 Received: from localhost ([127.0.0.1]:46113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX76j-0005IH-BY for submit@debbugs.gnu.org; Wed, 23 Mar 2022 15:57:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX76h-0005Hr-8N for control@debbugs.gnu.org; Wed, 23 Mar 2022 15:57:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=16qtng1zlNYkz67Dmk0C2W5pVGlwT53ebd1pMhRHrXo=; b=QpUNRItDej6N/r0nQWyQc0NzUl DQEMqglycMEf9/Pwz9dP9Fzjkm9maD2JLnFWUlLKqlEsWxbPexorfEaF6nxH5HB0FxNMJhZpEQJVy rKmRk4g9P6qP7TAdu76+S8Uk0mFadnzYBmeG6UYy8Qc5DPWmpv8gtHc/Dg2vx+xPG+SE=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX76Z-0007fI-S7 for control@debbugs.gnu.org; Wed, 23 Mar 2022 20:57:17 +0100 Date: Wed, 23 Mar 2022 20:57:14 +0100 Message-Id: <8735j87885.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13547 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 13547 wontfix close 13547 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 13547 wontfix close 13547 quit