From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 24 17:22:35 2013 Received: (at submit) by debbugs.gnu.org; 24 Jan 2013 22:22:35 +0000 Received: from localhost ([127.0.0.1]:48254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyVBq-0000Ci-FD for submit@debbugs.gnu.org; Thu, 24 Jan 2013 17:22:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50876) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyVBo-0000CY-28 for submit@debbugs.gnu.org; Thu, 24 Jan 2013 17:22:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyVBg-0007i1-RM for submit@debbugs.gnu.org; Thu, 24 Jan 2013 17:22:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-106.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyVBg-0007hh-NO for submit@debbugs.gnu.org; Thu, 24 Jan 2013 17:22:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyVBe-0000O3-PU for bug-guile@gnu.org; Thu, 24 Jan 2013 17:22:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyVBa-0007h1-C0 for bug-guile@gnu.org; Thu, 24 Jan 2013 17:22:22 -0500 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:14311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyV3M-0005R0-PJ for bug-guile@gnu.org; Thu, 24 Jan 2013 17:13:48 -0500 X-IronPort-AV: E=Sophos;i="4.84,532,1355094000"; d="scan'208";a="191412879" Received: from reverse-83.fdn.fr (HELO pluto) ([80.67.176.83]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 24 Jan 2013 23:13:39 +0100 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guile@gnu.org Subject: (web http) fails to parse numeric timezones in Date header X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?utf-8?Q?Pluvi=C3=B4se?= an 221 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 24 Jan 2013 23:13:39 +0100 Message-ID: <8738xqjkks.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (use-modules(web client)(web uri)) scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/")) web/http.scm:768:6: In procedure parse-asctime-date: web/http.scm:768:6: Bad Date header: Thu, 24 Jan 2013 21:53:01 +0000 --8<---------------cut here---------------end--------------->8--- RFC 1123 reads: There is a strong trend towards the use of numeric timezone indicators, and implementations SHOULD use numeric timezones instead of timezone names. However, all implementations MUST accept either notation. If timezone names are used, they MUST be exactly as defined in RFC-822. Here=E2=80=99s a tentative patch to fix it: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/module/web/http.scm b/module/web/http.scm index 216fddd..2ab5bd0 100644 --- a/module/web/http.scm +++ b/module/web/http.scm @@ -1,6 +1,6 @@ ;;; HTTP messages -;; Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc. +;; Copyright (C) 2010, 2011, 2012, 2013 Free Software Foundation, Inc. ;; This library is free software; you can redistribute it and/or ;; modify it under the terms of the GNU Lesser General Public @@ -732,6 +732,20 @@ as an ordered alist." (minute (parse-non-negative-integer str 19 21)) (second (parse-non-negative-integer str 22 24))) (make-date 0 second minute hour date month year 0))) + ((string-match? str "aaa, dd aaa dddd dd:dd:dd .0000") + (let ((date (parse-non-negative-integer str 5 7)) + (month (parse-month str 8 11)) + (year (parse-non-negative-integer str 12 16)) + (hour (parse-non-negative-integer str 17 19)) + (minute (parse-non-negative-integer str 20 22)) + (second (parse-non-negative-integer str 23 25)) + (tz (parse-non-negative-integer str 28 31)) + (tz-sign (case (string-ref str 27) + ((#\+) +1) + ((#\-) -1) + (else (bad-header 'date str) #f)))) + (make-date 0 second minute hour date month year + (* tz-sign tz)))) (else (bad-header 'date str) ; prevent tail call #f))) @@ -778,7 +792,8 @@ as an ordered alist." (make-date 0 second minute hour date month year 0))) (define (parse-date str) - (if (string-suffix? " GMT" str) + (if (or (string-suffix? " GMT" str) + (string-match "[+-][0-9]{4}$" str)) (let ((comma (string-index str #\,))) (cond ((not comma) (bad-header 'date str)) ((= comma 3) (parse-rfc-822-date str)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Problem is, this particular example has another problem: it has an extra space before the month name. How is this best addressed? Should the parser be more tolerant, possibly using plain regexps? Thanks, Ludo=E2=80=99. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 17:29:26 2013 Received: (at 13544) by debbugs.gnu.org; 7 Mar 2013 22:29:26 +0000 Received: from localhost ([127.0.0.1]:37299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDjJW-0005aq-AV for submit@debbugs.gnu.org; Thu, 07 Mar 2013 17:29:26 -0500 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:58906 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDjJT-0005aj-FM for 13544@debbugs.gnu.org; Thu, 07 Mar 2013 17:29:24 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 4CA63B5A7; Thu, 7 Mar 2013 17:28:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=kD/59j/Wekcb yKUGR3f1ttSY/1g=; b=eMFyScxjWdJqa9KidkA5y+GJ8K1hir+Ygu+7eS5tPAjT pmi1HhQE7puouSRmD//vTD+EzZOpi68KiWLmUC2T0Y0fLapNKGV1VpRgcaw2QmZT DN4fOlFxEiATI+hTTFQ0zA0pwuKtBUSdZs1CvF1ns3vLhfml9DlzIRSkc5q3bW4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=tIYJeo XFAvc8SnyskyO+vyHawXmDYZ6BNd+msTy3AjSTNMge26+kQTPCMh3WLhQ0Wf65d7 TdHzhNfvD0bP7ageNUovcZIiLkysmdZN6yaha8rSQFLS0YtWhYWpFwlyBaRBUV07 T/rk9GOSnfUBwC6yOyvn9V/wvZl/3e8HibbJE= Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 440A3B5A6; Thu, 7 Mar 2013 17:28:49 -0500 (EST) Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id BC194B5A5; Thu, 7 Mar 2013 17:28:48 -0500 (EST) From: Andy Wingo To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> Date: Thu, 07 Mar 2013 23:28:42 +0100 In-Reply-To: <8738xqjkks.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 24 Jan 2013 23:13:39 +0100") Message-ID: <87d2vac09x.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 61AA15FC-8776-11E2-9B1E-59240E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 13544 Cc: 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) On Thu 24 Jan 2013 23:13, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > scheme@(guile-user)> (use-modules(web client)(web uri)) > scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/")) > web/http.scm:768:6: In procedure parse-asctime-date: > web/http.scm:768:6: Bad Date header: Thu, 24 Jan 2013 21:53:01 +0000 As you can see here: http://pretty-rfc.herokuapp.com/RFC2616#date-time-formats HTTP doesn't actually support other time zones. The date header being reported by sqlite.org is invalid. Andy --=20 http://wingolog.org/ From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 08 20:42:35 2013 Received: (at 13544) by debbugs.gnu.org; 9 Mar 2013 01:42:35 +0000 Received: from localhost ([127.0.0.1]:40332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE8ny-0000ut-KE for submit@debbugs.gnu.org; Fri, 08 Mar 2013 20:42:34 -0500 Received: from mail-ia0-f180.google.com ([209.85.210.180]:44830) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE8nv-0000ue-Qu for 13544@debbugs.gnu.org; Fri, 08 Mar 2013 20:42:32 -0500 Received: by mail-ia0-f180.google.com with SMTP id f27so2008758iae.39 for <13544@debbugs.gnu.org>; Fri, 08 Mar 2013 17:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=Wxt5dkf6EBJD/l4ebrAVmRDbdogeg5cJKRuUJtmHzTw=; b=bUZk5Cu21wS04XevO8UX2fEH7iORO3/r3+nqEBiF4YcqbJN57d+de16p5Py69NAeVq ZO6B8LYzy2xvRemv6MLlrSUFga3DPb57uNtwlwJdmho67dS/RDSUzPv+wvMMT4pnnR9k uR89i+P/cphgt3jfSV8vmlBpSxVp4PhluhmLsaGAjtqJgx+q1d6EFH+jD17lFhGgFmpz moxbFG/EyLGlH3xfcnqQIn9eYhkVaV+IbmbjIqiy5k3Of0I5aErazJ3/q3vJwL8daniT HGZdPjv63nJm7sCe1uWHpAhg+AN0reIVYKcCQQgPXWcYcLAlIdto6dnaKp/8p9fxiP9y vemg== MIME-Version: 1.0 X-Received: by 10.50.36.169 with SMTP id r9mr940959igj.96.1362793306210; Fri, 08 Mar 2013 17:41:46 -0800 (PST) Received: by 10.64.26.168 with HTTP; Fri, 8 Mar 2013 17:41:46 -0800 (PST) In-Reply-To: <87d2vac09x.fsf@pobox.com> References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> Date: Sat, 9 Mar 2013 09:41:46 +0800 Message-ID: Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header From: Daniel Hartwig To: Andy Wingo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13544 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 8 March 2013 06:28, Andy Wingo wrote: > On Thu 24 Jan 2013 23:13, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> scheme@(guile-user)> (use-modules(web client)(web uri)) >> scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/")) >> web/http.scm:768:6: In procedure parse-asctime-date: >> web/http.scm:768:6: Bad Date header: Thu, 24 Jan 2013 21:53:01 +0000 > > As you can see here: > > http://pretty-rfc.herokuapp.com/RFC2616#date-time-formats > > HTTP doesn't actually support other time zones. The date header being > reported by sqlite.org is invalid. Correct, though =E2=80=98+0000=E2=80=99 is the right time zone, just the fo= rmat is wrong (according to RFC 2616). A survey of HTTP sites I performed last year as research for another header issue in Guile showed something like 1% of those sites using the numeric timezone format, contrary to the specification. This is likely due to false reliance on RFC 1123 (quoted by Ludo in the original report), which indicates a preference for numeric timezones that are are indirectly forbidden by RFC 2616 (which states, timezone must be the string =E2=80=9CGMT=E2=80=9D) Interpretting =E2=80=98+0000=E2=80=99 timezone is sensible in a robust impl= ementation, though what to do if a numeric timezone is given other than this? Convert it to GMT is one option, since the spec. defines that the header must be in this timezone. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 08 21:09:44 2013 Received: (at 13544) by debbugs.gnu.org; 9 Mar 2013 02:09:44 +0000 Received: from localhost ([127.0.0.1]:40376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE9EG-0001cx-AP for submit@debbugs.gnu.org; Fri, 08 Mar 2013 21:09:44 -0500 Received: from mail-ie0-f178.google.com ([209.85.223.178]:46901) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UE9ED-0001ci-UJ for 13544@debbugs.gnu.org; Fri, 08 Mar 2013 21:09:43 -0500 Received: by mail-ie0-f178.google.com with SMTP id c13so2895474ieb.9 for <13544@debbugs.gnu.org>; Fri, 08 Mar 2013 18:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=w5w/HPj2EjUzmoDDwOe1iRPcIxg6WUGY6mul3xCb7Oc=; b=so31vdhrdpm+w/hopKlPfNfuoHrewUhtCx+wadgC8tYsiCLW0Xbn2Xy9zqgM5Rcvlz Uo50Z3AKNiOJTOWo2S0Xd2LcJX1U6/KpTWgoA2sAHIj3y0IdGqm5YcEcGJsTti7FfHgh XP78OJ/JYMUJaO8qDU6FD/yt1jvDiV62am5nGE21vI65QkCrDGmoRw3iIK/J5o6zLx4T Q8wD4dPco05eiUgyXHdOWJynCaGK+dcIRqiVXikeNPiji4ryeOb67k1XsRpCr0qjQLMq ef1ZuQJLVrAXqIA17C2uAucYYVJr9BcdqdMGDVk/4kXUudIfQvRGS/LSyzgiCLIN9q+0 9qbQ== MIME-Version: 1.0 X-Received: by 10.42.149.135 with SMTP id w7mr203805icv.25.1362794936092; Fri, 08 Mar 2013 18:08:56 -0800 (PST) Received: by 10.64.26.168 with HTTP; Fri, 8 Mar 2013 18:08:56 -0800 (PST) In-Reply-To: References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> Date: Sat, 9 Mar 2013 10:08:56 +0800 Message-ID: Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header From: Daniel Hartwig To: Andy Wingo Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13544 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) On 9 March 2013 09:41, Daniel Hartwig wrote: > A survey of HTTP sites I performed > last year as research for another header issue in Guile showed > something like 1% of those sites using the numeric timezone format, > contrary to the specification. Reference: . From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 03:22:40 2013 Received: (at 13544) by debbugs.gnu.org; 9 Mar 2013 08:22:40 +0000 Received: from localhost ([127.0.0.1]:40763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEF39-0001ho-Qm for submit@debbugs.gnu.org; Sat, 09 Mar 2013 03:22:40 -0500 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:42495 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEF35-0001hd-Et for 13544@debbugs.gnu.org; Sat, 09 Mar 2013 03:22:38 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id AA5DBCC7C; Sat, 9 Mar 2013 03:21:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=OvbU3iFB+1nh dK5teX1uIQp17CI=; b=hDFnlkgN2z0h0n7qmIJWXTfz2Ga5krAqi3PbtgfOVxoF HzbyaMOd/G4mlMEtrrvgqcCOONZ0FF9k+hc0vtSrOvYKcoLg0FjTrLr0HdasRpmc cAMwvWSKQq53+LHiFeP2g9lnr5YIGdG5TGt7bOW6qHCCIL2XszV5Ev5M49ppQUU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=VqA3yD Zc1zHQBYX1xPJKbcS4ZtiILxDHTwV3ao3b7G3gLlfJ65WRnIQ22eaTa2BoclLXu4 pCatgMkgKqey2NzpabhLcza29HaNZQTmLRg0iAntTe07nzuAK76w7/CXuU57/6B/ kjaoTG+F02IRQRD9dT6ZP6PhuqsNfjiPBLQ84= Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 98992CC7A; Sat, 9 Mar 2013 03:21:52 -0500 (EST) Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 102B6CC79; Sat, 9 Mar 2013 03:21:51 -0500 (EST) From: Andy Wingo To: Daniel Hartwig Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> Date: Sat, 09 Mar 2013 09:21:49 +0100 In-Reply-To: (Daniel Hartwig's message of "Sat, 9 Mar 2013 09:41:46 +0800") Message-ID: <877glh56g2.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 65603DF8-8892-11E2-AFF5-59240E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 13544 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: > Interpretting =E2=80=98+0000=E2=80=99 timezone is sensible in a robust im= plementation, Yes, I agree, this makes sense. > though what to do if a numeric timezone is given other than this? I would continue to raise an error I think. Timezones get complicated, fast, and there is little hope that we could preserve correctness. WDYT? Andy --=20 http://wingolog.org/ From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 18:51:51 2013 Received: (at 13544) by debbugs.gnu.org; 9 Mar 2013 23:51:51 +0000 Received: from localhost ([127.0.0.1]:42458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UETYN-0001OX-H1 for submit@debbugs.gnu.org; Sat, 09 Mar 2013 18:51:51 -0500 Received: from mail-ia0-f181.google.com ([209.85.210.181]:62638) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UETYJ-0001OJ-T6 for 13544@debbugs.gnu.org; Sat, 09 Mar 2013 18:51:49 -0500 Received: by mail-ia0-f181.google.com with SMTP id w33so2583134iag.12 for <13544@debbugs.gnu.org>; Sat, 09 Mar 2013 15:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=IbiRsCuhjCaVgXKQqg3IHx6Q8hq8MDOYM9Uw0U2Cs0k=; b=u2DSYUTK7VyEluqM87fwHAfYATGxHtLalKGPiSWKRLtIhcsGVYwHLtt22X2NH+S+fo Bx1ode9HSeIRy/g328YT100jqoOKYamP9N4QLPvkIy/EWZwyR5LpYqC/SHBCrFVV7A8S Mov7uBN4ve8A7cBCp99DP4KZtHuZDMlDM7O2W0XZHmhiDDi/Qh62c0Fx2f+b40XHGSi+ mochKpIMn0wq0xSLsurxZGRdoVW1br2i54fC5kwM8+xcXnRI0fCPUrzQNkTTrIhzsOH/ tcTNcRIcfGuYEUT0nd99YKirP6RAbbUmXXzSvpzYhKfhnZ/2PkMuhnlB2xYk3vyQyG7L vjxA== MIME-Version: 1.0 X-Received: by 10.50.135.105 with SMTP id pr9mr3618782igb.6.1362873056708; Sat, 09 Mar 2013 15:50:56 -0800 (PST) Received: by 10.64.26.168 with HTTP; Sat, 9 Mar 2013 15:50:56 -0800 (PST) In-Reply-To: <877glh56g2.fsf@pobox.com> References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> Date: Sun, 10 Mar 2013 07:50:56 +0800 Message-ID: Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header From: Daniel Hartwig To: Andy Wingo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13544 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On 9 March 2013 16:21, Andy Wingo wrote: > On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: > >> Interpretting =E2=80=98+0000=E2=80=99 timezone is sensible in a robust i= mplementation, > > Yes, I agree, this makes sense. > >> though what to do if a numeric timezone is given other than this? > > I would continue to raise an error I think. Timezones get complicated, > fast, and there is little hope that we could preserve correctness. > WDYT? Ok. What about Ludo's original comment, about the extra space in the sqlite header? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 10 14:32:53 2013 Received: (at 13544) by debbugs.gnu.org; 10 Mar 2013 18:32:53 +0000 Received: from localhost ([127.0.0.1]:44310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEl3D-0003CX-Qh for submit@debbugs.gnu.org; Sun, 10 Mar 2013 14:32:53 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:53699 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEl3B-0003CE-76 for 13544@debbugs.gnu.org; Sun, 10 Mar 2013 14:32:50 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 3EA41B734; Sun, 10 Mar 2013 14:31:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=jTJKaIAI3XbY swZ+aZ0jCucjTdA=; b=Cg0iJNZKTEODX7YF9qrIHGGJZXUtaBuf8yQvmOKuTMA0 Pl6WoFXhGvuLN8B5xndDTN+U7MVPZ0WJtUeScl+ajxdMfTdysUcxab4uvCZYklr4 SsC6js17DHX/nxMIFV0QaeyGMcWsNDbVwfNkl68GMks9aPGF/HiTEN1y0z0NR0E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=V/cjUX WKEqcGo0tcR/NGmyXtP4BXk2fpPlHT+fyh21VMfdRMS1HSY/JXV3EOKQ3IAQbLmZ aL197upU+iUyPM2c9ukCsotcGKyZ3POcET18padB1GHjF+6gG0TkaYCZoyX+CRIj oZNAQ8lb9qfX718lckf1nIla4kPmrX96lbrwQ= Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 37F98B733; Sun, 10 Mar 2013 14:31:59 -0400 (EDT) Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id B1061B732; Sun, 10 Mar 2013 14:31:58 -0400 (EDT) From: Andy Wingo To: Daniel Hartwig Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> Date: Sun, 10 Mar 2013 19:31:56 +0100 In-Reply-To: (Daniel Hartwig's message of "Sun, 10 Mar 2013 07:50:56 +0800") Message-ID: <87r4jnw1gj.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: CB10B35C-89B0-11E2-AAE1-59240E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: 13544 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) On Sun 10 Mar 2013 00:50, Daniel Hartwig writes: > On 9 March 2013 16:21, Andy Wingo wrote: >> On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: >> >>> Interpretting =E2=80=98+0000=E2=80=99 timezone is sensible in a robust = implementation, >> >> Yes, I agree, this makes sense. >> >>> though what to do if a numeric timezone is given other than this? >> >> I would continue to raise an error I think. Timezones get complicated, >> fast, and there is little hope that we could preserve correctness. >> WDYT? > > Ok. What about Ludo's original comment, about the extra space in the > sqlite header? Dunno. Is it common? In this particular case I would mail and try to get them to fix their server, given that it is run by hackers. Let us leave that particular issue for another bug. Andy --=20 http://wingolog.org/ From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 14 09:35:51 2013 Received: (at 13544) by debbugs.gnu.org; 14 Mar 2013 13:35:51 +0000 Received: from localhost ([127.0.0.1]:53222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG8Ju-0000wi-Lu for submit@debbugs.gnu.org; Thu, 14 Mar 2013 09:35:50 -0400 Received: from xanadu.aquilenet.fr ([88.191.123.111]:40425) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG8Jo-0000wY-Vs for 13544@debbugs.gnu.org; Thu, 14 Mar 2013 09:35:45 -0400 Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id E7BC8C51C; Thu, 14 Mar 2013 14:34:28 +0100 (CET) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0hdPuQVv2Qu; Thu, 14 Mar 2013 14:34:28 +0100 (CET) Received: from pluto (unknown [193.50.110.66]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id 9B626C184; Thu, 14 Mar 2013 14:34:28 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Andy Wingo Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> <87r4jnw1gj.fsf@pobox.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vent=C3=B4se?= an 221 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 14 Mar 2013 14:34:28 +0100 In-Reply-To: <87r4jnw1gj.fsf@pobox.com> (Andy Wingo's message of "Sun, 10 Mar 2013 19:31:56 +0100") Message-ID: <8738vyt89n.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andy Wingo skribis: > On Sun 10 Mar 2013 00:50, Daniel Hartwig writes: > >> On 9 March 2013 16:21, Andy Wingo wrote: >>> On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: >>> >>>> Interpretting ‘+0000’ timezone is sensible in a robust implementation, >>> >>> Yes, I agree, this makes sense. >>> >>>> though what to do if a numeric timezone is given other than this? >>> >>> I would continue to raise an error I think. Timezones get complicated, >>> fast, and there is little hope that we could preserve correctness. >>> WDYT? >> >> Ok. What about Ludo's original comment, about the extra space in the >> sqlite header? > > Dunno. Is it common? In this particular case I would mail and try to > get them to fix their server, given that it is run by hackers. Let us > leave that particular issue for another bug. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4988] X-Debbugs-Envelope-To: 13544 Cc: 13544@debbugs.gnu.org, Cyril Roelandt , Daniel Hartwig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) Andy Wingo skribis: > On Sun 10 Mar 2013 00:50, Daniel Hartwig writes: > >> On 9 March 2013 16:21, Andy Wingo wrote: >>> On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: >>> >>>> Interpretting =E2=80=98+0000=E2=80=99 timezone is sensible in a robust= implementation, >>> >>> Yes, I agree, this makes sense. >>> >>>> though what to do if a numeric timezone is given other than this? >>> >>> I would continue to raise an error I think. Timezones get complicated, >>> fast, and there is little hope that we could preserve correctness. >>> WDYT? >> >> Ok. What about Ludo's original comment, about the extra space in the >> sqlite header? > > Dunno. Is it common? In this particular case I would mail and try to > get them to fix their server, given that it is run by hackers. Let us > leave that particular issue for another bug. I think standards unfortunately don=E2=80=99t matter as much as usage here. Fossil=E2=80=99s web server (by the same author, I think) doesn=E2=80=99t h= ave the problem, and sqlite.org doesn=E2=80=99t have a =E2=80=98Server=E2=80=99 hea= der, so it=E2=80=99s hard to tell if it=E2=80=99s common. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 14 11:02:10 2013 Received: (at 13544) by debbugs.gnu.org; 14 Mar 2013 15:02:11 +0000 Received: from localhost ([127.0.0.1]:54181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG9fR-0003MS-R4 for submit@debbugs.gnu.org; Thu, 14 Mar 2013 11:02:10 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:59321 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UG9fM-0003Lx-3H for 13544@debbugs.gnu.org; Thu, 14 Mar 2013 11:02:05 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 038D2B0FC; Thu, 14 Mar 2013 11:00:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=L4+kkEg/6Rf8 ilJ0tn/sRP7HWXI=; b=WjPvSaLTTPRU5Lfw+rZDMo+TIYrZ7ZTJu4sJ1E/a66GI GW9p6cbqCfL11iN7mjfO5A9Bhjm26sFXVZARepmqUuPyW60jMtxLI0pHhYGyUlow B6OGAqdsfcKuZW4YGTY/fjL6ibie+upkXEMogNOO4LlT1dQNczgonQ6z1zjl+Gs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=ocZLNH XoCjOlSbmdbk4sPELFYP/s23OlAuvJEAT2AXf3II10Ie7pRO2P6grRsPnQ6eUwYT ROWTkDu74xzB7JleghEI6iLyRolRja4qbWRL/4ggGQxaFeVE9JvZ5/LwFnOpgk2Q DPnYxOdW+GYzRuY497neIPnk78JRsXPreVgRI= Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id F0170B0F7; Thu, 14 Mar 2013 11:00:47 -0400 (EDT) Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 717D5B0F1; Thu, 14 Mar 2013 11:00:47 -0400 (EDT) From: Andy Wingo To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> <87r4jnw1gj.fsf@pobox.com> <8738vyt89n.fsf@gnu.org> Date: Thu, 14 Mar 2013 16:00:44 +0100 In-Reply-To: <8738vyt89n.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 14 Mar 2013 14:34:28 +0100") Message-ID: <87ppz29gbn.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: F40D978E-8CB7-11E2-91C8-0B750E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 13544 Cc: 13544@debbugs.gnu.org, Cyril Roelandt , Daniel Hartwig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) On Thu 14 Mar 2013 14:34, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>> Ok. What about Ludo's original comment, about the extra space in the >>> sqlite header? >> >> Dunno. Is it common? In this particular case I would mail and try to >> get them to fix their server, given that it is run by hackers. Let us >> leave that particular issue for another bug. > > I think standards unfortunately don=E2=80=99t matter as much as usage her= e. It's a tradeoff. Guile's web module is not permissive; though perhaps a permissive parsing flag could make sense (one that doesn't propagate exceptions). But anyway it will never parse the whole range of crap that people put on the internet. So with nonstandard productions it's always a tradeoff. In this case the tradeoff is not worth it to me, especially given other options, but that is MHO. Andy --=20 http://wingolog.org/ From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 14 12:09:01 2013 Received: (at 13544) by debbugs.gnu.org; 14 Mar 2013 16:09:01 +0000 Received: from localhost ([127.0.0.1]:54342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGAi8-00051B-W2 for submit@debbugs.gnu.org; Thu, 14 Mar 2013 12:09:00 -0400 Received: from xanadu.aquilenet.fr ([88.191.123.111]:58721) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGAi3-00050z-3u for 13544@debbugs.gnu.org; Thu, 14 Mar 2013 12:08:55 -0400 Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id E8CF0C9AD; Thu, 14 Mar 2013 17:07:37 +0100 (CET) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CHq35AQOkbf3; Thu, 14 Mar 2013 17:07:37 +0100 (CET) Received: from pluto (unknown [193.50.110.66]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id A2570C75A; Thu, 14 Mar 2013 17:07:37 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Andy Wingo Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> <87r4jnw1gj.fsf@pobox.com> <8738vyt89n.fsf@gnu.org> <87ppz29gbn.fsf@pobox.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vent=C3=B4se?= an 221 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 14 Mar 2013 17:07:37 +0100 In-Reply-To: <87ppz29gbn.fsf@pobox.com> (Andy Wingo's message of "Thu, 14 Mar 2013 16:00:44 +0100") Message-ID: <87hakeq81i.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andy Wingo skribis: > On Thu 14 Mar 2013 14:34, ludo@gnu.org (Ludovic Courtès) writes: > >>>> Ok. What about Ludo's original comment, about the extra space in the >>>> sqlite header? >>> >>> Dunno. Is it common? In this particular case I would mail and try to >>> get them to fix their server, given that it is run by hackers. Let us >>> leave that particular issue for another bug. >> >> I think standards unfortunately don’t matter as much as usage here. > > It's a tradeoff. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-Debbugs-Envelope-To: 13544 Cc: 13544@debbugs.gnu.org, Cyril Roelandt , Daniel Hartwig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andy Wingo skribis: > On Thu 14 Mar 2013 14:34, ludo@gnu.org (Ludovic Courtès) writes: > >>>> Ok. What about Ludo's original comment, about the extra space in the >>>> sqlite header? >>> >>> Dunno. Is it common? In this particular case I would mail and try to >>> get them to fix their server, given that it is run by hackers. Let us >>> leave that particular issue for another bug. >> >> I think standards unfortunately don’t matter as much as usage here. > > It's a tradeoff. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4885] Andy Wingo skribis: > On Thu 14 Mar 2013 14:34, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >>>> Ok. What about Ludo's original comment, about the extra space in the >>>> sqlite header? >>> >>> Dunno. Is it common? In this particular case I would mail and try to >>> get them to fix their server, given that it is run by hackers. Let us >>> leave that particular issue for another bug. >> >> I think standards unfortunately don=E2=80=99t matter as much as usage he= re. > > It's a tradeoff. Yes, of course. That was a broad statement, not an argument for this particular case. I think looking at the workarounds found in software like Wget and cURL gives an idea of how far we =E2=80=9Ccould=E2=80=9D go (but perhaps they do= n=E2=80=99t have any workarounds, and instead just happen to be tolerant because they have half-baked parsers in C.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 03:10:01 2013 Received: (at 13544) by debbugs.gnu.org; 15 Mar 2013 07:10:01 +0000 Received: from localhost ([127.0.0.1]:55338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGOm6-0003P7-Ua for submit@debbugs.gnu.org; Fri, 15 Mar 2013 03:10:00 -0400 Received: from mail-ia0-f180.google.com ([209.85.210.180]:44872) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGOm3-0003Ot-GK for 13544@debbugs.gnu.org; Fri, 15 Mar 2013 03:09:57 -0400 Received: by mail-ia0-f180.google.com with SMTP id f27so2877470iae.25 for <13544@debbugs.gnu.org>; Fri, 15 Mar 2013 00:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=zSt8XXs4e0H2QR+QKYXvUFgK9egcAXb7zi36FQj6OTc=; b=gwcl/nvdeLL8INa8ZVEkX+V9V2divxQ16GBFYbfg0LwGXAIl8WV5jZ4K/ZVhWIA+Zg C8cHBAvxZQBT03rpGyYWfld8croKWHLHFIDJNZq+KfSLq8i50/KbAJB71gwr5meUI7za SXbYq1KexX+zjc5etPSTpKk34bLT8LsVKyJv++qaNQwAX6U8cY0a1Qe6/naIBipaFOYl pYpiVYh6WPEau8Uh/qUIbW7eRN0gFAJywWDCicIUIDoWCnYdhFMMnUrh3Hzb4bDz3QAP TxEHSy7UGOsNFa7j1XKRtosR9GCF1iGWcoTQV+eHW/DRBnKxyOBxLiOwA2E5QVLYESn2 z6iA== MIME-Version: 1.0 X-Received: by 10.42.149.135 with SMTP id w7mr3958535icv.25.1363331314352; Fri, 15 Mar 2013 00:08:34 -0700 (PDT) Received: by 10.64.26.168 with HTTP; Fri, 15 Mar 2013 00:08:33 -0700 (PDT) In-Reply-To: <87ppz29gbn.fsf@pobox.com> References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> <87r4jnw1gj.fsf@pobox.com> <8738vyt89n.fsf@gnu.org> <87ppz29gbn.fsf@pobox.com> Date: Fri, 15 Mar 2013 15:08:33 +0800 Message-ID: Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header From: Daniel Hartwig To: Andy Wingo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13544 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 14 March 2013 23:00, Andy Wingo wrote: > On Thu 14 Mar 2013 14:34, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >>>> Ok. What about Ludo's original comment, about the extra space in the >>>> sqlite header? >>> >>> Dunno. Is it common? In the sample data from last year there were no instances of any extra whitespace in any date-valued header. Let us consider it rare, which is enough reason to not support it. The same reasoning was applied in #10147. Otherwise, having =E2=80=98string-match?=E2=80=99 collapse whitesp= ace may be ok. Ludo=E2=80=99s patch can be applied with support for arbitrary timezones removed. On a related note, how RFC-strict is =E2=80=98valid-header?=E2=80= =99 supposed to be? At the moment it will pass a date value in any timezone. >>> In this particular case I would mail and try to >>> get them to fix their server, given that it is run by hackers. Let us >>> leave that particular issue for another bug. >> >> I think standards unfortunately don=E2=80=99t matter as much as usage he= re. > > It's a tradeoff. Guile's web module is not permissive; though perhaps a > permissive parsing flag could make sense (one that doesn't propagate > exceptions). But anyway it will never parse the whole range of crap > that people put on the internet. So with nonstandard productions it's > always a tradeoff. In this case the tradeoff is not worth it to me, > especially given other options, but that is MHO. Regards From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 03:18:31 2013 Received: (at 13544) by debbugs.gnu.org; 15 Mar 2013 07:18:31 +0000 Received: from localhost ([127.0.0.1]:55343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGOuM-0003bX-Km for submit@debbugs.gnu.org; Fri, 15 Mar 2013 03:18:31 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:48991) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGOuI-0003bI-HJ for 13544@debbugs.gnu.org; Fri, 15 Mar 2013 03:18:29 -0400 Received: by mail-ie0-f178.google.com with SMTP id c13so3961690ieb.37 for <13544@debbugs.gnu.org>; Fri, 15 Mar 2013 00:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=zmTUS94eMB1vW4H1QFVxc6T/DmG2SnhDfwUxJ/9Jcp4=; b=yzh3hmcBV9XkH5r1Hn3fPRKsNtNdV2RFQNZWzatmZKoRqZH932JdGefrJXO73GFUcL lGdY1BHbnZJKQIV9Gk42wgPSBvu45CIDTRxC6JezhsMsrsMtjRo3xr3v1/mIhRm9kgF4 uPo1bSyMeQxA58la8FsqA1FgtIfQqGHBUvLdYULAOwfwnQPNA5I0x7Q1ipuIe4nn6++1 kS6PXACWevvityeeb5D1o2hNMmYTUbOzhrSGxmthesvN0wXih7Yub9l3HL6cL0Jf/aBH 2ry3NN6HS+KV6aUCogtYyWcBlpZ0dpAiQ236dQ+RwRv9AZjGzZeXEYrQ62jHUFehwIfD G7hg== MIME-Version: 1.0 X-Received: by 10.50.135.105 with SMTP id pr9mr490840igb.6.1363331825431; Fri, 15 Mar 2013 00:17:05 -0700 (PDT) Received: by 10.64.26.168 with HTTP; Fri, 15 Mar 2013 00:17:05 -0700 (PDT) In-Reply-To: References: <8738xqjkks.fsf@gnu.org> <87d2vac09x.fsf@pobox.com> <877glh56g2.fsf@pobox.com> <87r4jnw1gj.fsf@pobox.com> <8738vyt89n.fsf@gnu.org> <87ppz29gbn.fsf@pobox.com> Date: Fri, 15 Mar 2013 15:17:05 +0800 Message-ID: Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header From: Daniel Hartwig To: Andy Wingo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13544 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 13544@debbugs.gnu.org, Cyril Roelandt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 15 March 2013 15:08, Daniel Hartwig wrote: > Ludo=E2=80=99s patch can be applied with support for arbitrary timezones > removed. Actually, Appendix C (RFC 2616) recommends converting non-GMT tz to GMT: If an HTTP header incorrectly carries a date value with a time zone other than GMT, it MUST be converted into GMT using the most conservative possible conversion. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 10:42:01 2013 Received: (at 13544) by debbugs.gnu.org; 15 Mar 2013 14:42:01 +0000 Received: from localhost ([127.0.0.1]:56503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGVpX-0006ra-Tt for submit@debbugs.gnu.org; Fri, 15 Mar 2013 10:42:01 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:64634) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGVpU-0006rF-4E for 13544@debbugs.gnu.org; Fri, 15 Mar 2013 10:41:57 -0400 Received: by mail-pb0-f53.google.com with SMTP id un1so3875838pbc.40 for <13544@debbugs.gnu.org>; Fri, 15 Mar 2013 07:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=jHGzvA4ZZhg0gam8Z0TF8pHkNSK6AS3O6u0uwMRfMKc=; b=BgiNyMY0Sx7fNdddW1Pwx4c09Mw8u5l+E+vzR3/SfI2OUfKeJUpFLstgWT+Teq+i1j Tx2U8K04tEvTbLSdMxjaAZxXUN/FjNNwXXd4hG/6YRFICEYqRxejNFDEyYS5fDQrqZ2F ihXOy8yK6C1jSB/1EWMreh8VDAwfO3nbYyz+Dazpj5DfO8PD30WKNyVAWUN8B/e0nJmp SIEP+3vPPYnrKRU4gtsxt3c+hCwWA95z/L/N5D2hagpNZZpqOOFCKFlU8B8t+fM1naQm PCAYDqutAK08ymk/vqmkoue6SQnUHzVBpb3yMUDQnFttRQ0OGa9htd2WnDSPEJLwl4Z1 GPqg== X-Received: by 10.68.222.73 with SMTP id qk9mr16635296pbc.115.1363358432690; Fri, 15 Mar 2013 07:40:32 -0700 (PDT) Received: from io ([120.156.22.79]) by mx.google.com with ESMTPS id qb10sm9067546pbb.43.2013.03.15.07.40.29 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 15 Mar 2013 07:40:31 -0700 (PDT) From: Daniel Hartwig To: 13544@debbugs.gnu.org Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header Date: Fri, 15 Mar 2013 22:40:17 +0800 Message-ID: <877gl8ohf2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13544 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --=-=-= See attached for handling of numeric time zones that may or may not be GMT. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-web-http-parse-numeric-time-zones-in-headers.patch >From 430fc9498ee08f6d06b5ec494a5d65e395c6c067 Mon Sep 17 00:00:00 2001 From: Daniel Hartwig Date: Fri, 15 Mar 2013 22:25:10 +0800 Subject: [PATCH] web http: parse numeric time zones in headers * module/web/http.scm (parse-zone-offset, normalize-date): New procedures. (parse-rfc-822-date, parse-rfc-850-date, parse-date): Update. * test-suite/tests/web-http.test ("general headers"): Add test. --- module/web/http.scm | 61 ++++++++++++++++++++++++++++++---------- test-suite/tests/web-http.test | 3 ++ 2 files changed, 49 insertions(+), 15 deletions(-) diff --git a/module/web/http.scm b/module/web/http.scm index c79d57d..975eb8e 100644 --- a/module/web/http.scm +++ b/module/web/http.scm @@ -702,29 +702,50 @@ as an ordered alist." (else (bad)))) (else (bad)))))) +;; "GMT" | "+" 4DIGIT | "-" 4DIGIT +;; +;; RFC 2616 requires date values to use "GMT", but recommends accepting +;; the others as they are commonly generated by e.g. RFC 822 sources. +(define (parse-zone-offset str start) + (let ((s (substring str start))) + (define (bad) + (bad-header-component 'zone-offset s)) + (cond + ((string=? s "GMT") + 0) + ((string-match? s ".dddd") + (let ((sign (case (string-ref s 0) + ((#\+) +1) + ((#\-) -1) + (else (bad)))) + (hours (parse-non-negative-integer s 1 3)) + (minutes (parse-non-negative-integer s 3 5))) + (* sign 60 (+ (* 60 hours) minutes)))) ; seconds east of Greenwich + (else (bad))))) + ;; RFC 822, updated by RFC 1123 ;; ;; Sun, 06 Nov 1994 08:49:37 GMT ;; 01234567890123456789012345678 ;; 0 1 2 -(define (parse-rfc-822-date str) +(define (parse-rfc-822-date str space zone-offset) ;; We could verify the day of the week but we don't. - (cond ((string-match? str "aaa, dd aaa dddd dd:dd:dd GMT") + (cond ((string-match? (substring str 0 space) "aaa, dd aaa dddd dd:dd:dd") (let ((date (parse-non-negative-integer str 5 7)) (month (parse-month str 8 11)) (year (parse-non-negative-integer str 12 16)) (hour (parse-non-negative-integer str 17 19)) (minute (parse-non-negative-integer str 20 22)) (second (parse-non-negative-integer str 23 25))) - (make-date 0 second minute hour date month year 0))) - ((string-match? str "aaa, d aaa dddd dd:dd:dd GMT") + (make-date 0 second minute hour date month year zone-offset))) + ((string-match? (substring str 0 space) "aaa, d aaa dddd dd:dd:dd") (let ((date (parse-non-negative-integer str 5 6)) (month (parse-month str 7 10)) (year (parse-non-negative-integer str 11 15)) (hour (parse-non-negative-integer str 16 18)) (minute (parse-non-negative-integer str 19 21)) (second (parse-non-negative-integer str 22 24))) - (make-date 0 second minute hour date month year 0))) + (make-date 0 second minute hour date month year zone-offset))) (else (bad-header 'date str) ; prevent tail call #f))) @@ -733,10 +754,10 @@ as an ordered alist." ;; Sunday, 06-Nov-94 08:49:37 GMT ;; 0123456789012345678901 ;; 0 1 2 -(define (parse-rfc-850-date str comma) +(define (parse-rfc-850-date str comma space zone-offset) ;; We could verify the day of the week but we don't. - (let ((tail (substring str (1+ comma)))) - (if (not (string-match? tail " dd-aaa-dd dd:dd:dd GMT")) + (let ((tail (substring str (1+ comma) space))) + (if (not (string-match? tail " dd-aaa-dd dd:dd:dd")) (bad-header 'date str)) (let ((date (parse-non-negative-integer tail 1 3)) (month (parse-month tail 4 7)) @@ -750,7 +771,7 @@ as an ordered alist." (cond ((< (+ then 50) now) (+ then 100)) ((< (+ now 50) then) (- then 100)) (else then))) - 0)))) + zone-offset)))) ;; ANSI C's asctime() format ;; Sun Nov 6 08:49:37 1994 @@ -770,13 +791,23 @@ as an ordered alist." (second (parse-non-negative-integer str 17 19))) (make-date 0 second minute hour date month year 0))) +;; Convert all date values to GMT time zone, as per RFC 2616 appendix C. +(define (normalize-date date) + (if (zero? (date-zone-offset date)) + date + (time-utc->date (date->time-utc date) 0))) + (define (parse-date str) - (if (string-suffix? " GMT" str) - (let ((comma (string-index str #\,))) - (cond ((not comma) (bad-header 'date str)) - ((= comma 3) (parse-rfc-822-date str)) - (else (parse-rfc-850-date str comma)))) - (parse-asctime-date str))) + (let* ((space (string-rindex str #\space)) + (zone-offset (and space (false-if-exception + (parse-zone-offset str (1+ space)))))) + (normalize-date + (if zone-offset + (let ((comma (string-index str #\,))) + (cond ((not comma) (bad-header 'date str)) + ((= comma 3) (parse-rfc-822-date str space zone-offset)) + (else (parse-rfc-850-date str comma space zone-offset)))) + (parse-asctime-date str))))) (define (write-date date port) (define (display-digits n digits port) diff --git a/test-suite/tests/web-http.test b/test-suite/tests/web-http.test index 97f5559..0baa6ab 100644 --- a/test-suite/tests/web-http.test +++ b/test-suite/tests/web-http.test @@ -109,6 +109,9 @@ (pass-if-parse date "Tue, 15 Nov 1994 08:12:31 GMT" (string->date "Tue, 15 Nov 1994 08:12:31 +0000" "~a, ~d ~b ~Y ~H:~M:~S ~z")) + (pass-if-parse date "Tue, 15 Nov 1994 16:12:31 +0800" + (string->date "Tue, 15 Nov 1994 08:12:31 +0000" + "~a, ~d ~b ~Y ~H:~M:~S ~z")) (pass-if-parse date "Wed, 7 Sep 2011 11:25:00 GMT" (string->date "Wed, 7 Sep 2011 11:25:00 +0000" "~a,~e ~b ~Y ~H:~M:~S ~z")) -- 1.7.10.4 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 19:06:14 2013 Received: (at 13544) by debbugs.gnu.org; 15 Mar 2013 23:06:14 +0000 Received: from localhost ([127.0.0.1]:56906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGdhU-0002Io-O1 for submit@debbugs.gnu.org; Fri, 15 Mar 2013 19:06:13 -0400 Received: from xanadu.aquilenet.fr ([88.191.123.111]:42072) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGdhM-0002IY-QC for 13544@debbugs.gnu.org; Fri, 15 Mar 2013 19:06:07 -0400 Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id B4147C8DE; Sat, 16 Mar 2013 00:04:43 +0100 (CET) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jpb+JL-YtivI; Sat, 16 Mar 2013 00:04:43 +0100 (CET) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id 0EA5FC407; Sat, 16 Mar 2013 00:04:42 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Daniel Hartwig Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <877gl8ohf2.fsf@gmail.com> Date: Sat, 16 Mar 2013 00:04:42 +0100 In-Reply-To: <877gl8ohf2.fsf@gmail.com> (Daniel Hartwig's message of "Fri, 15 Mar 2013 22:40:17 +0800") Message-ID: <87mwu4tgc5.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Daniel Hartwig skribis: > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New > procedures. > (parse-rfc-822-date, parse-rfc-850-date, parse-date): Update. > * test-suite/tests/web-http.test ("general headers"): Add test. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4835] X-Debbugs-Envelope-To: 13544 Cc: 13544@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) Daniel Hartwig skribis: > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New > procedures. > (parse-rfc-822-date, parse-rfc-850-date, parse-date): Update. > * test-suite/tests/web-http.test ("general headers"): Add test. Looks good to me. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 11:27:42 2013 Received: (at 13544-done) by debbugs.gnu.org; 27 Mar 2013 15:27:43 +0000 Received: from localhost ([127.0.0.1]:47706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsGM-0000wd-KE for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:27:42 -0400 Received: from xanadu.aquilenet.fr ([88.191.123.111]:47369) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsGJ-0000wU-EZ for 13544-done@debbugs.gnu.org; Wed, 27 Mar 2013 11:27:40 -0400 Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 51D90A092; Wed, 27 Mar 2013 16:25:13 +0100 (CET) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N7ACuKPYP9Pn; Wed, 27 Mar 2013 16:25:13 +0100 (CET) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id E0B1C961D; Wed, 27 Mar 2013 16:25:12 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Daniel Hartwig Subject: Re: bug#13544: (web http) fails to parse numeric timezones in Date header References: <8738xqjkks.fsf@gnu.org> <877gl8ohf2.fsf@gmail.com> Date: Wed, 27 Mar 2013 16:25:12 +0100 In-Reply-To: <877gl8ohf2.fsf@gmail.com> (Daniel Hartwig's message of "Fri, 15 Mar 2013 22:40:17 +0800") Message-ID: <87620csw4n.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Daniel Hartwig skribis: >>From 430fc9498ee08f6d06b5ec494a5d65e395c6c067 Mon Sep 17 00:00:00 2001 > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New > procedures. > (parse-rfc-822-date, parse-rfc-850-date, parse-date): Update. > * test-suite/tests/web-http.test ("general headers"): Add test. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4987] X-Debbugs-Envelope-To: 13544-done Cc: 13544-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) Daniel Hartwig skribis: >>>From 430fc9498ee08f6d06b5ec494a5d65e395c6c067 Mon Sep 17 00:00:00 2001 > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New > procedures. > (parse-rfc-822-date, parse-rfc-850-date, parse-date): Update. > * test-suite/tests/web-http.test ("general headers"): Add test. I=E2=80=99ve pushed the patch, so I guess we can close this bug now. Thanks! Ludo=E2=80=99. From unknown Wed Aug 20 03:37:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Apr 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator