From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 24 15:33:03 2013 Received: (at submit) by debbugs.gnu.org; 24 Jan 2013 20:33:03 +0000 Received: from localhost ([127.0.0.1]:48194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyTTq-00057c-Nn for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:33:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51805) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyTTn-00057F-Ts for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:33:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyTTh-0006aZ-M0 for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:32:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTh-0006aV-JL for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:32:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTc-0004DF-Cx for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyTTV-0006XW-SR for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:48 -0500 Received: from mail-ee0-f48.google.com ([74.125.83.48]:45342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTV-0006Wi-KO for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:41 -0500 Received: by mail-ee0-f48.google.com with SMTP id t10so4941806eei.35 for ; Thu, 24 Jan 2013 12:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=eLoEtHobSTQqT1u9/EDVHVfdEII62WuAEGpedmCKPho=; b=epiYg7CT85RXPPEhfrao580tC8TfP88jkLm6Pz0vSE31MOQuadGYJR/TLu+jWW+plg cZE1nZHo/D9TTgaqGNjDkjAkC+ZDbNoZ5RHsTd9L3+NjVtU6SzLujBTQ55XXa205awal eU1WSbTQWwi+EaQenhohAvtvTuEPPsq9xSVN1zYobrxruxESphtq2Rdg7uA5R+V/FLo8 Uhj84P/vTAyCxX0nVpKHSV0BdOb/sbJUTYNN021qQf1ANRr6V2rJCnPEcVvnwh0bMslc 30SRfpVpoHTQsUEP4g98cKNAMOZ5nXo7FeA0c1w8pRfgnMYYLv1lgqjpaCExDaKKXd2m ZnsQ== X-Received: by 10.14.223.135 with SMTP id v7mr9697838eep.41.1359059559331; Thu, 24 Jan 2013 12:32:39 -0800 (PST) Received: from desktop ([37.229.4.200]) by mx.google.com with ESMTPS id q5sm21767432eeo.17.2013.01.24.12.32.37 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Jan 2013 12:32:38 -0800 (PST) From: Oleksandr Gavenko To: bug-gnu-emacs@gnu.org Subject: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Date: Thu, 24 Jan 2013 22:32:35 +0200 Message-ID: <878v7i1fvg.fsf@gavenkoa.example.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --=-=-= Content-Type: text/plain In GNU Emacs 24.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.10) of 2012-09-09 on trouble, modified by Debian 'should' from lisp/emacs-lisp/ert.el fail to create character from number, for example evaluate one of these expressions: (should (equal #x1000000 1)) (should (equal 1 -1)) Problem come from "?%c" in: (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (typecase x (fixnum (list x (format "#x%x" x) (format "?%c" x))) (t x))) Another problem from (format "?%c" x) is performance penalty when "x" is rare character code (font library intensively scan for missing character glyph among all system available fonts causing 5 second delay and 100% hard disk usage). I recommend remove formatting to character as amount of problems are larger then amount of benefits. I discover this issue when start write tests for low level binary parsing library (ASN.1). --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: ert--explain-format-atom.patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-12-19 13:01:16 +0000 +++ lisp/ChangeLog 2013-01-24 20:29:45 +0000 @@ -1,3 +1,10 @@ +2013-01-24 Oleksandr Gavenko + + * ert.el (ert--explain-format-atom): Delete formating into + character due to performance issue on attempts to find font glyph + for rare used character and impossibility handle negative or large + numbers. + 2012-12-19 Michael Albinus * net/tramp-sh.el (tramp-sh-handle-file-acl): Delete empty lines === modified file 'lisp/emacs-lisp/ert.el' --- lisp/emacs-lisp/ert.el 2012-11-23 03:26:09 +0000 +++ lisp/emacs-lisp/ert.el 2013-01-24 20:21:48 +0000 @@ -568,7 +568,7 @@ (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x - (fixnum (list x (format "#x%x" x) (format "?%c" x))) + (fixnum (list x (format "#x%x" x))) (t x))) (defun ert--explain-equal-rec (a b) --=-=-= Content-Type: text/plain -- Best regards! --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 04 02:50:16 2013 Received: (at 13543) by debbugs.gnu.org; 4 Feb 2013 07:50:16 +0000 Received: from localhost ([127.0.0.1]:35122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2Gof-0002AD-OE for submit@debbugs.gnu.org; Mon, 04 Feb 2013 02:50:16 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:38558) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2God-0002A5-3m for 13543@debbugs.gnu.org; Mon, 04 Feb 2013 02:50:12 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U2GnZ-000390-Re; Mon, 04 Feb 2013 02:49:05 -0500 From: Glenn Morris To: Oleksandr Gavenko Subject: Re: bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers References: <878v7i1fvg.fsf@gavenkoa.example.com> X-Spook: Pine Gap bootleg enemy of the state Lexis-Nexis MIT-LL X-Ran: `ZY?EYl7U}2ZI1@CfEnS=&!yt%fWoX32z:;~{bBQT>7L\8"h"hptmh4Gq&Y1V'sVr2(Q_& X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 04 Feb 2013 02:49:05 -0500 In-Reply-To: <878v7i1fvg.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Thu, 24 Jan 2013 22:32:35 +0200") Message-ID: <8gmwvktt72.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 13543 Cc: 13543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Oleksandr Gavenko wrote: > 'should' from lisp/emacs-lisp/ert.el fail to create character from > number, for example evaluate one of these expressions: > > (should (equal #x1000000 1)) > (should (equal 1 -1)) I can see some usefulness to printing the character form for something like (should (equal ?a ?b)) so I installed this change: *************** *** 568,574 **** (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x ! (fixnum (list x (format "#x%x" x) (format "?%c" x))) (t x))) (defun ert--explain-equal-rec (a b) --- 568,575 ---- (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x ! (character (list x (format "#x%x" x) (format "?%c" x))) ! (fixnum (list x (format "#x%x" x))) (t x))) (defun ert--explain-equal-rec (a b) > Another problem from (format "?%c" x) is performance penalty when "x" > is rare character code (font library intensively scan for missing > character glyph among all system available fonts causing 5 second > delay and 100% hard disk usage). This seems like a general issue rather than an ERT one. > I recommend remove formatting to character as amount of problems are > larger then amount of benefits. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 04 10:34:56 2013 Received: (at 13543) by debbugs.gnu.org; 4 Feb 2013 15:34:56 +0000 Received: from localhost ([127.0.0.1]:36142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2O4N-0000Es-Ce for submit@debbugs.gnu.org; Mon, 04 Feb 2013 10:34:55 -0500 Received: from mail-ee0-f52.google.com ([74.125.83.52]:56120) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2O4L-0000Ek-58 for 13543@debbugs.gnu.org; Mon, 04 Feb 2013 10:34:53 -0500 Received: by mail-ee0-f52.google.com with SMTP id b15so3172289eek.11 for <13543@debbugs.gnu.org>; Mon, 04 Feb 2013 07:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=nSht8G/5nrn08cpmpdD39inrPk4YEW+PfveNQscYK8k=; b=AEnqhgE7NoGJ20e0BNWZzv3S7uxQQkD+TUKBbTI6jmUWI116sR4HFvQE8GifrJ1rm9 5uPujnAhbXnT2KgDS8DrCaApYq+HEz7A/ZBrDQPodt2S1G7ujfm8NWsWYbaGoexMbZDn tC3/mIwTD2QW67szFY3EBcw8vOBsRHgMy71CprwGuC2/HihwNYTPFmWA4YKsM173qahF tkKWao/prEp4EF1nR88Tyiy0XvpACdC/+WuGDPgPpCvlDHbOMslB+9B6eVvgCA4mkvre cvLZ3Vhr2wQ0YatI9EuCczSmMZmnEzgLIm7WEpN7OV38BA23hBoITN/1Mn1D7zq/cB1e IM2w== X-Received: by 10.14.4.194 with SMTP id 42mr73493889eej.35.1359992027092; Mon, 04 Feb 2013 07:33:47 -0800 (PST) Received: from desktop ([37.229.4.200]) by mx.google.com with ESMTPS id a1sm2506791eep.2.2013.02.04.07.33.45 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 04 Feb 2013 07:33:45 -0800 (PST) From: Oleksandr Gavenko To: Glenn Morris Subject: Re: bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Organization: Oleksandr Gavenko , http://gavenkoa.users.sf.net References: <878v7i1fvg.fsf@gavenkoa.example.com> <8gmwvktt72.fsf@fencepost.gnu.org> Date: Mon, 04 Feb 2013 17:33:43 +0200 In-Reply-To: <8gmwvktt72.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 04 Feb 2013 02:49:05 -0500") Message-ID: <87boc0drfs.fsf@gavenkoa.example.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13543 Cc: 13543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-02-04, Glenn Morris wrote: >> 'should' from lisp/emacs-lisp/ert.el fail to create character from >> number, for example evaluate one of these expressions: >> >> (should (equal #x1000000 1)) >> (should (equal 1 -1)) > > I can see some usefulness to printing the character form for something > like > > (should (equal ?a ?b)) > > so I installed this change: > > *************** > *** 568,574 **** > (defun ert--explain-format-atom (x) > "Format the atom X for `ert--explain-equal'." > (cl-typecase x > ! (fixnum (list x (format "#x%x" x) (format "?%c" x))) > (t x))) > > (defun ert--explain-equal-rec (a b) > --- 568,575 ---- > (defun ert--explain-format-atom (x) > "Format the atom X for `ert--explain-equal'." > (cl-typecase x > ! (character (list x (format "#x%x" x) (format "?%c" x))) > ! (fixnum (list x (format "#x%x" x))) > (t x))) > > (defun ert--explain-equal-rec (a b) > Your idea look good to me. I think about it but afraid inconsistent of output (print 3 filed for character and 2 for fixnum). That is why I don't suggest this solution... One essential point is that if some test check fail all followed tests doesn't executed due to this bug. So this must be fixed in any way... -- Best regards! From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 19:08:59 2013 Received: (at control) by debbugs.gnu.org; 11 Jun 2013 23:08:59 +0000 Received: from localhost ([127.0.0.1]:57338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXgQ-0002GS-RC for submit@debbugs.gnu.org; Tue, 11 Jun 2013 19:08:58 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:41734 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXgO-0002GL-Pq for control@debbugs.gnu.org; Tue, 11 Jun 2013 19:08:57 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UmXg7-00023K-4L for control@debbugs.gnu.org; Tue, 11 Jun 2013 19:08:39 -0400 Date: Tue, 11 Jun 2013 19:08:39 -0400 Message-Id: Subject: control message for bug 13543 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) close 13543 24.4 From unknown Wed Aug 20 06:39:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Jul 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator