GNU bug report logs - #13523
24.2.92; [regression] mark-active

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Tue, 22 Jan 2013 08:21:02 UTC

Severity: important

Tags: confirmed, help

Found in versions 24.2, 24.1, 24.2.92

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13523 <at> debbugs.gnu.org, Chong Yidong <cyd <at> gnu.org>
Subject: bug#13523: 24.2.92; [regression] mark-active
Date: Wed, 30 Jan 2013 21:47:11 -0500

> Can we turn the test around, so that rather than saying "deactivate the
> mark if the final event was mouse-set-point or mouse-set-region", we say
> "deactivate the mark unless the final event was X or Y"?
> (I don't know what X or Y are, something related to multi-clicks I guess.)

Can someone point out why the patch below wouldn't work?


        Stefan


=== modified file 'lisp/mouse.el'
--- lisp/mouse.el	2013-01-30 17:14:24 +0000
+++ lisp/mouse.el	2013-01-31 02:45:05 +0000
@@ -880,9 +880,9 @@
 		     (copy-region-as-kill (mark) (point)))))
 
 	  ;; Otherwise, run binding of terminating up-event.
+          (deactivate-mark)
 	  (if do-multi-click
 	      (goto-char start-point)
-	    (deactivate-mark)
 	    (unless moved-off-start
 	      (pop-mark)))
This bug report was last modified 12 years and 108 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.