From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13523@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135884280626629 (code B ref -1); Tue, 22 Jan 2013 08:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jan 2013 08:20:06 +0000 Received: from localhost ([127.0.0.1]:44018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZ5R-0006vP-2q for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:20:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50771) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZ5O-0006vH-ST for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxZ4H-0003oM-N5 for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:18:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxZ4H-0003oI-Jb for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:18:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxYpx-0000Gz-NK for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxYpw-0008PA-C9 for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:05 -0500 Received: from mail-pb0-f47.google.com ([209.85.160.47]:34123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxYpw-0008Ou-47 for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:04 -0500 Received: by mail-pb0-f47.google.com with SMTP id wz17so3814095pbc.20 for ; Tue, 22 Jan 2013 00:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=Ph8sdB5ExcwrtQ818PQLVZDht5dnTJIQhMicYAn06Gs=; b=gZo/nEBc70jAPeFrgvVp77P4jzOCjMUvJlYt+WWz7jD+f71iEpGaoif3jS8FRWkQ7S JLn+PjufyEw4T2TXVj3N4BTmHyVO/kZQWZsV8Bmc5knVnB3OXIFh2pdwlcXlmZqS9RPq c9p1ZGzm+boSGuHaLU1KYuPJlUksNiHonLBavdxWGaOS1tPo4RZxdK7BqMtH2XM49yrA sLmgz70hoOERO2DHUqKojtRYY4uvRby78BdfgweQ6rwRKJ5Y/Gr416PFYSM9RNuHxFrF 8LvJY0O/76RTEU6BE4DO713yCY/gqx+pJoydKB20dXlxiI+yV6LoquCR/gXZRyWk3rCy nU2w== X-Received: by 10.66.79.97 with SMTP id i1mr54084991pax.47.1358841841125; Tue, 22 Jan 2013 00:04:01 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.66]) by mx.google.com with ESMTPS id gv9sm10296272pbc.21.2013.01.22.00.03.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 00:04:00 -0800 (PST) From: Leo Liu Date: Tue, 22 Jan 2013 16:03:53 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) I have just wasted a few hours wondering some odd behaviour in js2-mode but to discover it is due to change between Emacs 23 and 24. 1. (global-set-key [mouse-1] (lambda (e) (interactive "e"))) 2. Mouse-1 click on a buffer and check the value of mark-active In emacs 23 it is nil; but in emacs 24.2/24.2.92, it is t. With mark-active set to t, some commands following mouse-1 activate the region unexpectedly and inconveniently, for example, in js2-mode, C-a activate the region between the mouse and line beginning. It seems 23 and 24 is consistent only if [mouse-1] is bound to mouse-set-point. As a result of this bug, most customised [mouse-1] commands fail to handle mark-active i.e. it is subtle and hard to get the customised mouse-1 command behave like mouse-set-point leaving users with creepy behaviour like the one I am seeing in js2 mode. Leo From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 13523@debbugs.gnu.org Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135884337627566 (code B ref 13523); Tue, 22 Jan 2013 08:30:02 +0000 Received: (at 13523) by debbugs.gnu.org; 22 Jan 2013 08:29:36 +0000 Received: from localhost ([127.0.0.1]:44057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZEe-0007AY-2A for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:29:36 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:64668) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZEY-0007AN-A6 for 13523@debbugs.gnu.org; Tue, 22 Jan 2013 03:29:34 -0500 Received: by mail-lb0-f179.google.com with SMTP id j14so376190lbo.24 for <13523@debbugs.gnu.org>; Tue, 22 Jan 2013 00:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=7rcMa8AwTd9mvlS0dvrQRsINs65LXMDZs2wXYdEKIqg=; b=b5RZqLO1PhtT+U0S0AQpXZIfsAv3aRNxPbR3PhXncKQ/1gXA+WJjRNgJnEgvZxVBSb G0kTmqh8pScWqyVfJ6n6Zj+H4jCov2A2UfG60zNCeKZLtWdjZN/+iv49V57AlOQ0bOwA REcFQWRW2jSq+5iiGI7ebdS/J1SWzFDcLwwLwHztmHrZ0vGL/tX3945aj4lKAxgNiq4l UgFWJ/HGaFegtd9BK2RxrEJCoikrQejCiBmvSjQ6Xo58IETW9JOiKLwUk7rlEbix/5X0 0T425vMmLsJCcdADfRcdc7IyKIRVwLo8qp1efZHlFlKxpQY1akmbtXAUk5bjPQVwgr0A Q9RA== X-Received: by 10.112.98.232 with SMTP id el8mr8564058lbb.121.1358843301012; Tue, 22 Jan 2013 00:28:21 -0800 (PST) Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id bf3sm6527922lbb.16.2013.01.22.00.28.18 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 00:28:19 -0800 (PST) From: Dmitry Gutov In-Reply-To: (Leo Liu's message of "Tue, 22 Jan 2013 16:03:53 +0800") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) Date: Tue, 22 Jan 2013 12:28:19 +0400 Message-ID: <87d2wxwrj0.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Leo Liu writes: > I have just wasted a few hours wondering some odd behaviour in js2-mode > but to discover it is due to change between Emacs 23 and 24. > > 1. (global-set-key [mouse-1] (lambda (e) (interactive "e"))) > 2. Mouse-1 click on a buffer and check the value of mark-active > > In emacs 23 it is nil; but in emacs 24.2/24.2.92, it is t. > > With mark-active set to t, some commands following mouse-1 activate the > region unexpectedly and inconveniently, for example, in js2-mode, C-a > activate the region between the mouse and line beginning. > > It seems 23 and 24 is consistent only if [mouse-1] is bound to > mouse-set-point. > > As a result of this bug, most customised [mouse-1] commands fail to > handle mark-active i.e. it is subtle and hard to get the customised > mouse-1 command behave like mouse-set-point leaving users with creepy > behaviour like the one I am seeing in js2 mode. As far as js2-mode goes, this is supposed to be fixed: https://github.com/mooz/js2-mode/issues/77 Also see http://lists.gnu.org/archive/html/help-gnu-emacs/2012-12/msg00152.html From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jan 2013 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 13523@debbugs.gnu.org Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135884526030436 (code B ref 13523); Tue, 22 Jan 2013 09:01:01 +0000 Received: (at 13523) by debbugs.gnu.org; 22 Jan 2013 09:01:00 +0000 Received: from localhost ([127.0.0.1]:44064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZj1-0007uq-Qx for submit@debbugs.gnu.org; Tue, 22 Jan 2013 04:01:00 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:58028) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZiy-0007ui-FG for 13523@debbugs.gnu.org; Tue, 22 Jan 2013 04:00:58 -0500 Received: by mail-pa0-f50.google.com with SMTP id hz10so3942813pad.9 for <13523@debbugs.gnu.org>; Tue, 22 Jan 2013 00:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=7VuoElCPdNrnuk5Rl1PULcbAlM7pxwFuSj6/meJcEDc=; b=c+OHSMkLnyM96mU2iyr+jrKNtvqsLaPU2P7mKdWX2Bmk8uxyV9rP0NRtO+2K6OjS35 V83COl/WEl4QM9R3ygp6zGJz7m8AgH2lNN5G/iVw702SCYTnBk5UoT+f9bO5Wo8HzXzY I+HBRVdmGmXPEqGWfoM/S7tm98tLiVgApzNJYNvPkev1i4s+5zywPqzD9/YyKGRhTvZL 7Ue8gZ/GXPyGFIQ/6/WTZtpqQEhM2x7/dfR7GT7ySSQiiIs0kl2vA5Z8F3bkOSzODVQ/ KVO4WqJ9U97+0gFrZbnG/zjwQGU+lFh6+5kPuGZRC3OmugAkgwTqsSTiLacaYbQtEhVu onGQ== X-Received: by 10.68.130.225 with SMTP id oh1mr36891274pbb.147.1358845187446; Tue, 22 Jan 2013 00:59:47 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.66]) by mx.google.com with ESMTPS id qt2sm10380399pbb.24.2013.01.22.00.59.43 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 00:59:46 -0800 (PST) From: Leo Liu References: <87d2wxwrj0.fsf@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Tue, 22 Jan 2013 16:59:38 +0800 In-Reply-To: <87d2wxwrj0.fsf@yandex.ru> (Dmitry Gutov's message of "Tue, 22 Jan 2013 12:28:19 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-01-22 16:28 +0800, Dmitry Gutov wrote: > As far as js2-mode goes, this is supposed to be fixed: > https://github.com/mooz/js2-mode/issues/77 Thanks for the info. I am merely using js2 as an example; (my copy of js2 is not even up-to-date). > Also see >http://lists.gnu.org/archive/html/help-gnu-emacs/2012-12/msg00152.html I guess that thread didn't go anywhere. But I can't believe such a design error has persisted for so long. Hopefully someone get around to clean it up for the release. Leo From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13523@debbugs.gnu.org Cc: Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.13589284503047 (code B ref 13523); Wed, 23 Jan 2013 08:08:01 +0000 Received: (at 13523) by debbugs.gnu.org; 23 Jan 2013 08:07:30 +0000 Received: from localhost ([127.0.0.1]:45576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxvMn-0000n5-CK for submit@debbugs.gnu.org; Wed, 23 Jan 2013 03:07:30 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:51240) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxvMk-0000mt-Kq for 13523@debbugs.gnu.org; Wed, 23 Jan 2013 03:07:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TxvLW-0008SV-L0; Wed, 23 Jan 2013 03:06:10 -0500 From: Glenn Morris References: X-Spook: mindwar 2600 Magazine AGT. AMME RSA ICE Steve Case X-Ran: D} X-Hue: red X-Attribution: GM Date: Wed, 23 Jan 2013 03:06:10 -0500 In-Reply-To: (Leo Liu's message of "Tue, 22 Jan 2013 16:03:53 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) So IIUC the issue can be summarized as: down-mouse-1 runs mouse-drag-region mouse-1 runs mouse-set-point mouse-drag-region calls mouse-drag-track. Since 2010-07-03 (I think), this unconditionally pushes mark. It then uses track-mouse to watch for further mouse events. If at the end, point has not moved and the last event was mouse-set-point or mouse-set-region, it deactivates and pops the mark. Otherwise it assumes it is handling a multi-click event (since 2010-07-05), and does not deactivate mark. The result is that if you bind mouse-1 to something other than mouse-set-point, and leave down-mouse-1 alone, then after a mouse-1 click the mark stays active (unless you specifically deactivate it). Examples can be seen with image-dired and rst-toc-mode, which both bind mouse-1 but not down-mouse-1. In both cases, mouse-1 clicks leave the mouse active. It doesn't seem to matter in either case, but probably is not intended. Is the intention that people bind down-mouse-1 as well/instead of mouse-1, or that things bound to mouse-1 deactivate mark, or can the multi-click detection be changed somehow to avoid this? From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135894541926402 (code B ref 13523); Wed, 23 Jan 2013 12:51:02 +0000 Received: (at 13523) by debbugs.gnu.org; 23 Jan 2013 12:50:19 +0000 Received: from localhost ([127.0.0.1]:45826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxzmU-0006rk-A3 for submit@debbugs.gnu.org; Wed, 23 Jan 2013 07:50:18 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54043) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxzmR-0006rQ-NT for 13523@debbugs.gnu.org; Wed, 23 Jan 2013 07:50:16 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0NCmq60003935; Wed, 23 Jan 2013 07:48:56 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 0A081AE194; Wed, 23 Jan 2013 07:48:48 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Wed, 23 Jan 2013 07:48:48 -0500 In-Reply-To: (Glenn Morris's message of "Wed, 23 Jan 2013 03:06:10 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4469=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4469> : streams <893442> : uri <1325793> X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > It then uses track-mouse to watch for further mouse events. > If at the end, point has not moved and the last event was > mouse-set-point or mouse-set-region, it deactivates and pops the mark. It should probably unconditionally deactivate the mark and let the command of the up event run in the normal way. > Is the intention that people bind down-mouse-1 as well/instead of > mouse-1, or that things bound to mouse-1 deactivate mark, or can the > multi-click detection be changed somehow to avoid this? It can be changed, but IIRC this might be tricky. Partly because the current code is pretty tricky already. Stefan From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jan 2013 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135899052226752 (code B ref 13523); Thu, 24 Jan 2013 01:23:02 +0000 Received: (at 13523) by debbugs.gnu.org; 24 Jan 2013 01:22:02 +0000 Received: from localhost ([127.0.0.1]:46993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyBVx-0006xL-PR for submit@debbugs.gnu.org; Wed, 23 Jan 2013 20:22:02 -0500 Received: from mail-pb0-f44.google.com ([209.85.160.44]:47162) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyBVv-0006xC-NL for 13523@debbugs.gnu.org; Wed, 23 Jan 2013 20:22:00 -0500 Received: by mail-pb0-f44.google.com with SMTP id uo1so5054047pbc.3 for <13523@debbugs.gnu.org>; Wed, 23 Jan 2013 17:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=jQ4ucrxWbg/q6sxcTQAl1pdT6EBoQjDkhbDxLhk0meU=; b=V0QJ+Aw05rKpbargjS9MQfqoz7sgx35hGi0dVJo0i2nRjElY6TRC04v8rPVxK0DFdE +rvfat1j27b4P4fnqmA0nqsDSGa0AjAH5NJG7et8BEUvb85ttiGV5qeOEuKzBcQSGr8C /BlPaHHa/FoOCfThtB9UYNca7E7uV1QsAZ6Fe/U7FJCfTK2D0PSWuXMqq9WSokcshsGa 3hxOygEHgd3wkItTgUKkOTR3442lwQf80C/ArZS1AL6GINcKGJJ8+KlnNzCwXLkQnHas LWLSMOQlfHeNUu8cBu4MTyy++7urMd+RDNNvcxU9jBPD1i//LgOViXsxMc1VAcOl8Sh3 G9iw== X-Received: by 10.68.236.100 with SMTP id ut4mr464618pbc.92.1358990440047; Wed, 23 Jan 2013 17:20:40 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.66]) by mx.google.com with ESMTPS id t6sm14558702paz.11.2013.01.23.17.20.36 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 23 Jan 2013 17:20:39 -0800 (PST) From: Leo Liu References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Thu, 24 Jan 2013 09:20:27 +0800 In-Reply-To: (Glenn Morris's message of "Wed, 23 Jan 2013 03:06:10 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (OS X 10.8.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-01-23 16:06 +0800, Glenn Morris wrote: > In both cases, mouse-1 clicks leave the mouse active. It doesn't seem > to matter in either case, but probably is not intended. One example, C-s following mouse-1 click would unexpectedly activate region. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 24 21:44:36 2013 Received: (at control) by debbugs.gnu.org; 25 Jan 2013 02:44:36 +0000 Received: from localhost ([127.0.0.1]:48361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyZHQ-0007Ct-9Z for submit@debbugs.gnu.org; Thu, 24 Jan 2013 21:44:36 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35717) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyZHP-0007Cn-At for control@debbugs.gnu.org; Thu, 24 Jan 2013 21:44:35 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TyZHJ-00020e-FY for control@debbugs.gnu.org; Thu, 24 Jan 2013 21:44:29 -0500 Date: Thu, 24 Jan 2013 21:44:29 -0500 Message-Id: Subject: control message for bug 13523 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) found 13523 24.1 found 13523 24.2 From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 02:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.13592530269886 (code B ref 13523); Sun, 27 Jan 2013 02:18:02 +0000 Received: (at 13523) by debbugs.gnu.org; 27 Jan 2013 02:17:06 +0000 Received: from localhost ([127.0.0.1]:50900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzHnu-0002ZP-Eq for submit@debbugs.gnu.org; Sat, 26 Jan 2013 21:17:06 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54389) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzHnt-0002ZJ-3h for 13523@debbugs.gnu.org; Sat, 26 Jan 2013 21:17:05 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TzHnb-0000jB-J8; Sat, 26 Jan 2013 21:16:47 -0500 From: Glenn Morris References: X-Spook: high security supercomputer Commecen Syria e-cash X-Ran: m.ACV#\lT.7XqS(+TsIsnZ*t%x(T+w?( (Stefan Monnier's message of "Wed, 23 Jan 2013 07:48:48 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Stefan Monnier wrote: >> If at the end, point has not moved and the last event was >> mouse-set-point or mouse-set-region, it deactivates and pops the mark. > > It should probably unconditionally deactivate the mark and let the > command of the up event run in the normal way. This seems like something that should be fixed for 24.3, but I don't see how to do it. From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jan 2013 01:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135933685224571 (code B ref 13523); Mon, 28 Jan 2013 01:35:02 +0000 Received: (at 13523) by debbugs.gnu.org; 28 Jan 2013 01:34:12 +0000 Received: from localhost ([127.0.0.1]:51825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tzdbw-0006OG-Ba for submit@debbugs.gnu.org; Sun, 27 Jan 2013 20:34:12 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18649) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tzdbu-0006O9-ME for 13523@debbugs.gnu.org; Sun, 27 Jan 2013 20:34:11 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhoHAG6Zu09FpYpx/2dsb2JhbABEgXuuTYNJgQiCFQEBBAFWIxALDiYSFBgNJIgcBboJkEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="213819391" Received: from 69-165-138-113.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.138.113]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Jan 2013 20:33:47 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 0738DAE0F4; Sun, 27 Jan 2013 20:33:46 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Sun, 27 Jan 2013 20:33:46 -0500 In-Reply-To: (Glenn Morris's message of "Sat, 26 Jan 2013 21:16:47 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>> If at the end, point has not moved and the last event was >>> mouse-set-point or mouse-set-region, it deactivates and pops the mark. >> It should probably unconditionally deactivate the mark and let the >> command of the up event run in the normal way. > This seems like something that should be fixed for 24.3, but I don't see > how to do it. Fixing it right is clearly out of scope of 24.3, but I don't know either how to patch it up for 24.3. Stefan From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jan 2013 02:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Stefan Monnier Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135951128116010 (code B ref 13523); Wed, 30 Jan 2013 02:02:02 +0000 Received: (at 13523) by debbugs.gnu.org; 30 Jan 2013 02:01:21 +0000 Received: from localhost ([127.0.0.1]:54921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0MzI-0004A9-MT for submit@debbugs.gnu.org; Tue, 29 Jan 2013 21:01:21 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:54159) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0MzG-0004A1-AQ for 13523@debbugs.gnu.org; Tue, 29 Jan 2013 21:01:19 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0Myg-00027z-OM; Tue, 29 Jan 2013 21:00:42 -0500 From: Glenn Morris References: X-Spook: dictionary Uzi constitution DES SDI oil ANC Ft. Bragg X-Ran: b4`/qga:|bK~U/Qj}_rjbaUGt]+)iG (Stefan Monnier's message of "Sun, 27 Jan 2013 20:33:46 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Stefan Monnier wrote: >>>> If at the end, point has not moved and the last event was >>>> mouse-set-point or mouse-set-region, it deactivates and pops the mark. [...] > Fixing it right is clearly out of scope of 24.3, but I don't know either > how to patch it up for 24.3. Can we turn the test around, so that rather than saying "deactivate the mark if the final event was mouse-set-point or mouse-set-region", we say "deactivate the mark unless the final event was X or Y"? (I don't know what X or Y are, something related to multi-clicks I guess.) From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Glenn Morris Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135960047326643 (code B ref 13523); Thu, 31 Jan 2013 02:48:01 +0000 Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 02:47:53 +0000 Received: from localhost ([127.0.0.1]:56527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kBt-0006vf-BU for submit@debbugs.gnu.org; Wed, 30 Jan 2013 21:47:53 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:21850) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kBs-0006vZ-29 for 13523@debbugs.gnu.org; Wed, 30 Jan 2013 21:47:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="82172" Received: from 184-175-13-222.dsl.teksavvy.com (HELO ceviche.home) ([184.175.13.222]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jan 2013 21:47:11 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 4A7D866130; Wed, 30 Jan 2013 21:47:11 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Wed, 30 Jan 2013 21:47:11 -0500 In-Reply-To: (Glenn Morris's message of "Tue, 29 Jan 2013 21:00:42 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Can we turn the test around, so that rather than saying "deactivate the > mark if the final event was mouse-set-point or mouse-set-region", we say > "deactivate the mark unless the final event was X or Y"? > (I don't know what X or Y are, something related to multi-clicks I guess.) Can someone point out why the patch below wouldn't work? Stefan === modified file 'lisp/mouse.el' --- lisp/mouse.el 2013-01-30 17:14:24 +0000 +++ lisp/mouse.el 2013-01-31 02:45:05 +0000 @@ -880,9 +880,9 @@ (copy-region-as-kill (mark) (point))))) ;; Otherwise, run binding of terminating up-event. + (deactivate-mark) (if do-multi-click (goto-char start-point) - (deactivate-mark) (unless moved-off-start (pop-mark))) From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 03:36:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Stefan Monnier Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135960332631485 (code B ref 13523); Thu, 31 Jan 2013 03:36:04 +0000 Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 03:35:26 +0000 Received: from localhost ([127.0.0.1]:56541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kvu-0008Bm-0N for submit@debbugs.gnu.org; Wed, 30 Jan 2013 22:35:26 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45710) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kvm-0008Ba-3Q for 13523@debbugs.gnu.org; Wed, 30 Jan 2013 22:35:20 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0kv6-000250-F1; Wed, 30 Jan 2013 22:34:36 -0500 From: Glenn Morris References: X-Spook: monarchist Hamas Becker genetic SDI Skipjack MILSATCOM X-Ran: UAO?edtFO:g*C)_~OA@HH*>j#DHLc4qXS@Yxu@Q$0?uD@|jSQ2]..hY54B?c?p9I9tgJPU X-Hue: red X-Attribution: GM Date: Wed, 30 Jan 2013 22:34:36 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 30 Jan 2013 21:47:11 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) Stefan Monnier wrote: >> Can we turn the test around, so that rather than saying "deactivate the >> mark if the final event was mouse-set-point or mouse-set-region", we say >> "deactivate the mark unless the final event was X or Y"? >> (I don't know what X or Y are, something related to multi-clicks I guess.) > > Can someone point out why the patch below wouldn't work? Won't it break dragging to select a region and activate the mark? From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 07:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Stefan Monnier Cc: 13523@debbugs.gnu.org Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135961695222718 (code B ref 13523); Thu, 31 Jan 2013 07:23:01 +0000 Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 07:22:32 +0000 Received: from localhost ([127.0.0.1]:56718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0oTg-0005uN-DB for submit@debbugs.gnu.org; Thu, 31 Jan 2013 02:22:32 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:55476) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0oTe-0005uG-5f for 13523@debbugs.gnu.org; Thu, 31 Jan 2013 02:22:30 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0oSy-0000dj-Fu; Thu, 31 Jan 2013 02:21:48 -0500 From: Glenn Morris References: X-Spook: import Uzbekistan Centro Chobetsu computer terrorism X-Ran: k.adhi#N9th.%{A}Y4uSvI5QH/d/T<3$F(1{w#>\zw'J2R"2mds((z^.C;.'Kd0s0{:q.h X-Hue: black X-Attribution: GM Date: Thu, 31 Jan 2013 02:21:48 -0500 In-Reply-To: (Glenn Morris's message of "Wed, 30 Jan 2013 22:34:36 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) Glenn Morris wrote: >> Can someone point out why the patch below wouldn't work? > > Won't it break dragging to select a region and activate the mark? Maybe not? I don't understand how any of this works... Anyway, the conditional deactivation was introduced in r100728 http://lists.gnu.org/archive/html/emacs-diffs/2010-07/msg00055.html as something do with double and triple clicks. From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Stefan Monnier Cc: 13523@debbugs.gnu.org Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135961858125204 (code B ref 13523); Thu, 31 Jan 2013 07:50:02 +0000 Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 07:49:41 +0000 Received: from localhost ([127.0.0.1]:56749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0otw-0006YQ-Gw for submit@debbugs.gnu.org; Thu, 31 Jan 2013 02:49:41 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56391) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0otu-0006YJ-4P for 13523@debbugs.gnu.org; Thu, 31 Jan 2013 02:49:39 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U0otE-0003k4-3m; Thu, 31 Jan 2013 02:48:56 -0500 From: Glenn Morris References: X-Spook: Qaddafi morse NASA TWA HAMASMOIS smuggle sweep Kennedy X-Ran: I*-P&=>4|w*H|?Bv!{,rvWOh4{~!vo]&hjN&mYIi#z-~;>VWF4"9v-5}^:uo*+R!&lMuwd X-Hue: white X-Attribution: GM Date: Thu, 31 Jan 2013 02:48:55 -0500 In-Reply-To: (Glenn Morris's message of "Thu, 31 Jan 2013 02:21:48 -0500") Message-ID: <81ud1dc7s.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) Glenn Morris wrote: > I don't understand how any of this works... Bearing that in mind, this seems odd: (> (event-click-count event) 0) since surely event-click-count is always >= 1? But this code predates 24.1. From unknown Sun Jun 22 00:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13523: 24.2.92; [regression] mark-active Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help To: Glenn Morris Cc: 13523@debbugs.gnu.org, Chong Yidong Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.1359643704300 (code B ref 13523); Thu, 31 Jan 2013 14:49:01 +0000 Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 14:48:24 +0000 Received: from localhost ([127.0.0.1]:57124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0vR9-0008WS-If for submit@debbugs.gnu.org; Thu, 31 Jan 2013 09:48:24 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49849) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0vR6-0008WI-0x for 13523@debbugs.gnu.org; Thu, 31 Jan 2013 09:48:21 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0VElaOc020238; Thu, 31 Jan 2013 09:47:36 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 74F7EB4182; Thu, 31 Jan 2013 09:47:36 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 31 Jan 2013 09:47:36 -0500 In-Reply-To: (Glenn Morris's message of "Wed, 30 Jan 2013 22:34:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4478=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4478> : streams <898109> : uri <1332930> X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) >>> Can we turn the test around, so that rather than saying "deactivate the >>> mark if the final event was mouse-set-point or mouse-set-region", we say >>> "deactivate the mark unless the final event was X or Y"? >>> (I don't know what X or Y are, something related to multi-clicks I guess.) >> Can someone point out why the patch below wouldn't work? > Won't it break dragging to select a region and activate the mark? I don't think so, because the next command (the one bound to the up-event) should/will activate the mark (since the next event should be a drag-mouse-1). And in my tests, it seems to work just fine, indeed. > Bearing that in mind, this seems odd: > (> (event-click-count event) 0) > since surely event-click-count is always >= 1? Indeed even (event-click-count ?a) returns 1, so the test seems broken. Stefan From unknown Sun Jun 22 00:32:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#13523: closed (Re: bug#13523: 24.2.92; [regression] mark-active) Message-ID: References: X-Gnu-PR-Message: they-closed 13523 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: confirmed help Reply-To: 13523@debbugs.gnu.org Date: Fri, 01 Feb 2013 23:43:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1359762181-3269-1" This is a multi-part message in MIME format... ------------=_1359762181-3269-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13523: 24.2.92; [regression] mark-active which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13523@debbugs.gnu.org. --=20 13523: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13523 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1359762181-3269-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13523-done) by debbugs.gnu.org; 1 Feb 2013 23:42:46 +0000 Received: from localhost ([127.0.0.1]:60097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1QFq-0000qB-Cl for submit@debbugs.gnu.org; Fri, 01 Feb 2013 18:42:46 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23129) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1QFn-0000q2-MY for 13523-done@debbugs.gnu.org; Fri, 01 Feb 2013 18:42:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="245160" Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Feb 2013 18:41:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id 8D5105943E; Fri, 1 Feb 2013 18:41:52 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#13523: 24.2.92; [regression] mark-active Message-ID: References: Date: Fri, 01 Feb 2013 18:41:52 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 30 Jan 2013 21:47:11 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 13523-done Cc: Chong Yidong , 13523-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Can someone point out why the patch below wouldn't work? I've installed the patch in emacs-24. Stefan ------------=_1359762181-3269-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jan 2013 08:20:06 +0000 Received: from localhost ([127.0.0.1]:44018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZ5R-0006vP-2q for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:20:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50771) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TxZ5O-0006vH-ST for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxZ4H-0003oM-N5 for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:18:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxZ4H-0003oI-Jb for submit@debbugs.gnu.org; Tue, 22 Jan 2013 03:18:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxYpx-0000Gz-NK for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxYpw-0008PA-C9 for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:05 -0500 Received: from mail-pb0-f47.google.com ([209.85.160.47]:34123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxYpw-0008Ou-47 for bug-gnu-emacs@gnu.org; Tue, 22 Jan 2013 03:04:04 -0500 Received: by mail-pb0-f47.google.com with SMTP id wz17so3814095pbc.20 for ; Tue, 22 Jan 2013 00:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=Ph8sdB5ExcwrtQ818PQLVZDht5dnTJIQhMicYAn06Gs=; b=gZo/nEBc70jAPeFrgvVp77P4jzOCjMUvJlYt+WWz7jD+f71iEpGaoif3jS8FRWkQ7S JLn+PjufyEw4T2TXVj3N4BTmHyVO/kZQWZsV8Bmc5knVnB3OXIFh2pdwlcXlmZqS9RPq c9p1ZGzm+boSGuHaLU1KYuPJlUksNiHonLBavdxWGaOS1tPo4RZxdK7BqMtH2XM49yrA sLmgz70hoOERO2DHUqKojtRYY4uvRby78BdfgweQ6rwRKJ5Y/Gr416PFYSM9RNuHxFrF 8LvJY0O/76RTEU6BE4DO713yCY/gqx+pJoydKB20dXlxiI+yV6LoquCR/gXZRyWk3rCy nU2w== X-Received: by 10.66.79.97 with SMTP id i1mr54084991pax.47.1358841841125; Tue, 22 Jan 2013 00:04:01 -0800 (PST) Received: from Shidais-iMac.local ([119.255.41.66]) by mx.google.com with ESMTPS id gv9sm10296272pbc.21.2013.01.22.00.03.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 00:04:00 -0800 (PST) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.2.92; [regression] mark-active Date: Tue, 22 Jan 2013 16:03:53 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) I have just wasted a few hours wondering some odd behaviour in js2-mode but to discover it is due to change between Emacs 23 and 24. 1. (global-set-key [mouse-1] (lambda (e) (interactive "e"))) 2. Mouse-1 click on a buffer and check the value of mark-active In emacs 23 it is nil; but in emacs 24.2/24.2.92, it is t. With mark-active set to t, some commands following mouse-1 activate the region unexpectedly and inconveniently, for example, in js2-mode, C-a activate the region between the mouse and line beginning. It seems 23 and 24 is consistent only if [mouse-1] is bound to mouse-set-point. As a result of this bug, most customised [mouse-1] commands fail to handle mark-active i.e. it is subtle and hard to get the customised mouse-1 command behave like mouse-set-point leaving users with creepy behaviour like the one I am seeing in js2 mode. Leo ------------=_1359762181-3269-1--