GNU bug report logs - #13507
small patch for 1.13.1 t/lisp-flags.sh

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13507: closed (small patch for 1.13.1 t/lisp-flags.sh)
Date: Mon, 21 Jan 2013 12:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 21 Jan 2013 13:37:45 +0100
with message-id <50FD3699.3050605 <at> gmail.com>
and subject line Re: bug#13507: small patch for 1.13.1 t/lisp-flags.sh
has caused the debbugs.gnu.org bug report #13507,
regarding small patch for 1.13.1 t/lisp-flags.sh
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13507: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13507
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thien-Thi Nguyen <ttn <at> gnuvola.org>
To: bug-automake <at> gnu.org
Subject: small patch for 1.13.1 t/lisp-flags.sh
Date: Sun, 20 Jan 2013 19:05:37 +0100

[Message part 3 (text/plain, inline)]

Here is a suitable ChangeLog entry:

2013-01-20  Thien-Thi Nguyen  <ttn <at> gnuvola.org>  (tiny change)

	Don't get fooled when running "make check" inside Emacs.

	Some versions of Emacs set the env var 'EMACS' to 't'
	for child processes.  Thus, when running from inside Emacs,
	'$(MAKE) -e' erroneously allows the 't' to override the one
	in the Makefile.  This change avoids that problem.

	* t/lisp-flags.sh: Unset var 'EMACS'.

Here is the patch, proper:

[lisp-flags.patch (text/x-diff, inline)]

diff -u lisp-flags.sh\~ lisp-flags.sh
--- lisp-flags.sh~	2012-12-31 21:13:40.000000000 +0100
+++ lisp-flags.sh	2013-01-20 18:54:18.000000000 +0100
@@ -28,6 +28,9 @@
 AC_OUTPUT
 EOF

+# Don't get fooled when running as an Emacs subprocess.
+unset EMACS
+
 $ACLOCAL
 $AUTOCONF
 $AUTOMAKE --add-missing

Diff finished.  Sun Jan 20 18:55:14 2013

[Message part 5 (text/plain, inline)]

With this change (and a few hours waiting on this old slow computer), i
am able to see GNU Automake 1.13.1 pass "make check".

-- 
Thien-Thi Nguyen ..................................... GPG key: 4C807502
.                  NB: ttn at glug dot org is not me                   .
.                 (and has not been since 2007 or so)                  .
.                        ACCEPT NO SUBSTITUTES                         .
........... please send technical questions to mailing lists ...........

[Message part 6 (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Thien-Thi Nguyen <ttn <at> gnuvola.org>
Cc: 13507-done <at> debbugs.gnu.org
Subject: Re: bug#13507: small patch for 1.13.1 t/lisp-flags.sh
Date: Mon, 21 Jan 2013 13:37:45 +0100

On 01/20/2013 07:05 PM, Thien-Thi Nguyen wrote:
> Here is a suitable ChangeLog entry:
> 
> 2013-01-20  Thien-Thi Nguyen  <ttn <at> gnuvola.org>  (tiny change)
> 
> 	Don't get fooled when running "make check" inside Emacs.
> 
> 	Some versions of Emacs set the env var 'EMACS' to 't'
> 	for child processes.  Thus, when running from inside Emacs,
> 	'$(MAKE) -e' erroneously allows the 't' to override the one
> 	in the Makefile.  This change avoids that problem.
> 
> 	* t/lisp-flags.sh: Unset var 'EMACS'.
> 
> Here is the patch, proper:
>
Applied, thanks.  I'm thus closing this report.

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.