From unknown Sun Jun 22 17:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13500: 24.2.92; tetris score grows after ending the game Resent-From: Sven Joachim Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: svenjoac@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2013 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13500@debbugs.gnu.org Cc: Sven Joachim X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Sven Joachim Received: via spool by submit@debbugs.gnu.org id=B.135861911916376 (code B ref -1); Sat, 19 Jan 2013 18:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jan 2013 18:11:59 +0000 Received: from localhost ([127.0.0.1]:40539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Twctb-0004G4-3H for submit@debbugs.gnu.org; Sat, 19 Jan 2013 13:11:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39041) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwctY-0004Fw-QG for submit@debbugs.gnu.org; Sat, 19 Jan 2013 13:11:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Twcse-00046j-OC for submit@debbugs.gnu.org; Sat, 19 Jan 2013 13:11:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twcse-00046e-LB for submit@debbugs.gnu.org; Sat, 19 Jan 2013 13:11:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twcsd-0002je-EJ for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 13:11:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwcsY-00045W-Md for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 13:10:59 -0500 Received: from mout.gmx.net ([212.227.17.21]:63206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwcsY-00045E-DF for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 13:10:54 -0500 Received: from mailout-de.gmx.net ([10.1.76.12]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MUSkP-1TVqoh4Bgh-00RKh4 for ; Sat, 19 Jan 2013 19:10:53 +0100 Received: (qmail invoked by alias); 19 Jan 2013 18:10:52 -0000 Received: from p4FC62B45.dip.t-dialin.net (EHLO turtle.gmx.de) [79.198.43.69] by mail.gmx.net (mp012) with SMTP; 19 Jan 2013 19:10:52 +0100 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX18cc8UpewYcV9Gc6OLWPa68BnCnemhjqB8rjY4btz FDAb3FKfzP9LrK Received: by turtle.gmx.de (Postfix, from userid 1000) id 683F93F4E8; Sat, 19 Jan 2013 19:10:52 +0100 (CET) From: Sven Joachim Date: Sat, 19 Jan 2013 19:10:52 +0100 Message-ID: <87mww5cac3.fsf@turtle.gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > Please describe exactly what actions triggered the bug, and > the precise symptoms of the bug. If you can, give a recipe > starting from `emacs -Q': Start tetris with M-x tetris and keep pressing SPC until the playing area is filled. Now Emacs writes the score to ~/.emacs.d/games/tetris-scores, but not only once but several times per second, increasing the score each time as if the game is still going on (press C-g to stop that). ,---- | 199 sven Sven Joachim Sat Jan 19 18:54:41 2013 | 194 sven Sven Joachim Sat Jan 19 18:54:41 2013 | 188 sven Sven Joachim Sat Jan 19 18:54:41 2013 | 182 sven Sven Joachim Sat Jan 19 18:54:40 2013 | 176 sven Sven Joachim Sat Jan 19 18:54:40 2013 | 170 sven Sven Joachim Sat Jan 19 18:54:39 2013 | 164 sven Sven Joachim Sat Jan 19 18:54:39 2013 | 158 sven Sven Joachim Sat Jan 19 18:54:39 2013 | 152 sven Sven Joachim Sat Jan 19 18:54:38 2013 | 147 sven Sven Joachim Sat Jan 19 18:54:38 2013 | 141 sven Sven Joachim Sat Jan 19 18:54:37 2013 | 135 sven Sven Joachim Sat Jan 19 18:54:37 2013 | 129 sven Sven Joachim Sat Jan 19 18:54:37 2013 | 123 sven Sven Joachim Sat Jan 19 18:54:36 2013 | 118 sven Sven Joachim Sat Jan 19 18:54:36 2013 | 112 sven Sven Joachim Sat Jan 19 18:54:35 2013 | 106 sven Sven Joachim Sat Jan 19 18:54:35 2013 | 100 sven Sven Joachim Sat Jan 19 18:54:35 2013 | 94 sven Sven Joachim Sat Jan 19 18:54:34 2013 | 89 sven Sven Joachim Sat Jan 19 18:54:34 2013 | 84 sven Sven Joachim Sat Jan 19 18:54:33 2013 | 79 sven Sven Joachim Sat Jan 19 18:54:33 2013 | 73 sven Sven Joachim Sat Jan 19 18:54:33 2013 | 67 sven Sven Joachim Sat Jan 19 18:54:32 2013 `---- This is a regression from previous releases. In GNU Emacs 24.2.92.4 (i486-pc-linux-gnu, GTK+ Version 3.4.2) of 2013-01-19 on turtle Bzr revision: 111189 sdl.web@gmail.com-20130118183544-w2orvtivfjawazg4 Windowing system distributor `The X.Org Foundation', version 11.0.11204000 System Description: Debian GNU/Linux Configured using: `configure '--build=i486-pc-linux-gnu' '--without-gconf' 'build_alias=i486-pc-linux-gnu'' Important settings: value of $LC_COLLATE: C value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x t e t r i s SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC C-g M-x r e p o r t - e m Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Buffer is read-only: # Loading vc-git...done Quit Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git disp-table tetris gamegrid time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From unknown Sun Jun 22 17:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13500: 24.2.92; tetris score grows after ending the game Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2013 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sven Joachim Cc: 13500@debbugs.gnu.org Received: via spool by 13500-submit@debbugs.gnu.org id=B13500.135862634627250 (code B ref 13500); Sat, 19 Jan 2013 20:13:02 +0000 Received: (at 13500) by debbugs.gnu.org; 19 Jan 2013 20:12:26 +0000 Received: from localhost ([127.0.0.1]:40559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwemA-00075T-FQ for submit@debbugs.gnu.org; Sat, 19 Jan 2013 15:12:26 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:41759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Twem8-00075M-Jn for 13500@debbugs.gnu.org; Sat, 19 Jan 2013 15:12:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TwelE-0002cb-M2; Sat, 19 Jan 2013 15:11:28 -0500 From: Glenn Morris References: <87mww5cac3.fsf@turtle.gmx.de> X-Spook: Uzbekistan Rumsfeld White Water tempest csim offensive X-Ran: 6x;`((1#5P=>p8|Kw?G}?h3,JtVOwD')42H+69^o!px~(f4.9#NI!.(gd_wP#/(]Z"mn.L X-Hue: black X-Attribution: GM Date: Sat, 19 Jan 2013 15:11:28 -0500 In-Reply-To: <87mww5cac3.fsf@turtle.gmx.de> (Sven Joachim's message of "Sat, 19 Jan 2013 19:10:52 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Sven Joachim wrote: > Start tetris with M-x tetris and keep pressing SPC until the playing > area is filled. Now Emacs writes the score to > ~/.emacs.d/games/tetris-scores, but not only once but several times per > second, increasing the score each time as if the game is still going on > (press C-g to stop that). I can't reproduce this, though I did find an (old) bug in gamegrid-add-score-with-update-game-score. The fact that your scores get written to ~/.emacs.d/games means that /usr/local/libexec/emacs/24.2.92/arch/update-game-score is not setuid. If I set it non-setuid, and do rm- rf ~/.emacs.d/games/ then Emacs fails to write score files due to a gamegrid-add-score-with-update-game-score bug. If I fix that bug (see below), or mkdir ~/.emacs.d/games first, then it works fine. What happens if you rm ~/.emacs.d/games/tetris-scores? *** lisp/play/gamegrid.el 2013-01-01 09:11:05 +0000 --- lisp/play/gamegrid.el 2013-01-19 20:02:52 +0000 *************** *** 507,513 **** gamegrid-user-score-file-directory)) (t (let ((f (expand-file-name gamegrid-user-score-file-directory))) ! (when (file-writable-p f) (unless (eq (car-safe (file-attributes f)) t) (make-directory f)) --- 507,513 ---- gamegrid-user-score-file-directory)) (t (let ((f (expand-file-name gamegrid-user-score-file-directory))) ! (when (file-writable-p (directory-file-name f)) (unless (eq (car-safe (file-attributes f)) t) (make-directory f)) From unknown Sun Jun 22 17:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13500: 24.2.92; tetris score grows after ending the game Resent-From: Sven Joachim Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2013 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 13500@debbugs.gnu.org Received: via spool by 13500-submit@debbugs.gnu.org id=B13500.135862927731703 (code B ref 13500); Sat, 19 Jan 2013 21:02:02 +0000 Received: (at 13500) by debbugs.gnu.org; 19 Jan 2013 21:01:17 +0000 Received: from localhost ([127.0.0.1]:40582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwfXP-0008FG-Ku for submit@debbugs.gnu.org; Sat, 19 Jan 2013 16:01:16 -0500 Received: from mout.gmx.net ([212.227.17.21]:56082) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwfXM-0008F3-Jn for 13500@debbugs.gnu.org; Sat, 19 Jan 2013 16:01:14 -0500 Received: from mailout-de.gmx.net ([10.1.76.10]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MYIEJ-1TRiMq2Urp-00V5T5 for <13500@debbugs.gnu.org>; Sat, 19 Jan 2013 22:00:17 +0100 Received: (qmail invoked by alias); 19 Jan 2013 21:00:17 -0000 Received: from p4FC62B45.dip.t-dialin.net (EHLO turtle.gmx.de) [79.198.43.69] by mail.gmx.net (mp010) with SMTP; 19 Jan 2013 22:00:17 +0100 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1/CZ08cdAXCV8nOHFkKpzt2Be53N4eRWANTYinFm1 2ZAES1MLrMGrDV Received: by turtle.gmx.de (Postfix, from userid 1000) id 922563F4E8; Sat, 19 Jan 2013 22:00:17 +0100 (CET) From: Sven Joachim References: <87mww5cac3.fsf@turtle.gmx.de> Date: Sat, 19 Jan 2013 22:00:16 +0100 In-Reply-To: (Glenn Morris's message of "Sat, 19 Jan 2013 15:11:28 -0500") Message-ID: <87622sdh27.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 13500 + moreinfo unreproducible thanks On 2013-01-19 21:11 +0100, Glenn Morris wrote: > Sven Joachim wrote: > >> Start tetris with M-x tetris and keep pressing SPC until the playing >> area is filled. Now Emacs writes the score to >> ~/.emacs.d/games/tetris-scores, but not only once but several times per >> second, increasing the score each time as if the game is still going on >> (press C-g to stop that). > > I can't reproduce this, though I did find an (old) bug in > gamegrid-add-score-with-update-game-score. > > The fact that your scores get written to ~/.emacs.d/games means that > /usr/local/libexec/emacs/24.2.92/arch/update-game-score > > is not setuid. Correct, I did not even run "make install". > If I set it non-setuid, and do > > rm- rf ~/.emacs.d/games/ > > then Emacs fails to write score files due to a > gamegrid-add-score-with-update-game-score bug. If I fix that bug (see > below), or mkdir ~/.emacs.d/games first, then it works fine. > > What happens if you rm ~/.emacs.d/games/tetris-scores? I was not able to reproduce the bug then; but even with the file back in place I couldn't, although it happened both in my regular session and the "emacs -Q" instance I started specially for reporting it. Now it does not happen in either. :-/ There's another problem in that the file is not truncated to gamegrid-score-file-length lines, but that has been the case for a long time IIRC. Cheers, Sven From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 20:42:33 2014 Received: (at control) by debbugs.gnu.org; 6 Feb 2014 01:42:33 +0000 Received: from localhost ([127.0.0.1]:51743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDz7-0002Q0-1Z for submit@debbugs.gnu.org; Wed, 05 Feb 2014 20:42:33 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53112) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDz5-0002Ps-4F for control@debbugs.gnu.org; Wed, 05 Feb 2014 20:42:31 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBDyq-0000AB-WB for control@debbugs.gnu.org; Thu, 06 Feb 2014 02:42:17 +0100 Date: Wed, 05 Feb 2014 17:41:14 -0800 Message-Id: <87eh3huif9.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13500 X-MailScanner-ID: 1WBDyq-0000AB-WB X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392255737.93076@JszuIJz267KwO8mXCPqpLQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 13500