From unknown Sun Jun 22 17:15:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13477: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...) Resent-From: "Richard W.M. Jones" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 17 Jan 2013 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13477 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 13477@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135844255023958 (code B ref -1); Thu, 17 Jan 2013 17:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jan 2013 17:09:10 +0000 Received: from localhost ([127.0.0.1]:37229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tvsxf-0006EL-Ns for submit@debbugs.gnu.org; Thu, 17 Jan 2013 12:09:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55210) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvoiQ-0008KR-Gd for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:37:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvohk-0004F8-Km for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:36:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-106.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohk-0004F4-Hu for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:36:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohj-0006Ws-Fq for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvohg-0004EO-Tz for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohg-0004E7-MP for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:20 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HCaIFv002269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 07:36:18 -0500 Received: from localhost (vpn1-5-145.ams2.redhat.com [10.36.5.145]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HCaHvF024185 for ; Thu, 17 Jan 2013 07:36:18 -0500 Date: Thu, 17 Jan 2013 12:36:15 +0000 From: "Richard W.M. Jones" Message-ID: <20130117123615.GB1543@rhmail.home.annexia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Mailman-Approved-At: Thu, 17 Jan 2013 12:09:06 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) I have a project that has a TESTS variable like this ('test_progs' is defined elsewhere): TESTS = run-bindtests \ $(sort \ $(patsubst %,%.bc,$(test_progs)) \ $(patsubst %,%.opt,$(test_progs))) This breaks with automake 1.13.1. 'make' gives unterminated variable errors. It is fairly obvious why when you look at the generated code: run-bindtests.log: run-bindtests @p='run-bindtests'; \ b='run-bindtests'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(sort.log: $(sort @p='$(sort'; \ b='$(sort'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(patsubst.log: $(patsubst @p='$(patsubst'; \ b='$(patsubst'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) %,%.bc,$(test_progs)).log: %,%.bc,$(test_progs)) This used to work fine in automake <= 1.12. I also tried jamming the whole thing into a single line, but that didn't help. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top From unknown Sun Jun 22 17:15:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13477: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...) Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 17 Jan 2013 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13477 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: "Richard W.M. Jones" Cc: 13477@debbugs.gnu.org Received: via spool by 13477-submit@debbugs.gnu.org id=B13477.135844741931354 (code B ref 13477); Thu, 17 Jan 2013 18:31:01 +0000 Received: (at 13477) by debbugs.gnu.org; 17 Jan 2013 18:30:19 +0000 Received: from localhost ([127.0.0.1]:37284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvuEE-00089e-8N for submit@debbugs.gnu.org; Thu, 17 Jan 2013 13:30:18 -0500 Received: from mail-bk0-f52.google.com ([209.85.214.52]:56259) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvuEB-00089X-PN for 13477@debbugs.gnu.org; Thu, 17 Jan 2013 13:30:16 -0500 Received: by mail-bk0-f52.google.com with SMTP id w5so1576270bku.11 for <13477@debbugs.gnu.org>; Thu, 17 Jan 2013 10:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=D09IUkSyE4ai91lrs50AsvESo8jEMG+z0yg2VaxVdhs=; b=Ib63Ic4tDU/M8Vd7voZ70zNlTQxY7TAY4pfAYWmA6ODD7QnDQ+Ca5qLeY6Vi9wwHnS 0KAr8WkYwxlzluJV04hFMNyuRCpN7We/i8URbo9d8NgNhJUUypu+F4oJUi6i4bWU0T+M 6QjJ/dwAaQNAV3LPBQO0F4sJBzcQuOtyn62f+pN8unrVwHgZ5TkJM6I+aGkUd8JdLw0r EB/aiKJzGYweJeIbHQZVnIR7iFHgDaOFGvLnO66t0ucBuy9UuIumtmrCpPn/zUSGq8c0 TXuGN533e+BHk8bQ59t1j4MBTl5JAB+2kRiWIZ4IT51hLkUVyNITR38wUF179dc1VoZt +R8w== X-Received: by 10.204.146.92 with SMTP id g28mr1777922bkv.127.1358447372845; Thu, 17 Jan 2013 10:29:32 -0800 (PST) Received: from [192.168.178.20] (host137-94-dynamic.4-87-r.retail.telecomitalia.it. [87.4.94.137]) by mx.google.com with ESMTPS id q22sm2140737bkv.16.2013.01.17.10.29.30 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Jan 2013 10:29:31 -0800 (PST) Message-ID: <50F84309.7010102@gmail.com> Date: Thu, 17 Jan 2013 19:29:29 +0100 From: Stefano Lattarini MIME-Version: 1.0 References: <20130117123615.GB1543@rhmail.home.annexia.org> In-Reply-To: <20130117123615.GB1543@rhmail.home.annexia.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 01/17/2013 01:36 PM, Richard W.M. Jones wrote: > I have a project that has a TESTS variable like this ('test_progs' is > defined elsewhere): > > TESTS = run-bindtests \ > $(sort \ > $(patsubst %,%.bc,$(test_progs)) \ > $(patsubst %,%.opt,$(test_progs))) > > This breaks with automake 1.13.1. 'make' gives unterminated variable > errors. It is fairly obvious why when you look at the generated code: > > run-bindtests.log: run-bindtests > @p='run-bindtests'; \ > b='run-bindtests'; \ > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > --log-file $$b.log --trs-file $$b.trs \ > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > - $(LOG_COMPILE) \ > "$$tst" $(AM_TESTS_FD_REDIRECT) > $(sort.log: $(sort > @p='$(sort'; \ > b='$(sort'; \ > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > --log-file $$b.log --trs-file $$b.trs \ > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > - $(LOG_COMPILE) \ > "$$tst" $(AM_TESTS_FD_REDIRECT) > $(patsubst.log: $(patsubst > @p='$(patsubst'; \ > b='$(patsubst'; \ > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > --log-file $$b.log --trs-file $$b.trs \ > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > - $(LOG_COMPILE) \ > "$$tst" $(AM_TESTS_FD_REDIRECT) > %,%.bc,$(test_progs)).log: %,%.bc,$(test_progs)) > > This used to work fine in automake <= 1.12. I also tried jamming the > whole thing into a single line, but that didn't help. > Does the thing work again if you use the 'serial-tests' option (which was the default before automake 1.13)? Regards, Stefano From unknown Sun Jun 22 17:15:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13477: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...) Resent-From: "Richard W.M. Jones" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 17 Jan 2013 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13477 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini Cc: 13477@debbugs.gnu.org Received: via spool by 13477-submit@debbugs.gnu.org id=B13477.13584536698182 (code B ref 13477); Thu, 17 Jan 2013 20:15:01 +0000 Received: (at 13477) by debbugs.gnu.org; 17 Jan 2013 20:14:29 +0000 Received: from localhost ([127.0.0.1]:37377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tvvr3-00027v-Gv for submit@debbugs.gnu.org; Thu, 17 Jan 2013 15:14:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65150) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tvvqw-00027e-MJ for 13477@debbugs.gnu.org; Thu, 17 Jan 2013 15:14:27 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HJK00d021486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Jan 2013 14:20:00 -0500 Received: from localhost (vpn1-5-145.ams2.redhat.com [10.36.5.145]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HJJxIo009790; Thu, 17 Jan 2013 14:19:59 -0500 Date: Thu, 17 Jan 2013 19:19:56 +0000 From: "Richard W.M. Jones" Message-ID: <20130117191956.GD1543@rhmail.home.annexia.org> References: <20130117123615.GB1543@rhmail.home.annexia.org> <50F84309.7010102@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50F84309.7010102@gmail.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On Thu, Jan 17, 2013 at 07:29:29PM +0100, Stefano Lattarini wrote: > On 01/17/2013 01:36 PM, Richard W.M. Jones wrote: > > I have a project that has a TESTS variable like this ('test_progs' is > > defined elsewhere): > > > > TESTS = run-bindtests \ > > $(sort \ > > $(patsubst %,%.bc,$(test_progs)) \ > > $(patsubst %,%.opt,$(test_progs))) > > > > This breaks with automake 1.13.1. 'make' gives unterminated variable > > errors. It is fairly obvious why when you look at the generated code: > > > > run-bindtests.log: run-bindtests > > @p='run-bindtests'; \ > > b='run-bindtests'; \ > > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > > --log-file $$b.log --trs-file $$b.trs \ > > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > > - $(LOG_COMPILE) \ > > "$$tst" $(AM_TESTS_FD_REDIRECT) > > $(sort.log: $(sort > > @p='$(sort'; \ > > b='$(sort'; \ > > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > > --log-file $$b.log --trs-file $$b.trs \ > > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > > - $(LOG_COMPILE) \ > > "$$tst" $(AM_TESTS_FD_REDIRECT) > > $(patsubst.log: $(patsubst > > @p='$(patsubst'; \ > > b='$(patsubst'; \ > > $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ > > --log-file $$b.log --trs-file $$b.trs \ > > $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ > > - $(LOG_COMPILE) \ > > "$$tst" $(AM_TESTS_FD_REDIRECT) > > %,%.bc,$(test_progs)).log: %,%.bc,$(test_progs)) > > > > This used to work fine in automake <= 1.12. I also tried jamming the > > whole thing into a single line, but that didn't help. > > > Does the thing work again if you use the 'serial-tests' option (which was the > default before automake 1.13)? Yes, specifying serial-tests does appear to have fixed this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top From unknown Sun Jun 22 17:15:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Richard W.M. Jones" Subject: bug#13477: closed (Re: bug#13477: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...)) Message-ID: References: <50F86579.7050901@gmail.com> <20130117123615.GB1543@rhmail.home.annexia.org> X-Gnu-PR-Message: they-closed 13477 X-Gnu-PR-Package: automake Reply-To: 13477@debbugs.gnu.org Date: Thu, 17 Jan 2013 20:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1358456282-11996-1" This is a multi-part message in MIME format... ------------=_1358456282-11996-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13477: automake 1.13 breaks when TESTS variable contains GNU make macros l= ike $(sort ...) which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13477@debbugs.gnu.org. --=20 13477: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13477 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1358456282-11996-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13477-done) by debbugs.gnu.org; 17 Jan 2013 20:57:27 +0000 Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvwWc-00036b-NP for submit@debbugs.gnu.org; Thu, 17 Jan 2013 15:57:27 -0500 Received: from mail-bk0-f44.google.com ([209.85.214.44]:43921) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvwWZ-00036R-Rk for 13477-done@debbugs.gnu.org; Thu, 17 Jan 2013 15:57:24 -0500 Received: by mail-bk0-f44.google.com with SMTP id w11so1668965bku.31 for <13477-done@debbugs.gnu.org>; Thu, 17 Jan 2013 12:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1uToTQeUP7pkvHOyqtnaIw+zd6Eauog93ecB7NrTx2M=; b=b+a+bJu2KmbfOV8J2Kvc7URBzetgluR3tMSZ633fPTriOs+N5ODdmbF0T0OVxo5wbk X4ZhFss8AhL1Rh49CWrzgr/WUl6Ue+fHFLzQKz35ocM5eIUgiuK1UMmkyBCeLtAoEGdF DlngvP8X0gDtIHFpH47/PTCvn4zlonX0HGtiDRmWc/a6Uu5NKle60Dr53O5tUBm+Ky97 30KWh13zH0FQ7Eq5FXvyw1EeEHejpZT54xMKrmcx/Du1QZm9/CBRjIaH4VrFUsr1nJ6v 4zfv8P5g1YkTd+wIAcpvy7Bkye81AbW1+UlctfG+YipjT7ga0xcFZrHEOxxg3iWcED9m uLHg== X-Received: by 10.204.11.78 with SMTP id s14mr1923490bks.118.1358456200316; Thu, 17 Jan 2013 12:56:40 -0800 (PST) Received: from [192.168.178.20] (host137-94-dynamic.4-87-r.retail.telecomitalia.it. [87.4.94.137]) by mx.google.com with ESMTPS id i20sm2496387bkw.5.2013.01.17.12.56.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Jan 2013 12:56:39 -0800 (PST) Message-ID: <50F86579.7050901@gmail.com> Date: Thu, 17 Jan 2013 21:56:25 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: "Richard W.M. Jones" Subject: Re: bug#13477: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...) References: <20130117123615.GB1543@rhmail.home.annexia.org> <50F84309.7010102@gmail.com> <20130117191956.GD1543@rhmail.home.annexia.org> In-Reply-To: <20130117191956.GD1543@rhmail.home.annexia.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13477-done Cc: 13477-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 01/17/2013 08:19 PM, Richard W.M. Jones wrote: > On Thu, Jan 17, 2013 at 07:29:29PM +0100, Stefano Lattarini wrote: >> On 01/17/2013 01:36 PM, Richard W.M. Jones wrote: >>> I have a project that has a TESTS variable like this ('test_progs' is >>> defined elsewhere): >>> >>> TESTS = run-bindtests \ >>> $(sort \ >>> $(patsubst %,%.bc,$(test_progs)) \ >>> $(patsubst %,%.opt,$(test_progs))) >>> >>> This breaks with automake 1.13.1. 'make' gives unterminated variable >>> errors. It is fairly obvious why when you look at the generated code: >>> >>> run-bindtests.log: run-bindtests >>> @p='run-bindtests'; \ >>> b='run-bindtests'; \ >>> $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ >>> --log-file $$b.log --trs-file $$b.trs \ >>> $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ >>> - $(LOG_COMPILE) \ >>> "$$tst" $(AM_TESTS_FD_REDIRECT) >>> $(sort.log: $(sort >>> @p='$(sort'; \ >>> b='$(sort'; \ >>> $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ >>> --log-file $$b.log --trs-file $$b.trs \ >>> $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ >>> - $(LOG_COMPILE) \ >>> "$$tst" $(AM_TESTS_FD_REDIRECT) >>> $(patsubst.log: $(patsubst >>> @p='$(patsubst'; \ >>> b='$(patsubst'; \ >>> $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ >>> --log-file $$b.log --trs-file $$b.trs \ >>> $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ >>> - $(LOG_COMPILE) \ >>> "$$tst" $(AM_TESTS_FD_REDIRECT) >>> %,%.bc,$(test_progs)).log: %,%.bc,$(test_progs)) >>> >>> This used to work fine in automake <= 1.12. I also tried jamming the >>> whole thing into a single line, but that didn't help. >>> >> Does the thing work again if you use the 'serial-tests' option (which was the >> default before automake 1.13)? > > Yes, specifying serial-tests does appear to have fixed this. > OK, as I suspected. The problem is that the use of GNU make built-in in TESTS was *never* supported by the parallel harness, unfortunately :-( Since that is nothing new, I'm closing this bug report. Thanks, Stefano ------------=_1358456282-11996-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Jan 2013 17:09:10 +0000 Received: from localhost ([127.0.0.1]:37229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tvsxf-0006EL-Ns for submit@debbugs.gnu.org; Thu, 17 Jan 2013 12:09:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55210) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TvoiQ-0008KR-Gd for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:37:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvohk-0004F8-Km for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:36:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-106.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohk-0004F4-Hu for submit@debbugs.gnu.org; Thu, 17 Jan 2013 07:36:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohj-0006Ws-Fq for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvohg-0004EO-Tz for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvohg-0004E7-MP for bug-automake@gnu.org; Thu, 17 Jan 2013 07:36:20 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HCaIFv002269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 07:36:18 -0500 Received: from localhost (vpn1-5-145.ams2.redhat.com [10.36.5.145]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HCaHvF024185 for ; Thu, 17 Jan 2013 07:36:18 -0500 Date: Thu, 17 Jan 2013 12:36:15 +0000 From: "Richard W.M. Jones" To: bug-automake@gnu.org Subject: automake 1.13 breaks when TESTS variable contains GNU make macros like $(sort ...) Message-ID: <20130117123615.GB1543@rhmail.home.annexia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 17 Jan 2013 12:09:06 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) I have a project that has a TESTS variable like this ('test_progs' is defined elsewhere): TESTS = run-bindtests \ $(sort \ $(patsubst %,%.bc,$(test_progs)) \ $(patsubst %,%.opt,$(test_progs))) This breaks with automake 1.13.1. 'make' gives unterminated variable errors. It is fairly obvious why when you look at the generated code: run-bindtests.log: run-bindtests @p='run-bindtests'; \ b='run-bindtests'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(sort.log: $(sort @p='$(sort'; \ b='$(sort'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(patsubst.log: $(patsubst @p='$(patsubst'; \ b='$(patsubst'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) %,%.bc,$(test_progs)).log: %,%.bc,$(test_progs)) This used to work fine in automake <= 1.12. I also tried jamming the whole thing into a single line, but that didn't help. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top ------------=_1358456282-11996-1--