From unknown Thu Jun 19 14:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13439: 24.4.50; improvement of describe-variable/pp Resent-From: shigeru.fukaya@gmail.com Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jan 2013 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13439@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135819722219621 (code B ref -1); Mon, 14 Jan 2013 21:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2013 21:00:22 +0000 Received: from localhost ([127.0.0.1]:60335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tur8n-00056O-RG for submit@debbugs.gnu.org; Mon, 14 Jan 2013 16:00:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42633) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tur8m-00056H-2s for submit@debbugs.gnu.org; Mon, 14 Jan 2013 16:00:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tur17-0004Hk-Pi for submit@debbugs.gnu.org; Mon, 14 Jan 2013 15:52:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tur17-0004Hg-LB for submit@debbugs.gnu.org; Mon, 14 Jan 2013 15:52:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tur0l-0001Co-Mr for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2013 15:52:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tur0f-00048h-8m for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2013 15:52:03 -0500 Received: from mail-da0-f43.google.com ([209.85.210.43]:47390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tur0f-00048P-2N for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2013 15:51:57 -0500 Received: by mail-da0-f43.google.com with SMTP id u36so1974647dak.2 for ; Mon, 14 Jan 2013 12:51:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:mime-version:content-type :content-transfer-encoding:x-mailer:message-id; bh=dOQyREgIUYrolCelS13cyv0He4nbRzel6+la8LHLegI=; b=nmDJE+BHj7d0vAZINhI43RSsxmlPHP9u1ytquto1U0H1V+jfUg+/EuUGt5UkaTUy0D FtEsjnSD8KsRzuwRwg60ReOaY739S2FpzfPNFzoSt8oFXa3qxI6vQSywVewKE4Q2/yzA OxUuyme0h1GHmAbV7AtIDgLmphmjTKZqYoopSpVDACJjUIZhyjDy0uR2lQtf1yKEl1Ly 6x5ujVIGlEduglEwZP7Agc61OZDUEXFpVm0dqLSAn8W7aJF3SPd+rK2JLyUTNjwIO2Qz nr1o1W4DTLbuQfHFAflUv+AXRVckhSoCqTBCY5XVnvMxT8kEFCDgbndcp39uCT/Ws6Y0 uN2g== X-Received: by 10.68.233.99 with SMTP id tv3mr75956810pbc.64.1358196715419; Mon, 14 Jan 2013 12:51:55 -0800 (PST) Received: from gmail.com (115x125x38x6.ap115.ftth.ucom.ne.jp. [115.125.38.6]) by mx.google.com with ESMTPS id o5sm9339797paz.32.2013.01.14.12.51.52 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 14 Jan 2013 12:51:53 -0800 (PST) From: shigeru.fukaya@gmail.com Date: Tue, 15 Jan 2013 05:51:52 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: HidemaruMail 6.00 (WinNT,601) Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Hi, `describe-variable' is very slow for large objects. It is mainly because `pp' used in it is slow on that case (comments say `take an age'). When `pp' is to a buffer, in other words, output stream is a buffer, current code is as follows: 1) Output the object to a temporary buffer. 2) Convert the buffer contents to a string. 3) Insert the string to an output buffer. If the insertion is directry from the temporary buffer without conversion, things go better dramatically. Regards, Shigeru From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 06 22:49:54 2016 Received: (at control) by debbugs.gnu.org; 7 Dec 2016 03:49:54 +0000 Received: from localhost ([127.0.0.1]:58676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cETEv-0001VM-V9 for submit@debbugs.gnu.org; Tue, 06 Dec 2016 22:49:54 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:34975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cETEu-0001V7-J8; Tue, 06 Dec 2016 22:49:52 -0500 Received: by mail-io0-f193.google.com with SMTP id h133so25679279ioe.2; Tue, 06 Dec 2016 19:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fOUiZOxPeB0yjhSpA/vp9gH6BJ502VIMjT5X31O30lY=; b=BOjar0fTigaemD2PpzBblHytioOYTrCkMdGVSZ5YJW0cLS15gHgjvsehA6ir7vziUt ilDkhaZcAm/CSm7UoiePjlSRbXvj9JxyhfZyuBfKrJ3pQtUQHJtPd6EglXQ2b0+g07Iz s97XT3IA+jYKHtF/S7ljpvHidZQ06W1mETvvoiBZBpwuflV44inQKHNCOPGBhdfH41Jn r0drHKI2tr5ysq0L82cH0kNN8bI09rlWGUWJpjhUNZz0T6+kHqUUYIB3z+2cG73RVjcb CTFQ7BpFuiFtoJiHakVbLGUgpfyqIZvnu6IElELWWuS8sb6ZjWn3SHZofP871z1oDgk6 2Sag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=fOUiZOxPeB0yjhSpA/vp9gH6BJ502VIMjT5X31O30lY=; b=AzmV/NSoj78x6j+ioyRjoKVPOvttN1KLhwOxuEiqtdqFezJmCPBGhOr90Jtbcul9Bi DEvUajM5SrqCgkwU/QHWlKBM6VpljR4E7i8AW4fCUR28ZxvitGEsEnKUdJQ+LaHkZWS9 qxzZo9oNOpeLt8XVzpUYP7iVfHGn6ONRePa6a7ylE0eIpwSvyVzjj08c2kc1woDDBvR7 l7PHyZOj8jckIHH8Sap5uMKHHvviKa3QrL3LXZjA8KecUusHp14xErSUmx/WW7nSG6nt Uvwqn/W2nm1oXACfi+NYG3FLVPIVbWOedM9Of3rfRGCBms2RnTUfKhGYbCvtuIxvUSsf 6lhw== X-Gm-Message-State: AKaTC00txrM+UisMmVJM0ncBdwmIgDHWeAx+WZB3B5jwxM7sVRLKq8I+f7WSXsAfop1Ftg== X-Received: by 10.36.127.84 with SMTP id r81mr548332itc.57.1481082587067; Tue, 06 Dec 2016 19:49:47 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 9sm2753553itv.0.2016.12.06.19.49.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Dec 2016 19:49:46 -0800 (PST) From: npostavs@users.sourceforge.net To: Thierry Volpiatto Subject: Re: bug#25122: 24.5; function describe-variable hangs on large variables References: <20161206022112.GF25778@E15-2016.optimum.net> <87twahk19y.fsf@gmail.com> Date: Tue, 06 Dec 2016 22:50:46 -0500 In-Reply-To: <87twahk19y.fsf@gmail.com> (Thierry Volpiatto's message of "Tue, 06 Dec 2016 07:41:13 +0100") Message-ID: <87d1h4fld5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 25122@debbugs.gnu.org, Boruch Baum X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) merge 13439 25122 quit Thierry Volpiatto writes: > Boruch Baum writes: > >> Subject: 24.5; function describe-variable hangs on large variables >> >> 1) When evaluating function describe-variable for variable >> package-archive-conteqnts, emacs hangs for minutes before I gave up. > > I have already reported this bug. > I use this to workaround it: I wonder if the suggestion in #13439 might also help? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 00:46:30 2017 Received: (at control) by debbugs.gnu.org; 13 Mar 2017 04:46:30 +0000 Received: from localhost ([127.0.0.1]:53127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnHsL-0001my-Tw for submit@debbugs.gnu.org; Mon, 13 Mar 2017 00:46:30 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:37445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnHsJ-0001mg-M6; Mon, 13 Mar 2017 00:46:28 -0400 Received: by mail-it0-f43.google.com with SMTP id g138so25236000itb.0; Sun, 12 Mar 2017 21:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+HVfNan0vzQbhsFpVI3DS0tkNCwHH97eXeXRsVbcBjo=; b=UMY3uVeUNDTxRdi96i2yfH4q5h/D3IQ484RDHqw1DV4ksKrxqvreNjtECcGYj142Np nGyXxMm2Jpw0KIlkJzYFEi+zIfPdIy2HR6HPfigAE10BUKhx8I1ArHbj4an+pnNTOlXg jearI/37Rsa/alLW/FbqUgipgqTkpfjMIgml7i9fm1XGyCsdIVY6Z0MSIs+Oc8PAS3+w 7eigdt7alR4kw7zV9ik7K87Co9lzqQlQbtC99Mh0fpQ8DgK2r16EFy4RmtwrlqXn/Mfp 9QqBucgg+WQuIL3jXnm5mkI/QPs/Yj0u6Wj9jAPSQdp3YALlJ4mkMoGEt53OK4MrXrUy 0zvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+HVfNan0vzQbhsFpVI3DS0tkNCwHH97eXeXRsVbcBjo=; b=ZUfrUTyAjt21TtuMJH3LlolP5XMwjccEf5Wjkg/PABbuNmnf3nZr3keKO5qpdSEJKX 87MPQxxvE9F5sP6kp7Rv8ChSO+BVK+KaMUoiaMgyRcPxLj+v8/qKaZ2w2u1Mk4zHNogF CC1lWzG0WF9mo75/rmyfhrr0UuFyxUy7KKnBB88P6zOT0dJT9ljx0sTQm2wI4BkLqrjC uPb+Tmnlw4jw5eVVuaNywfHXQr8g9dfesJv6iV5Os20MFJqMGwIATDOK5JMSKJ3/yzQd ErQYYU1Rvr4ejq15x2IPW4pOJUWQz2Gno36kGAM6OJ/68iI5klsmTlUQBaO6d8/wzOtn i8hg== X-Gm-Message-State: AFeK/H3d87TE8551ojJet+4S4hGDfh0WO1KWmsvoXP3CiUAjC4Z3ZaZuoou3OoGw/f+dwA== X-Received: by 10.36.153.197 with SMTP id a188mr9297425ite.5.1489380382055; Sun, 12 Mar 2017 21:46:22 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 62sm3744204itl.1.2017.03.12.21.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Mar 2017 21:46:21 -0700 (PDT) From: npostavs@users.sourceforge.net To: Thierry Volpiatto Subject: Re: bug#25122: 24.5; function describe-variable hangs on large variables References: <20161206022112.GF25778@E15-2016.optimum.net> <87twahk19y.fsf@gmail.com> <87d1h4fld5.fsf@users.sourceforge.net> <871sxkyv2m.fsf@gmail.com> <87mvcs8j7w.fsf@users.sourceforge.net> <87lgsbtxwe.fsf@gmail.com> <871su38ogm.fsf@users.sourceforge.net> <87d1dnrq96.fsf@gmail.com> <87wpbu7f9i.fsf@users.sourceforge.net> <87r32278wf.fsf@users.sourceforge.net> Date: Mon, 13 Mar 2017 00:47:38 -0400 In-Reply-To: <87r32278wf.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sun, 12 Mar 2017 12:32:48 -0400") Message-ID: <87lgs97pg5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 25122@debbugs.gnu.org, Stefan Monnier , Boruch Baum X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain tags 25122 patch quit npostavs@users.sourceforge.net writes: > Also, this doesn't really solve the performance problem, it just makes > it much less likely to occur, e.g., (pp (list load-history)) is still > slow. Okay, I think I found the real fix now: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-reparse-the-sexp-in-indent-sexp-Bug-25122.patch Content-Description: patch >From 5188d6e366426d83934505296b585744f50e24a5 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 12 Mar 2017 23:59:19 -0400 Subject: [PATCH] Don't reparse the sexp in indent-sexp (Bug#25122) * lisp/emacs-lisp/lisp-mode.el (calculate-lisp-indent): Let PARSE-START be a parse state that can be reused. (indent-sexp): Pass the running parse state to calculate-lisp-indent instead of the sexp beginning position. --- lisp/emacs-lisp/lisp-mode.el | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index eb07c18b03..8d4abc24e8 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -781,6 +781,10 @@ calculate-lisp-indent If the value is nil, that means don't change the indentation because the line starts inside a string. +PARSE-START may be a buffer position to start parsing from, or a +parse state as returned by calling `parse-partial-sexp' up to the +beginning of the current line. + The value can also be a list of the form (COLUMN CONTAINING-SEXP-START). This means that following lines at the same level of indentation should not necessarily be indented the same as this line. @@ -794,12 +798,14 @@ calculate-lisp-indent (desired-indent nil) (retry t) calculate-lisp-indent-last-sexp containing-sexp) - (if parse-start - (goto-char parse-start) - (beginning-of-defun)) - ;; Find outermost containing sexp - (while (< (point) indent-point) - (setq state (parse-partial-sexp (point) indent-point 0))) + (cond ((or (markerp parse-start) (integerp parse-start)) + (goto-char parse-start)) + ((null parse-start) (beginning-of-defun)) + (t (setq state parse-start))) + (unless state + ;; Find outermost containing sexp + (while (< (point) indent-point) + (setq state (parse-partial-sexp (point) indent-point 0)))) ;; Find innermost containing sexp (while (and retry state @@ -1070,11 +1076,6 @@ indent-sexp ENDPOS is encountered." (interactive) (let* ((indent-stack (list nil)) - ;; If ENDPOS is non-nil, use beginning of defun as STARTING-POINT. - ;; If ENDPOS is nil, it is safe not to scan before point - ;; since every line we indent is more deeply nested than point is. - (starting-point (save-excursion (if endpos (beginning-of-defun)) - (point))) ;; Use `syntax-ppss' to get initial state so we don't get ;; confused by starting inside a string. We don't use ;; `syntax-ppss' in the loop, because this is measurably @@ -1132,8 +1133,12 @@ indent-sexp (unless (or (eolp) (eq (char-syntax (char-after)) ?<)) (let ((this-indent (car indent-stack))) (when (listp this-indent) - (let ((val (calculate-lisp-indent - (or (car this-indent) starting-point)))) + ;; The state here is actually to the end of the + ;; previous line, but that's fine for our purposes. + ;; And continuing the parse to the next line would + ;; destroy element 2 (last sexp position) which + ;; `calculate-lisp-indent' needs. + (let ((val (calculate-lisp-indent state))) (setq this-indent (cond ((integerp val) -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 14:24:04 2017 Received: (at control) by debbugs.gnu.org; 22 Apr 2017 18:24:04 +0000 Received: from localhost ([127.0.0.1]:34666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1zhU-0005rx-Gd for submit@debbugs.gnu.org; Sat, 22 Apr 2017 14:24:04 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:33651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1zhT-0005rP-9s; Sat, 22 Apr 2017 14:24:03 -0400 Received: by mail-it0-f66.google.com with SMTP id z67so5860187itb.0; Sat, 22 Apr 2017 11:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EmOKstKSIMAmqrj6uwsHED6XBgSQ74VP3nzKYsKlZ6Q=; b=VmIWyi4T6aAjuAdfzWrf+j0/kbWZYD1APu7GFv6NGgQ1fKkPbIRckojRiYyr7THot/ j9n1lUFBWWCeVu7X+9eY7iIQQaZupDGocZ/oqQNrvxKIJekM0ONq7vSJWJ3T9Q/dnW3R 07ObNeGY53Zcq+eBFPoA81xAEVPd6C+264SY6Lz+E2t7lp92Bn+1SkVQxJISzJlGaGo2 DRCD2ALUrF7V6N8DQNDaP2HEiSCmYDSOv3jrsSsHBcvMkEDz1iouBI5nEDFD85FkkTnX 4KjpwM9Wt6zp8gGO8JNDJf3/rsINxg7+YMFfUJpCV5ktbC/Y4CYKGwjArtvATe4NVmeg kJBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=EmOKstKSIMAmqrj6uwsHED6XBgSQ74VP3nzKYsKlZ6Q=; b=ZMCt55TuRWfTL5qRaDMeshpew6lAi/s42l4Ub4gs4uNV4NgTmwyd8WXIzqe02XbUVQ mL//foI18pnsg74fkWfP5Gs/ASPFL9ZXMU8gNAxFHzII/rQ00c0SZr+Ew73Mn62e5L0Y df1tntQIB2XUFbief6lr/twmCdIri5aNA3/SPpVAMyG+rCUmyHlt0nR4k1nwzL1/ojrp +Ug4HmHyEZ1JEcr6b31dDAHG6i9sjlt09DgFDbrjFFbwcB8Tssyph3ZOflEF6C1MUlU3 w0bXiSGhgJDog1awDEqqzNjn9C3M4iWk8yv80ZHUAHxjGNGQJerSgmOicmuI9hdTdaOU 1tDQ== X-Gm-Message-State: AN3rC/7iyNEfMbiiRkjCXO9vEirvm2CoPPYi5Dq4gSfErQ815WtVa4nD aCBU9prW6FXUKw== X-Received: by 10.36.95.144 with SMTP id r138mr5227406itb.11.1492885437857; Sat, 22 Apr 2017 11:23:57 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e191sm2233256ita.9.2017.04.22.11.23.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Apr 2017 11:23:57 -0700 (PDT) From: npostavs@users.sourceforge.net To: Thierry Volpiatto Subject: Re: bug#25122: 24.5; function describe-variable hangs on large variables References: <20161206022112.GF25778@E15-2016.optimum.net> <87twahk19y.fsf@gmail.com> <87d1h4fld5.fsf@users.sourceforge.net> <871sxkyv2m.fsf@gmail.com> <87mvcs8j7w.fsf@users.sourceforge.net> <87lgsbtxwe.fsf@gmail.com> <871su38ogm.fsf@users.sourceforge.net> <87d1dnrq96.fsf@gmail.com> <87wpbu7f9i.fsf@users.sourceforge.net> <87r32278wf.fsf@users.sourceforge.net> <87lgs97pg5.fsf@users.sourceforge.net> <87innd6zti.fsf@users.sourceforge.net> <878to653tr.fsf@users.sourceforge.net> <87fuh6s75x.fsf@users.sourceforge.net> Date: Sat, 22 Apr 2017 14:25:27 -0400 In-Reply-To: <87fuh6s75x.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 17 Apr 2017 23:53:30 -0400") Message-ID: <87mvb8paeg.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 25122@debbugs.gnu.org, Stefan Monnier , Boruch Baum X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 25122 fixed close 25122 26.1 quit npostavs@users.sourceforge.net writes: > > I intend to close this bug as fixed after merging these, as this does > fix the performance bug. Pushed to master. [1: 6fa9cc0593]: 2017-04-22 14:18:46 -0400 ; Merge: improve indent-sexp and lisp-indent-region performance http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6fa9cc0593150a318f0e08e69ec10672d548a7c1 [2: 4713dd425b]: 2017-04-22 14:09:58 -0400 Add new `lisp-indent-region' that doesn't reparse the code. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4713dd425beac5cb459704e67dcb8f6faf714375 [3: 2f6769f9cd]: 2017-04-22 14:09:58 -0400 Remove ignored argument from lisp-indent-line http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2f6769f9cdb799e880fdcc09057353a0a2349bfc [4: 8bb5d7adaf]: 2017-04-22 14:09:57 -0400 * lisp/emacs-lisp/lisp-mode.el (indent-sexp): Clean up marker. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8bb5d7adaf45264900385530c7f76175ba490a77 [5: 43c84577a3]: 2017-04-22 14:09:57 -0400 Don't reparse the sexp in indent-sexp (Bug#25122) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=43c84577a3055d5ddf1f5d1b999e6ecca6139f60