GNU bug report logs - #1343
[PATCH] trace package

Previous Next

Full log

Message #39 received at 1343 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: psainty <at> orcon.net.nz, 1343 <at> debbugs.gnu.org, 27397 <at> debbugs.gnu.org,
 michael.albinus <at> gmx.de, dgutov <at> yandex.ru
Subject: Re: bug#27397: [PATCH] New commands for bulk tracing of elisp
 functions
Date: Sun, 11 Sep 2022 15:33:32 +0300

> Cc: 1343 <at> debbugs.gnu.org, 27397 <at> debbugs.gnu.org,
>  Michael Albinus <michael.albinus <at> gmx.de>, Dmitry Gutov <dgutov <at> yandex.ru>
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 11 Sep 2022 13:49:51 +0200
> 
> Phil Sainty <psainty <at> orcon.net.nz> writes:
> 
> > After a brief hiatus, I've resumed (maybe completed) my work on this.
> >
> > The branch scratch/bulk-tracing contains the updated code for Emacs 29
> > (rebased over master).
> 
> For reference, I've included the diff between master and the branch
> below.
> 
> I have not tried the patch myself -- does anybody have any comments
> here?  It seems like useful functionality to me.

Yes, it is useful.

The documentation uses UK English spelling ("behaviour").  (Perhaps
today this is justified, but since a few days will have passed until
this is landed, I think we should use US English conventions
nonetheless.)

I see lack of important detail where stuff like 'context' and
'trace-value' is described: at the very least the manual should say
whether the text will be inserted verbatim, or with something like
newlines and/or other decorations added.

IMO, the description of trace-value should be before all the untrace-*
functions.

Why isn't trace-is-traceable-p documented in the manual?  It sounds
relevant to the discussion of the restrictions.

I think the description should be updated fore native-compilation (it
only mentions byte-compilation).

The hunk from modes.texi seems unrelated.

The NEWS entry should have a single-line heading that is a full
sentence ending with a period.

Please verify that doc strings of functions mention all the
arguments.  (E.g., trace-currently-traced doesn't.)

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.