From unknown Fri Jun 20 07:23:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13379 <13379@debbugs.gnu.org> To: bug#13379 <13379@debbugs.gnu.org> Subject: Status: 24.3.50; compilation-start-hook: misleading docstring Reply-To: bug#13379 <13379@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:23:14 +0000 retitle 13379 24.3.50; compilation-start-hook: misleading docstring reassign 13379 emacs submitter 13379 Christopher Schmidt severity 13379 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 07 15:13:25 2013 Received: (at submit) by debbugs.gnu.org; 7 Jan 2013 20:13:25 +0000 Received: from localhost ([127.0.0.1]:34681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsJ4U-0002Rj-66 for submit@debbugs.gnu.org; Mon, 07 Jan 2013 15:13:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39125) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TsJ4L-0002RL-Tz for submit@debbugs.gnu.org; Mon, 07 Jan 2013 15:13:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJ49-0006jn-0m for submit@debbugs.gnu.org; Mon, 07 Jan 2013 15:13:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJ48-0006jj-TX for submit@debbugs.gnu.org; Mon, 07 Jan 2013 15:13:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJ45-0003Bg-SG for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2013 15:13:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJ42-0006iu-JY for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2013 15:12:57 -0500 Received: from ristopher.com ([146.185.21.93]:40910 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJ42-0006ih-Bi for bug-gnu-emacs@gnu.org; Mon, 07 Jan 2013 15:12:54 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 7D1EB203F6; Mon, 7 Jan 2013 20:12:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1357589571; bh=J11NbspTN3brsaj3WQLxyFsjYI25ccEBK/dOQoe/70o=; h=From:To:Subject:Message-ID:MIME-Version:Content-Type:Date; b=FupeSax/7Qu+gqAx4na0lJ5Ts1tukEYT8Abj5In+Z9WUVU+vF7QvH97G761WtUzfy piPEtbqDWDfTUJSjHjGP3D3k8PZ9gk23m9OSjqxe2Nb4PbL2scM2j/0OEdp68CfoZ6 O0rC+iCcF4PDfPqNEVX/RivO2FZPJ9xKs0aViPvE= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: 24.3.50; compilation-start-hook: misleading docstring Message-ID: <87lic4zr96@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Mon, 7 Jan 2013 20:12:51 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Severity: minor The docstring of compilation-start-hook is misleading. The reference to run-hook-with-args is superfluous, so is the reference to omake. I do not think set-process-query-on-exit-flag should be used in compilation-start-hook - compilation-always-kill is the way to go, or it should be explained why the lambda is added buffer locally and where this form should be evaled. Christopher From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 01:33:02 2013 Received: (at 13379-done) by debbugs.gnu.org; 2 Feb 2013 06:33:02 +0000 Received: from localhost ([127.0.0.1]:60271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Wer-0007n1-Em for submit@debbugs.gnu.org; Sat, 02 Feb 2013 01:33:02 -0500 Received: from ristopher.com ([146.185.21.93]:35797 helo=saturn.ch.ristopher.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Weo-0007mn-6o for 13379-done@debbugs.gnu.org; Sat, 02 Feb 2013 01:32:59 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 99C5020433; Sat, 2 Feb 2013 06:32:04 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1359786724; bh=Oxz0KxKb/CxwDVEx1fsr2uxksLraaK0ZuxlkKxlD+sY=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=i5JkoQqLl9/XaYRnTfSo+FbEy/gxwdlyF10NwxZGxijmWGCu5XayyBodfrotWlVXa nW/lrBKHM9yw5fIF2Oh3Gj6y9lIDXXO9qkUZqY37akXoO/2KogQ+Q/Q2HVDuQ1fOGF EdzrHWndRGXwjS0Q+JtDK9tZPGdXq6kpHmd8URFM= From: Christopher Schmidt To: 13379-done@debbugs.gnu.org Subject: Re: bug#13379: 24.3.50; compilation-start-hook: misleading docstring In-Reply-To: <87lic4zr96@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 7 Jan 2013 20:12:51 +0000 (GMT)") Message-ID: <87mwvnxm3f@ch.ristopher.com> References: <87lic4zr96@ch.ristopher.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sat, 2 Feb 2013 06:32:04 +0000 (GMT) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 13379-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Christopher Schmidt writes: > The docstring of compilation-start-hook is misleading. > > The reference to run-hook-with-args is superfluous, so is the > reference to omake. I do not think set-process-query-on-exit-flag > should be used in compilation-start-hook - compilation-always-kill is > the way to go, or it should be explained why the lambda is added > buffer locally and where this form should be evaled. I went ahead and committed this in r111661. --=-=-= Content-Type: text/x-diff Content-Disposition: inline --- lisp/ChangeLog +++ lisp/ChangeLog @@ -2,6 +2,7 @@ * progmodes/compile.el (compilation-error-regexp-alist-alist): Identify g++ template instantiation trace. (Bug#12287) + (compilation-start-hook): Simplify docstring. (Bug#13379) 2013-02-02 Stefan Monnier --- lisp/progmodes/compile.el +++ lisp/progmodes/compile.el @@ -48,12 +48,8 @@ ;;;###autoload (defcustom compilation-start-hook nil - "List of hook functions run by `compilation-start' on the compilation process. -\(See `run-hook-with-args'). -If you use \"omake -P\" and do not want \\[save-buffers-kill-terminal] to ask whether you want -the compilation to be killed, you can use this hook: - (add-hook 'compilation-start-hook - (lambda (process) (set-process-query-on-exit-flag process nil)) nil t)" + "Hook run after starting a new compilation process. The hook +is run with one argument, the new process." :type 'hook :group 'compilation) --=-=-= Content-Type: text/plain If there is any doubt whatsoever regarding what I have just done, please revert immediately and reopen the bug. Thank you! Christopher --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 02:40:22 2013 Received: (at 13379) by debbugs.gnu.org; 2 Feb 2013 07:40:22 +0000 Received: from localhost ([127.0.0.1]:60370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Xi0-0001LI-68 for submit@debbugs.gnu.org; Sat, 02 Feb 2013 02:40:21 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:49342) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Xhv-0001L2-Ie for 13379@debbugs.gnu.org; Sat, 02 Feb 2013 02:40:17 -0500 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3YynBL23rLz4KK4L; Sat, 2 Feb 2013 08:39:21 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3YynBK6VJ5zbggC; Sat, 2 Feb 2013 08:39:21 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id RtZqFzpxnbbE; Sat, 2 Feb 2013 08:38:22 +0100 (CET) X-Auth-Info: TYRAtdVEbVkLJ0c2MY68aK1Tgpd2fIiR916y9JCngUw= Received: from linux.local (ppp-93-104-155-66.dynamic.mnet-online.de [93.104.155.66]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 2 Feb 2013 08:39:20 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id 390611E550D; Sat, 2 Feb 2013 08:39:19 +0100 (CET) From: Andreas Schwab To: 13379@debbugs.gnu.org Subject: Re: bug#13379: 24.3.50; compilation-start-hook: misleading docstring References: <87lic4zr96@ch.ristopher.com> <87mwvnxm3f@ch.ristopher.com> X-Yow: The appreciation of the average visual graphisticator alone is worth the whole suaveness and decadence which abounds!! Date: Sat, 02 Feb 2013 08:39:19 +0100 In-Reply-To: <87mwvnxm3f@ch.ristopher.com> (Christopher Schmidt's message of "Sat, 2 Feb 2013 06:32:04 +0000 (GMT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 13379 Cc: christopher@ch.ristopher.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Christopher Schmidt writes: > + "Hook run after starting a new compilation process. The hook The first line of a doc string should always be a complete sentence, only. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 03:47:25 2013 Received: (at submit) by debbugs.gnu.org; 2 Feb 2013 08:47:25 +0000 Received: from localhost ([127.0.0.1]:60427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Ykv-0003LU-4K for submit@debbugs.gnu.org; Sat, 02 Feb 2013 03:47:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37867) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1Yks-0003LJ-Eq for submit@debbugs.gnu.org; Sat, 02 Feb 2013 03:47:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1Yjz-0000nu-O2 for submit@debbugs.gnu.org; Sat, 02 Feb 2013 03:46:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Yjz-0000nq-Kx for submit@debbugs.gnu.org; Sat, 02 Feb 2013 03:46:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Yjx-0002AV-1N for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 03:46:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1Yjt-0000mz-IM for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 03:46:24 -0500 Received: from ristopher.com ([146.185.21.93]:52847 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Yjt-0000ma-9x for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 03:46:21 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 38E3920433; Sat, 2 Feb 2013 08:46:18 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1359794778; bh=bh37aPK5tl6nQQNiMv12q6QelzdBfJO5ZZW0UKl1rEU=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=ngyGKptyr94MHcSDVGxtLvtAow2qMb6vwGafKyecP60lvScZEioN2bunyJ7M9MHm+ VwfnoiFRVb0QwKS/s6z3uVQAE1Y3nl6GizJScD+alpb/S8VsNKTtcqZnhd3HNy+9ZA aYS0ilyGwJ8sF0n5NhGR5ZW67g93V/d0CeFZz2Dg= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: Re: bug#13379: 24.3.50; compilation-start-hook: misleading docstring In-Reply-To: (Andreas Schwab's message of "Sat, 02 Feb 2013 08:39:19 +0100") Message-ID: <87vcabayte@ch.ristopher.com> References: <87lic4zr96@ch.ristopher.com> <87mwvnxm3f@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Sat, 2 Feb 2013 08:46:17 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Andreas Schwab writes: > Christopher Schmidt writes: > >> + "Hook run after starting a new compilation process. The hook > > The first line of a doc string should always be a complete sentence, > only. I fixed the fix. Christopher From unknown Fri Jun 20 07:23:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Mar 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator