From unknown Tue Jun 17 01:47:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jan 2013 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13348@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.135723876214037 (code B ref -1); Thu, 03 Jan 2013 18:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2013 18:46:02 +0000 Received: from localhost ([127.0.0.1]:41903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqpnk-0003eI-Lv for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:46:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57349) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqpnh-0003e8-F5 for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqpne-0005Ko-1e for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpnd-0005Kj-Uk for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpnc-00056H-Po for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqpnb-0005K5-2V for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:39729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpna-0005Jt-RG for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:50 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r03IjnPw016175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Jan 2013 18:45:50 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r03IjmiH023829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 3 Jan 2013 18:45:49 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r03IjmBW004097 for ; Thu, 3 Jan 2013 12:45:48 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Jan 2013 10:45:48 -0800 From: "Drew Adams" Date: Thu, 3 Jan 2013 10:45:47 -0800 Message-ID: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac3p4ouF2HMQ0lPMT2qiJMqF0/Go1Q== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) `M-e' in Isearch is `isearch-edit-string'. Here is its doc: Edit the search string in the minibuffer. The following additional command keys are active while editing. M-x exit-minibuffer to resume incremental searching with the edited string. RET to do one nonincremental search. C-s to resume isearching forward. C-r to resume isearching backward. C-M-i to complete the search string using the search ring. C-x 8 RET to insert a Unicode character by name (with completion). If first char entered is C-w, then do word search instead. Now do this: `C-s M-e C-h k C-s'. You see this: C-s runs the command isearch-forward-exit-minibuffer, which is an interactive compiled Lisp function in `isearch.el'. It is bound to C-s. (isearch-forward-exit-minibuffer) Not documented. Not documented? Why not? Emacs users deserve better. These commands (for keys `C-s', `C-r', `RET') are explicitly called out in the doc for `isearch-edit-string'. They should have doc strings. `C-M-i' (`isearch-complete-edit') does, and so should all of the other keys mentioned in the doc of `isearch-edit-string'. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2012-12-31 on ODIEONE Bzr revision: 111388 rudalics@gmx.at-20121231113513-subz2dazg6yjukzh Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' From unknown Tue Jun 17 01:47:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jan 2013 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 13348@debbugs.gnu.org Received: via spool by 13348-submit@debbugs.gnu.org id=B13348.135725860125096 (code B ref 13348); Fri, 04 Jan 2013 00:17:02 +0000 Received: (at 13348) by debbugs.gnu.org; 4 Jan 2013 00:16:41 +0000 Received: from localhost ([127.0.0.1]:42213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tquxk-0006Wi-MZ for submit@debbugs.gnu.org; Thu, 03 Jan 2013 19:16:40 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:58889 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tquxg-0006WJ-IP for 13348@debbugs.gnu.org; Thu, 03 Jan 2013 19:16:37 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id CE830229B80729; Thu, 3 Jan 2013 16:16:31 -0800 (PST) From: Juri Linkov Organization: JURTA References: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> Date: Fri, 04 Jan 2013 02:04:28 +0200 In-Reply-To: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> (Drew Adams's message of "Thu, 3 Jan 2013 10:45:47 -0800") Message-ID: <87a9spu7t7.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > (isearch-forward-exit-minibuffer) > > Not documented. > > Not documented? Why not? Emacs users deserve better. Is this what you expected? === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-01-02 16:13:04 +0000 +++ lisp/isearch.el 2013-01-04 00:03:23 +0000 @@ -1291,11 +1293,13 @@ (defun isearch-nonincremental-exit-minib (exit-minibuffer)) (defun isearch-forward-exit-minibuffer () + "Resume isearching forward." (interactive) (setq isearch-new-forward t) (exit-minibuffer)) (defun isearch-reverse-exit-minibuffer () + "Resume isearching backward." (interactive) (setq isearch-new-forward nil) (exit-minibuffer)) From unknown Tue Jun 17 01:47:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jan 2013 00:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Juri Linkov'" Cc: 13348@debbugs.gnu.org Received: via spool by 13348-submit@debbugs.gnu.org id=B13348.135726013527679 (code B ref 13348); Fri, 04 Jan 2013 00:43:02 +0000 Received: (at 13348) by debbugs.gnu.org; 4 Jan 2013 00:42:15 +0000 Received: from localhost ([127.0.0.1]:42246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqvMU-0007CM-MC for submit@debbugs.gnu.org; Thu, 03 Jan 2013 19:42:15 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36468) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqvMS-0007CE-1D for 13348@debbugs.gnu.org; Thu, 03 Jan 2013 19:42:13 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r040g6v2016839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Jan 2013 00:42:07 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r040g6uL010967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Jan 2013 00:42:06 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r040g5IX007220; Thu, 3 Jan 2013 18:42:05 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Jan 2013 16:42:05 -0800 From: "Drew Adams" References: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> <87a9spu7t7.fsf@mail.jurta.org> Date: Thu, 3 Jan 2013 16:42:04 -0800 Message-ID: <1D518890DCE34548A5A5BEC043950771@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87a9spu7t7.fsf@mail.jurta.org> Thread-Index: Ac3qEMDh6dP6C9hxQRC2UWRqJ8rtPAAA1ivQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) > Is this what you expected? > (defun isearch-forward-exit-minibuffer () > + "Resume isearching forward." > > (defun isearch-reverse-exit-minibuffer () > + "Resume isearching backward." Sure, but why not say also what the searching is resuming _from_? It's not necessarily the case that someone checking this documentation gets there from `C-h k' from within an Isearch edit. From unknown Tue Jun 17 01:47:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 May 2013 09:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 13348@debbugs.gnu.org Received: via spool by 13348-submit@debbugs.gnu.org id=B13348.136791780228500 (code B ref 13348); Tue, 07 May 2013 09:11:01 +0000 Received: (at 13348) by debbugs.gnu.org; 7 May 2013 09:10:02 +0000 Received: from localhost ([127.0.0.1]:60598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZduL-0007PP-3A for submit@debbugs.gnu.org; Tue, 07 May 2013 05:10:01 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:36927 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZduJ-0007PC-LF for 13348@debbugs.gnu.org; Tue, 07 May 2013 05:10:00 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 976B2258B9E93C; Tue, 7 May 2013 02:08:56 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> <87a9spu7t7.fsf@mail.jurta.org> <1D518890DCE34548A5A5BEC043950771@us.oracle.com> Date: Tue, 07 May 2013 11:49:18 +0300 In-Reply-To: <1D518890DCE34548A5A5BEC043950771@us.oracle.com> (Drew Adams's message of "Thu, 3 Jan 2013 16:42:04 -0800") Message-ID: <87a9o7duul.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Is this what you expected? > >> (defun isearch-forward-exit-minibuffer () >> + "Resume isearching forward." >> >> (defun isearch-reverse-exit-minibuffer () >> + "Resume isearching backward." > > Sure, but why not say also what the searching is resuming _from_? It would be more helpful if you wrote these docstrings as you want instead of explaining your wishes. Now I added your additions below. Also I noticed that `isearch-nonincremental-exit-minibuffer' has no effect, so I removed it instead of adding a docstring to this unused function: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-05-01 08:10:12 +0000 +++ lisp/isearch.el 2013-05-07 08:48:31 +0000 @@ -528,7 +528,7 @@ (defvar isearch-mode-map (defvar minibuffer-local-isearch-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) - (define-key map "\r" 'isearch-nonincremental-exit-minibuffer) + (define-key map "\r" 'exit-minibuffer) (define-key map "\M-\t" 'isearch-complete-edit) (define-key map "\C-s" 'isearch-forward-exit-minibuffer) (define-key map "\C-r" 'isearch-reverse-exit-minibuffer) @@ -1273,7 +1274,6 @@ (defun isearch-edit-string () The following additional command keys are active while editing. \\ \\[exit-minibuffer] to resume incremental searching with the edited string. -\\[isearch-nonincremental-exit-minibuffer] to do one nonincremental search. \\[isearch-forward-exit-minibuffer] to resume isearching forward. \\[isearch-reverse-exit-minibuffer] to resume isearching backward. \\[isearch-complete-edit] to complete the search string using the search ring." @@ -1303,17 +1303,14 @@ (defun isearch-edit-string () (mapconcat 'isearch-text-char-description isearch-new-string ""))))) -(defun isearch-nonincremental-exit-minibuffer () - (interactive) - (setq isearch-nonincremental t) - (exit-minibuffer)) - (defun isearch-forward-exit-minibuffer () + "Resume isearching forward from the minibuffer that edits the search string." (interactive) (setq isearch-new-forward t) (exit-minibuffer)) (defun isearch-reverse-exit-minibuffer () + "Resume isearching backward from the minibuffer that edits the search string." (interactive) (setq isearch-new-forward nil) (exit-minibuffer)) From unknown Tue Jun 17 01:47:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2013 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 13348@debbugs.gnu.org Received: via spool by 13348-submit@debbugs.gnu.org id=B13348.136804723514221 (code B ref 13348); Wed, 08 May 2013 21:08:02 +0000 Received: (at 13348) by debbugs.gnu.org; 8 May 2013 21:07:15 +0000 Received: from localhost ([127.0.0.1]:34163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaBZz-0003hF-3l for submit@debbugs.gnu.org; Wed, 08 May 2013 17:07:15 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:42321 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaBZv-0003gw-Dr for 13348@debbugs.gnu.org; Wed, 08 May 2013 17:07:14 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E9F40258B9E91C; Wed, 8 May 2013 14:07:08 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> <87a9spu7t7.fsf@mail.jurta.org> <1D518890DCE34548A5A5BEC043950771@us.oracle.com> <87a9o7duul.fsf@mail.jurta.org> Date: Thu, 09 May 2013 00:04:53 +0300 In-Reply-To: <87a9o7duul.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 07 May 2013 11:49:18 +0300") Message-ID: <87wqr9mbd6.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Also I noticed that `isearch-nonincremental-exit-minibuffer' > has no effect, so I removed it instead of adding a docstring > to this unused function: Better than removing is to mark it obsolete. I propose also to rename the recently added function `isearch-insert-char-by-name' to `isearch-char-by-name' (using naming convention like in `isearch-other-meta-char' and `isearch-printing-char') because it doesn't insert a character to the buffer but adds a character to the search string: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2013-05-01 08:10:12 +0000 +++ lisp/isearch.el 2013-05-08 20:49:59 +0000 @@ -47,7 +47,7 @@ ;; modify the search string before executing the search. There are ;; three commands to terminate the editing: C-s and C-r exit the ;; minibuffer and search forward and reverse respectively, while C-m -;; exits and does a nonincremental search. +;; exits and searches in the last search direction. ;; Exiting immediately from isearch uses isearch-edit-string instead ;; of nonincremental-search, if search-nonincremental-instead is non-nil. @@ -515,12 +515,12 @@ (defvar isearch-mode-map (define-key map "\M-so" 'isearch-occur) (define-key map "\M-shr" 'isearch-highlight-regexp) - ;; The key translations defined in the C-x 8 prefix should insert - ;; characters into the search string. See iso-transl.el. + ;; The key translations defined in the C-x 8 prefix should add + ;; characters to the search string. See iso-transl.el. (define-key map "\C-x" nil) (define-key map [?\C-x t] 'isearch-other-control-char) (define-key map "\C-x8" nil) - (define-key map "\C-x8\r" 'isearch-insert-char-by-name) + (define-key map "\C-x8\r" 'isearch-char-by-name) map) "Keymap for `isearch-mode'.") @@ -528,7 +528,7 @@ (defvar isearch-mode-map (defvar minibuffer-local-isearch-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) - (define-key map "\r" 'isearch-nonincremental-exit-minibuffer) + (define-key map "\r" 'exit-minibuffer) (define-key map "\M-\t" 'isearch-complete-edit) (define-key map "\C-s" 'isearch-forward-exit-minibuffer) (define-key map "\C-r" 'isearch-reverse-exit-minibuffer) @@ -679,6 +679,8 @@ (defun isearch-forward (&optional regexp Type \\[isearch-yank-pop] to replace string just yanked into search prompt with string killed before it. Type \\[isearch-quote-char] to quote control character to search for it. +Type \\[isearch-char-by-name] to add a character to search by Unicode name,\ + with completion. \\[isearch-abort] while searching or when search has failed cancels input\ back to what has been found successfully. @@ -1273,7 +1275,6 @@ (defun isearch-edit-string () The following additional command keys are active while editing. \\ \\[exit-minibuffer] to resume incremental searching with the edited string. -\\[isearch-nonincremental-exit-minibuffer] to do one nonincremental search. \\[isearch-forward-exit-minibuffer] to resume isearching forward. \\[isearch-reverse-exit-minibuffer] to resume isearching backward. \\[isearch-complete-edit] to complete the search string using the search ring." @@ -1307,13 +1308,18 @@ (defun isearch-nonincremental-exit-minib (interactive) (setq isearch-nonincremental t) (exit-minibuffer)) +;; Changing the value of `isearch-nonincremental' has no effect here, +;; because `isearch-edit-string' ignores this change. Thus marked as obsolete. +(make-obsolete 'isearch-nonincremental-exit-minibuffer 'exit-minibuffer "24.4") (defun isearch-forward-exit-minibuffer () + "Resume isearching forward from the minibuffer that edits the search string." (interactive) (setq isearch-new-forward t) (exit-minibuffer)) (defun isearch-reverse-exit-minibuffer () + "Resume isearching backward from the minibuffer that edits the search string." (interactive) (setq isearch-new-forward nil) (exit-minibuffer)) @@ -1866,11 +1872,12 @@ (defun isearch-yank-line () (lambda () (let ((inhibit-field-text-motion t)) (line-end-position (if (eolp) 2 1)))))) -(defun isearch-insert-char-by-name () - "Read a character by its Unicode name and insert it into search string." +(defun isearch-char-by-name () + "Read a character by its Unicode name and add it to the search string. +Completion is available like in `read-char-by-name' used by `insert-char'." (interactive) (with-isearch-suspended - (let ((char (read-char-by-name "Insert character (Unicode name or hex): "))) + (let ((char (read-char-by-name "Add character to search (Unicode name or hex): "))) (when char (setq isearch-new-string (concat isearch-string (string char)) isearch-new-message (concat isearch-message === modified file 'doc/emacs/search.texi' --- doc/emacs/search.texi 2013-01-01 09:11:05 +0000 +++ doc/emacs/search.texi 2013-05-08 20:52:42 +0000 @@ -175,7 +175,7 @@ (@pxref{Faces}). The current search str @kindex M-e @r{(Incremental search)} To edit the current search string in the minibuffer without -replacing it with items from the search ring, type @kbd{M-e}. Type +replacing it with items from the search ring, type @kbd{M-e}. Type @key{RET}, @kbd{C-s} or @kbd{C-r} to finish editing the string and search for it. @node Error in Isearch From unknown Tue Jun 17 01:47:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Drew Adams" Subject: bug#13348: closed (Re: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map') Message-ID: References: <87d2srde1f.fsf@mail.jurta.org> <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> X-Gnu-PR-Message: they-closed 13348 X-Gnu-PR-Package: emacs Reply-To: 13348@debbugs.gnu.org Date: Wed, 15 May 2013 23:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1368660242-21197-1" This is a multi-part message in MIME format... ------------=_1368660242-21197-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13348@debbugs.gnu.org. --=20 13348: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13348 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1368660242-21197-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13348-done) by debbugs.gnu.org; 15 May 2013 23:23:07 +0000 Received: from localhost ([127.0.0.1]:46602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ucl2I-0005Ub-QF for submit@debbugs.gnu.org; Wed, 15 May 2013 19:23:06 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:43703 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ucl2G-0005UU-RB for 13348-done@debbugs.gnu.org; Wed, 15 May 2013 19:23:05 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 5CEB4258B9E93C; Wed, 15 May 2013 16:22:56 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#13348: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Organization: JURTA References: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> Date: Thu, 16 May 2013 02:22:20 +0300 In-Reply-To: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> (Drew Adams's message of "Thu, 3 Jan 2013 10:45:47 -0800") Message-ID: <87d2srde1f.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13348-done Cc: 13348-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Not documented? Why not? Emacs users deserve better. It is documented now. ------------=_1368660242-21197-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2013 18:46:02 +0000 Received: from localhost ([127.0.0.1]:41903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqpnk-0003eI-Lv for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:46:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57349) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqpnh-0003e8-F5 for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqpne-0005Ko-1e for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpnd-0005Kj-Uk for submit@debbugs.gnu.org; Thu, 03 Jan 2013 13:45:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpnc-00056H-Po for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqpnb-0005K5-2V for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:39729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqpna-0005Jt-RG for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2013 13:45:50 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r03IjnPw016175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Jan 2013 18:45:50 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r03IjmiH023829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 3 Jan 2013 18:45:49 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r03IjmBW004097 for ; Thu, 3 Jan 2013 12:45:48 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Jan 2013 10:45:48 -0800 From: "Drew Adams" To: Subject: 24.3.50; `C-s', `C-r', `RET' in `minibuffer-local-isearch-map' Date: Thu, 3 Jan 2013 10:45:47 -0800 Message-ID: <7482F5EE927A40CFB51A25788D9E5305@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac3p4ouF2HMQ0lPMT2qiJMqF0/Go1Q== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) `M-e' in Isearch is `isearch-edit-string'. Here is its doc: Edit the search string in the minibuffer. The following additional command keys are active while editing. M-x exit-minibuffer to resume incremental searching with the edited string. RET to do one nonincremental search. C-s to resume isearching forward. C-r to resume isearching backward. C-M-i to complete the search string using the search ring. C-x 8 RET to insert a Unicode character by name (with completion). If first char entered is C-w, then do word search instead. Now do this: `C-s M-e C-h k C-s'. You see this: C-s runs the command isearch-forward-exit-minibuffer, which is an interactive compiled Lisp function in `isearch.el'. It is bound to C-s. (isearch-forward-exit-minibuffer) Not documented. Not documented? Why not? Emacs users deserve better. These commands (for keys `C-s', `C-r', `RET') are explicitly called out in the doc for `isearch-edit-string'. They should have doc strings. `C-M-i' (`isearch-complete-edit') does, and so should all of the other keys mentioned in the doc of `isearch-edit-string'. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2012-12-31 on ODIEONE Bzr revision: 111388 rudalics@gmx.at-20121231113513-subz2dazg6yjukzh Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' ------------=_1368660242-21197-1--