GNU bug report logs - #1334
23.0.60; bug of bytecomp arithmetic operations

Previous Next

Package: emacs;

Reported by: "Shigeru Fukaya" <shigeru.fukaya <at> gmail.com>

Date: Wed, 12 Nov 2008 15:05:04 UTC

Severity: normal

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

Message #45 received at 1334-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Shigeru Fukaya" <shigeru.fukaya <at> gmail.com>
Cc: 1334-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; bug of bytecomp arithmetic operations
Date: Fri, 21 Nov 2008 13:56:15 -0500

I've reviewed your patch, and checked most of it into CVS (I took the
liberty of rewording some comments, plus some minor edits).

> *** Optimize addtion/subtraction where their last operand is 1 or
> -1 to use `1+', `1-' funcitons. This pattern often appears and
> more effective at least in size (byte-add1 vs constant 1).

Let's leave this till after the release.  It's not clear to me that
there is a significant speed increase from it, and we should try to
restrict the changes to bug fixes for the moment.

Thanks very much for working on this.
This bug report was last modified 16 years and 233 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.