From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 31 14:45:15 2012 Received: (at submit) by debbugs.gnu.org; 31 Dec 2012 19:45:15 +0000 Received: from localhost ([127.0.0.1]:38333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TplIQ-0000ci-JL for submit@debbugs.gnu.org; Mon, 31 Dec 2012 14:45:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43396) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TplIM-0000cY-JD for submit@debbugs.gnu.org; Mon, 31 Dec 2012 14:45:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TplHB-00051x-PA for submit@debbugs.gnu.org; Mon, 31 Dec 2012 14:43:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:54314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TplHB-00051t-Lt for submit@debbugs.gnu.org; Mon, 31 Dec 2012 14:43:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TplH6-00021D-0E for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2012 14:43:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TplH4-00051F-Kc for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2012 14:43:51 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:22336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TplH4-000517-EJ for bug-gnu-emacs@gnu.org; Mon, 31 Dec 2012 14:43:50 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBVJhnii002886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 31 Dec 2012 19:43:49 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBVJhmle024108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 31 Dec 2012 19:43:48 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBVJhmbK026542 for ; Mon, 31 Dec 2012 13:43:48 -0600 Received: from dradamslap1 (/10.159.239.69) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Dec 2012 11:43:48 -0800 From: "Drew Adams" To: Subject: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion Date: Mon, 31 Dec 2012 11:43:36 -0800 Message-ID: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac3njx/09sAl+Gs3Ssakntmb33Z2+A== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 1. Please provide for `completion-all-sorted-completions' to sort using a function other than what is returned by `cycle-sort-function' from the metadata. E.g., an optional arg SORT-FUN. 2. Please make duplicate deletion optional. E.g., an optional arg DONT-REMOVE-DUPS. Suggested code below - it just adds the args and respects them. But please also add a doc string in any case. (defun completion-all-sorted-completions (&optional sort-fun dont-remove-dups) "FIXME - I NEED A HELPFUL DOC STRING" (or completion-all-sorted-completions (let* ((start (field-beginning)) (end (field-end)) (string (buffer-substring start end)) (md (completion--field-metadata start)) (all (completion-all-completions string minibuffer-completion-table minibuffer-completion-predicate (- (point) start) md)) (last (last all)) (base-size (or (cdr last) 0)) (all-md (completion--metadata (buffer-substring-no-properties start (point)) base-size md minibuffer-completion-table minibuffer-completion-predicate))) (unless sort-fun (setq sort-fun (completion-metadata-get all-md 'cycle-sort-function))) (when last (setcdr last nil) ;; Delete duplicates: do it after setting last's cdr to nil (so ;; it's a proper list), and be careful to reset `last' since it ;; may be a different cons-cell. (unless dont-remove-dups (setq all (delete-dups all))) (setq last (last all)) (setq all (if sort-fun (funcall sort-fun all) ;; Prefer shorter completions, by default. (sort all (lambda (c1 c2) (< (length c1) (length c2)))))) ;; Prefer recently used completions. (when (minibufferp) (let ((hist (symbol-value minibuffer-history-variable))) (setq all (sort all (lambda (c1 c2) (> (length (member c1 hist)) (length (member c2 hist)))))))) ;; Cache the result. This is not just for speed, but also so that ;; repeated calls to minibuffer-force-complete can cycle through ;; all possibilities. (completion--cache-all-sorted-completions (nconc all base-size)))))) `completion-all-sorted-completions' currently does a mix of things. Perhaps those things should be separated into different functions that users could use on their own. Is there a good reason to couple these things? a. calculation of the completions b. duplicate deletion c. sorting d. caching Dunnow whether caching should be separated out, but perhaps b and c could be. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2012-12-18 on MS-W7-DANI Bzr revision: 111265 eliz@gnu.org-20121218190556-x9wmq083vwecgu0f Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -Ic:/emacs/libs/libXpm-3.5.10/include -Ic:/emacs/libs/libXpm-3.5.10/src -Ic:/emacs/libs/libpng-dev_1.4.3-1_win32/include -Ic:/emacs/libs/zlib-dev_1.2.5-2_win32/include -Ic:/emacs/libs/giflib-4.1.4-1-lib/include -Ic:/emacs/libs/jpeg-6b-4-lib/include -Ic:/emacs/libs/tiff-3.8.2-1-lib/include -Ic:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2 -Ic:/emacs/libs/gnutls-3.0.9-w32-bin/include -Ic:/emacs/libs/libiconv-1.9.2-1-lib/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 31 16:12:26 2012 Received: (at 13322) by debbugs.gnu.org; 31 Dec 2012 21:12:26 +0000 Received: from localhost ([127.0.0.1]:38437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tpmen-0005Rg-OK for submit@debbugs.gnu.org; Mon, 31 Dec 2012 16:12:26 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50990) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tpmej-0005RX-3U for 13322@debbugs.gnu.org; Mon, 31 Dec 2012 16:12:21 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBVLB8Nn020874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <13322@debbugs.gnu.org>; Mon, 31 Dec 2012 21:11:08 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBVLB7PZ017938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <13322@debbugs.gnu.org>; Mon, 31 Dec 2012 21:11:07 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBVLB79I031564 for <13322@debbugs.gnu.org>; Mon, 31 Dec 2012 15:11:07 -0600 Received: from dradamslap1 (/10.159.239.69) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Dec 2012 13:11:06 -0800 From: "Drew Adams" To: <13322@debbugs.gnu.org> References: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> Subject: RE: bug#13322: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion Date: Mon, 31 Dec 2012 13:10:55 -0800 Message-ID: <64F4026487BC4A83892CBBC7C0BCE7D1@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-reply-to: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> Thread-Index: Ac3njx/09sAl+Gs3Ssakntmb33Z2+AAC793g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 13322 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) Oops. Forgot to handle the second sorting occurrence also. If a user supplies a sort function then we should not overrule that to re-sort by history. This code should do it (but the code is just a suggestion, again): (defun completion-all-sorted-completions (&optional sort-function dont-remove-dups) "Like `c-a-s-c', but with added optional args." (or completion-all-sorted-completions (let* ((start (field-beginning)) (end (field-end)) (string (buffer-substring start end)) (md (completion--field-metadata start)) (all (completion-all-completions string minibuffer-completion-table minibuffer-completion-predicate (- (point) start) md)) (last (last all)) (base-size (or (cdr last) 0)) (all-md (completion--metadata (buffer-substring-no-properties start (point)) base-size md minibuffer-completion-table minibuffer-completion-predicate)) (sort-fun (or sort-function (completion-metadata-get all-md 'cycle-sort-function)))) (when last (setcdr last nil) ;; Delete duplicates: do it after setting last's cdr to nil (so ;; it's a proper list), and be careful to reset `last' since it ;; may be a different cons-cell. (unless dont-remove-dups (setq all (delete-dups all))) (setq last (last all)) (setq all (if sort-fun (funcall sort-fun all) ;; Prefer shorter completions, by default. (sort all (lambda (c1 c2) (< (length c1) (length c2)))))) ;; Prefer recently used completions. (when (and (minibufferp) (not sort-fun)) (let ((hist (symbol-value minibuffer-history-variable))) (setq all (sort all (lambda (c1 c2) (> (length (member c1 hist)) (length (member c2 hist)))))))) ;; Cache the result. This is not just for speed, but also so that ;; repeated calls to minibuffer-force-complete can cycle through ;; all possibilities. (completion--cache-all-sorted-completions (nconc all base-size)))))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 12:02:46 2013 Received: (at 13322) by debbugs.gnu.org; 3 Jan 2013 17:02:46 +0000 Received: from localhost ([127.0.0.1]:41797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqoBp-0006iA-Gl for submit@debbugs.gnu.org; Thu, 03 Jan 2013 12:02:45 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:39113) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TqoBo-0006i3-Cr for 13322@debbugs.gnu.org; Thu, 03 Jan 2013 12:02:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhoHAG6Zu09FxK5W/2dsb2JhbABEgXuuTYNJgQiCFQEBBAFWIwULCzQSFBgNJIgcBboJixGFMwOIQppxgViDB4E4 X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="211282045" Received: from 69-196-174-86.dsl.teksavvy.com (HELO pastel.home) ([69.196.174.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jan 2013 12:02:41 -0500 Received: by pastel.home (Postfix, from userid 20848) id A111358FAD; Thu, 3 Jan 2013 12:02:41 -0500 (EST) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#13322: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion Message-ID: References: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> Date: Thu, 03 Jan 2013 12:02:41 -0500 In-Reply-To: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> (Drew Adams's message of "Mon, 31 Dec 2012 11:43:36 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 13322 Cc: 13322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.0 (/) > 1. Please provide for `completion-all-sorted-completions' to sort using > a function other than what is returned by `cycle-sort-function' from the > metadata. E.g., an optional arg SORT-FUN. > 2. Please make duplicate deletion optional. E.g., an optional arg > DONT-REMOVE-DUPS. Since the completion-all-sorted-completions function just returns the value of the completion-all-sorted-completions cache when that cache is populated, it clearly can't take arguments since they'd not always be obeyed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 12:39:58 2013 Received: (at 13322) by debbugs.gnu.org; 3 Jan 2013 17:39:58 +0000 Received: from localhost ([127.0.0.1]:41841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqolp-000088-A0 for submit@debbugs.gnu.org; Thu, 03 Jan 2013 12:39:57 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50423) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tqolk-00007x-PD for 13322@debbugs.gnu.org; Thu, 03 Jan 2013 12:39:54 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r03HdlPk011946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Jan 2013 17:39:49 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r03HdkBP025290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Jan 2013 17:39:47 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r03HdkWV002702; Thu, 3 Jan 2013 11:39:46 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Jan 2013 09:39:46 -0800 From: "Drew Adams" To: "'Stefan Monnier'" References: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> Subject: RE: bug#13322: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion Date: Thu, 3 Jan 2013 09:39:45 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac3p1CXKym2PZstiQi27UU3vgrQhUgAAVcYA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 13322 Cc: 13322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > Since the completion-all-sorted-completions function just returns the > value of the completion-all-sorted-completions cache when > that cache is populated, it clearly can't take arguments since they'd > not always be obeyed. They would be obeyed whenever the function does not simply return the cached value. That's the point. Code can call `completion--flush-all-sorted-completions' when it wants `completion-all-sorted-completions' to update the cache. That function (`c--f-a-s-c') should not be "internal", BTW, IMHO. (It might also be helpful for `completion-all-sorted-completions' itself to be able to decide whether to reuse the cached value - other than testing its mere presence. It could do so based on another optional argument or on a(nother) global variable value.) FWIW, as an example, in `icomplete+.el' I use this version, which is essentially what I sent here before, but this also handles `completion-ignored-extensions' and an alist COLLECTION arg of absolute file names (for Icicles). (See also bug #12939, which has gotten no reply, about handling `completion-ignored-extensions'.) (defun icompletep-completion-all-sorted-completions (&optional sort-function dont-remove-dups) "Like `completion-all-sorted-completions', but with added optional args. If SORT-FUNCTION is nil, sort per `completion-all-sorted-completions': * per property `cycle-sort-function', if defined * else by shorter length, then by recent use." (or completion-all-sorted-completions (let* ((start (field-beginning)) (end (field-end)) (string (buffer-substring start end)) (md (completion--field-metadata start)) (all (completion-all-completions string minibuffer-completion-table minibuffer-completion-predicate (- (point) start) md)) (last (last all)) (base-size (or (cdr last) 0)) (all-md (completion--metadata (buffer-substring-no-properties start (point)) base-size md minibuffer-completion-table minibuffer-completion-predicate)) (sort-fun (or sort-function (completion-metadata-get all-md 'cycle-sort-function)))) (when last (setcdr last ()) ;; Exclude files for `completion-ignored-extensions'. (when (or minibuffer-completing-file-name (and (boundp 'icicle-abs-file-candidates) icicle-abs-file-candidates)) (setq all (delete-if (lambda (fl) (string-match-p (regexp-opt completion-ignored-extensions) fl)) all))) (unless dont-remove-dups (setq all (delete-dups all))) (setq last (last all) all (if sort-fun (funcall sort-fun all) (sort all (lambda (c1 c2) (< (length c1) (length c2)))))) (when (and (minibufferp) (not sort-fun)) (let ((hist (symbol-value minibuffer-history-variable))) (setq all (sort all (lambda (c1 c2) (> (length (member c1 hist)) (length (member c2 hist)))))))) (completion--cache-all-sorted-completions (nconc all base-size)))))) I call `completion--flush-all-sorted-completions' from Icicles when a user hits `C-,' in the minibuffer, which cycles to the next Icicles candidate sort order. This cache flushing makes Icomplete re-order the candidates, so the order in Icomplete reflects the new current (Icicles) sort order. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 15:15:46 2016 Received: (at 13322) by debbugs.gnu.org; 28 Apr 2016 19:15:46 +0000 Received: from localhost ([127.0.0.1]:53563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avrPe-0004LU-7V for submit@debbugs.gnu.org; Thu, 28 Apr 2016 15:15:46 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:34404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avrPc-0004LF-48 for 13322@debbugs.gnu.org; Thu, 28 Apr 2016 15:15:44 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avrPV-0006rb-Kx; Thu, 28 Apr 2016 21:15:40 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#13322: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion References: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> Date: Thu, 28 Apr 2016 21:15:36 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 03 Jan 2013 12:02:41 -0500") Message-ID: <878tzx5yuf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 13322 Cc: 13322@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> 1. Please provide for `completion-all-sorted-completions' to sort using >> a function other than what is returned by `cycle-sort-function' from the >> metadata. E.g., an optional arg SORT-FUN. > >> 2. Please make duplicate deletion optional. E.g., an optional arg >> DONT-REMOVE-DUPS. > > Since the completion-all-sorted-completions function just returns the > value of the completion-all-sorted-completions cache when that cache is > populated, it clearly can't take arguments since they'd not always > be obeyed. And as I understand it from recent discussion, it doesn't really matter whether duplicates are removed or not, since they are removed at a later stage. So I'm not seeing anything to be done here. Closing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 15:15:48 2016 Received: (at control) by debbugs.gnu.org; 28 Apr 2016 19:15:48 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avrPg-0004Lf-FO for submit@debbugs.gnu.org; Thu, 28 Apr 2016 15:15:48 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:34412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avrPd-0004LO-Re for control@debbugs.gnu.org; Thu, 28 Apr 2016 15:15:46 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avrPb-0006ro-P2 for control@debbugs.gnu.org; Thu, 28 Apr 2016 21:15:45 +0200 Date: Thu, 28 Apr 2016 21:15:43 +0200 Message-Id: <877ffh5yu8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #13322 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 13322 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 20:45:31 2016 Received: (at 13322) by debbugs.gnu.org; 29 Apr 2016 00:45:31 +0000 Received: from localhost ([127.0.0.1]:53790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avwYl-0001q6-3x for submit@debbugs.gnu.org; Thu, 28 Apr 2016 20:45:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avwYk-0001kn-9G for 13322@debbugs.gnu.org; Thu, 28 Apr 2016 20:45:30 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3T0jO1r021133 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Apr 2016 00:45:24 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u3T0jMjU022106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Apr 2016 00:45:23 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u3T0jKup013248; Fri, 29 Apr 2016 00:45:22 GMT MIME-Version: 1.0 Message-ID: <084f9fef-06d6-4772-bc1e-e90e8302cca8@default> Date: Thu, 28 Apr 2016 17:45:19 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen , Stefan Monnier Subject: RE: bug#13322: 24.3.50; `completion-all-sorted-completions': sorting and duplicate deletion References: <62F6B49F5A0840038CF7139810B32470@us.oracle.com> <878tzx5yuf.fsf@gnus.org> In-Reply-To: <878tzx5yuf.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 13322 Cc: 13322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > >> 1. Please provide for `completion-all-sorted-completions' to sort usin= g > >> a function other than what is returned by `cycle-sort-function' from > the > >> metadata. E.g., an optional arg SORT-FUN. > > > >> 2. Please make duplicate deletion optional. E.g., an optional arg > >> DONT-REMOVE-DUPS. >=20 > And as I understand it from recent discussion, it doesn't really matter > whether duplicates are removed or not, since they are removed at a later > stage. So I'm not seeing anything to be done here. Closing. Nonsense. The request is for Emacs not to force duplicate removal. You are replying that it doesn't matter whether it removes duplicates because it removes duplicates anyway. Silly. From unknown Tue Sep 23 05:52:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 May 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator