GNU bug report logs - #13304
[PATCH] full-path gud breakpoints now don't get confused by tramp

Previous Next

Full log

Message #23 received at 13304 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <lists <at> dima.secretsauce.net>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 13304 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: master 127bafd: Fix setting breakpoints when remote-debugging
Date: Mon, 21 Sep 2015 11:35:59 -0700

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 9ab0667..8b5d490 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
>>  (defun gud-format-command (str arg)
>>    (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
>>  	(frame (or gud-last-frame gud-last-last-frame))
>> +	(buffer-file-name-localized
>> +	 (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
>> +	     (tramp-file-name-localname (tramp-dissect-file-name
>> +					 (buffer-file-name) t))
>> +	   (buffer-file-name)))
>
> Better would be
>
> (buffer-file-name-localized
>  (and (buffer-file-name)
>       (or (file-remote-p (buffer-file-name) 'localname)
>           (buffer-file-name))))
>
> Tramp internal function calls shall be avoided.

Hi. Yes, you mentioned that in the bug report (13304), and I updated the
patch in the bug report. Eli committed the older version of the patch by
mistake, however.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.