From unknown Mon Aug 11 21:19:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#13304 <13304@debbugs.gnu.org> To: bug#13304 <13304@debbugs.gnu.org> Subject: Status: [PATCH] full-path gud breakpoints now don't get confused by tramp Reply-To: bug#13304 <13304@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:19:07 +0000 retitle 13304 [PATCH] full-path gud breakpoints now don't get confused by t= ramp reassign 13304 emacs submitter 13304 Dima Kogan severity 13304 normal tag 13304 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 29 06:01:28 2012 Received: (at submit) by debbugs.gnu.org; 29 Dec 2012 11:01:28 +0000 Received: from localhost ([127.0.0.1]:35639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TouAS-0001Gi-9i for submit@debbugs.gnu.org; Sat, 29 Dec 2012 06:01:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34843) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TouAO-0001GZ-JL for submit@debbugs.gnu.org; Sat, 29 Dec 2012 06:01:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tou9P-0001nj-Ix for submit@debbugs.gnu.org; Sat, 29 Dec 2012 06:00:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tou9P-0001mp-FN for submit@debbugs.gnu.org; Sat, 29 Dec 2012 06:00:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tou9K-00020K-Sx for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 06:00:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tou9I-0001gX-0E for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 06:00:18 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tou9H-0001fv-LN for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 06:00:15 -0500 Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 6BE02206BC for ; Sat, 29 Dec 2012 06:00:13 -0500 (EST) Received: from frontend1.nyi.mail.srv.osa ([10.202.2.160]) by compute5.internal (MEProxy); Sat, 29 Dec 2012 06:00:13 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=from:to:subject:date:message-id:mime-version:content-type; s= mesmtp; bh=M10vJodC6JIYC421Eq1Dd8DUzzM=; b=Uez8ydSWlE1tIu+8YNuAA qQvCZwF1HtsJmjx7cN1kWz//nj4OTqsqd6QB2cqs84rEQld0o3ocsnzWNzp/NHEi g2kyqj3JSuQQtJQSOp8trlfWugKpIY/9+xrIkHdPy3k0nnoAxXWpJ4/oMH4cje93 OCYLyhAq/cXw95RdWEOjz8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :mime-version:content-type; s=smtpout; bh=M10vJodC6JIYC421Eq1Dd8 DUzzM=; b=CO27AytJ7F12CsNA4Z78RYEvH5BYRa+bRbxbJiv1XGSCkD2uKCq4/7 a9HFEOEwSQjuCo2OA1PX5hphU4lHJQajyqucDV4/je++l5JKjzmrDjaPk5c3mhze BgtA34DbOeYWrk2xbSH70l4NXflw8U9SZihLUSq/JIdl1d9l8YOWE= X-Sasl-enc: kKb2KHl2MdLfCPoa8xOiTT4eRNSwoDEoSQq6220EjXlW 1356778813 Received: from shorty.local (unknown [76.169.242.46]) by mail.messagingengine.com (Postfix) with ESMTPA id 238CE8E0726 for ; Sat, 29 Dec 2012 06:00:13 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.80) (envelope-from ) id 1Tou9D-0004MG-O4 for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 03:00:11 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: [PATCH] full-path gud breakpoints now don't get confused by tramp Date: Sat, 29 Dec 2012 03:00:11 -0800 Message-ID: <87sj6p86o4.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain This patch fixes a bug I hit when remotely-debugging a python program with gud through tramp. If I tried to set a breakpoint from the source buffer, the python debugger would be given the full path to the file, tramp fields and all. This made it impossible to set breakpoints in this manner. Attached is a patch that strips out the remote pieces of the path when communicating with the backend debugger. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-full-path-gud-breakpoints-now-don-t-get-confused-by-.patch Content-Description: patch >From 3bfe6f560a8c6f96ef0ed9200015bab0d29235c9 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sat, 29 Dec 2012 02:54:40 -0800 Subject: [PATCH] full-path gud breakpoints now don't get confused by tramp prior to this patch if gud used a path to set a breakpoint, the FULL path would be sent to the backend debugger, including the tramp pieces. The backends don't know anything about tramp, so they were naturally confused by this. Most notably, it was impossible to set from-source breakpoints in pdb, the python debugger. --- lisp/progmodes/gud.el | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el index 13eac83..45e0ddf 100644 --- a/lisp/progmodes/gud.el +++ b/lisp/progmodes/gud.el @@ -2743,6 +2743,11 @@ Obeying it means displaying in another window the specified file and line." (defun gud-format-command (str arg) (let ((insource (not (eq (current-buffer) gud-comint-buffer))) (frame (or gud-last-frame gud-last-last-frame)) + (buffer-file-name-localized + (if (and (buffer-file-name) (file-remote-p (buffer-file-name))) + (tramp-file-name-localname (tramp-dissect-file-name + (buffer-file-name) t)) + (buffer-file-name))) result) (while (and str (let ((case-fold-search nil)) @@ -2752,15 +2757,15 @@ Obeying it means displaying in another window the specified file and line." (cond ((eq key ?f) (setq subst (file-name-nondirectory (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?F) (setq subst (file-name-base (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?d) (setq subst (file-name-directory (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?l) (setq subst (int-to-string -- 1.7.10.4 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 29 15:24:27 2012 Received: (at 13304) by debbugs.gnu.org; 29 Dec 2012 20:24:27 +0000 Received: from localhost ([127.0.0.1]:36395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tp2xH-0000RZ-CN for submit@debbugs.gnu.org; Sat, 29 Dec 2012 15:24:27 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46258) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tp2xE-0000RR-Jc for 13304@debbugs.gnu.org; Sat, 29 Dec 2012 15:24:25 -0500 Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 07BF220902 for <13304@debbugs.gnu.org>; Sat, 29 Dec 2012 15:23:24 -0500 (EST) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute6.internal (MEProxy); Sat, 29 Dec 2012 15:23:24 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=date:from:to:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=eq2ce22suNwmBqgG4MVu1t/H53w=; b=driBXJYWsqIyPzSM1Y1ZESXxgZs6 YCykIdY9p480rXqdQ5ZV1LJtB51rcmrXfnBZXdh00hFa/e4IXQ3E7+3QBaxI39LM rcxG2go5nlu/DMLHou10KExrer5BNyhFber1E1/KDImbmC6Fr5UfBVFW/ae/NhTh B2UE7wfyXaiUSSQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding; s=smtpout; bh=eq2ce22suNwmBqgG4MVu1t /H53w=; b=Kfw8UZpJgJSR6SM6S+AHY5puWFdANR8oSGgVAMUrdWGwlS1BeSNfF/ CNBpL2dPMp9/TESOyuNsbFXbbWsAwcVZRW3Itq5jIi7Lt8uz5giXpah8nEhdq0HP /QjuXOE+NxfoHUBbzy5kiKvE0JNHzlNPnxGadJB9+9y9Qm+pLl0ys= X-Sasl-enc: uF3FysWT43wcSkqiZbui48iuYQ+Lfwuc7TpF0QOde1ud 1356812603 Received: from shorty.local (unknown [76.169.242.46]) by mail.messagingengine.com (Postfix) with ESMTPA id 7AB2C4827C1 for <13304@debbugs.gnu.org>; Sat, 29 Dec 2012 15:23:23 -0500 (EST) Date: Sat, 29 Dec 2012 12:23:21 -0800 From: Dima Kogan To: 13304@debbugs.gnu.org Subject: Re: bug#13304: Acknowledgement ([PATCH] full-path gud breakpoints now don't get confused by tramp) Message-ID: <20121229122321.4ed2005c@shorty.local> In-Reply-To: References: <87sj6p86o4.fsf@secretsauce.net> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Here's a recipe to reproduce the bug as it was. Note that I'm on an amd64 linux box. 1. Create a new python program. I put it in /tmp/tst.py with these contents: #!/usr/bin/python print("hi") 2. Run pdb on this file via tramp. I did this: M-x pdb pdb /127.0.0.1:/tmp/tst.py This launches pdb and opens the remote /tmp/tst.py 3. Now navigate to the print("hi") line, and do C-x SPC. This is supposed to set a breakpoint there, but it doesn't work. If it did, pdb would say "Breakpoint 1 at /tmp/tst.py:2". Instead it says "End of file". The command being sent to the pdb backend is break /scpc:127.0.0.1:/tmp/tst.py:2 but it should be break /tmp/tst.py:2 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 31 10:43:07 2012 Received: (at 13304) by debbugs.gnu.org; 31 Dec 2012 15:43:07 +0000 Received: from localhost ([127.0.0.1]:38160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TphW6-00025H-MD for submit@debbugs.gnu.org; Mon, 31 Dec 2012 10:43:07 -0500 Received: from mout.gmx.net ([212.227.15.19]:63106) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TphW2-00024t-12 for 13304@debbugs.gnu.org; Mon, 31 Dec 2012 10:43:03 -0500 Received: from mailout-de.gmx.net ([10.1.76.10]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MHuVv-1Tsjtj3PRt-003gOY for <13304@debbugs.gnu.org>; Mon, 31 Dec 2012 16:41:50 +0100 Received: (qmail invoked by alias); 31 Dec 2012 15:41:50 -0000 Received: from p57BB98C5.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.152.197] by mail.gmx.net (mp010) with SMTP; 31 Dec 2012 16:41:50 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/CjbNltbXCncnJTG1KeV/8xSC4qnIz5Yf+vuturG IAPy1bs89j5h5y From: Michael Albinus To: Dima Kogan Subject: Re: bug#13304: [PATCH] full-path gud breakpoints now don't get confused by tramp References: <87sj6p86o4.fsf@secretsauce.net> Date: Mon, 31 Dec 2012 16:41:42 +0100 In-Reply-To: <87sj6p86o4.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 29 Dec 2012 03:00:11 -0800") Message-ID: <87mwwup6tl.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 13304 Cc: 13304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Dima Kogan writes: > + (tramp-file-name-localname (tramp-dissect-file-name > + (buffer-file-name) t)) Don't use Tramp internal functions, they are not documented by intention. You could use instead (file-remote-p (buffer-file-name) 'localname) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 31 14:56:23 2012 Received: (at 13304) by debbugs.gnu.org; 31 Dec 2012 19:56:23 +0000 Received: from localhost ([127.0.0.1]:38339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TplTC-0000tl-6z for submit@debbugs.gnu.org; Mon, 31 Dec 2012 14:56:23 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57473) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TplT8-0000tZ-QL for 13304@debbugs.gnu.org; Mon, 31 Dec 2012 14:56:20 -0500 Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 2111B209AE; Mon, 31 Dec 2012 14:55:07 -0500 (EST) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute3.internal (MEProxy); Mon, 31 Dec 2012 14:55:07 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; s=mesmtp; bh=9nB6HjTddP8pfOjdimvzA9C ivI0=; b=HlM510mZ8JZT7j7aE2lh3oiXnWwpa9gVDFy7ccwxzpkhir/GzDkd7oO XkVvaO+i6MESeTjTLCZi3klqNXG2GIiXbgS884YdlafuyRW+yPet/M1v01D4OCDw y9TtscpRB1Fx44tP+9X6WXoW4O0F3lPUSHnOKf2mUKSGjs7GHQ0w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type; s=smtpout; bh=9nB6HjTddP8pfOjdimvzA9CivI0=; b=CwJ5U+SG55SCufn3O8A4LMM9k1EV bzMoizxe3JNzbDdIBj5U4YX5sJXQyzFaAiHSJzx4vVHSP8o1jnyk6H8ra2lMvH+j c9cDik55BvJQQFnxGlOHO9yCIWte89ftzB35fOzUXGntKK1da8l1uSFmhvCQ02SQ JibfEwyYvdS1Qho= X-Sasl-enc: b6ULrnEb9scp2smzpvfpsSiC6PY+LMYhdF2YLSJFX82O 1356983706 Received: from fatty (unknown [204.154.109.20]) by mail.messagingengine.com (Postfix) with ESMTPA id 9881A4827CE; Mon, 31 Dec 2012 14:55:06 -0500 (EST) Date: Mon, 31 Dec 2012 11:53:13 -0800 From: Dima Kogan To: Michael Albinus Subject: Re: bug#13304: [PATCH] full-path gud breakpoints now don't get confused by tramp Message-ID: <20121231115313.3be6b7ea@fatty> In-Reply-To: <87mwwup6tl.fsf@gmx.de> References: <87sj6p86o4.fsf@secretsauce.net> <87mwwup6tl.fsf@gmx.de> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/IHbZdcb/pAOU6qX2zIfWH2x" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 13304 Cc: 13304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --MP_/IHbZdcb/pAOU6qX2zIfWH2x Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline > On Mon, 31 Dec 2012 16:41:42 +0100 > Michael Albinus wrote: > > Dima Kogan writes: > > > + (tramp-file-name-localname (tramp-dissect-file-name > > + (buffer-file-name) t)) > > Don't use Tramp internal functions, they are not documented by > intention. You could use instead > > (file-remote-p (buffer-file-name) 'localname) Great point; this is really much better. I'm attaching an updated patch. --MP_/IHbZdcb/pAOU6qX2zIfWH2x Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-full-path-gud-breakpoints-now-don-t-get-confused-by-.patch >From f27e176b58dc9fd813ad5f9228066d3fcc2c226c Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sat, 29 Dec 2012 02:54:40 -0800 Subject: [PATCH] full-path gud breakpoints now don't get confused by tramp prior to this patch if gud used a path to set a breakpoint, the FULL path would be sent to the backend debugger, including the tramp pieces. The backends don't know anything about tramp, so they were naturally confused by this. Most notably, it was impossible to set from-source breakpoints in pdb, the python debugger. --- lisp/progmodes/gud.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el index 13eac83..c178a53 100644 --- a/lisp/progmodes/gud.el +++ b/lisp/progmodes/gud.el @@ -2743,6 +2743,9 @@ Obeying it means displaying in another window the specified file and line." (defun gud-format-command (str arg) (let ((insource (not (eq (current-buffer) gud-comint-buffer))) (frame (or gud-last-frame gud-last-last-frame)) + (buffer-file-name-localized + (and (buffer-file-name) (or (file-remote-p (buffer-file-name) 'localname) + (buffer-file-name)))) result) (while (and str (let ((case-fold-search nil)) @@ -2752,15 +2755,15 @@ Obeying it means displaying in another window the specified file and line." (cond ((eq key ?f) (setq subst (file-name-nondirectory (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?F) (setq subst (file-name-base (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?d) (setq subst (file-name-directory (if insource - (buffer-file-name) + buffer-file-name-localized (car frame))))) ((eq key ?l) (setq subst (int-to-string -- 1.7.10.4 --MP_/IHbZdcb/pAOU6qX2zIfWH2x-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 20 22:37:43 2015 Received: (at 13304) by debbugs.gnu.org; 21 Sep 2015 02:37:43 +0000 Received: from localhost ([127.0.0.1]:39341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdqz8-0003Ia-Ld for submit@debbugs.gnu.org; Sun, 20 Sep 2015 22:37:42 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdqz6-0003IR-An for 13304@debbugs.gnu.org; Sun, 20 Sep 2015 22:37:41 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B9E33201FC for <13304@debbugs.gnu.org>; Sun, 20 Sep 2015 22:37:39 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sun, 20 Sep 2015 22:37:39 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=YIq9h7QCblhhuXrbAiKeHC2Q0YM =; b=ZNwuuFf5a6gADhPaSUSiFOJaM6A6+KHU9cndxrWycnq8+KZSbyXckqmXQUy Vr3KaFgFzqLqJiYwSiOpOyZFJK47bXNL4c4Jc0Z0mdiwUvC/e78yhupHzuG91Z37 +Zun0qDsD+EMaHZI/Etu1aHjZvvQato0AsUFiF2mJ5j+rge0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=YI q9h7QCblhhuXrbAiKeHC2Q0YM=; b=Yr+R2ilqpGzkETg1elloXFNcqhWqyY7Isk VuV1hSGgtOGiD6vprYjoaIrVEZy8Gcn28258hzlgcX6kuHEKOm3099LRbzgjmSq0 gIo9OiHliOeOdLCisGG+uWLR2q8hDKBSaRv23J5lhVmlfuTqlQomL7D5vTEFOzuh KMm65uL+0= X-Sasl-enc: S92Pf8zx8k8ZmMpq0pKK9jIvjBK3LcPiq7xC81hPo/wz 1442803059 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 6AD8EC0001D for <13304@debbugs.gnu.org>; Sun, 20 Sep 2015 22:37:39 -0400 (EDT) Received: from ip6-localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Zdqz4-0004jM-6p for 13304@debbugs.gnu.org; Sun, 20 Sep 2015 19:37:38 -0700 From: Dima Kogan To: 13304@debbugs.gnu.org Subject: ping Date: Sun, 20 Sep 2015 19:37:38 -0700 Message-ID: <87twqo8pl9.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi. This is a gentle ping. This patch is useful and fixes a real bug. Can somebody please take a look and maybe merge it? Thanks! From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 21 06:56:18 2015 Received: (at 13304) by debbugs.gnu.org; 21 Sep 2015 10:56:18 +0000 Received: from localhost ([127.0.0.1]:39598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdyle-0006Qx-3F for submit@debbugs.gnu.org; Mon, 21 Sep 2015 06:56:18 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:37036) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdylc-0006Qn-1R for 13304@debbugs.gnu.org; Mon, 21 Sep 2015 06:56:17 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NV000300X0QO100@a-mtaout20.012.net.il> for 13304@debbugs.gnu.org; Mon, 21 Sep 2015 13:55:59 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NV0003UVX1B6OB0@a-mtaout20.012.net.il>; Mon, 21 Sep 2015 13:55:59 +0300 (IDT) Date: Mon, 21 Sep 2015 13:56:09 +0300 From: Eli Zaretskii Subject: Re: bug#13304: ping In-reply-to: <87twqo8pl9.fsf@secretsauce.net> X-012-Sender: halo1@inter.net.il To: Dima Kogan Message-id: <831tdsnira.fsf@gnu.org> References: <87sj6p86o4.fsf@secretsauce.net> <87twqo8pl9.fsf@secretsauce.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 13304 Cc: 13304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Dima Kogan > Date: Sun, 20 Sep 2015 19:37:38 -0700 > > Hi. This is a gentle ping. This patch is useful and fixes a real bug. > Can somebody please take a look and maybe merge it? Thanks! Thanks, pushed. Should we close the bug now? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 21 14:36:09 2015 Received: (at 13304) by debbugs.gnu.org; 21 Sep 2015 18:36:09 +0000 Received: from localhost ([127.0.0.1]:40643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5wf-0001hh-8C for submit@debbugs.gnu.org; Mon, 21 Sep 2015 14:36:09 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5wd-0001hY-Of for 13304@debbugs.gnu.org; Mon, 21 Sep 2015 14:36:08 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 97CC520335 for <13304@debbugs.gnu.org>; Mon, 21 Sep 2015 14:36:07 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 21 Sep 2015 14:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=PTAbQ xGhWlzMs3ZoQ9UKmWhtr/o=; b=vxZ8WwKG0YVkTHoyh8ohLjcInAqoIJBLC7+1m Oygiwgd3yfFG7FyBeevMqd19kotm4zzcD/UOICQl2P2PRXIPqlEZJM/iobDvoSMy nr8x8ctlA8SLMj/VcqfQ4+pmWLfVYoVPyQKXUisOypKnCi1rDcCrfdj8OPsa3vKO QcDDoo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=PTAbQxGhWlzMs3ZoQ9UKmWhtr/o=; b=tbiBa f7rFuZz58GfI/MQrD0zWUbnT9E/hL2uecE6VOPc7v3f6BF1wpDS45WCBIByCidhk ptO/lMGwVROiC8xpGgZ2pCMZhRok3/8M0rJT/UoQCSoWsZogXQyUZ8IjtRJuHsRn AiKUtH/vyyWowKu1ONSleXoWLAV0uZKdbQyIVI= X-Sasl-enc: rYZW8Cm+rRF2xxreIKiy6kz+0rGZuAoebwv3QxRb37i8 1442860567 Received: from shorty.local (unknown [172.56.17.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EC94C00013; Mon, 21 Sep 2015 14:36:07 -0400 (EDT) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Ze5wV-0007hq-VJ; Mon, 21 Sep 2015 11:36:00 -0700 References: <20150921105525.27576.92526@vcs.savannah.gnu.org> <87io74q79a.fsf@gmx.de> From: Dima Kogan To: Michael Albinus Subject: Re: master 127bafd: Fix setting breakpoints when remote-debugging In-reply-to: <87io74q79a.fsf@gmx.de> Date: Mon, 21 Sep 2015 11:35:59 -0700 Message-ID: <87k2rj8vsg.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13304 Cc: 13304@debbugs.gnu.org, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Michael Albinus writes: > Eli Zaretskii writes: > >> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el >> index 9ab0667..8b5d490 100644 >> --- a/lisp/progmodes/gud.el >> +++ b/lisp/progmodes/gud.el >> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line." >> (defun gud-format-command (str arg) >> (let ((insource (not (eq (current-buffer) gud-comint-buffer))) >> (frame (or gud-last-frame gud-last-last-frame)) >> + (buffer-file-name-localized >> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name))) >> + (tramp-file-name-localname (tramp-dissect-file-name >> + (buffer-file-name) t)) >> + (buffer-file-name))) > > Better would be > > (buffer-file-name-localized > (and (buffer-file-name) > (or (file-remote-p (buffer-file-name) 'localname) > (buffer-file-name)))) > > Tramp internal function calls shall be avoided. Hi. Yes, you mentioned that in the bug report (13304), and I updated the patch in the bug report. Eli committed the older version of the patch by mistake, however. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 21 14:38:27 2015 Received: (at 13304-done) by debbugs.gnu.org; 21 Sep 2015 18:38:27 +0000 Received: from localhost ([127.0.0.1]:40647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5ys-0001l6-O4 for submit@debbugs.gnu.org; Mon, 21 Sep 2015 14:38:27 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39440) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ze5yr-0001kz-Fw for 13304-done@debbugs.gnu.org; Mon, 21 Sep 2015 14:38:25 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3A4052074E for <13304-done@debbugs.gnu.org>; Mon, 21 Sep 2015 14:38:25 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Mon, 21 Sep 2015 14:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=pn7n2 5q0voIXKUqt6fJSfBFVrGs=; b=uibZ98xVOPnuIkh++UXeN67ro9wKUumER0v+4 zFDio0nWonV67ypvoJAB5pbEXwW0fQVv8QUepJBRGU2VL4Au4oaVvosCJyY/At6l X0KqsVTgw8mr4LcQ1/+0zQwVy8RNNOxTVNu3m7UEFzJnmFHNonJfUZQoEF7Ngk9E lLZ3z8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=pn7n25q0voIXKUqt6fJSfBFVrGs=; b=Bnw+/ DMc9UZAhNY91eMa8mFa8BnBWsISRUcdbPY9QwEBY3y6Se6lGR9U1J3CjDizO5hpg QCmwQQjIJV5QrdsR9+7KJS1s7TOyhxbhIgq1Nycl0n1qudwUZKFolfgdrWUPNXRf GLZwzy9p38fztRLqtgZgaRguisCRv7X0QntGDY= X-Sasl-enc: WC1ZgjqV7FsqQPX422uqSXFkuftRjNbd40nKeXaMwuWO 1442860704 Received: from shorty.local (unknown [172.56.17.42]) by mail.messagingengine.com (Postfix) with ESMTPA id AB0F8C0001A; Mon, 21 Sep 2015 14:38:24 -0400 (EDT) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Ze5yj-0007i4-Sv; Mon, 21 Sep 2015 11:38:17 -0700 References: <87sj6p86o4.fsf@secretsauce.net> <87twqo8pl9.fsf@secretsauce.net> <831tdsnira.fsf@gnu.org> From: Dima Kogan To: Eli Zaretskii Subject: Re: bug#13304: ping In-reply-to: <831tdsnira.fsf@gnu.org> Date: Mon, 21 Sep 2015 11:38:16 -0700 Message-ID: <87io738von.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 13304-done Cc: 13304-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Thanks, pushed. > > Should we close the bug now? Thanks for doing that. You accidentally pushed the original patch, the one from before I addressed Michael's comments, so it might be good to update the tree with the later patch. In any case, I'm closing the bug. Thanks again. From unknown Mon Aug 11 21:19:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Oct 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator